1. 18 Jul, 2007 1 commit
  2. 19 Jun, 2007 2 commits
  3. 17 Jun, 2007 3 commits
  4. 22 May, 2007 2 commits
    • Salyzyn, Mark's avatar
      [SCSI] aacraid: apply commit config for reset_devices flag · 1208bab5
      Salyzyn, Mark authored
      
      
      Under some conditions associated with the unclean transition to kdump,
      the aacraid adapters will view the array as foreign and not export it to
      prevent access and data manipulation. The solution is to submit a commit
      configuration to export the devices since this is a expected behavior
      when transitioning to a kdump kernel.
      
      This patch adds the aacraid.reset_devices flag and when either this or
      the global reset_devices flag is set, ensures that a commit config is
      issued and extends the startup_timeout if it is set less than 5 minutes.
      Signed-off-by: default avatarMark Salyzyn <aacraid@adaptec.com>
      Signed-off-by: default avatarJames Bottomley <James.Bottomley@SteelEye.com>
      1208bab5
    • Salyzyn, Mark's avatar
      [SCSI] aacraid: add support for FUA · 9d399cc7
      Salyzyn, Mark authored
      
      
      Back in the beginning of last year we disabled mode page 8 and mode page
      3f requests through device quirk bits instead of enhancing the driver to
      respond to these mode pages because there was no apparent added value.
      
      The Firmware that supports the new communication commands supports the
      ability to force a write around of the adapter cache on a command by
      command basis. In the attached patch we enable mode page 8 and 3f and
      spoof the results as needed in order to *convince* the layers above to
      submit writes with the FUA (Force Unit Attention) bit set if the file
      system or application requires it, if the Firmware supports the write
      through, or instead to submit a SYNCHRONIZE_CACHE if the Firmware does
      not. The added value here is for file systems that benefit from this
      functionality and for clustering or redundancy scenarios.
      
      Caveats: By convince, we are responding with a minimal short 3 byte
      content mode page 8, with only the data the SCSI layer needs and that we
      can fill confidently. Applications that require the customarily larger
      mode page 8 results may be confused by this(?). The FUA, or the
      SYNCHRONIZE_CACHE only affect the cache on the controller. Our firmware
      by default ensure that the underlying physical drives of the array have
      their cache turned off so normally this is not a problem.
      
      This attached patch is against current scsi-misc-2.6 and was unit tested
      on RHEL5. Since this is a feature enhancement, it should not be
      considered for any current stabilization efforts.
      Signed-off-by: default avatarMark Salyzyn <aacraid@adaptec.com>
      Signed-off-by: default avatarJames Bottomley <James.Bottomley@SteelEye.com>
      9d399cc7
  5. 16 May, 2007 1 commit
    • James Bottomley's avatar
      [SCSI] aacraid: fix panic on short Inquiry · cab537d6
      James Bottomley authored
      
      
      Unable to handle kernel paging request at ffff8101c0000000 RIP:
       [<ffffffff880b22a1>] :aacraid:aac_internal_transfer+0xd6/0xe3
      PGD 8063 PUD 0
      Oops: 0000 [1] SMP
      last sysfs file: /block/sdb/removable
      CPU 2
      Modules linked in: autofs4(U) hidp(U) nfs(U) lockd(U)
      fscache(U) nfs_acl(U) rfcomm(U) l2cap(U) bluetooth(U)
      sunrpc(U) ipv6(U) cpufreq_ondemand(U) dm_mirror(U) dm_mod(U)
      video(U) sbs(U) i2c_ec(U) button(U) battery(U) asus_acpi(U)
      acpi_memhotplug(U) ac(U) parport_pc(U) lp(U) parport(U)
      joydev(U) ide_cd(U) i2c_i801(U) i2c_core(U) shpchp(U)
      cdrom(U) bnx2(U) sg(U) pcspkr(U) ata_piix(U) libata(U)
      aacraid(U) sd_mod(U) scsi_mod(U) ext3(U) jbd(U) ehci_hcd(U)
      ohci_hcd(U) uhci_hcd(U)
      Pid: 2352, comm: syslogd Not tainted 2.6.18-prep #1
      RIP: 0010:[<ffffffff880b22a1>]  [<ffffffff880b22a1>] :aacraid:aac_internal_transfer+0xd6/0xe3
      RSP: 0000:ffff8101bfd1fe68  EFLAGS: 00010083
      RAX: 0000000000000063 RBX: 0000000000000008 RCX: 00000000ffd1fea0
      RDX: ffffffff802da628 RSI: ffff8101c0000000 RDI: ffff8101b2a08168
      RBP: ffff8101b2728010 R08: ffffffff802da628 R09: 0000000000000046
      R10: 0000000000000000 R11: 0000000000000080 R12: 0000000000000010
      R13: ffff8101bfd1fea8 R14: ffff8101bc74df58 R15: ffff8101bc74df58
      FS:  00002aaaab0146f0(0000) GS:ffff8101bfcd2e40(0000) knlGS:0000000000000000
      CS:  0010 DS: 0000 ES: 0000 CR0: 000000008005003b
      CR2: ffff8101c0000000 CR3: 00000001bdecd000 CR4: 00000000000006e0
      Process syslogd (pid: 2352, threadinfo ffff8101bc74c000, task ffff8101bd979040)
      Stack:  0000000000000012 0000000000000036 0000000000000000 ffff8101bee9a800
       ffff8101be9d3a00 ffff8101be9d3a00 ffff8101be8014f8 ffffffff880b26cc
       40212227607e3141 2029282a26252423 0000000000000003 ffff810037e3a000
      Call Trace:
       <IRQ [<ffffffff880b26cc>] :aacraid:get_container_name_callback+0x8b/0xb5
       [<ffffffff880b6f67>] :aacraid:aac_intr_normal+0x1b3/0x1f9
       [<ffffffff880b8007>] :aacraid:aac_rkt_intr+0x37/0x115
       [<ffffffff80099749>] __rcu_process_callbacks+0xf8/0x1a8
       [<ffffffff80010705>] handle_IRQ_event+0x29/0x58
       [<ffffffff800b2fe0>] __do_IRQ+0xa4/0x105
       [<ffffffff80011c19>] __do_softirq+0x5e/0xd5
       [<ffffffff8006a193>] do_IRQ+0xe7/0xf5
       [<ffffffff8005b649>] ret_from_intr+0x0/0xa
      
      On digging into it, it turned out that the customer was probing an
      aacraid device with an INQUIRY of 8 bytes.  The way aacraid works, it
      was blindly trying to use aac_internal_transfer to copy the container
      name to byte 16 of the inquiry data, resulting in a negative transfer
      length.  It then copies over the whole of kernel memory before
      dropping off the end.
      
      Fix updated and corrected by Mark Salyzyn
      Signed-off-by: default avatarJames Bottomley <James.Bottomley@SteelEye.com>
      cab537d6
  6. 17 Apr, 2007 1 commit
  7. 01 Apr, 2007 1 commit
    • Salyzyn, Mark's avatar
      [SCSI] aacraid: fix print of Firmware Build Date and add TSID · a45c863f
      Salyzyn, Mark authored
      
      
      The Adapter build date that is to be printed on instantiation was not
      displayed as a result of the supplemental adapter information structure
      not being in sync with the Firmware; the driver took an early test cycle
      version that had a miss-sized padded region at the head and the
      structure was not re-checked at the end of qualification. The Build Date
      was not a priority and is merely a cosmetic enhancement, and the wrong
      location for the start of the structure member would not induce any
      side-effect problems. We updated the structure to match the actual
      format, and added the TSID (Tech Support Identification) value print,
      should it be present, to the adapter instantiation announcements during
      driver load.
      
      This later enhancement should improve the relationship between Service
      folk & Tech Support if the printed value of the TSID found it's way into
      the circular file labeled G...
      
      Neither of these values show in sysfs (yet).
      Signed-off-by: default avatarMark Salyzyn <aacraid@adaptec.com>
      Signed-off-by: default avatarJames Bottomley <James.Bottomley@SteelEye.com>
      a45c863f
  8. 21 Mar, 2007 2 commits
  9. 20 Mar, 2007 3 commits
    • Mark Haverkamp's avatar
      [SCSI] aacraid: Improved error handling · 03d44337
      Mark Haverkamp authored
      
      
      Received from Mark Salyzyn,
      
      This set of fixes improve error handling stability of the driver. A popular
      manifestation of the problems is an NULL pointer reference in the interrupt
      handler when referencing portions of the scsi command context, or in the
      scsi_done handling when an offlined device is referenced.
      
      The aacraid driver currently does not get notification of orphaned command
      completions due to devices going offline. The driver also fails to handle the
      commands that are finished by the error handler, and thus can complete again
      later at the hands of the adapter causing situations of completion of an
      invalid scsi command context. Test Unit Ready calls abort assuming that the
      abort was successful, but are not, and thus when the interrupt from the adapter
      occurs, they reference invalid command contexts. We add in a TIMED_OUT flag to
      inform the aacraid FIB context that the interrupt service should merely release
      the driver resources and not complete the command up. We take advantage of this
      with the abort handler as well for select abortable commands. And we detect and
      react if a command that can not be aborted is currently still outstanding to
      the controller when reissued by the retry mechanism.
      Signed-off-by: default avatarMark Haverkamp <markh@linux-foundation.org>
      Signed-off-by: default avatarJames Bottomley <James.Bottomley@SteelEye.com>
      03d44337
    • Mark Haverkamp's avatar
      [SCSI] aacraid: remove un-needed references to container id (cid) · 9e7c349c
      Mark Haverkamp authored
      
      
      Received from Mark Salyzyn,
      
      This little patch removes the ',cid)' container identification argument
      from some of the functions. The argument is used in some cases as merely
      a debug helper and thus not used, and in others, the value can be
      quickly acquired from the scsi command in their single solitary use in
      the procedure rather than wasting resources on passing the argument in
      from above.
      Signed-off-by: default avatarMark Haverkamp <markh@linux-foundation.org>
      Signed-off-by: default avatarJames Bottomley <James.Bottomley@SteelEye.com>
      9e7c349c
    • Mark Haverkamp's avatar
      [SCSI] aacraid: Fix blocking issue with container probing function (cast update) · fe76df42
      Mark Haverkamp authored
      
      
      Received from Mark Salyzyn,
      
      The aac_probe_container call blocks. This is an issue because it is called on
      occasion in the context of the queuecommand handler. Once in a blue moon this
      has resulted in a kernel panic sleeping during interrupt; or problems with some
      embedded system versions of the kernel that depend on queuecommand to not
      block. This ugly patch rewrites the aac_probe_container call into a new routine
      _aac_probe_container that is an asynchronous state machine to complete the
      series of operations. The legacy blocking aac_probe_container call used in
      other areas of the driver (during initialization scanning for all targets and
      in the separate hot-add/remove [aacraid] thread) merely issues
      _aac_probe_container and then simple spins calling schedule() waiting for
      completion.
      Signed-off-by: default avatarMark Haverkamp <markh@linux-foundation.org>
      Signed-off-by: default avatarJames Bottomley <James.Bottomley@SteelEye.com>
      fe76df42
  10. 14 Feb, 2007 1 commit
    • Tim Schmielau's avatar
      [PATCH] remove many unneeded #includes of sched.h · cd354f1a
      Tim Schmielau authored
      
      
      After Al Viro (finally) succeeded in removing the sched.h #include in module.h
      recently, it makes sense again to remove other superfluous sched.h includes.
      There are quite a lot of files which include it but don't actually need
      anything defined in there.  Presumably these includes were once needed for
      macros that used to live in sched.h, but moved to other header files in the
      course of cleaning it up.
      
      To ease the pain, this time I did not fiddle with any header files and only
      removed #includes from .c-files, which tend to cause less trouble.
      
      Compile tested against 2.6.20-rc2 and 2.6.20-rc2-mm2 (with offsets) on alpha,
      arm, i386, ia64, mips, powerpc, and x86_64 with allnoconfig, defconfig,
      allmodconfig, and allyesconfig as well as a few randconfigs on x86_64 and all
      configs in arch/arm/configs on arm.  I also checked that no new warnings were
      introduced by the patch (actually, some warnings are removed that were emitted
      by unnecessarily included header files).
      Signed-off-by: default avatarTim Schmielau <tim@physik3.uni-rostock.de>
      Acked-by: default avatarRussell King <rmk+kernel@arm.linux.org.uk>
      Signed-off-by: default avatarAndrew Morton <akpm@linux-foundation.org>
      Signed-off-by: default avatarLinus Torvalds <torvalds@linux-foundation.org>
      cd354f1a
  11. 27 Jan, 2007 2 commits
    • Mark Haverkamp's avatar
      [SCSI] aacraid: expanded expose physical device code (new) · e37ee4be
      Mark Haverkamp authored
      
      
      Received from Mark Salyzyn,
      
      Take the expose_physicals flag and allow the user to select default (physicals
      available via /dev/sg), exposed (physicals available via /dev/sd for
      experimental reasons) and hidden (physicals blocked from all access). This
      expands the functionality of the previous expose_physicals insmod parameter
      which was added to support some experimental configurations.
      
      Signed-off-by Mark Haverkamp <markh@linux-foundation.org>
      Signed-off-by: default avatarJames Bottomley <James.Bottomley@SteelEye.com>
      e37ee4be
    • Mark Haverkamp's avatar
      [SCSI] aacraid: rework packet support code · e8f32de5
      Mark Haverkamp authored
      
      
      Received from Mark Salyzyn,
      
      Replace all if/else packet formations with platform function calls. This is in
      recognition of the proliferation of read and write packet types, and in the
      need to migrate to up-and-coming packets for new products.
      
      Signed-off-by Mark Haverkamp <markh@linux-foundation.org>
      Signed-off-by: default avatarJames Bottomley <James.Bottomley@SteelEye.com>
      e8f32de5
  12. 13 Dec, 2006 1 commit
    • Robert P. J. Day's avatar
      [PATCH] getting rid of all casts of k[cmz]alloc() calls · 5cbded58
      Robert P. J. Day authored
      
      
      Run this:
      
      	#!/bin/sh
      	for f in $(grep -Erl "\([^\)]*\) *k[cmz]alloc" *) ; do
      	  echo "De-casting $f..."
      	  perl -pi -e "s/ ?= ?\([^\)]*\) *(k[cmz]alloc) *\(/ = \1\(/" $f
      	done
      
      And then go through and reinstate those cases where code is casting pointers
      to non-pointers.
      
      And then drop a few hunks which conflicted with outstanding work.
      
      Cc: Russell King <rmk@arm.linux.org.uk>, Ian Molton <spyro@f2s.com>
      Cc: Mikael Starvik <starvik@axis.com>
      Cc: Yoshinori Sato <ysato@users.sourceforge.jp>
      Cc: Roman Zippel <zippel@linux-m68k.org>
      Cc: Geert Uytterhoeven <geert@linux-m68k.org>
      Cc: Ralf Baechle <ralf@linux-mips.org>
      Cc: Paul Mackerras <paulus@samba.org>
      Cc: Kyle McMartin <kyle@mcmartin.ca>
      Cc: Benjamin Herrenschmidt <benh@kernel.crashing.org>
      Cc: Martin Schwidefsky <schwidefsky@de.ibm.com>
      Cc: "David S. Miller" <davem@davemloft.net>
      Cc: Jeff Dike <jdike@addtoit.com>
      Cc: Greg KH <greg@kroah.com>
      Cc: Jens Axboe <jens.axboe@oracle.com>
      Cc: Paul Fulghum <paulkf@microgate.com>
      Cc: Alan Cox <alan@lxorguk.ukuu.org.uk>
      Cc: Karsten Keil <kkeil@suse.de>
      Cc: Mauro Carvalho Chehab <mchehab@infradead.org>
      Cc: Jeff Garzik <jeff@garzik.org>
      Cc: James Bottomley <James.Bottomley@steeleye.com>
      Cc: Ian Kent <raven@themaw.net>
      Cc: Steven French <sfrench@us.ibm.com>
      Cc: David Woodhouse <dwmw2@infradead.org>
      Cc: Neil Brown <neilb@cse.unsw.edu.au>
      Cc: Jaroslav Kysela <perex@suse.cz>
      Cc: Takashi Iwai <tiwai@suse.de>
      Signed-off-by: default avatarAndrew Morton <akpm@osdl.org>
      Signed-off-by: default avatarLinus Torvalds <torvalds@osdl.org>
      5cbded58
  13. 23 Sep, 2006 2 commits
    • Mark Haverkamp's avatar
      [SCSI] aacraid: expose physical devices · 653ba58d
      Mark Haverkamp authored
      
      
      Received from Mark Salyzyn:
      
      I am placing this functionality into an insmod parameter. Normally the physical
      components are exported to sg, and are blocked from showing up in sd.
      
      Note that the pass-through I/O path via the driver through the Firmware to the
      physical disks is not an optimized path, the card is designed for Hardware
      RAID, elevator sorting and caching. This should not be used as a means for
      utilizing the aacraid based controllers as a generic scsi/SATA/SAS controller,
      performance should suck by a few percentage points, any RAID meta-data on the
      drives will confuse the controller about who owns the drives and there is a
      high risk of destroying content in both directions. Unreliable and for
      experimentation or strange controlled circumstances only.
      Signed-off-by: default avatarMark Haverkamp <markh@osdl.org>
      Signed-off-by: default avatarJames Bottomley <James.Bottomley@SteelEye.com>
      653ba58d
    • Mark Haverkamp's avatar
      [SCSI] aacraid: misc cleanup · 65101355
      Mark Haverkamp authored
      
      
      Received from Mark Salyzyn:
      
      Basically cleanup, nothing here will have an affect. Adjusting some
      error codes, removing superfluous definitions and code fragments.
      Signed-off-by: default avatarMark Haverkamp <markh@osdl.org>
      Signed-off-by: default avatarJames Bottomley <James.Bottomley@SteelEye.com>
      65101355
  14. 19 Aug, 2006 2 commits
  15. 23 Jun, 2006 1 commit
  16. 10 Jun, 2006 1 commit
  17. 06 Jun, 2006 1 commit
  18. 20 May, 2006 2 commits
    • Mark Haverkamp's avatar
      [SCSI] aacraid: adjustable timeouts · 404d9a90
      Mark Haverkamp authored
      
      
      Received From Mark Salyzyn
      
      Add the ability to adjust for unusual corner case failures. Both of
      these additional module parameters deal with embedded, non-intel or
      complicated system scenarios.
      
      Aif_timeout can be increased past the default 2 minute timeout to drop
      application registrations when a system has an unusually high event load
      resulting from continuing management requests, or simultaneous builds,
      or sluggish user space as a result of system load.
      
      Startup_timeout can be increased past the default 3 minute timeout to
      drop an adapter initialization for systems that have a very large number
      of targets, or slow to spin-up targets, or a complicated set of array
      configurations that extend the time for the firmware to declare that it
      is operational. This timeout would only have an affect on non-intel
      based systems, as the (more patient) BIOS would generally be where the
      startup delay would be dealt with.
      Signed-off-by: default avatarMark Haverkamp <markh@osdl.org>
      Signed-off-by: default avatarJames Bottomley <James.Bottomley@SteelEye.com>
      404d9a90
    • Mark Haverkamp's avatar
      [SCSI] aacraid: optimize sg alloc · 3c1e0cca
      Mark Haverkamp authored
      
      
      Received From Mark Salyzyn
      
      Slight space and speed efficiency improvement.
      Signed-off-by: default avatarMark Haverkamp <markh@osdl.org>
      Signed-off-by: default avatarJames Bottomley <James.Bottomley@SteelEye.com>
      3c1e0cca
  19. 13 Apr, 2006 4 commits
  20. 28 Mar, 2006 1 commit
  21. 04 Feb, 2006 2 commits
  22. 09 Nov, 2005 1 commit
  23. 28 Oct, 2005 3 commits