1. 27 Jun, 2008 1 commit
    • Steven Whitehouse's avatar
      [GFS2] Fix ordering bug in lock_dlm · f3c9d38a
      Steven Whitehouse authored
      
      
      This looks like a lot of change, but in fact its not. Mostly its
      things moving from one file to another. The change is just that
      instead of queuing lock completions and callbacks from the DLM
      we now pass them directly to GFS2.
      
      This gives us a net loss of two list heads per glock (a fair
      saving in memory) plus a reduction in the latency of delivering
      the messages to GFS2, plus we now have one thread fewer as well.
      There was a bug where callbacks and completions could be delivered
      in the wrong order due to this unnecessary queuing which is fixed
      by this patch.
      Signed-off-by: default avatarSteven Whitehouse <swhiteho@redhat.com>
      Cc: Bob Peterson <rpeterso@redhat.com>
      f3c9d38a
  2. 31 Mar, 2008 1 commit
    • Benjamin Marzinski's avatar
      [GFS2] Invalidate cache at correct point · 58e9fee1
      Benjamin Marzinski authored
      
      
      GFS2 wasn't invalidating its cache before it called into the lock manager
      with a request that could potentially drop a lock.  This was leaving a
      window where the lock could be actually be held by another node, but the
      file's page cache would still appear valid, causing coherency problems.
      This patch moves the cache invalidation to before the lock manager call
      when dropping a lock. It also adds the option to the lock_dlm lock
      manager to not use conversion mode deadlock avoidance, which, on a
      conversion from shared to exclusive, could internally drop the lock, and
      then reacquire in. GFS2 now asks lock_dlm to not do this.  Instead, GFS2
      manually drops the lock and reacquires it.
      Signed-off-by: default avatarBenjamin Marzinski <bmarzins@redhat.com>
      Signed-off-by: default avatarSteven Whitehouse <swhiteho@redhat.com>
      58e9fee1
  3. 25 Jan, 2008 1 commit
  4. 10 Oct, 2007 1 commit
    • Bob Peterson's avatar
      [GFS2] GFS2: chmod hung - fix race in thread creation · 55c0c4ac
      Bob Peterson authored
      
      
      The problem boiled down to a race between the gdlm_init_threads()
      function initializing thread1 and its setting of blist = 1.
      Essentially, "if (current == ls->thread1)" was checked by the thread
      before the thread creator set ls->thread1.
      
      Since thread1 is the only thread who is allowed to work on the
      blocking queue, and since neither thread thought it was thread1, no one
      was working on the queue.  So everything just sat.
      
      This patch reuses the ls->async_lock spin_lock to fix the race,
      and it fixes the problem.  I've done more than 2000 iterations of the
      loop that was recreating the failure and it seems to work.
      Signed-off-by: default avatarBob Peterson <rpeterso@redhat.com>
      Signed-off-by: default avatarSteven Whitehouse <swhiteho@redhat.com>
      
      --
      55c0c4ac
  5. 09 Jul, 2007 1 commit
  6. 25 Sep, 2006 1 commit
  7. 07 Sep, 2006 1 commit
    • Steven Whitehouse's avatar
      [GFS2] Remove one typedef · 1c089c32
      Steven Whitehouse authored
      
      
      This removes one of the typedefs from the locking interface. It
      is replaced by a forward declaration of the gfs2 superblock. The
      other two are not so easy to solve since in their case, they
      can refer to one of two possible structures.
      
      Cc: David Teigland <teigland@redhat.com>
      Cc: Jan Engelhardt <jengelh@linux01.gwdg.de>
      Signed-off-by: default avatarSteven Whitehouse <swhiteho@redhat.com>
      1c089c32
  8. 04 Sep, 2006 2 commits
  9. 01 Sep, 2006 1 commit
    • Steven Whitehouse's avatar
      [GFS2] Update copyright, tidy up incore.h · e9fc2aa0
      Steven Whitehouse authored
      
      
      As per comments from Jan Engelhardt <jengelh@linux01.gwdg.de> this
      updates the copyright message to say "version" in full rather than
      "v.2". Also incore.h has been updated to remove forward structure
      declarations which are not required.
      
      The gfs2_quota_lvb structure has now had endianess annotations added
      to it. Also quota.c has been updated so that we now store the
      lvb data locally in endian independant format to avoid needing
      a structure in host endianess too. As a result the endianess
      conversions are done as required at various points and thus the
      conversion routines in lvb.[ch] are no longer required. I've
      moved the one remaining constant in lvb.h thats used into lm.h
      and removed the unused lvb.[ch].
      
      I have not changed the HIF_ constants. That is left to a later patch
      which I hope will unify the gh_flags and gh_iflags fields of the
      struct gfs2_holder.
      
      Cc: Jan Engelhardt <jengelh@linux01.gwdg.de>
      Signed-off-by: default avatarSteven Whitehouse <swhiteho@redhat.com>
      e9fc2aa0
  10. 20 Jun, 2006 1 commit
    • David Woodhouse's avatar
      [GFS2] Fix printk format warnings in DLM code · 0239c4ae
      David Woodhouse authored
      
      
      fs/gfs2/locking/dlm/thread.c: In function ‘process_complete’:
      fs/gfs2/locking/dlm/thread.c:56: warning: format ‘%llx’ expects type ‘long long unsigned int’, but argument 3 has type ‘uint64_t’
      fs/gfs2/locking/dlm/thread.c:69: warning: format ‘%llx’ expects type ‘long long unsigned int’, but argument 4 has type ‘uint64_t’
      fs/gfs2/locking/dlm/thread.c:102: warning: format ‘%llx’ expects type ‘long long unsigned int’, but argument 3 has type ‘uint64_t’
      fs/gfs2/locking/dlm/thread.c:124: warning: format ‘%llx’ expects type ‘long long unsigned int’, but argument 4 has type ‘uint64_t’
      fs/gfs2/locking/dlm/thread.c:146: warning: format ‘%llx’ expects type ‘long long unsigned int’, but argument 4 has type ‘uint64_t’
      fs/gfs2/locking/dlm/thread.c:148: warning: format ‘%llx’ expects type ‘long long unsigned int’, but argument 4 has type ‘uint64_t’
      Signed-off-by: default avatarDavid Woodhouse <dwmw2@infradead.org>
      0239c4ae
  11. 23 Feb, 2006 1 commit
  12. 17 Jan, 2006 1 commit
  13. 16 Jan, 2006 1 commit