1. 11 Jan, 2011 1 commit
  2. 01 Oct, 2010 4 commits
  3. 04 Aug, 2010 1 commit
  4. 14 May, 2010 4 commits
  5. 13 Sep, 2009 1 commit
  6. 11 Sep, 2009 1 commit
  7. 09 Aug, 2009 2 commits
    • Chuck Lever's avatar
      SUNRPC: Kill RPC_DISPLAY_ALL · c740eff8
      Chuck Lever authored
      At some point, I recall that rpc_pipe_fs used RPC_DISPLAY_ALL.
      Currently there are no uses of RPC_DISPLAY_ALL outside the transport
      modules themselves, so we can safely get rid of it.
      Signed-off-by: default avatarChuck Lever <chuck.lever@oracle.com>
      Signed-off-by: default avatarTrond Myklebust <Trond.Myklebust@netapp.com>
    • Chuck Lever's avatar
      SUNRPC: Remove duplicate universal address generation · ba809130
      Chuck Lever authored
      RPC universal address generation is currently done in several places:
      rpcb_clnt.c, nfs4proc.c xprtsock.c, and xprtrdma.c.  Remove the
      redundant cases that convert a socket address to a universal
      address.  The nfs4proc.c case takes a pre-formatted presentation
      address string, not a socket address, so we'll leave that one.
      Because the new uaddr constructor uses the recently introduced
      rpc_ntop(), it now supports proper "::" shorthanding for IPv6
      addresses.  This allows the kernel to register properly formed
      universal addresses with the local rpcbind service, in _all_ cases.
      The kernel can now also send properly formed universal addresses in
      RPCB_GETADDR requests, and support link-local properly when
      encoding and decoding IPv6 addresses.
      Signed-off-by: default avatarChuck Lever <chuck.lever@oracle.com>
      Signed-off-by: default avatarTrond Myklebust <Trond.Myklebust@netapp.com>
  8. 17 Jun, 2009 4 commits
    • Ricardo Labiaga's avatar
      nfs41: Rename rq_received to rq_reply_bytes_recvd · dd2b63d0
      Ricardo Labiaga authored
      The 'rq_received' member of 'struct rpc_rqst' is used to track when we
      have received a reply to our request.  With v4.1, the backchannel
      can now accept callback requests over the existing connection.  Rename
      this field to make it clear that it is only used for tracking reply bytes
      and not all bytes received on the connection.
      Signed-off-by: default avatarRicardo Labiaga <Ricardo.Labiaga@netapp.com>
      Signed-off-by: default avatarBenny Halevy <bhalevy@panasas.com>
    • Ricardo Labiaga's avatar
      nfs41: Add backchannel processing support to RPC state machine · 55ae1aab
      Ricardo Labiaga authored
      Adds rpc_run_bc_task() which is called by the NFS callback service to
      process backchannel requests.  It performs similar work to rpc_run_task()
      though "schedules" the backchannel task to be executed starting at the
      call_trasmit state in the RPC state machine.
      It also introduces some miscellaneous updates to the argument validation,
      call_transmit, and transport cleanup functions to take into account
      that there are now forechannel and backchannel tasks.
      Backchannel requests do not carry an RPC message structure, since the
      payload has already been XDR encoded using the existing NFSv4 callback
      Introduce a new transmit state for the client to reply on to backchannel
      requests.  This new state simply reserves the transport and issues the
      reply.  In case of a connection related error, disconnects the transport and
      drops the reply.  It requires the forechannel to re-establish the connection
      and the server to retransmit the request, as stated in NFSv4.1 section
      2.9.2 "Client and Server Transport Behavior".
      Note: There is no need to loop attempting to reserve the transport.  If EAGAIN
      is returned by xprt_prepare_transmit(), return with tk_status == 0,
      setting tk_action to call_bc_transmit.  rpc_execute() will invoke it again
      after the task is taken off the sleep queue.
      [nfs41: rpc_run_bc_task() need not be exported outside RPC module]
      [nfs41: New call_bc_transmit RPC state]
      Signed-off-by: default avatarRicardo Labiaga <Ricardo.Labiaga@netapp.com>
      Signed-off-by: default avatarBenny Halevy <bhalevy@panasas.com>
      [nfs41: Backchannel: No need to loop in call_bc_transmit()]
      Signed-off-by: default avatarAndy Adamson <andros@netapp.com>
      Signed-off-by: default avatarRicardo Labiaga <Ricardo.Labiaga@netapp.com>
      Signed-off-by: default avatarBenny Halevy <bhalevy@panasas.com>
      [rpc_count_iostats incorrectly exits early]
      Signed-off-by: default avatarRicardo Labiaga <Ricardo.Labiaga@netapp.com>
      Signed-off-by: default avatarBenny Halevy <bhalevy@panasas.com>
      [Convert rpc_reply_expected() to inline function]
      [Remove unnecessary BUG_ON()]
      [Rename variable]
      Signed-off-by: default avatarRicardo Labiaga <Ricardo.Labiaga@netapp.com>
      Signed-off-by: default avatarBenny Halevy <bhalevy@panasas.com>
    • Ricardo Labiaga's avatar
      nfs41: New backchannel helper routines · fb7a0b9a
      Ricardo Labiaga authored
      This patch introduces support to setup the callback xprt on the client side.
      It allocates/ destroys the preallocated memory structures used to process
      backchannel requests.
      At setup time, xprt_setup_backchannel() is invoked to allocate one or
      more rpc_rqst structures and substructures.  This ensures that they
      are available when an RPC callback arrives.  The rpc_rqst structures
      are maintained in a linked list attached to the rpc_xprt structure.
      We keep track of the number of allocations so that they can be correctly
      removed when the channel is destroyed.
      When an RPC callback arrives, xprt_alloc_bc_request() is invoked to
      obtain a preallocated rpc_rqst structure.  An rpc_xprt structure is
      returned, and its RPC_BC_PREALLOC_IN_USE bit is set in
      rpc_xprt->bc_flags.  The structure is removed from the the list
      since it is now in use, and it will be later added back when its
      user is done with it.
      After the RPC callback replies, the rpc_rqst structure is returned
      by invoking xprt_free_bc_request().  This clears the
      RPC_BC_PREALLOC_IN_USE bit and adds it back to the list, allowing it
      to be reused by a subsequent RPC callback request.
      To be consistent with the reception of RPC messages, the backchannel requests
      should be placed into the 'struct rpc_rqst' rq_rcv_buf, which is then in turn
      copied to the 'struct rpc_rqst' rq_private_buf.
      [nfs41: Preallocate rpc_rqst receive buffer for handling callbacks]
      Signed-off-by: default avatarRicardo Labiaga <Ricardo.Labiaga@netapp.com>
      Signed-off-by: default avatarBenny Halevy <bhalevy@panasas.com>
      [Update copyright notice and explain page allocation]
      Signed-off-by: default avatarRicardo Labiaga <Ricardo.Labiaga@netapp.com>
      Signed-off-by: default avatarBenny Halevy <bhalevy@panasas.com>
    • Ricardo Labiaga's avatar
      nfs41: client callback structures · 56632b5b
      Ricardo Labiaga authored
      Adds new list of rpc_xprt structures, and a readers/writers lock to
      protect the list.  The list is used to preallocate resources for
      the backchannel during backchannel requests.  Callbacks are not
      expected to cause significant latency, so only one callback will
      be allowed at this time.
      It also adds a pointer to the NFS callback service so that
      requests can be directed to it for processing.
      New callback members added to svc_serv. The NFSv4.1 callback service will
      sleep on the svc_serv->svc_cb_waitq until new callback requests arrive.
      The request will be queued in svc_serv->svc_cb_list. This patch adds this
      list, the sleep queue and spinlock to svc_serv.
      [nfs41: NFSv4.1 callback support]
      Signed-off-by: default avatarRicardo Labiaga <ricardo.labiaga@netapp.com>
      Signed-off-by: default avatarBenny Halevy <bhalevy@panasas.com>
  9. 02 May, 2009 1 commit
  10. 19 Mar, 2009 1 commit
    • Trond Myklebust's avatar
      SUNRPC: Add the equivalent of the linger and linger2 timeouts to RPC sockets · 7d1e8255
      Trond Myklebust authored
      This fixes a regression against FreeBSD servers as reported by Tomas
      Kasparek. Apparently when using RPC over a TCP socket, the FreeBSD servers
      don't ever react to the client closing the socket, and so commit
       (SUNRPC: Use shutdown() instead of
      close() when disconnecting a TCP socket) causes the setup to hang forever
      whenever the client attempts to close and then reconnect.
      We break the deadlock by adding a 'linger2' style timeout to the socket,
      after which, the client will abort the connection using a TCP 'RST'.
      The default timeout is set to 15 seconds. A subsequent patch will put it
      under user control by means of a systctl.
      Signed-off-by: default avatarTrond Myklebust <Trond.Myklebust@netapp.com>
  11. 11 Mar, 2009 1 commit
  12. 23 Dec, 2008 1 commit
  13. 19 Apr, 2008 2 commits
    • Trond Myklebust's avatar
      SUNRPC: Don't disconnect more than once if retransmitting NFSv4 requests · 7c1d71cf
      Trond Myklebust authored
      NFSv4 requires us to ensure that we break the TCP connection before we're
      allowed to retransmit a request. However in the case where we're
      retransmitting several requests that have been sent on the same
      connection, we need to ensure that we don't interfere with the attempt to
      reconnect and/or break the connection again once it has been established.
      We therefore introduce a 'connection' cookie that is bumped every time a
      connection is broken. This allows requests to track if they need to force a
      Signed-off-by: default avatarTrond Myklebust <Trond.Myklebust@netapp.com>
    • Trond Myklebust's avatar
      SUNRPC: Fix up xprt_write_space() · b6ddf64f
      Trond Myklebust authored
      The rest of the networking layer uses SOCK_ASYNC_NOSPACE to signal whether
      or not we have someone waiting for buffer memory. Convert the SUNRPC layer
      to use the same idiom.
      Remove the unlikely()s in xs_udp_write_space and xs_tcp_write_space. In
      fact, the most common case will be that there is nobody waiting for buffer
      SOCK_NOSPACE is there to tell the TCP layer whether or not the cwnd was
      limited by the application window. Ensure that we follow the same idiom as
      the rest of the networking layer here too.
      Finally, ensure that we clear SOCK_ASYNC_NOSPACE once we wake up, so that
      write_space() doesn't keep waking things up on xprt->pending.
      Signed-off-by: default avatarTrond Myklebust <Trond.Myklebust@netapp.com>
  14. 30 Jan, 2008 6 commits
  15. 09 Oct, 2007 7 commits
  16. 10 Jul, 2007 2 commits
  17. 14 May, 2007 1 commit