All new accounts created on Gitlab now require administrator approval. If you invite any collaborators, please let Flux staff know so they can approve the accounts.

  1. 11 Feb, 2013 15 commits
  2. 08 Feb, 2013 1 commit
  3. 05 Feb, 2013 1 commit
  4. 04 Feb, 2013 16 commits
    • Marco Porsch's avatar
      mac80211: mesh power save basics · 3f52b7e3
      Marco Porsch authored
      Add routines to
      - maintain a PS mode for each peer and a non-peer PS mode
      - indicate own PS mode in transmitted frames
      - track neighbor STAs power modes
      - buffer frames when neighbors are in PS mode
      - add TIM and Awake Window IE to beacons
      - release frames in Mesh Peer Service Periods
      
      Add local_pm to sta_info to represent the link-specific power
      mode at this station towards the remote station. When a peer
      link is established, use the default power mode stored in mesh
      config. Update the PS status if the peering status of a neighbor
      changes.
      Maintain a mesh power mode for non-peer mesh STAs. Set the
      non-peer power mode to active mode during peering. Authenticated
      mesh peering is currently not working when either node is
      configured to be in power save mode.
      
      Indicate the current power mode in transmitted frames. Use QoS
      Nulls to indicate mesh power mode transitions.
      For performance reasons, calls to the function setting the frame
      flags are placed in HWMP routing routines, as there the STA
      pointer is already available.
      
      Add peer_pm to sta_info to represent the peer's link-specific
      power mode towards the local station. Add nonpeer_pm to
      represent the peer's power mode towards all non-peer stations.
      Track power modes based on received frames.
      
      Add the ps_data structure to ieee80211_if_mesh (for TIM map, PS
      neighbor counter and group-addressed frame buffer).
      
      Set WLAN_STA_PS flag for STA in PS mode to use the unicast frame
      buffering routines in the tx path. Update num_sta_ps to buffer
      and release group-addressed frames after DTIM beacons.
      
      Announce the awake window duration in beacons if in light or
      deep sleep mode towards any peer or non-peer. Create a TIM IE
      similarly to AP mode and add it to mesh beacons. Parse received
      Awake Window IEs and check TIM IEs for buffered frames.
      
      Release frames towards peers in mesh Peer Service Periods. Use
      the corresponding trigger frames and monitor the MPSP status.
      Append a QoS Null as trigger frame if neccessary to properly end
      the MPSP. Currently, in HT channels MPSPs behave imperfectly and
      show large delay spikes and frame losses.
      Signed-off-by: default avatarMarco Porsch <marco@cozybit.com>
      Signed-off-by: default avatarIvan Bezyazychnyy <ivan.bezyazychnyy@gmail.com>
      Signed-off-by: default avatarMike Krinkin <krinkin.m.u@gmail.com>
      Signed-off-by: default avatarMax Filippov <jcmvbkbc@gmail.com>
      Signed-off-by: default avatarJohannes Berg <johannes.berg@intel.com>
      3f52b7e3
    • Johannes Berg's avatar
      cfg80211: wrap BSS kref · 0532d4f1
      Johannes Berg authored
      Add inline wrappers for the BSS struct krefs
      to be able to extend them easily later.
      Signed-off-by: default avatarJohannes Berg <johannes.berg@intel.com>
      0532d4f1
    • Johannes Berg's avatar
      cfg80211: remove a local variable · 9537f227
      Johannes Berg authored
      This local variable is only used once, so remove it.
      Signed-off-by: default avatarJohannes Berg <johannes.berg@intel.com>
      9537f227
    • Johannes Berg's avatar
      cfg80211: use lockdep to assert lock is held · 4b1af479
      Johannes Berg authored
      Instead of annotating with a comment, add a lockdep
      annotation which also serves as documentation.
      Signed-off-by: default avatarJohannes Berg <johannes.berg@intel.com>
      4b1af479
    • Johannes Berg's avatar
      mac80211: send deauth if connection was lost during suspend · 6b684db1
      Johannes Berg authored
      If the driver determined the connection was lost or that
      it couldn't securely maintain the connection when coming
      out of WoWLAN, send a deauth frame to the AP to also let
      it know.
      Signed-off-by: default avatarJohannes Berg <johannes.berg@intel.com>
      6b684db1
    • Johannes Berg's avatar
      mac80211: allow transmitting deauth with tainted key · e54faf29
      Johannes Berg authored
      When we had a connection for WoWLAN and after resume it
      needed to be disconnected, the previous commit enabled
      sending a deauth frame to the AP. This frame would not
      go through on MFP-enabled networks as the key for it is
      marked tainted before the frame is transmitted.
      
      Allow a tainted key to be used for deauth frames. Worst
      case, we'll use a wrong key because the PTK was rekeyed
      while suspended, but more likely the PTK is still fine
      and the taint flag really only applies to the GTK(s).
      Signed-off-by: default avatarJohannes Berg <johannes.berg@intel.com>
      e54faf29
    • Johannes Berg's avatar
      cfg80211: move locking into cfg80211_bss_age · 2ca813ad
      Johannes Berg authored
      There's no reason for it to require external
      locking, move it into the function.
      Signed-off-by: default avatarJohannes Berg <johannes.berg@intel.com>
      2ca813ad
    • Johannes Berg's avatar
      cfg80211: fix BSS IE allocation comment · 50521aa8
      Johannes Berg authored
      The comment about allocating the IEs together with
      the BSS struct is no longer true, remove it. Also
      fix a typo in the same area.
      Signed-off-by: default avatarJohannes Berg <johannes.berg@intel.com>
      50521aa8
    • Johannes Berg's avatar
      mac80211: remove unused SSID from BSS · 3146a7da
      Johannes Berg authored
      The ssid/ssid_len fields in the private BSS
      struct are unused, contrary to the comment
      we do look up the SSID in the few cases we
      need it.
      Signed-off-by: default avatarJohannes Berg <johannes.berg@intel.com>
      3146a7da
    • Johannes Berg's avatar
      cfg80211: remove unused cfg80211_get_mesh · 37e08381
      Johannes Berg authored
      As Thomas pointed out, cfg80211_get_mesh() is
      unused and can be removed.
      
      Cc: Thomas Pedersen <thomas@cozybit.com>
      Signed-off-by: default avatarJohannes Berg <johannes.berg@intel.com>
      37e08381
    • Johannes Berg's avatar
      cfg80211: simplify mesh BSS comparison · 3af6341c
      Johannes Berg authored
      Instead of first checking if a BSS is an MBSS
      and then doing the comparisons, inline it all
      into the BSS comparison function. This avoids
      doing the IE searches twice and is also a lot
      less code.
      Signed-off-by: default avatarJohannes Berg <johannes.berg@intel.com>
      3af6341c
    • Johannes Berg's avatar
      cfg80211: fix BSS list hidden SSID lookup · 4593c4cb
      Johannes Berg authored
      When trying to find a hidden SSID, the lookup function
      is done wrong; the code is trying to combine the two
      lookups into one, and as a consequence doesn't always
      find the entry at all. To understand this, consider a
      case where multiple BSS entries with the same channel
      and BSSID exist but have different SSID length. Then
      comparing against the probe response SSID length is
      bound to cause problems since the hidden one might be
      either zeroed out or zero-length.
      
      To fix this we need to do two lookups for the two ways
      to hide SSIDs.
      Signed-off-by: default avatarJohannes Berg <johannes.berg@intel.com>
      4593c4cb
    • Johannes Berg's avatar
      cfg80211: refactor hidden SSID finding · 5622f5bb
      Johannes Berg authored
      Instead of duplicating the rbtree functions, pass
      an argument to the compare function. This removes
      the code duplication for the two searches.
      Signed-off-by: default avatarJohannes Berg <johannes.berg@intel.com>
      5622f5bb
    • Vladimir Kondratiev's avatar
      cfg80211: expand per-station byte counters to 64bit · 42745e03
      Vladimir Kondratiev authored
      In per-station statistics, present 32bit counters are too small
      for practical purposes - with gigabit speeds, it get overlapped
      every few seconds.
      
      Expand counters in the struct station_info to be 64-bit.
      Driver can still fill only 32-bit and indicate in @filled
      only bits like STATION_INFO_[TR]X_BYTES; in case driver provides
      full 64-bit counter, it should also set in @filled
      bit STATION_INFO_[TR]RX_BYTES64
      
      Netlink sends both 32-bit and 64-bit counters, if present, to not
      break userspace.
      Signed-off-by: default avatarVladimir Kondratiev <qca_vkondrat@qca.qualcomm.com>
      [change to also have 32-bit counters if driver advertises 64-bit]
      Signed-off-by: default avatarJohannes Berg <johannes.berg@intel.com>
      42745e03
    • Johannes Berg's avatar
      mac80211: always allow calling ieee80211_connection_loss() · 682bd38b
      Johannes Berg authored
      With multi-channel, there's a corner case where a driver
      doesn't receive a beacon soon enough to be able to sync
      its timers with the AP. In this case, the only recovery
      (after trying again) is to disconnect from the AP. Allow
      calling ieee80211_connection_loss() for such cases. To
      make that possible, modify the work function to not rely
      on the IEEE80211_HW_CONNECTION_MONITOR flag but use new
      state kept in the interface instead.
      Signed-off-by: default avatarJohannes Berg <johannes.berg@intel.com>
      682bd38b
    • Johannes Berg's avatar
      mac80211: send deauth when connection is lost · eef9e54c
      Johannes Berg authored
      If the driver determines the connection is lost,
      send a deauth frame to the AP anyway just in case
      it still considers the connection alive. The frame
      might not go through, but at least we've tried.
      Signed-off-by: default avatarJohannes Berg <johannes.berg@intel.com>
      eef9e54c
  5. 01 Feb, 2013 7 commits
    • Andre Guedes's avatar
      Bluetooth: Refactor mgmt_pending_foreach · a3d09356
      Andre Guedes authored
      This patch does a trivial refactor in mgmt_pending_foreach function.
      It replaces list_for_each_safe by list_for_each_entry_safe, simplifying
      the function.
      Signed-off-by: default avatarAndre Guedes <andre.guedes@openbossa.org>
      Signed-off-by: default avatarGustavo Padovan <gustavo.padovan@collabora.co.uk>
      a3d09356
    • Andre Guedes's avatar
      Bluetooth: Remove unneeded locking · 2b8a9a2e
      Andre Guedes authored
      This patch removes unneeded locking in hci_le_adv_report_evt. There
      is no need to lock hdev before calling mgmt_device_found.
      Signed-off-by: default avatarAndre Guedes <andre.guedes@openbossa.org>
      Signed-off-by: default avatarGustavo Padovan <gustavo.padovan@collabora.co.uk>
      2b8a9a2e
    • Andre Guedes's avatar
      Bluetooth: Reduce critical section in sco_conn_ready · 40528088
      Andre Guedes authored
      This patch reduces the critical section protected by sco_conn_lock in
      sco_conn_ready function. The lock is acquired only when it is really
      needed.
      
      This patch fixes the following lockdep warning which is generated
      when the host terminates a SCO connection.
      
      Today, this warning is a false positive. There is no way those
      two threads reported by lockdep are running at the same time since
      hdev->workqueue (where rx_work is queued) is single-thread. However,
      if somehow this behavior is changed in future, we will have a
      potential deadlock.
      
      ======================================================
      [ INFO: possible circular locking dependency detected ]
      3.8.0-rc1+ #7 Not tainted
      -------------------------------------------------------
      kworker/u:1H/1018 is trying to acquire lock:
       (&(&conn->lock)->rlock){+.+...}, at: [<ffffffffa0033ba6>] sco_chan_del+0x66/0x190 [bluetooth]
      
      but task is already holding lock:
       (slock-AF_BLUETOOTH-BTPROTO_SCO){+.+...}, at: [<ffffffffa0033d5a>] sco_conn_del+0x8a/0xe0 [bluetooth]
      
      which lock already depends on the new lock.
      
      the existing dependency chain (in reverse order) is:
      
      -> #1 (slock-AF_BLUETOOTH-BTPROTO_SCO){+.+...}:
             [<ffffffff81083011>] lock_acquire+0xb1/0xe0
             [<ffffffff813efd01>] _raw_spin_lock+0x41/0x80
             [<ffffffffa003436e>] sco_connect_cfm+0xbe/0x350 [bluetooth]
             [<ffffffffa0015d6c>] hci_event_packet+0xd3c/0x29b0 [bluetooth]
             [<ffffffffa0004583>] hci_rx_work+0x133/0x870 [bluetooth]
             [<ffffffff8104d65f>] process_one_work+0x2bf/0x4f0
             [<ffffffff81050022>] worker_thread+0x2b2/0x3e0
             [<ffffffff81056021>] kthread+0xd1/0xe0
             [<ffffffff813f14bc>] ret_from_fork+0x7c/0xb0
      
      -> #0 (&(&conn->lock)->rlock){+.+...}:
             [<ffffffff81082215>] __lock_acquire+0x1465/0x1c70
             [<ffffffff81083011>] lock_acquire+0xb1/0xe0
             [<ffffffff813efd01>] _raw_spin_lock+0x41/0x80
             [<ffffffffa0033ba6>] sco_chan_del+0x66/0x190 [bluetooth]
             [<ffffffffa0033d6d>] sco_conn_del+0x9d/0xe0 [bluetooth]
             [<ffffffffa0034653>] sco_disconn_cfm+0x53/0x60 [bluetooth]
             [<ffffffffa000fef3>] hci_disconn_complete_evt.isra.54+0x363/0x3c0 [bluetooth]
             [<ffffffffa00150f7>] hci_event_packet+0xc7/0x29b0 [bluetooth]
             [<ffffffffa0004583>] hci_rx_work+0x133/0x870 [bluetooth]
             [<ffffffff8104d65f>] process_one_work+0x2bf/0x4f0
             [<ffffffff81050022>] worker_thread+0x2b2/0x3e0
             [<ffffffff81056021>] kthread+0xd1/0xe0
             [<ffffffff813f14bc>] ret_from_fork+0x7c/0xb0
      
      other info that might help us debug this:
      
       Possible unsafe locking scenario:
      
             CPU0                    CPU1
             ----                    ----
        lock(slock-AF_BLUETOOTH-BTPROTO_SCO);
                                     lock(&(&conn->lock)->rlock);
                                     lock(slock-AF_BLUETOOTH-BTPROTO_SCO);
        lock(&(&conn->lock)->rlock);
      
       *** DEADLOCK ***
      
      4 locks held by kworker/u:1H/1018:
       #0:  (hdev->name#2){.+.+.+}, at: [<ffffffff8104d5f8>] process_one_work+0x258/0x4f0
       #1:  ((&hdev->rx_work)){+.+.+.}, at: [<ffffffff8104d5f8>] process_one_work+0x258/0x4f0
       #2:  (&hdev->lock){+.+.+.}, at: [<ffffffffa000fbe9>] hci_disconn_complete_evt.isra.54+0x59/0x3c0 [bluetooth]
       #3:  (slock-AF_BLUETOOTH-BTPROTO_SCO){+.+...}, at: [<ffffffffa0033d5a>] sco_conn_del+0x8a/0xe0 [bluetooth]
      
      stack backtrace:
      Pid: 1018, comm: kworker/u:1H Not tainted 3.8.0-rc1+ #7
      Call Trace:
       [<ffffffff813e92f9>] print_circular_bug+0x1fb/0x20c
       [<ffffffff81082215>] __lock_acquire+0x1465/0x1c70
       [<ffffffff81083011>] lock_acquire+0xb1/0xe0
       [<ffffffffa0033ba6>] ? sco_chan_del+0x66/0x190 [bluetooth]
       [<ffffffff813efd01>] _raw_spin_lock+0x41/0x80
       [<ffffffffa0033ba6>] ? sco_chan_del+0x66/0x190 [bluetooth]
       [<ffffffffa0033ba6>] sco_chan_del+0x66/0x190 [bluetooth]
       [<ffffffffa0033d6d>] sco_conn_del+0x9d/0xe0 [bluetooth]
       [<ffffffffa0034653>] sco_disconn_cfm+0x53/0x60 [bluetooth]
       [<ffffffffa000fef3>] hci_disconn_complete_evt.isra.54+0x363/0x3c0 [bluetooth]
       [<ffffffffa000fbd0>] ? hci_disconn_complete_evt.isra.54+0x40/0x3c0 [bluetooth]
       [<ffffffffa00150f7>] hci_event_packet+0xc7/0x29b0 [bluetooth]
       [<ffffffff81202e90>] ? __dynamic_pr_debug+0x80/0x90
       [<ffffffff8133ff7d>] ? kfree_skb+0x2d/0x40
       [<ffffffffa0021644>] ? hci_send_to_monitor+0x1a4/0x1c0 [bluetooth]
       [<ffffffffa0004583>] hci_rx_work+0x133/0x870 [bluetooth]
       [<ffffffff8104d5f8>] ? process_one_work+0x258/0x4f0
       [<ffffffff8104d65f>] process_one_work+0x2bf/0x4f0
       [<ffffffff8104d5f8>] ? process_one_work+0x258/0x4f0
       [<ffffffff8104fdc1>] ? worker_thread+0x51/0x3e0
       [<ffffffffa0004450>] ? hci_tx_work+0x800/0x800 [bluetooth]
       [<ffffffff81050022>] worker_thread+0x2b2/0x3e0
       [<ffffffff8104fd70>] ? busy_worker_rebind_fn+0x100/0x100
       [<ffffffff81056021>] kthread+0xd1/0xe0
       [<ffffffff81055f50>] ? flush_kthread_worker+0xc0/0xc0
       [<ffffffff813f14bc>] ret_from_fork+0x7c/0xb0
       [<ffffffff81055f50>] ? flush_kthread_worker+0xc0/0xc0
      Signed-off-by: default avatarAndre Guedes <andre.guedes@openbossa.org>
      Signed-off-by: default avatarGustavo Padovan <gustavo.padovan@collabora.co.uk>
      40528088
    • Johan Hedberg's avatar
      Bluetooth: Increment Management interface revision · 3810285c
      Johan Hedberg authored
      This patch increments the management interface revision due to the
      various fixes, improvements and other changes that have gone in lately.
      Signed-off-by: default avatarJohan Hedberg <johan.hedberg@intel.com>
      Acked-by: default avatarMarcel Holtmann <marcel@holtmann.org>
      Signed-off-by: default avatarGustavo Padovan <gustavo.padovan@collabora.co.uk>
      3810285c
    • Johan Hedberg's avatar
      Bluetooth: Fix link security setting when powering on · f0ff92fb
      Johan Hedberg authored
      If a controller is powered on while the HCI_AUTO_OFF flag is set the
      link security setting (HCI_LINK_SECURITY) might not be in sync with the
      actual state of the controller (HCI_AUTH). This patch fixes the issue by
      checking for inequality between the intended and actual settings and
      sends a HCI_Write_Auth_Enable command if necessary.
      Signed-off-by: default avatarJohan Hedberg <johan.hedberg@intel.com>
      Acked-by: default avatarMarcel Holtmann <marcel@holtmann.org>
      Signed-off-by: default avatarGustavo Padovan <gustavo.padovan@collabora.co.uk>
      f0ff92fb
    • Johan Hedberg's avatar
      Bluetooth: Add support for 128-bit UUIDs in EIR data · c00d575b
      Johan Hedberg authored
      This patch adds the necessary code for encoding a list of 128-bit UUIDs
      into the EIR data.
      Signed-off-by: default avatarJohan Hedberg <johan.hedberg@intel.com>
      Acked-by: default avatarMarcel Holtmann <marcel@holtmann.org>
      Signed-off-by: default avatarGustavo Padovan <gustavo.padovan@collabora.co.uk>
      c00d575b
    • Johan Hedberg's avatar
      Bluetooth: Add support for 32-bit UUIDs in EIR data · cdf1963f
      Johan Hedberg authored
      This patch adds the necessary code for inserting a list of 32-bit UUIDs
      into the EIR data.
      Signed-off-by: default avatarJohan Hedberg <johan.hedberg@intel.com>
      Acked-by: default avatarMarcel Holtmann <marcel@holtmann.org>
      Signed-off-by: default avatarGustavo Padovan <gustavo.padovan@collabora.co.uk>
      cdf1963f