1. 02 Aug, 2010 8 commits
    • Aneesh Kumar K.V's avatar
    • Venkateswararao Jujjuri (JV)'s avatar
      fs/9p: This patch implements TLCREATE for 9p2000.L protocol. · 5643135a
      Venkateswararao Jujjuri (JV) authored
          size[4] Tlcreate tag[2] fid[4] name[s] flags[4] mode[4] gid[4]
          size[4] Rlcreate tag[2] qid[13] iounit[4]
      The Tlreate request asks the file server to create a new regular file with the
      name supplied, in the directory (dir) represented by fid.
      The mode argument specifies the permissions to use. New file is created with
      the uid if the fid and with supplied gid.
      The flags argument represent Linux access mode flags with which the caller
      is requesting to open the file with. Protocol allows all the Linux access
      modes but it is upto the server to allow/disallow any of these acess modes.
      If the server doesn't support any of the access mode, it is expected to
      return error.
      Signed-off-by: default avatarVenkateswararao Jujjuri <jvrao@linux.vnet.ibm.com>
      Signed-off-by: default avatarEric Van Hensbergen <ericvh@gmail.com>
    • M. Mohan Kumar's avatar
      9p: Implement TMKDIR · 01a622bd
      M. Mohan Kumar authored
      Implement TMKDIR as part of 2000.L Work
          size[4] Tmkdir tag[2] fid[4] name[s] mode[4] gid[4]
          size[4] Rmkdir tag[2] qid[13]
          mkdir asks the file server to create a directory with given name,
          mode and gid. The qid for the new directory is returned with
          the mkdir reply message.
      Note: 72 is selected as the opcode for TMKDIR from the reserved list.
      Signed-off-by: default avatarM. Mohan Kumar <mohan@in.ibm.com>
      Signed-off-by: default avatarVenkateswararao Jujjuri <jvrao@linux.vnet.ibm.com>
      Signed-off-by: default avatarEric Van Hensbergen <ericvh@gmail.com>
    • M. Mohan Kumar's avatar
      9p: Implement TMKNOD · 4b43516a
      M. Mohan Kumar authored
          size[4] Tmknod tag[2] fid[4] name[s] mode[4] major[4] minor[4] gid[4]
          size[4] Rmknod tag[2] qid[13]
          mknod asks the file server to create a device node with given major and
          minor number, mode and gid. The qid for the new device node is returned
          with the mknod reply message.
      [sripathik@in.ibm.com: Fix error handling code]
      Signed-off-by: default avatarM. Mohan Kumar <mohan@in.ibm.com>
      Signed-off-by: default avatarVenkateswararao Jujjuri <jvrao@linux.vnet.ibm.com>
      Signed-off-by: default avatarEric Van Hensbergen <ericvh@gmail.com>
    • Venkateswararao Jujjuri (JV)'s avatar
      9p: Define and implement TSYMLINK for 9P2000.L · 50cc42ff
      Venkateswararao Jujjuri (JV) authored
      Create a symbolic link
      size[4] Tsymlink tag[2] fid[4] name[s] symtgt[s] gid[4]
      size[4] Rsymlink tag[2] qid[13]
      Create a symbolic link named 'name' pointing to 'symtgt'.
      gid represents the effective group id of the caller.
      The  permissions of a symbolic link are irrelevant hence it is omitted
      from the protocol.
      Signed-off-by: default avatarVenkateswararao Jujjuri <jvrao@linux.vnet.ibm.com>
      Reviewed-by: default avatarSripathi Kodi <sripathik@in.ibm.com>
      Signed-off-by: default avatarEric Van Hensbergen <ericvh@gmail.com>
    • Eric Van Hensbergen's avatar
      9p: Define and implement TLINK for 9P2000.L · 09d34ee5
      Eric Van Hensbergen authored
      This patch adds a helper function to get the dentry from inode and
      uses it in creating a Hardlink
      size[4] Tlink tag[2] dfid[4] oldfid[4] newpath[s]
      size[4] Rlink tag[2]
      Create a link 'newpath' in directory pointed by dfid linking to oldfid path.
      [sripathik@in.ibm.com : p9_client_link should not free req structure
      if p9_client_rpc has returned an error.]
      Signed-off-by: default avatarVenkateswararao Jujjuri <jvrao@linux.vnet.ibm.com>
      Signed-off-by: default avatarEric Van Hensbergen <ericvh@gmail.com>
    • Sripathi Kodi's avatar
      9p: Implement client side of setattr for 9P2000.L protocol. · 87d7845a
      Sripathi Kodi authored
            size[4] Tsetattr tag[2] attr[n]
            size[4] Rsetattr tag[2]
            The setattr command changes some of the file status information.
            attr resembles the iattr structure used in Linux kernel. It
            specifies which status parameter is to be changed and to what
            value. It is laid out as follows:
                  specifies which status information is to be changed. Possible
                  values are:
                  ATTR_MODE       (1 << 0)
                  ATTR_UID        (1 << 1)
                  ATTR_GID        (1 << 2)
                  ATTR_SIZE       (1 << 3)
                  ATTR_ATIME      (1 << 4)
                  ATTR_MTIME      (1 << 5)
                  ATTR_ATIME_SET  (1 << 7)
                  ATTR_MTIME_SET  (1 << 8)
                  The last two bits represent whether the time information
                  is being sent by the client's user space. In the absense
                  of these bits the server always uses server's time.
                  File permission bits
                  Owner id of file
                  Group id of the file
                  File size
                  Time of last file access, seconds
                  Time of last file access, nanoseconds
                  Time of last file modification, seconds
                  Time of last file modification, nanoseconds
      Explanation of the patches:
      *) The kernel just copies relevent contents of iattr structure to
         p9_iattr_dotl structure and passes it down to the client. The
         only check it has is calling inode_change_ok()
      *) The p9_iattr_dotl structure does not have ctime and ia_file
         parameters because I don't think these are needed in our case.
         The client user space can request updating just ctime by calling
         chown(fd, -1, -1). This is handled on server side without a need
         for putting ctime on the wire.
      *) The server currently supports changing mode, time, ownership and
         size of the file.
      *) 9P RFC says "Either all the changes in wstat request happen, or
         none of them does: if the request succeeds, all changes were made;
         if it fails, none were."
         I have not done anything to implement this specifically because I
         don't see a reason.
      Signed-off-by: default avatarSripathi Kodi <sripathik@in.ibm.com>
      Signed-off-by: default avatarVenkateswararao Jujjuri <jvrao@linux.vnet.ibm.com>
      Signed-off-by: default avatarEric Van Hensbergen <ericvh@gmail.com>
    • Sripathi Kodi's avatar
      9p: getattr client implementation for 9P2000.L protocol. · f0853122
      Sripathi Kodi authored
                    size[4] Tgetattr tag[2] fid[4] request_mask[8]
                    size[4] Rgetattr tag[2] lstat[n]
                    The getattr transaction inquires about the file identified by fid.
                    request_mask is a bit mask that specifies which fields of the
                    stat structure is the client interested in.
                    The reply will contain a machine-independent directory entry,
                    laid out as follows:
                          Bit mask that indicates which fields in the stat structure
                          have been populated by the server
                          the type of the file (directory, etc.), represented as a bit
                          vector corresponding to the high 8 bits of the file's mode
                          version number for given path
                          the file server's unique identification for the file
                          Permission and flags
                          User id of owner
                          Group ID of owner
                          Number of hard links
                          Device ID (if special file)
                          Size, in bytes
                          Block size for file system IO
                          Number of file system blocks allocated
                          Time of last access, seconds
                          Time of last access, nanoseconds
                          Time of last modification, seconds
                          Time of last modification, nanoseconds
                          Time of last status change, seconds
                          Time of last status change, nanoseconds
                          Time of creation (birth) of file, seconds
                          Time of creation (birth) of file, nanoseconds
                          Inode generation
                          Data version number
                    request_mask and result_mask bit masks contain the following bits
                       #define P9_STATS_MODE          0x00000001ULL
                       #define P9_STATS_NLINK         0x00000002ULL
                       #define P9_STATS_UID           0x00000004ULL
                       #define P9_STATS_GID           0x00000008ULL
                       #define P9_STATS_RDEV          0x00000010ULL
                       #define P9_STATS_ATIME         0x00000020ULL
                       #define P9_STATS_MTIME         0x00000040ULL
                       #define P9_STATS_CTIME         0x00000080ULL
                       #define P9_STATS_INO           0x00000100ULL
                       #define P9_STATS_SIZE          0x00000200ULL
                       #define P9_STATS_BLOCKS        0x00000400ULL
                       #define P9_STATS_BTIME         0x00000800ULL
                       #define P9_STATS_GEN           0x00001000ULL
                       #define P9_STATS_DATA_VERSION  0x00002000ULL
                       #define P9_STATS_BASIC         0x000007ffULL
                       #define P9_STATS_ALL           0x00003fffULL
              This patch implements the client side of getattr implementation for
              9P2000.L. It introduces a new structure p9_stat_dotl for getting
              Linux stat information along with QID. The data layout is similar to
              stat structure in Linux user space with the following major
              inode (st_ino) is not part of data. Instead qid is.
              device (st_dev) is not part of data because this doesn't make sense
              on the client.
              All time variables are 64 bit wide on the wire. The kernel seems to use
              32 bit variables for these variables. However, some of the architectures
              have used 64 bit variables and glibc exposes 64 bit variables to user
              space on some architectures. Hence to be on the safer side we have made
              these 64 bit in the protocol. Refer to the comments in
              There are some additional fields: st_btime_sec, st_btime_nsec, st_gen,
              st_data_version apart from the bitmask, st_result_mask. The bit mask
              is filled by the server to indicate which stat fields have been
              populated by the server. Currently there is no clean way for the
              server to obtain these additional fields, so it sends back just the
              basic fields.
      Signed-off-by: default avatarSripathi Kodi <sripathik@in.ibm.com>
      Signed-off-by: default avatarEric Van Hensbegren <ericvh@gmail.com>
  2. 22 May, 2010 4 commits
  3. 21 May, 2010 3 commits
  4. 05 Apr, 2010 2 commits
  5. 30 Mar, 2010 1 commit
    • Tejun Heo's avatar
      include cleanup: Update gfp.h and slab.h includes to prepare for breaking... · 5a0e3ad6
      Tejun Heo authored
      include cleanup: Update gfp.h and slab.h includes to prepare for breaking implicit slab.h inclusion from percpu.h
      percpu.h is included by sched.h and module.h and thus ends up being
      included when building most .c files.  percpu.h includes slab.h which
      in turn includes gfp.h making everything defined by the two files
      universally available and complicating inclusion dependencies.
      percpu.h -> slab.h dependency is about to be removed.  Prepare for
      this change by updating users of gfp and slab facilities include those
      headers directly instead of assuming availability.  As this conversion
      needs to touch large number of source files, the following script is
      used as the basis of conversion.
      The script does the followings.
      * Scan files for gfp and slab usages and update includes such that
        only the necessary includes are there.  ie. if only gfp is used,
        gfp.h, if slab is used, slab.h.
      * When the script inserts a new include, it looks at the include
        blocks and try to put the new include such that its order conforms
        to its surrounding.  It's put in the include block which contains
        core kernel includes, in the same order that the rest are ordered -
        alphabetical, Christmas tree, rev-Xmas-tree or at the end if there
        doesn't seem to be any matching order.
      * If the script can't find a place to put a new include (mostly
        because the file doesn't have fitting include block), it prints out
        an error message indicating which .h file needs to be added to the
      The conversion was done in the following steps.
      1. The initial automatic conversion of all .c files updated slightly
         over 4000 files, deleting around 700 includes and adding ~480 gfp.h
         and ~3000 slab.h inclusions.  The script emitted errors for ~400
      2. Each error was manually checked.  Some didn't need the inclusion,
         some needed manual addition while adding it to implementation .h or
         embedding .c file was more appropriate for others.  This step added
         inclusions to around 150 files.
      3. The script was run again and the output was compared to the edits
         from #2 to make sure no file was left behind.
      4. Several build tests were done and a couple of problems were fixed.
         e.g. lib/decompress_*.c used malloc/free() wrappers around slab
         APIs requiring slab.h to be added manually.
      5. The script was run on all .h files but without automatically
         editing them as sprinkling gfp.h and slab.h inclusions around .h
         files could easily lead to inclusion dependency hell.  Most gfp.h
         inclusion directives were ignored as stuff from gfp.h was usually
         wildly available and often used in preprocessor macros.  Each
         slab.h inclusion directive was examined and added manually as
      6. percpu.h was updated not to include slab.h.
      7. Build test were done on the following configurations and failures
         were fixed.  CONFIG_GCOV_KERNEL was turned off for all tests (as my
         distributed build env didn't work with gcov compiles) and a few
         more options had to be turned off depending on archs to make things
         build (like ipr on powerpc/64 which failed due to missing writeq).
         * x86 and x86_64 UP and SMP allmodconfig and a custom test config.
         * powerpc and powerpc64 SMP allmodconfig
         * sparc and sparc64 SMP allmodconfig
         * ia64 SMP allmodconfig
         * s390 SMP allmodconfig
         * alpha SMP allmodconfig
         * um on x86_64 SMP allmodconfig
      8. percpu.h modifications were reverted so that it could be applied as
         a separate patch and serve as bisection point.
      Given the fact that I had only a couple of failures from tests on step
      6, I'm fairly confident about the coverage of this conversion patch.
      If there is a breakage, it's likely to be something in one of the arch
      headers which should be easily discoverable easily on most builds of
      the specific arch.
      Signed-off-by: default avatarTejun Heo <tj@kernel.org>
      Guess-its-ok-by: default avatarChristoph Lameter <cl@linux-foundation.org>
      Cc: Ingo Molnar <mingo@redhat.com>
      Cc: Lee Schermerhorn <Lee.Schermerhorn@hp.com>
  6. 05 Mar, 2010 2 commits
  7. 08 Feb, 2010 1 commit
    • M. Mohan Kumar's avatar
      9p: Include fsync support for 9p client · 7a4439c4
      M. Mohan Kumar authored
      Implement the fsync in the client side by marking stat field values to 'don't touch' so that server may 
      interpret it as a request to guarantee that the contents of the associated file are committed to stable 
      storage before the Rwstat message is returned.
      Without this patch, calling fsync on a 9p file results in "Invalid argument" error. Please check the attached 
      C program.
      Signed-off-by: Aneesh Kumar K.V <aneesh.kumar@linux.vnet.ibm.com> 
      Signed-off-by: M. Mohan Kumar <mohan@in.ibm.com> 
      Acked-by: default avatarVenkateswararao Jujjuri (JV) <jvrao@linux.vnet.ibm.com>
      Signed-off-by: default avatarEric Van Hensbergen <ericvh@gmail.com>
  8. 14 Jan, 2010 1 commit
  9. 02 Nov, 2009 1 commit
    • Martin Stava's avatar
      9p: fix readlink · 2511cd0b
      Martin Stava authored
      I do not know if you've looked on the patch, but unfortunately it is
      incorrect. A suggested better version is in this email (the old
      version didn't work in case the user provided buffer was not long
      enough - it incorrectly appended null byte on a position of last char,
      and thus broke the contract of the readlink method). However, I'm
      still not sure this is 100% correct thing to do, I think readlink is
      supposed to return buffer without last null byte in all cases, but we
      do return last null byte (even the old version).. on the other hand it
      is likely unspecified what is in the remaining part of the buffer, so
      null character may be fine there ;):
      Signed-off-by: default avatarMartin Stava <martin.stava@gmail.com>
      Signed-off-by: default avatarEric Van Hensbergen <ericvh@gmail.com>
  10. 23 Sep, 2009 2 commits
  11. 17 Aug, 2009 5 commits
  12. 19 Dec, 2008 2 commits
  13. 13 Nov, 2008 1 commit
  14. 17 Oct, 2008 2 commits
    • Magnus Deininger's avatar
      9p: fix device file handling · 57c7b4e6
      Magnus Deininger authored
      In v9fs_get_inode(), for block, as well as char devices (in theory), 
      the function init_special_inode() is called to set up callback functions 
      for file ops. this function uses the file mode's value to determine whether 
      to use block or char dev functions. In v9fs_inode_from_fid(), the function 
      p9mode2unixmode() is used, but for all devices it initially returns S_IFBLK, 
      then uses v9fs_get_inode() to initialise a new inode, then finally uses 
      v9fs_stat2inode(), which would determine whether the inode is a block or 
      character device. However, at that point init_special_inode() had already 
      decided to use the block device functions, so even if the inode's mode is 
      turned to a character device, the block functions are still used to operate 
      on them. The attached patch simply calls init_special_inode() again for devices 
      after parsing device node data in v9fs_stat2inode() so that the proper functions 
      are used.
      Signed-off-by: default avatarEric Van Hensbergen <ericvh@gmail.com>
    • Eric Van Hensbergen's avatar
      9p: rework client code to use new protocol support functions · 51a87c55
      Eric Van Hensbergen authored
      Now that the new protocol functions are in place, this patch switches
      the client code to using the new support code.
      Signed-off-by: default avatarEric Van Hensbergen <ericvh@gmail.com>
  15. 24 Sep, 2008 1 commit
  16. 03 Jul, 2008 1 commit
    • Eric Van Hensbergen's avatar
      9p: fix O_APPEND in legacy mode · 2e4bef41
      Eric Van Hensbergen authored
      The legacy protocol's open operation doesn't handle an append operation
      (it is expected that the client take care of it).  We were incorrectly
      passing the extended protocol's flag through even in legacy mode.  This
      was reported in bugzilla report #10689.  This patch fixes the problem
      by disallowing extended protocol open modes from being passed in legacy
      mode and implemented append functionality on the client side by adding
      a seek after the open.
      Signed-off-by: default avatarEric Van Hensbergen <ericvh@gmail.com>
  17. 14 May, 2008 1 commit
  18. 07 Feb, 2008 1 commit
  19. 06 Feb, 2008 1 commit