1. 07 Oct, 2009 1 commit
    • Johannes Berg's avatar
      iwlwifi: LED cleanup · e932a609
      Johannes Berg authored
      
      
      The iwlwifi drivers have LED blinking requirements that
      mac80211 cannot fulfill due to the use of just a single
      LED instead of different ones for TX, RX, radio etc.
      Instead, the single LED blinks according to transfers
      and is solid on the rest of the time. As such, having
      LED class devices registered that mac80211 triggers are
      connected to is pointless as we don't use the triggers
      anyway.
      
      Remove all the useless code and add hooks into the
      driver itself. At the same time, make the LED code
      abstracted so the core code that determines blink rate
      etc. can be shared between 3945 and agn in iwlcore.
      
      At the same time, the fact that we removed the use of
      the mac80211 LED triggers means we can also remove the
      IWLWIFI_LEDS Kconfig symbol since the LED support is
      now self-contained.
      Signed-off-by: default avatarJohannes Berg <johannes@sipsolutions.net>
      Signed-off-by: default avatarReinette Chatre <reinette.chatre@intel.com>
      Signed-off-by: default avatarJohn W. Linville <linville@tuxdriver.com>
      e932a609
  2. 28 Aug, 2009 1 commit
  3. 14 Aug, 2009 7 commits
  4. 29 Jul, 2009 1 commit
  5. 27 Jul, 2009 1 commit
  6. 24 Jul, 2009 3 commits
    • Reinette Chatre's avatar
      iwlwifi: make debug level more user friendly · a562a9dd
      Reinette Chatre authored
      
      
      * Deprecate the "debug50" module parameter used to obtain
        5000 series and up debugging. Replace it with "debug" module
        parameter to match with original driver and be consistent
        between them. The "debug50" module parameter can still be used,
        except that the module parameter is not writable in keeping
        with its previous state. We currently just mark it as "deprecated"
        and do not have it in the feature-removal-schedule. Some more
        cleanup of module parameters needs to be done and can then be
        entered together.
      
      * Only make "debug" module parameters visible if the driver
        is compiled with CONFIG_IWLWIFI_DEBUG. This will eliminate
        a lot of confusion where users think they have set debug flags
        but yet cannot see any debug output.
      
      * Make module parameters writable. This eliminates the need for the
        "debug_level" sysfs file, which can now also be deprecated and
        added to feature-removal-schedule. This file is in significant
        use though with many iwlwifi documents and text referring users
        to it. We can thus not take its removal lightly and keep it around.
      
      With iwlcore shared between iwlagn and iwl3945 we really do not need
      debug module parameters for each but can instead have one debug
      module parameter for the iwlcore module. The same issue is here as
      with the sysfs file - a lot of iwlwifi documentation and text (like
      bug reports) rely on iwlagn and iwl3945 having this module parameter,
      so changing this to a module parameter of iwlcore will have significant
      impact and we do not do this for that reason.
      
      One consequence of this patch is that if a user is running a system
      with both 3945 and later hardware then the setting of the one module
      parameter will affect the value of the other. The likelihood of this
      seems low - and even if this setup is present it does not seem like an
      issue for both modules to run with the same debug level.
      Signed-off-by: default avatarReinette Chatre <reinette.chatre@intel.com>
      Signed-off-by: default avatarJohn W. Linville <linville@tuxdriver.com>
      a562a9dd
    • Wey-Yi Guy's avatar
      iwlwifi: add led debugfs function · a283c011
      Wey-Yi Guy authored
      
      
      Adding debugfs file to show current led blinking rate
      /sys/kernel/debug/ieee80211/phy0/iwlagn/data/led
      Signed-off-by: default avatarWey-Yi Guy <wey-yi.w.guy@intel.com>
      Signed-off-by: default avatarReinette Chatre <reinette.chatre@intel.com>
      Signed-off-by: default avatarJohn W. Linville <linville@tuxdriver.com>
      a283c011
    • Wey-Yi Guy's avatar
      iwlwifi: move show_qos to debugfs · f5ad69fa
      Wey-Yi Guy authored
      
      
      This move the show_qos file from sysfs to debugfs because the "one
      value per file" sysfs rule.
      
      The file is located in
      /sys/kernel/debug/ieee80211/phy0/iwlagn/data
      Signed-off-by: default avatarWey-Yi Guy <wey-yi.w.guy@intel.com>
      Signed-off-by: default avatarReinette Chatre <reinette.chatre@intel.com>
      Signed-off-by: default avatarJohn W. Linville <linville@tuxdriver.com>
      f5ad69fa
  7. 10 Jul, 2009 1 commit
  8. 22 May, 2009 1 commit
  9. 22 Apr, 2009 1 commit
  10. 09 Feb, 2009 1 commit
  11. 29 Jan, 2009 9 commits
  12. 19 Dec, 2008 1 commit
  13. 12 Dec, 2008 1 commit
  14. 05 Dec, 2008 1 commit
  15. 21 Nov, 2008 1 commit
  16. 31 Oct, 2008 2 commits
  17. 22 Aug, 2008 1 commit
  18. 07 Aug, 2008 1 commit
  19. 04 Aug, 2008 1 commit
  20. 29 Jul, 2008 1 commit
    • Denis V. Lunev's avatar
      iwlwifi: compilation error when CONFIG_IWLWIFI_DEBUG is not set · c0b6a1c9
      Denis V. Lunev authored
      
      
      CC [M]  drivers/net/wireless/iwlwifi/iwl-rfkill.o
      drivers/net/wireless/iwlwifi/iwl-led.c: In function 'iwl_led_brightness_set':
      drivers/net/wireless/iwlwifi/iwl-led.c:198: error: 'led_type_str' undeclared (first use in this function)
      drivers/net/wireless/iwlwifi/iwl-led.c:198: error: (Each undeclared identifier is reported only once
      drivers/net/wireless/iwlwifi/iwl-led.c:198: error: for each function it appears in.)
      
      The problem is that led_type_str is defined under CONFIG_IWLWIFI_DEBUG
      while IWL_DEBUG is a static inline function in this case. Replace it
      with macro.
      Signed-off-by: default avatarDenis V. Lunev <den@openvz.org>
      Signed-off-by: default avatarJohn W. Linville <linville@tuxdriver.com>
      c0b6a1c9
  21. 14 Jun, 2008 2 commits
  22. 21 May, 2008 1 commit