1. 26 Aug, 2007 1 commit
    • Evgeniy Polyakov's avatar
      [VLAN/BRIDGE]: Fix "skb_pull_rcsum - Fatal exception in interrupt" · e7c243c9
      Evgeniy Polyakov authored
      
      
      I tried to preserve bridging code as it was before, but logic is quite
      strange - I think we should free skb on error, since it is already
      unshared and thus will just leak.
      
      Herbert Xu states:
      
      > +	if ((skb = skb_share_check(skb, GFP_ATOMIC)) == NULL)
      > +		goto out;
      
      If this happens it'll be a double-free on skb since we'll
      return NF_DROP which makes the caller free it too.
      
      We could return NF_STOLEN to prevent that but I'm not sure
      whether that's correct netfilter semantics.  Patrick, could
      you please make a call on this?
      
      Patrick McHardy states:
      
      NF_STOLEN should work fine here.
      Signed-off-by: default avatarEvgeniy Polyakov <johnpol@2ka.mipt.ru>
      Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
      e7c243c9
  2. 31 Jul, 2007 1 commit
    • Matthew Wilcox's avatar
      [NET]: ethtool ops are the only way · 61a44b9c
      Matthew Wilcox authored
      
      
      During the transition to the ethtool_ops way of doing things, we supported
      calling the device's ->do_ioctl method to allow unconverted drivers to
      continue working.  Those days are long behind us, all in-tree drivers
      use the ethtool_ops way, and so we no longer need to support this.
      
      The bonding driver is the biggest beneficiary of this; it no longer
      needs to call ioctl() as a fallback if ethtool_ops aren't supported.
      
      Also put a proper copyright statement on ethtool.c.
      Signed-off-by: default avatarMatthew Wilcox <matthew@wil.cx>
      Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
      61a44b9c
  3. 14 Jul, 2007 2 commits
  4. 11 Jul, 2007 1 commit
    • Patrick McHardy's avatar
      [VLAN]: Fix MAC address handling · 8c979c26
      Patrick McHardy authored
      
      
      The VLAN MAC address handling is broken in multiple ways. When the address
      differs when setting it, the real device is put in promiscous mode twice,
      but never taken out again. Additionally it doesn't resync when the real
      device's address is changed and needlessly puts it in promiscous mode when
      the vlan device is still down.
      
      Fix by moving address handling to vlan_dev_open/vlan_dev_stop and properly
      deal with address changes in the device notifier. Also switch to
      dev_unicast_add (which needs the exact same handling).
      
      Since the set_mac_address handler is identical to the generic ethernet one
      with these changes, kill it and use ether_setup().
      Signed-off-by: default avatarPatrick McHardy <kaber@trash.net>
      Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
      8c979c26
  5. 10 Jul, 2007 3 commits
  6. 25 Apr, 2007 4 commits
  7. 13 Apr, 2007 1 commit
    • Jerome Borsboom's avatar
      [VLAN]: Allow VLAN interface on top of bridge interface · 279e172a
      Jerome Borsboom authored
      
      
      When a VLAN interface is created on top of a bridge interface and 
      netfilter is enabled to see the bridged packets, the packets can be 
      corrupted when passing through the netfilter code. This is caused by the 
      VLAN driver not setting the 'protocol' and 'nh' members of the sk_buff 
      structure. In general, this is no problem as the VLAN interface is mostly 
      connected to a physical ethernet interface which does not use the 
      'protocol' and 'nh' members. For a bridge interface, however, these 
      members do matter.
      Signed-off-by: default avatarJerome Borsboom <j.borsboom@erasmusmc.nl>
      Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
      279e172a
  8. 11 Feb, 2007 1 commit
  9. 10 Oct, 2006 1 commit
  10. 20 Mar, 2006 1 commit
    • Herbert Xu's avatar
      [NET]: Replace skb_pull/skb_postpull_rcsum with skb_pull_rcsum · cbb042f9
      Herbert Xu authored
      
      
      We're now starting to have quite a number of places that do skb_pull
      followed immediately by an skb_postpull_rcsum.  We can merge these two
      operations into one function with skb_pull_rcsum.  This makes sense
      since most pull operations on receive skb's need to update the
      checksum.
      
      I've decided to make this out-of-line since it is fairly big and the
      fast path where hardware checksums are enabled need to call
      csum_partial anyway.
      
      Since this is a brand new function we get to add an extra check on the
      len argument.  As it is most callers of skb_pull ignore its return
      value which essentially means that there is no check on the len
      argument.
      Signed-off-by: default avatarHerbert Xu <herbert@gondor.apana.org.au>
      Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
      cbb042f9
  11. 10 Jan, 2006 1 commit
  12. 14 Dec, 2005 1 commit
  13. 19 Sep, 2005 1 commit
  14. 29 Aug, 2005 1 commit
    • David S. Miller's avatar
      [NET]: Kill skb->real_dev · f2ccd8fa
      David S. Miller authored
      
      
      Bonding just wants the device before the skb_bond()
      decapsulation occurs, so simply pass that original
      device into packet_type->func() as an argument.
      
      It remains to be seen whether we can use this same
      exact thing to get rid of skb->input_dev as well.
      Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
      f2ccd8fa
  15. 16 Apr, 2005 1 commit
    • Linus Torvalds's avatar
      Linux-2.6.12-rc2 · 1da177e4
      Linus Torvalds authored
      Initial git repository build. I'm not bothering with the full history,
      even though we have it. We can create a separate "historical" git
      archive of that later if we want to, and in the meantime it's about
      3.2GB when imported into git - space that would just make the early
      git days unnecessarily complicated, when we don't have a lot of good
      infrastructure for it.
      
      Let it rip!
      1da177e4