1. 26 Aug, 2007 1 commit
    • Evgeniy Polyakov's avatar
      [VLAN/BRIDGE]: Fix "skb_pull_rcsum - Fatal exception in interrupt" · e7c243c9
      Evgeniy Polyakov authored
      I tried to preserve bridging code as it was before, but logic is quite
      strange - I think we should free skb on error, since it is already
      unshared and thus will just leak.
      Herbert Xu states:
      > +	if ((skb = skb_share_check(skb, GFP_ATOMIC)) == NULL)
      > +		goto out;
      If this happens it'll be a double-free on skb since we'll
      return NF_DROP which makes the caller free it too.
      We could return NF_STOLEN to prevent that but I'm not sure
      whether that's correct netfilter semantics.  Patrick, could
      you please make a call on this?
      Patrick McHardy states:
      NF_STOLEN should work fine here.
      Signed-off-by: default avatarEvgeniy Polyakov <johnpol@2ka.mipt.ru>
      Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
  2. 14 Aug, 2007 1 commit
  3. 31 Jul, 2007 1 commit
    • Matthew Wilcox's avatar
      [NET]: ethtool ops are the only way · 61a44b9c
      Matthew Wilcox authored
      During the transition to the ethtool_ops way of doing things, we supported
      calling the device's ->do_ioctl method to allow unconverted drivers to
      continue working.  Those days are long behind us, all in-tree drivers
      use the ethtool_ops way, and so we no longer need to support this.
      The bonding driver is the biggest beneficiary of this; it no longer
      needs to call ioctl() as a fallback if ethtool_ops aren't supported.
      Also put a proper copyright statement on ethtool.c.
      Signed-off-by: default avatarMatthew Wilcox <matthew@wil.cx>
      Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
  4. 24 Jul, 2007 1 commit
  5. 14 Jul, 2007 3 commits
  6. 11 Jul, 2007 4 commits
  7. 10 Jul, 2007 10 commits
  8. 03 Jun, 2007 2 commits
  9. 03 May, 2007 1 commit
  10. 25 Apr, 2007 4 commits
  11. 13 Apr, 2007 1 commit
    • Jerome Borsboom's avatar
      [VLAN]: Allow VLAN interface on top of bridge interface · 279e172a
      Jerome Borsboom authored
      When a VLAN interface is created on top of a bridge interface and 
      netfilter is enabled to see the bridged packets, the packets can be 
      corrupted when passing through the netfilter code. This is caused by the 
      VLAN driver not setting the 'protocol' and 'nh' members of the sk_buff 
      structure. In general, this is no problem as the VLAN interface is mostly 
      connected to a physical ethernet interface which does not use the 
      'protocol' and 'nh' members. For a bridge interface, however, these 
      members do matter.
      Signed-off-by: default avatarJerome Borsboom <j.borsboom@erasmusmc.nl>
      Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
  12. 02 Mar, 2007 1 commit
  13. 12 Feb, 2007 1 commit
  14. 11 Feb, 2007 1 commit
  15. 10 Oct, 2006 1 commit
  16. 24 Jul, 2006 1 commit
  17. 21 Jul, 2006 1 commit
  18. 03 Jul, 2006 1 commit
  19. 30 Jun, 2006 1 commit
  20. 20 Mar, 2006 2 commits
    • Herbert Xu's avatar
      [NET]: Replace skb_pull/skb_postpull_rcsum with skb_pull_rcsum · cbb042f9
      Herbert Xu authored
      We're now starting to have quite a number of places that do skb_pull
      followed immediately by an skb_postpull_rcsum.  We can merge these two
      operations into one function with skb_pull_rcsum.  This makes sense
      since most pull operations on receive skb's need to update the
      I've decided to make this out-of-line since it is fairly big and the
      fast path where hardware checksums are enabled need to call
      csum_partial anyway.
      Since this is a brand new function we get to add an extra check on the
      len argument.  As it is most callers of skb_pull ignore its return
      value which essentially means that there is no check on the len
      Signed-off-by: default avatarHerbert Xu <herbert@gondor.apana.org.au>
      Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
    • Stefan Rompf's avatar
      [VLAN]: translate IF_OPER_DORMANT to netif_dormant_on() · ddd7bf9f
      Stefan Rompf authored
      this patch adds support to the VLAN driver to translate IF_OPER_DORMANT of the
      underlying device to netif_dormant_on(). Beside clean state forwarding, this
      allows running independant userspace supplicants on both the real device and
      the stacked VLAN. It depends on my RFC2863 patch.
      Signed-off-by: default avatarStefan Rompf <stefan@loplof.de>
      Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
  21. 11 Jan, 2006 1 commit