1. 15 Jul, 2008 9 commits
  2. 14 Jul, 2008 31 commits
    • Patrick McHardy's avatar
      61362766
    • Patrick McHardy's avatar
      vlan: clean up hard_start_xmit functions · d80aa31b
      Patrick McHardy authored
      
      
      Remove excessive comments and debugging, use NETDEV_TX codes,
      remove some empty lines.
      Signed-off-by: default avatarPatrick McHardy <kaber@trash.net>
      Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
      d80aa31b
    • Patrick McHardy's avatar
      vlan: clean up vlan_dev_hard_header() · 1349fe9a
      Patrick McHardy authored
      
      
      Remove some debugging and excessive comments, merge the two
      dev_hard_header calls into one.
      Signed-off-by: default avatarPatrick McHardy <kaber@trash.net>
      Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
      1349fe9a
    • Patrick McHardy's avatar
      vlan: ethtool ->get_flags support · 19b9a4e2
      Patrick McHardy authored
      
      
      Allow to query LRO settings of underlying device when VLAN RX
      acceleration is used.
      
      Suggested by Ben Hutchings <bhutchings@solarflare.com>.
      Signed-off-by: default avatarPatrick McHardy <kaber@trash.net>
      Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
      19b9a4e2
    • Patrick McHardy's avatar
      packet: deliver VLAN TCI to userspace · 393e52e3
      Patrick McHardy authored
      
      
      Store the VLAN tag in the auxillary data/tpacket2_hdr so userspace can
      properly deal with hardware VLAN tagging/stripping.
      Signed-off-by: default avatarPatrick McHardy <kaber@trash.net>
      Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
      393e52e3
    • Patrick McHardy's avatar
      packet: support extensible, 64 bit clean mmaped ring structure · bbd6ef87
      Patrick McHardy authored
      
      
      The tpacket_hdr is not 64 bit clean due to use of an unsigned long
      and can't be extended because the following struct sockaddr_ll needs
      to be at a fixed offset.
      
      Add support for a version 2 tpacket protocol that removes these
      limitations.
      
      Userspace can query the header size through a new getsockopt option
      and change the protocol version through a setsockopt option. The
      changes needed to switch to the new protocol version are:
      
      1. replace struct tpacket_hdr by struct tpacket2_hdr
      2. query header len and save
      3. set protocol version to 2
       - set up ring as usual
      4. for getting the sockaddr_ll, use (void *)hdr + TPACKET_ALIGN(hdrlen)
         instead of (void *)hdr + TPACKET_ALIGN(sizeof(struct tpacket_hdr))
      
      Steps 2 and 4 can be omitted if the struct sockaddr_ll isn't needed.
      Signed-off-by: default avatarPatrick McHardy <kaber@trash.net>
      Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
      bbd6ef87
    • Patrick McHardy's avatar
      vlan: deliver packets received with VLAN acceleration to network taps · bc1d0411
      Patrick McHardy authored
      
      
      When VLAN header stripping is used, packets currently bypass packet
      sockets (and other network taps) completely. For locally existing
      VLANs, they appear directly on the VLAN device, for unknown VLANs
      they are silently dropped.
      
      Add a new function netif_nit_deliver() to deliver incoming packets
      to all network interface taps and use it in __vlan_hwaccel_rx() to
      make VLAN packets visible on the underlying device.
      Signed-off-by: default avatarPatrick McHardy <kaber@trash.net>
      Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
      bc1d0411
    • Patrick McHardy's avatar
      vlan: Don't store VLAN tag in cb · 6aa895b0
      Patrick McHardy authored
      
      
      Use a real skb member to store the skb to avoid clashes with qdiscs,
      which are allowed to use the cb area themselves. As currently only real
      devices that consume the skb set the NETIF_F_HW_VLAN_TX flag, no explicit
      invalidation is neccessary.
      
      The new member fills a hole on 64 bit, the skb layout changes from:
      
              __u32                      mark;                 /*   172     4 */
              sk_buff_data_t             transport_header;     /*   176     4 */
              sk_buff_data_t             network_header;       /*   180     4 */
              sk_buff_data_t             mac_header;           /*   184     4 */
              sk_buff_data_t             tail;                 /*   188     4 */
              /* --- cacheline 3 boundary (192 bytes) --- */
              sk_buff_data_t             end;                  /*   192     4 */
      
              /* XXX 4 bytes hole, try to pack */
      
      to
      
              __u32                      mark;                 /*   172     4 */
              __u16                      vlan_tci;             /*   176     2 */
      
              /* XXX 2 bytes hole, try to pack */
      
              sk_buff_data_t             transport_header;     /*   180     4 */
              sk_buff_data_t             network_header;       /*   184     4 */
      Signed-off-by: default avatarPatrick McHardy <kaber@trash.net>
      Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
      6aa895b0
    • Allan Stephens's avatar
      tipc: Optimization to multicast name lookup algorithm · 968edbe1
      Allan Stephens authored
      
      
      This patch simplifies and speeds up TIPC's algorithm for identifying
      on-node and off-node destinations that overlap a multicast name
      sequence range.  Rather than traversing the list of all known name
      publications within the cluster, it now traverses the (potentially
      much shorter) list of name publications made by the node itself, and
      determines if any off-node destinations exist by comparing the sizes
      of the two lists.  (Since the node list must be a subset of the
      cluster list, a difference in sizes means that at least one off-node
      destination must exist.)
      Signed-off-by: default avatarAllan Stephens <allan.stephens@windriver.com>
      Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
      968edbe1
    • Allan Stephens's avatar
      tipc: Add missing locks when inspecting node list & link list · 1aad72d6
      Allan Stephens authored
      
      
      This patch ensures that TIPC configuration commands that display info
      about neighboring nodes and their links take the spinlocks that
      protect the node list and link lists from changing while the lists
      are being traversed.
      Signed-off-by: default avatarAllan Stephens <allan.stephens@windriver.com>
      Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
      1aad72d6
    • Allan Stephens's avatar
      tipc: Fix bug in scope checking for multicast messages · 08d2cf0f
      Allan Stephens authored
      
      
      This patch ensures that TIPC's multicast message name lookup
      algorithm does individualized scope checking for each published
      name it examines.  Previously, scope checking was only done for
      the first name in a name table publication list, which could
      result in incoming multicast messages being delivered to ports
      publishing names with "node" scope, or not being delivered to
      ports publishing names with "cluster" or "zone" scope.
      Signed-off-by: default avatarAllan Stephens <allan.stephens@windriver.com>
      Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
      08d2cf0f
    • Allan Stephens's avatar
      tipc: Eliminate improper use of TIPC_OK error code · 0e35fd5e
      Allan Stephens authored
      
      
      This patch corrects many places where TIPC routines indicated
      successful completion by returning TIPC_OK instead of 0.
      (The TIPC_OK symbol has the value 0, but it should only be used
      in contexts that deal with the error code field of a TIPC
      message header.)
      Signed-off-by: default avatarAllan Stephens <allan.stephens@windriver.com>
      Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
      0e35fd5e
    • Allan Stephens's avatar
      tipc: Fix race condition that could cause accept() to fail · 2da59918
      Allan Stephens authored
      
      
      This patch ensurs that accept() returns successfully even when
      the newly created socket is immediately disconnected by its peer.
      Previously, accept() would fail if it was unable to pass back
      the optional address info for the socket's peer before the
      socket became disconnected; TIPC now allows accept() to gather
      peer address information after disconnection.  As a bonus, the
      revised code accesses the socket's port more efficiently, without
      the overhead incurred by a reference table lookup.
      Signed-off-by: default avatarAllan Stephens <allan.stephens@windriver.com>
      Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
      2da59918
    • Allan Stephens's avatar
      tipc: Optimize pointer dereferencing when receiving stream data · 8642bd9e
      Allan Stephens authored
      
      
      This patch eliminates an unnecessary pointer dereference when
      accessing a stream-based socket's receive queue.
      Signed-off-by: default avatarAllan Stephens <allan.stephens@windriver.com>
      Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
      8642bd9e
    • Allan Stephens's avatar
      tipc: Remove unneeded parameter to tipc_createport_raw() · 0ea52241
      Allan Stephens authored
      
      
      This patch eliminates an unneeded parameter when creating a low-level
      TIPC port object.  Instead of returning both the pointer to the port
      structure and the port's reference ID, it now returns only the pointer
      since the port structure contains the reference ID as one of its fields.
      Signed-off-by: default avatarAllan Stephens <allan.stephens@windriver.com>
      Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
      0ea52241
    • Michael Chan's avatar
      bnx2: Update version to 1.7.8. · 3cb29b1b
      Michael Chan authored
      
      Signed-off-by: default avatarMichael Chan <mchan@braodcom.com>
      Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
      3cb29b1b
    • Benjamin Li's avatar
      bnx2: Support secondary MAC addresses. · 5fcaed01
      Benjamin Li authored
      
      
      Add support for configuring secondary unicast addresses.  There
      are 4 additional perfect match filters which can be used for
      secondary unicast address support.
      
        *  Modified bnx2_set_mac_addr() to be more generic in handling
           the setting of the perfect match filters
        *  Changed bnx2_set_rx_mode() to handle the unicast dev_addr_list
      Signed-off-by: default avatarBenjamin Li <benli@broadcom.com>
      Signed-off-by: default avatarMichael Chan <mchan@broadcom.com>
      Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
      5fcaed01
    • Michael Chan's avatar
      bnx2: Allow flexible VLAN tag settings. · 7c62e83b
      Michael Chan authored
      
      
      Negotiate with boot code and ASF firmware to see if it can
      support keeping VLAN tags in the RX packets.  If supported
      by firmware, the VLAN tag will be kept in the RX packet
      unless VLAN acceleration is registered.
      Signed-off-by: default avatarMichael Chan <mchan@broadcom.com>
      Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
      7c62e83b
    • Michael Chan's avatar
      bnx2: Add ack parameter to bnx2_fw_sync(). · a2f13890
      Michael Chan authored
      
      
      ack=1 means wait for firmware acknowledgement, and ack=0
      means don't wait.  All current callers will set it to 1.
      
      In the next patch, new calls will set ack=0.
      Signed-off-by: default avatarMichael Chan <mchan@broadcom.com>
      Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
      a2f13890
    • Michael Chan's avatar
      bnx2: Add PCI ID for 5716. · 7bb0a04f
      Michael Chan authored
      
      Signed-off-by: default avatarMichael Chan <mchan@broadcom.com>
      Signed-off-by: default avatarBenjamin Li <Benli@broadcom.com>
      Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
      7bb0a04f
    • Michael Chan's avatar
      bnx2: Prevent ethtool -s from crashing when device is down. · d6b14486
      Michael Chan authored
      
      
      The device may be in D3-hot state and may crash if we try to
      configure the speed settings by accessing the registers.
      Signed-off-by: default avatarMichael Chan <mchan@broadcom.com>
      Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
      d6b14486
    • David S. Miller's avatar
    • Denis V. Lunev's avatar
      netlabel: return msg overflow error from netlbl_cipsov4_list faster · 83aa2e96
      Denis V. Lunev authored
      
      
      Currently, we are trying to place the information from the kernel to
      1, 2, 3 and 4 pages sequentially. These pages are allocated via slab.
      Though, from the slab point of view steps 3 and 4 are equivalent on
      most architectures. So, lets skip 3 pages attempt.
      
      By the way, should we switch from .doit to .dumpit interface here?
      The amount of data seems quite big for me.
      Signed-off-by: default avatarDenis V. Lunev <den@openvz.org>
      Acked-by: default avatarPaul Moore <paul.moore@hp.com>
      Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
      83aa2e96
    • Johann Felix Soden's avatar
      net: Remove references to wan-router.txt in Kconfigs · 7197914c
      Johann Felix Soden authored
      This patch removes references in drivers/net/wan/Kconfig and
      net/wanrouter/Kconfig to Documentation/networking/wan-router.txt
      which was removed in commit 99971e70
      
      
      ("[WANPIPE]: Forgotten bits of Sangoma drivers removal.").
      Signed-off-by: default avatarJohann Felix Soden <johfel@users.sourceforge.net>
      Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
      7197914c
    • Max Krasnyansky's avatar
      tun: Fix/rewrite packet filtering logic · f271b2cc
      Max Krasnyansky authored
      Please see the following thread to get some context on this
      	http://marc.info/?l=linux-netdev&m=121564433018903&w=2
      
      
      
      Basically the issue is that current multi-cast filtering stuff in
      the TUN/TAP driver is seriously broken.
      Original patch went in without proper review and ACK. It was broken and
      confusing to start with and subsequent patches broke it completely.
      To give you an idea of what's broken here are some of the issues:
      
      - Very confusing comments throughout the code that imply that the
      character device is a network interface in its own right, and that packets
      are passed between the two nics. Which is completely wrong.
      
      - Wrong set of ioctls is used for setting up filters. They look like
      shortcuts for manipulating state of the tun/tap network interface but
      in reality manipulate the state of the TX filter.
      
      - ioctls that were originally used for setting address of the the TX filter
      got "fixed" and now set the address of the network interface itself. Which
      made filter totaly useless.
      
      - Filtering is done too late. Instead of filtering early on, to avoid
      unnecessary wakeups, filtering is done in the read() call.
      
      The list goes on and on :)
      
      So the patch cleans all that up. It introduces simple and clean interface for
      setting up TX filters (TUNSETTXFILTER + tun_filter spec) and does filtering
      before enqueuing the packets.
      
      TX filtering is useful in the scenarios where TAP is part of a bridge, in
      which case it gets all broadcast, multicast and potentially other packets when
      the bridge is learning. So for example Ethernet tunnelling app may want to
      setup TX filters to avoid tunnelling multicast traffic. QEMU and other
      hypervisors can push RX filtering that is currently done in the guest into the
      host context therefore saving wakeups and unnecessary data transfer.
      Signed-off-by: default avatarMax Krasnyansky <maxk@qualcomm.com>
      Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
      f271b2cc
    • Wang Chen's avatar
      8021q: Check return of dev_set_promiscuity/allmulti · 89146504
      Wang Chen authored
      
      
      dev_set_promiscuity/allmulti might overflow.
      Commit: "netdevice: Fix promiscuity and allmulti overflow" in net-next makes
      dev_set_promiscuity/allmulti return error number if overflow happened.
      
      Here, we check all positive increment for promiscuity and allmulti
      to get error return.
      Signed-off-by: default avatarWang Chen <wangchen@cn.fujitsu.com>
      Acked-by: default avatarPatrick McHardy <kaber@trash.net>
      Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
      89146504
    • Wang Chen's avatar
      macvlan: Check return of dev_set_allmulti · b89fb7da
      Wang Chen authored
      
      
      allmulti might overflow.
      Commit: "netdevice: Fix promiscuity and allmulti overflow" in net-next makes
      dev_set_promiscuity/allmulti return error number if overflow happened.
      
      Here, we check the positive increment for allmulti to get error return.
      Signed-off-by: default avatarWang Chen <wangchen@cn.fujitsu.com>
      Acked-by: default avatarPatrick McHardy <kaber@trash.net>
      Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
      b89fb7da
    • Wang Chen's avatar
      ipv4: Fix ipmr unregister device oops · 7dc00c82
      Wang Chen authored
      
      
      An oops happens during device unregister.
      
      The following oops happened when I add two tunnels, which
      use a same device, and then delete one tunnel.
      Obviously deleting tunnel "A" causes device unregister, which
      send a notification, and after receiving notification, ipmr do
      unregister again for tunnel "B" which also use same device.
      That is wrong.
      After receiving notification, ipmr only needs to decrease reference
      count and don't do duplicated unregister.
      Fortunately, IPv6 side doesn't add tunnel in ip6mr, so it's clean.
      
      This patch fixs:
      - unregister device oops
      - using after dev_put()
      
      Here is the oops:
      ===
      Jul 11 15:39:29 wangchen kernel: ------------[ cut here ]------------
      Jul 11 15:39:29 wangchen kernel: kernel BUG at net/core/dev.c:3651!
      Jul 11 15:39:29 wangchen kernel: invalid opcode: 0000 [#1] 
      Jul 11 15:39:29 wangchen kernel: Modules linked in: ipip tunnel4 nfsd lockd nfs_acl auth_rpcgss sunrpc exportfs ipv6 snd_pcm_oss snd_mixer_oss snd_seq snd_seq_device af_packet binfmt_misc button battery ac loop dm_mod usbhid ff_memless pcmcia firmware_class ohci1394 8139too mii ieee1394 yenta_socket rsrc_nonstatic pcmcia_core ide_cd_mod cdrom snd_intel8x0 snd_ac97_codec ac97_bus snd_pcm i2c_i801 snd_timer snd i2c_core soundcore snd_page_alloc rng_core shpchp ehci_hcd uhci_hcd pci_hotplug intel_agp agpgart usbcore ext3 jbd ata_piix ahci libata dock edd fan thermal processor thermal_sys piix sd_mod scsi_mod ide_disk ide_core [last unloaded: freq_table]
      Jul 11 15:39:29 wangchen kernel: 
      Jul 11 15:39:29 wangchen kernel: Pid: 4102, comm: mroute Not tainted (2.6.26-rc9-default #69)
      Jul 11 15:39:29 wangchen kernel: EIP: 0060:[<c024636b>] EFLAGS: 00010202 CPU: 0
      Jul 11 15:39:29 wangchen kernel: EIP is at rollback_registered+0x61/0xe3
      Jul 11 15:39:29 wangchen kernel: EAX: 00000001 EBX: ecba6000 ECX: 00000000 EDX: ffffffff
      Jul 11 15:39:29 wangchen kernel: ESI: 00000001 EDI: ecba6000 EBP: c03de2e8 ESP: ed8e7c3c
      Jul 11 15:39:29 wangchen kernel:  DS: 007b ES: 007b FS: 0000 GS: 0033 SS: 0068
      Jul 11 15:39:29 wangchen kernel: Process mroute (pid: 4102, ti=ed8e6000 task=ed41e830 task.ti=ed8e6000)
      Jul 11 15:39:29 wangchen kernel: Stack: ecba6000 c024641c 00000028 c0284e1a 00000001 c03de2e8 ecba6000 eecff360 
      Jul 11 15:39:29 wangchen kernel:        c0284e4c c03536f4 fffffff8 00000000 c029a819 ecba6000 00000006 ecba6000 
      Jul 11 15:39:29 wangchen kernel:        00000000 ecba6000 c03de2c0 c012841b ffffffff 00000000 c024639f ecba6000 
      Jul 11 15:39:29 wangchen kernel: Call Trace:
      Jul 11 15:39:29 wangchen kernel:  [<c024641c>] unregister_netdevice+0x2f/0x51
      Jul 11 15:39:29 wangchen kernel:  [<c0284e1a>] vif_delete+0xaf/0xc3
      Jul 11 15:39:29 wangchen kernel:  [<c0284e4c>] ipmr_device_event+0x1e/0x30
      Jul 11 15:39:29 wangchen kernel:  [<c029a819>] notifier_call_chain+0x2a/0x47
      Jul 11 15:39:29 wangchen kernel:  [<c012841b>] raw_notifier_call_chain+0x9/0xc
      Jul 11 15:39:29 wangchen kernel:  [<c024639f>] rollback_registered+0x95/0xe3
      Jul 11 15:39:29 wangchen kernel:  [<c024641c>] unregister_netdevice+0x2f/0x51
      Jul 11 15:39:29 wangchen kernel:  [<c0284e1a>] vif_delete+0xaf/0xc3
      Jul 11 15:39:29 wangchen kernel:  [<c0285eee>] ip_mroute_setsockopt+0x47a/0x801
      Jul 11 15:39:29 wangchen kernel:  [<eea5a70c>] do_get_write_access+0x2df/0x313 [jbd]
      Jul 11 15:39:29 wangchen kernel:  [<c01727c4>] __find_get_block_slow+0xda/0xe4
      Jul 11 15:39:29 wangchen kernel:  [<c0172a7f>] __find_get_block+0xf8/0x122
      Jul 11 15:39:29 wangchen kernel:  [<c0172a7f>] __find_get_block+0xf8/0x122
      Jul 11 15:39:29 wangchen kernel:  [<eea5d563>] journal_cancel_revoke+0xda/0x110 [jbd]
      Jul 11 15:39:29 wangchen kernel:  [<c0263501>] ip_setsockopt+0xa9/0x9ee
      Jul 11 15:39:29 wangchen kernel:  [<eea5d563>] journal_cancel_revoke+0xda/0x110 [jbd]
      Jul 11 15:39:29 wangchen kernel:  [<eea5a70c>] do_get_write_access+0x2df/0x313 [jbd]
      Jul 11 15:39:29 wangchen kernel:  [<eea69287>] __ext3_get_inode_loc+0xcf/0x271 [ext3]
      Jul 11 15:39:29 wangchen kernel:  [<eea743c7>] __ext3_journal_dirty_metadata+0x13/0x32 [ext3]
      Jul 11 15:39:29 wangchen kernel:  [<c0116434>] __wake_up+0xf/0x15
      Jul 11 15:39:29 wangchen kernel:  [<eea5a424>] journal_stop+0x1bd/0x1c6 [jbd]
      Jul 11 15:39:29 wangchen kernel:  [<eea703a7>] __ext3_journal_stop+0x19/0x34 [ext3]
      Jul 11 15:39:29 wangchen kernel:  [<c014291e>] get_page_from_freelist+0x94/0x369
      Jul 11 15:39:29 wangchen kernel:  [<c01408f2>] filemap_fault+0x1ac/0x2fe
      Jul 11 15:39:29 wangchen kernel:  [<c01a605e>] security_sk_alloc+0xd/0xf
      Jul 11 15:39:29 wangchen kernel:  [<c023edea>] sk_prot_alloc+0x36/0x78
      Jul 11 15:39:29 wangchen kernel:  [<c0240037>] sk_alloc+0x3a/0x40
      Jul 11 15:39:29 wangchen kernel:  [<c0276062>] raw_hash_sk+0x46/0x4e
      Jul 11 15:39:29 wangchen kernel:  [<c0166aff>] d_alloc+0x1b/0x157
      Jul 11 15:39:29 wangchen kernel:  [<c023e4d1>] sock_common_setsockopt+0x12/0x16
      Jul 11 15:39:29 wangchen kernel:  [<c023cb1e>] sys_setsockopt+0x6f/0x8e
      Jul 11 15:39:29 wangchen kernel:  [<c023e105>] sys_socketcall+0x15c/0x19e
      Jul 11 15:39:29 wangchen kernel:  [<c0103611>] sysenter_past_esp+0x6a/0x99
      Jul 11 15:39:29 wangchen kernel:  [<c0290000>] unix_poll+0x69/0x78
      Jul 11 15:39:29 wangchen kernel:  =======================
      Jul 11 15:39:29 wangchen kernel: Code: 83 e0 01 00 00 85 c0 75 1f 53 53 68 12 81 31 c0 e8 3c 30 ed ff ba 3f 0e 00 00 b8 b9 7f 31 c0 83 c4 0c 5b e9 f5 26 ed ff 48 74 04 <0f> 0b eb fe 89 d8 e8 21 ff ff ff 89 d8 e8 62 ea ff ff c7 83 e0 
      Jul 11 15:39:29 wangchen kernel: EIP: [<c024636b>] rollback_registered+0x61/0xe3 SS:ESP 0068:ed8e7c3c
      Jul 11 15:39:29 wangchen kernel: ---[ end trace c311acf85d169786 ]---
      ===
      Signed-off-by: default avatarWang Chen <wangchen@cn.fujitsu.com>
      Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
      7dc00c82
    • Wang Chen's avatar
      ipv4: Check return of dev_set_allmulti · d607032d
      Wang Chen authored
      
      
      allmulti might overflow.
      Commit: "netdevice: Fix promiscuity and allmulti overflow" in net-next makes
      dev_set_promiscuity/allmulti return error number if overflow happened.
      
      Here, we check the positive increment for allmulti to get error return.
      
      PS: For unwinding tunnel creating, we let ipip->ioctl() to handle it.
      Signed-off-by: default avatarWang Chen <wangchen@cn.fujitsu.com>
      Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
      d607032d
    • Wang Chen's avatar
      ipv6: Fix using after dev_put() · 7af3db78
      Wang Chen authored
      
      
      Patrick McHardy pointed it out.
      Signed-off-by: default avatarWang Chen <wangchen@cn.fujitsu.com>
      Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
      7af3db78
    • Wang Chen's avatar
      ipv6: Check return of dev_set_allmulti · 5ae7b444
      Wang Chen authored
      
      
      allmulti might overflow.
      Commit: "netdevice: Fix promiscuity and allmulti overflow" in net-next makes
      dev_set_promiscuity/allmulti return error number if overflow happened.
      
      Here, we check the positive increment for allmulti to get error return.
      Signed-off-by: default avatarWang Chen <wangchen@cn.fujitsu.com>
      Acked-by: Patrick McHardy <kaber@trash.net> 
      Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
      5ae7b444