1. 06 Jun, 2005 24 commits
  2. 04 Jun, 2005 8 commits
  3. 03 Jun, 2005 8 commits
    • Nathan Lynch's avatar
      [PATCH] prom_find_machine_type typo breaks pSeries lpar boot · 8be3de3f
      Nathan Lynch authored
      
      
      A typo in prom_find_machine_type from Ben's recent patch "ppc64: Fix
      result code handling in prom_init" prevents pSeries LPAR systems from
      booting.
      
      Tested on a pSeries 570 and OpenPower 720 (both Power5 LPAR).
      Signed-off-by: default avatarNathan Lynch <ntl@pobox.com>
      Signed-off-by: default avatarLinus Torvalds <torvalds@osdl.org>
      8be3de3f
    • Linus Torvalds's avatar
    • Greg Ungerer's avatar
      [PATCH] m68knommu: fix scheduling and race problems in idle loop · b05a720b
      Greg Ungerer authored
      
      
      Re-work the m68knommu specific idle code according to suggestions
      from Nick Piggin <nickpiggin@yahoo.com.au>.
      
      A couple of rules that we need to follow:
      
      1. Preempt should now disabled over idle routines. Should only be enabled
      to call schedule() then disabled again.
      
      3. When cpu_idle finds (need_resched() == 'true'), it should call schedule().
      It should not call schedule() otherwise.
      
      Also fix interrupt locking around the need_resched() and cpu stop state
      so that there is no race condition.
      Signed-off-by: default avatarGreg Ungerer <gerg@snapgear.com>
      Signed-off-by: default avatarLinus Torvalds <torvalds@osdl.org>
      b05a720b
    • David Brownell's avatar
      [PATCH] USB: resolve Zaurus problem · f4d340cf
      David Brownell authored
      
      
      This "obvious" one-liner is needed to recognize Zaurus SL 6000;
      it just checks two GUIDs not just one.
      
      OSDL bugids #4512 and #4545 seem to be duplicates of this report.
      
      From: Gerald Skerbitz <gsker@tcfreenet.org>
      Signed-off-by: default avatarDavid Brownell <dbrownell@users.sourceforge.net>
      Signed-off-by: default avatarLinus Torvalds <torvalds@osdl.org>
      f4d340cf
    • Nathan Lynch's avatar
      [SCSI] fix slab corruption during ipr probe · c92715b3
      Nathan Lynch authored
      With CONFIG_DEBUG_SLAB=y I see slab corruption messages during boot on
      pSeries machines with IPR adapters with any 2.6.12-rc kernel.
      
      The change which seems to have introduced the problem is "SCSI: revamp
      target scanning routines" and may be found at:
      http://marc.theaimsgroup.com/?l=bk-commits-head&m=111093946426333&w=2
      
      In order to revert that in a 2.6.12-rc1 tree, I had to revert "target
      code updates to support scanned targets" first:
      http://marc.theaimsgroup.com/?l=bk-commits-head&m=111094132524649&w=2
      
      
      
      With both patches reverted, the corruption messages go away.
      
      ipr: IBM Power RAID SCSI Device Driver version: 2.0.13 (February 21,
      2005)
      ipr 0001:d0:01.0: Found IOA with IRQ: 167
      ipr 0001:d0:01.0: Starting IOA initialization sequence.
      ipr 0001:d0:01.0: Adapter firmware version: 020A005C
      ipr 0001:d0:01.0: IOA initialized.
      scsi0 : IBM 570B Storage Adapter
        Vendor: IBM       Model: VSBPD4E1  U4SCSI  Rev: 4770
        Type:   Enclosure                          ANSI SCSI revision: 02
        Vendor: IBM   H0  Model: HUS103036FL3800   Rev: RPQF
        Type:   Direct-Access                      ANSI SCSI revision: 04
        Vendor: IBM   H0  Model: HUS103036FL3800   Rev: RPQF
        Type:   Direct-Access                      ANSI SCSI revision: 04
        Vendor: IBM   H0  Model: HUS103036FL3800   Rev: RPQF
        Type:   Direct-Access                      ANSI SCSI revision: 04
        Vendor: IBM   H0  Model: HUS103036FL3800   Rev: RPQF
        Type:   Direct-Access                      ANSI SCSI revision: 04
        Vendor: IBM       Model: VSBPD4E1  U4SCSI  Rev: 4770
        Type:   Enclosure                          ANSI SCSI revision: 02
      Slab corruption: start=c0000001e8de5268, len=512
      Redzone: 0x5a2cf071/0x5a2cf071.
      Last user: [<c00000000029c3a0>](.scsi_target_dev_release+0x28/0x50)
      080: 6b 6b 6b 6b 6b 6b 6b 6b 6b 6b 6b 6b 6b 6b 6b 6a
      Prev obj: start=c0000001e8de5050, len=512
      Redzone: 0x5a2cf071/0x5a2cf071.
      Last user: [<0000000000000000>](0x0)
      000: 6b 6b 6b 6b 6b 6b 6b 6b 6b 6b 6b 6b 6b 6b 6b 6b
      010: 6b 6b 6b 6b 6b 6b 6b 6b 6b 6b 6b 6b 6b 6b 6b 6b
      Next obj: start=c0000001e8de5480, len=512
      Redzone: 0x170fc2a5/0x170fc2a5.
      Last user: [<c000000000228d7c>](.as_init_queue+0x5c/0x228)
      000: c0 00 00 01 e8 83 26 08 00 00 00 00 00 00 00 00
      010: 00 00 00 00 00 00 00 00 c0 00 00 01 e8 de 54 98
      Slab corruption: start=c0000001e8de5268, len=512
      Redzone: 0x5a2cf071/0x5a2cf071.
      Last user: [<c00000000029c3a0>](.scsi_target_dev_release+0x28/0x50)
      080: 6b 6b 6b 6b 6b 6b 6b 6b 6b 6b 6b 6b 6b 6b 6b 6a
      Prev obj: start=c0000001e8de5050, len=512
      Redzone: 0x5a2cf071/0x5a2cf071.
      Last user: [<0000000000000000>](0x0)
      000: 6b 6b 6b 6b 6b 6b 6b 6b 6b 6b 6b 6b 6b 6b 6b 6b
      010: 6b 6b 6b 6b 6b 6b 6b 6b 6b 6b 6b 6b 6b 6b 6b 6b
      Next obj: start=c0000001e8de5480, len=512
      Redzone: 0x170fc2a5/0x170fc2a5.
      Last user: [<c000000000228d7c>](.as_init_queue+0x5c/0x228)
      000: c0 00 00 01 e8 83 26 08 00 00 00 00 00 00 00 00
      010: 00 00 00 00 00 00 00 00 c0 00 00 01 e8 de 54 98
      ...
      
      I did some digging and the problem seems to be a refcounting issue in
      __scsi_add_device.  The target gets freed in scsi_target_reap, and
      then __scsi_add_device tries to do another device_put on it.
      Signed-off-by: default avatarNathan Lynch <ntl@pobox.com>
      Signed-off-by: default avatarJames Bottomley <James.Bottomley@SteelEye.com>
      c92715b3
    • Andrew Vasquez's avatar
      [SCSI] qla2xxx: fix bad locking during eh_abort · 18e144d3
      Andrew Vasquez authored
      
      
      
      Correct incorrect locking order in qla2xxx_eh_abort() handler which
      would case a hang during certain code-paths.
      
      With extra pieces to fix the irq state in the locks.
      Signed-off-by: default avatarAndrew Vasquez <andrew.vasquez@qlogic.com>
      Signed-off-by: default avatarJames Bottomley <James.Bottomley@SteelEye.com>
      18e144d3
    • Craig Shelley's avatar
      [PATCH] USB: CP2101 Add support for flow control · 39a66b8d
      Craig Shelley authored
      
      
      Added support to get/set flow control line levels using TIOCMGET and
      TIOCMSET.
      Added support for RTSCTS hardware flow control.
      cp2101_get_config and cp2101_set_config modified to support long request
      strings, required for configuring flow control.
      
      Signed-off-by: Craig Shelley craig@microtron.org.uk
      Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@suse.de>
      39a66b8d
    • Roman Kagan's avatar
      [PATCH] USB: update urb documentation · 719df469
      Roman Kagan authored
      
      
      On Wed, May 04, 2005 at 01:37:30PM -0700, David Brownell wrote:
      > On Wednesday 04 May 2005 12:19 pm, Roman Kagan wrote:
      > > struct urb {
      > > 	/* private, usb core and host controller only fields in the urb */
      > > 	...
      > > 	struct list_head urb_list;	/* list pointer to all active urbs */
      > > 	...
      > > };
      > >
      > > Is it safe to use it for driver's purposes when the driver owns the urb,
      > > that is, starting from the completion routine until the urb is submitted
      > > with usb_submit_urb()?
      >
      > Right now, it should be.
      
      Great!  FWIW I've briefly tested a modified version of usbatm using
      the list head in struct urb instead of creating a wrapper struct, and I
      haven't seen any failures yet.  So I tend to believe that your "should
      be" actually means "is" :)
      
      > > If it is, can it be guaranteed in future, e.g.
      > > by moving the list head into the public section of struct urb?
      >
      > In fact I'm not sure why it ever got called "private" to usbcore/hcds.
      > I thought the idea was that it should be like urb->status, reserved for
      > whoever controls the URB.
      
      OK then how about the following (essentially documentation) patch?
      Signed-off-by: default avatarRoman Kagan <rkagan@mail.ru>
      Acked-by: default avatarDavid Brownell <david-b@pacbell.net>
      Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@suse.de>
      719df469