1. 06 Nov, 2015 2 commits
  2. 25 Jun, 2015 3 commits
  3. 08 Jul, 2014 1 commit
  4. 10 Feb, 2014 1 commit
  5. 23 Jan, 2014 1 commit
    • Joe Perches's avatar
      get_maintainer: add commit author information to --rolestats · c9ecefea
      Joe Perches authored
      
      
      get_maintainer currently uses "Signed-off-by" style lines to find
      interested parties to send patches to when the MAINTAINERS file does not
      have a specific section entry with a matching file pattern.
      
      Add statistics for commit authors and lines added and deleted to the
      information provided by --rolestats.
      
      These statistics are also emitted whenever --rolestats and --git are
      selected even when there is a specified maintainer.
      
      This can have the effect of expanding the number of people that are shown
      as possible "maintainers" of a particular file because "authors",
      "added_lines", and "removed_lines" are also used as criterion for the
      --max-maintainers option separate from the "commit_signers".
      
      The first "--git-max-maintainers" values of each criterion
      are emitted.  Any "ties" are not shown.
      
      For example: (forcedeth does not have a named maintainer)
      
      Old output:
      
      $ ./scripts/get_maintainer.pl -f drivers/net/ethernet/nvidia/forcedeth.c
      "David S. Miller" <davem@davemloft.net> (commit_signer:8/10=80%)
      Jiri Pirko <jiri@resnulli.us> (commit_signer:2/10=20%)
      Patrick McHardy <kaber@trash.net> (commit_signer:2/10=20%)
      Larry Finger <Larry.Finger@lwfinger.net> (commit_signer:1/10=10%)
      Peter Zijlstra <peterz@infradead.org> (commit_signer:1/10=10%)
      netdev@vger.kernel.org (open list:NETWORKING DRIVERS)
      linux-kernel@vger.kernel.org (open list)
      
      New output:
      
      $ ./scripts/get_maintainer.pl -f drivers/net/ethernet/nvidia/forcedeth.c
      "David S. Miller" <davem@davemloft.net> (commit_signer:8/10=80%)
      Jiri Pirko <jiri@resnulli.us> (commit_signer:2/10=20%,authored:2/10=20%,removed_lines:3/33=9%)
      Patrick McHardy <kaber@trash.net> (commit_signer:2/10=20%,authored:2/10=20%,added_lines:12/95=13%,removed_lines:10/33=30%)
      Larry Finger <Larry.Finger@lwfinger.net> (commit_signer:1/10=10%,authored:1/10=10%,added_lines:35/95=37%)
      Peter Zijlstra <peterz@infradead.org> (commit_signer:1/10=10%)
      "Peter Hüwe" <PeterHuewe@gmx.de> (authored:1/10=10%,removed_lines:15/33=45%)
      Joe Perches <joe@perches.com> (authored:1/10=10%)
      Neil Horman <nhorman@tuxdriver.com> (added_lines:40/95=42%)
      Bill Pemberton <wfp5p@virginia.edu> (removed_lines:3/33=9%)
      netdev@vger.kernel.org (open list:NETWORKING DRIVERS)
      linux-kernel@vger.kernel.org (open list)
      Signed-off-by: default avatarJoe Perches <joe@perches.com>
      Signed-off-by: default avatarAndrew Morton <akpm@linux-foundation.org>
      Signed-off-by: default avatarLinus Torvalds <torvalds@linux-foundation.org>
      c9ecefea
  6. 29 Apr, 2013 1 commit
  7. 27 Feb, 2013 1 commit
    • Stephen Warren's avatar
      get_maintainer: allow keywords to match filenames · eb90d085
      Stephen Warren authored
      
      
      Allow K: entries in MAINTAINERS to match directly against filenames;
      either those extracted from patch +++ or --- lines, or those specified
      on the command-line using the -f option.
      
      This potentially allows fewer lines in a MAINTAINERS entry, if all the
      relevant files are scattered throughout the whole kernel tree, yet
      contain some common keyword.  An example would be using an ARM SoC name
      as the keyword to catch all related drivers.
      
      I don't think setting exact_pattern_match_hash would be appropriate
      here; at least for intended Tegra use case, this feature is to ensure
      that all Tegra-related driver changes get Cc'd to the Tegra mailing
      list.  Setting exact_pattern_match_hash would prevent git history
      parsing for e.g.  S-o-b tags, which still seems like it would be useful.
      Hence, this flag isn't set.
      Signed-off-by: default avatarStephen Warren <swarren@nvidia.com>
      Acked-by: default avatarJoe Perches <joe@perches.com>
      Signed-off-by: default avatarAndrew Morton <akpm@linux-foundation.org>
      Signed-off-by: default avatarLinus Torvalds <torvalds@linux-foundation.org>
      eb90d085
  8. 21 Feb, 2013 1 commit
  9. 20 Jun, 2012 1 commit
  10. 23 Mar, 2012 2 commits
  11. 10 Jan, 2012 1 commit
    • Ian Campbell's avatar
      get_maintainers.pl: follow renames when looking up commit signers · ed128fea
      Ian Campbell authored
      
      
      I happen to have had a commit to various network drivers since the big
      renaming/reorg which happened to drivers/net recently.  This means that I
      now appear to be in the top few commit signers (by %age) for many of them
      so am getting sent all sorts of stuff and people who are involved with the
      driver are not.  e.g.  (to pick one at random):
      
              $ ./scripts/get_maintainer.pl -f drivers/net/ethernet/nvidia/forcedeth.c
              "David S. Miller" <davem@davemloft.net> (commit_signer:5/7=71%)
              Ian Campbell <ian.campbell@citrix.com> (commit_signer:2/7=29%)
              Eric Dumazet <eric.dumazet@gmail.com> (commit_signer:1/7=14%)
              Jeff Kirsher <jeffrey.t.kirsher@intel.com> (commit_signer:1/7=14%)
              Jiri Pirko <jpirko@redhat.com> (commit_signer:1/7=14%)
              netdev@vger.kernel.org (open list:NETWORKING DRIVERS)
              linux-kernel@vger.kernel.org (open list)
      
      With the following patch the renames are followed and the result appears
      much more sensible:
      
              $ ./scripts/get_maintainer.pl -f drivers/net/ethernet/nvidia/forcedeth.c
              "David S. Miller" <davem@davemloft.net> (commit_signer:31/34=91%)
              Joe Perches <joe@perches.com> (commit_signer:11/34=32%)
              Szymon Janc <szymon@janc.net.pl> (commit_signer:5/34=15%)
              Jiri Pirko <jpirko@redhat.com> (commit_signer:3/34=9%)
              Paul <paul.gortmaker@windriver.com> (commit_signer:2/34=6%)
              netdev@vger.kernel.org (open list:NETWORKING DRIVERS)
              linux-kernel@vger.kernel.org (open list)
      Signed-off-by: default avatarIan Campbell <Ian.Campbell@citrix.com>
      Acked-by: default avatarJoe Perches <joe@perches.com>
      Signed-off-by: default avatarAndrew Morton <akpm@linux-foundation.org>
      Signed-off-by: default avatarLinus Torvalds <torvalds@linux-foundation.org>
      ed128fea
  12. 25 Aug, 2011 1 commit
  13. 25 Jul, 2011 1 commit
  14. 22 Mar, 2011 1 commit
  15. 13 Jan, 2011 2 commits
  16. 26 Oct, 2010 12 commits
  17. 25 May, 2010 3 commits
    • Florian Mickler's avatar
      scripts/get_maintainer.pl: default to not include unspecified tags · 0fa05599
      Florian Mickler authored
      
      
      This changes the default of the option --git-all-signature-types to be
      disabled by default.
      
      The effect being, that only certain (currently Signed-Off-By:, Acked-by:
      and Reviewed-By:) tags are used to get adresses of potential maintainers.
      
      Motivated is this change by the desire to not 'spam' people unnecessary: A
      Tested-By or a Reported-By is not ment as a hint that those people want
      to/are able to review patches to the code in question.
      
      In a quest to find resilient statistics for this i came up with this:
      
      I produced a list of all the tag-signers not already covered with a
      signed-off/acked/reviewed tag somewhere in the last year of git history.
      
      Those were 650 addresses of "assumed non-developers".
      
      And to check if those "assumed non-developers" are professional
      testers/reporters worth cc'ing, i then counted their total appearences
      in the git log:
      
      469 were mentioned only once.
      123 were mentioned twice.
      38 three times
      8 four times
      5 six times
      5 five times
      1 eight times
      1 fourteen times
      
      I believe this supports my thesis, that the ''non-maintainer-tags'' are
      not actively useful for patch-review.  (except probably the guy mentioned
      fourteen times...)
      
      But of course one could also find arguments to poke holes in this
      statistics, for example does this statistic not include code-locality: A
      tested-by on a patch that touches some specific piece of code can be more
      worth than a signed-off in another part of the tree.
      
      But...  let's play it safe and let's err on the "safe" side meaning to not
      spam those people when in doubt.  We already have the signed-off's and
      Maintainers file.  So this should be ok.  And if need be, the maintainers
      can always forward the patch.
      
      [i probably could make a diploma thesis out of this changelog :)]
      Signed-off-by: default avatarFlorian Mickler <florian@mickler.org>
      Acked-by: default avatarWolfram Sang <w.sang@pengutronix.de>
      Cc: Joe Perches <joe@perches.com>
      Cc: Stefan Richter <stefanr@s5r6.in-berlin.de>
      Signed-off-by: default avatarAndrew Morton <akpm@linux-foundation.org>
      Signed-off-by: default avatarLinus Torvalds <torvalds@linux-foundation.org>
      0fa05599
    • Joe Perches's avatar
      scripts/get_maintainer.pl: add .get_maintainer.conf default options file · 368669da
      Joe Perches authored
      
      
      Allow the use of a .get_maintainer.conf file to control the default
      options applied when scripts/get_maintainer.pl is run.
      
      .get_maintainer.conf can contain any valid command-line argument.
      
      File contents are prepended to any additional command line arguments.
      
      Multiple lines may be used, blank lines ignored, # is a comment.
      
      Updated scripts/get_maintainer.pl version to 0.24
      Signed-off-by: default avatarJoe Perches <joe@perches.com>
      Reviewed-by: default avatarFlorian Mickler <florian@mickler.org>
      Signed-off-by: default avatarAndrew Morton <akpm@linux-foundation.org>
      Signed-off-by: default avatarLinus Torvalds <torvalds@linux-foundation.org>
      368669da
    • Joe Perches's avatar
      scripts/get_maintainer.pl: optionally ignore non-maintainer signatures · e4d26b02
      Joe Perches authored
      
      
      When using --git to determine who to send a patch to, get_maintainers will
      currently include all signatures.  This can include signers that simply
      report an issue or test a patch.  Signers that use this tag are not
      necessarily good candidates to review new patches.
      
      This patch allows get_maintainers to optionally restrict output to only
      signatures that use Signed-off-by:, Acked-by:, or Reviewed-by:.
      
      Signed-off-by: is included because those are people who are responsible
      for the code.
      
      Acked-by: is questionable, but as signers that use this tag tend to be
      active linux gatekeepers, false positives are tolerable.
      
      Reviewed-by: is included because signers responsible for the code thought
      that the review feedback for a changeset by that signer was valuable.
      
      This patch has been modified from Florian's original submission to change
      the supported signature types to the canonical forms and use slightly
      different spacing.  A couple of spacing issues were also corrected in the
      original source.  The command line argument was also renamed.
      Original-patch-by: default avatarFlorian Mickler <florian@mickler.org>
      Signed-off-by: default avatarFlorian Mickler <florian@mickler.org>
      Signed-off-by: default avatarJoe Perches <joe@perches.com>
      Signed-off-by: default avatarAndrew Morton <akpm@linux-foundation.org>
      Signed-off-by: default avatarLinus Torvalds <torvalds@linux-foundation.org>
      e4d26b02
  18. 24 Mar, 2010 1 commit
  19. 06 Mar, 2010 4 commits