1. 20 Nov, 2005 1 commit
  2. 25 Oct, 2005 1 commit
    • Herbert Xu's avatar
      [IPV4]: Kill redundant rcu_dereference on fa_info · 1371e37d
      Herbert Xu authored
      
      
      This patch kills a redundant rcu_dereference on fa->fa_info in fib_trie.c.
      As this dereference directly follows a list_for_each_entry_rcu line, we
      have already taken a read barrier with respect to getting an entry from
      the list.
      
      This read barrier guarantees that all values read out of fa are valid.
      In particular, the contents of structure pointed to by fa->fa_info is
      initialised before fa->fa_info is actually set (see fn_trie_insert);
      the setting of fa->fa_info itself is further separated with a write
      barrier from the insertion of fa into the list.
      
      Therefore by taking a read barrier after obtaining fa from the list
      (which is given by list_for_each_entry_rcu), we can be sure that
      fa->fa_info contains a valid pointer, as well as the fact that the
      data pointed to by fa->fa_info is itself valid.
      Signed-off-by: default avatarHerbert Xu <herbert@gondor.apana.org.au>
      Acked-by: default avatarPaul E. McKenney <paulmck@us.ibm.com>
      Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
      Signed-off-by: default avatarArnaldo Carvalho de Melo <acme@mandriva.com>
      1371e37d
  3. 04 Oct, 2005 1 commit
    • Robert Olsson's avatar
      [IPV4]: fib_trie root-node expansion · e6308be8
      Robert Olsson authored
      
      
      The patch below introduces special thresholds to keep root node in the trie 
      large. This gives a flatter tree at the cost of a modest memory increase.
      Overall it seems to be gain and this was also proposed by one the authors 
      of the paper in recent a seminar.
      
      Main table after loading 123 k routes.
      
      	Aver depth:     3.30
      	Max depth:      9
              Root-node size  12 bits
              Total size: 4044  kB
      
      With the patch:
      	Aver depth:     2.78
      	Max depth:      8
              Root-node size  15 bits
              Total size: 4150  kB
      
      An increase of 8-10% was seen in forwading performance for an rDoS attack. 
      Signed-off-by: default avatarRobert Olsson <robert.olsson@its.uu.se>
      Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
      e6308be8
  4. 21 Sep, 2005 1 commit
  5. 19 Sep, 2005 2 commits
  6. 09 Sep, 2005 1 commit
  7. 29 Aug, 2005 6 commits
  8. 23 Aug, 2005 1 commit
  9. 19 Jul, 2005 1 commit
  10. 05 Jul, 2005 2 commits
  11. 28 Jun, 2005 1 commit
  12. 21 Jun, 2005 2 commits