1. 15 Jan, 2010 1 commit
  2. 16 Dec, 2009 2 commits
    • Dave Chinner's avatar
      XFS: Free buffer pages array unconditionally · 3fc98b1a
      Dave Chinner authored
      
      
      The code in xfs_free_buf() only attempts to free the b_pages array if the
      buffer is a page cache backed or page allocated buffer. The extra log buffer
      that is used when the log wraps uses pages that are allocated to a different
      log buffer, but it still has a b_pages array allocated when those pages
      are associated to with the extra buffer in xfs_buf_associate_memory.
      
      Hence we need to always attempt to free the b_pages array when tearing
      down a buffer, not just on buffers that are explicitly marked as page bearing
      buffers. This fixes a leak detected by the kernel memory leak code.
      
      Signed-off-by: default avatarDave Chinner <david@fromorbit.com>
      Signed-off-by: default avatarAlex Elder <aelder@sgi.com>
      3fc98b1a
    • Dave Chinner's avatar
      xfs: improve metadata I/O merging in the elevator · 2ee1abad
      Dave Chinner authored
      
      
      Change all async metadata buffers to use [READ|WRITE]_META I/O types
      so that the I/O doesn't get issued immediately. This allows merging of
      adjacent metadata requests but still prioritises them over bulk data.
      This shows a 10-15% improvement in sequential create speed of small
      files.
      
      Don't include the log buffers in this classification - leave them as
      sync types so they are issued immediately.
      
      Signed-off-by: default avatarDave Chinner <dgc@sgi.com>
      Signed-off-by: default avatarChristoph Hellwig <hch@lst.de>
      Signed-off-by: default avatarAlex Elder <aelder@sgi.com>
      2ee1abad
  3. 14 Dec, 2009 1 commit
    • Christoph Hellwig's avatar
      xfs: event tracing support · 0b1b213f
      Christoph Hellwig authored
      Convert the old xfs tracing support that could only be used with the
      out of tree kdb and xfsidbg patches to use the generic event tracer.
      
      To use it make sure CONFIG_EVENT_TRACING is enabled and then enable
      all xfs trace channels by:
      
         echo 1 > /sys/kernel/debug/tracing/events/xfs/enable
      
      or alternatively enable single events by just doing the same in one
      event subdirectory, e.g.
      
         echo 1 > /sys/kernel/debug/tracing/events/xfs/xfs_ihold/enable
      
      or set more complex filters, etc. In Documentation/trace/events.txt
      all this is desctribed in more detail.  To reads the events do a
      
         cat /sys/kernel/debug/tracing/trace
      
      Compared to the last posting this patch converts the tracing mostly to
      the one tracepoint per callsite model that other users of the new
      tracing facility also employ.  This allows a very fine-grained control
      of the tracing, a cleaner output of the traces and also enables the
      perf tool to use each tracepoint as a virtual performance counter,
           allowing us to e.g. count how often certain workloads git various
           spots in XFS.  Take a look at
      
          http://lwn.net/Articles/346470/
      
      
      
      for some examples.
      
      Also the btree tracing isn't included at all yet, as it will require
      additional core tracing features not in mainline yet, I plan to
      deliver it later.
      
      And the really nice thing about this patch is that it actually removes
      many lines of code while adding this nice functionality:
      
       fs/xfs/Makefile                |    8
       fs/xfs/linux-2.6/xfs_acl.c     |    1
       fs/xfs/linux-2.6/xfs_aops.c    |   52 -
       fs/xfs/linux-2.6/xfs_aops.h    |    2
       fs/xfs/linux-2.6/xfs_buf.c     |  117 +--
       fs/xfs/linux-2.6/xfs_buf.h     |   33
       fs/xfs/linux-2.6/xfs_fs_subr.c |    3
       fs/xfs/linux-2.6/xfs_ioctl.c   |    1
       fs/xfs/linux-2.6/xfs_ioctl32.c |    1
       fs/xfs/linux-2.6/xfs_iops.c    |    1
       fs/xfs/linux-2.6/xfs_linux.h   |    1
       fs/xfs/linux-2.6/xfs_lrw.c     |   87 --
       fs/xfs/linux-2.6/xfs_lrw.h     |   45 -
       fs/xfs/linux-2.6/xfs_super.c   |  104 ---
       fs/xfs/linux-2.6/xfs_super.h   |    7
       fs/xfs/linux-2.6/xfs_sync.c    |    1
       fs/xfs/linux-2.6/xfs_trace.c   |   75 ++
       fs/xfs/linux-2.6/xfs_trace.h   | 1369 +++++++++++++++++++++++++++++++++++++++++
       fs/xfs/linux-2.6/xfs_vnode.h   |    4
       fs/xfs/quota/xfs_dquot.c       |  110 ---
       fs/xfs/quota/xfs_dquot.h       |   21
       fs/xfs/quota/xfs_qm.c          |   40 -
       fs/xfs/quota/xfs_qm_syscalls.c |    4
       fs/xfs/support/ktrace.c        |  323 ---------
       fs/xfs/support/ktrace.h        |   85 --
       fs/xfs/xfs.h                   |   16
       fs/xfs/xfs_ag.h                |   14
       fs/xfs/xfs_alloc.c             |  230 +-----
       fs/xfs/xfs_alloc.h             |   27
       fs/xfs/xfs_alloc_btree.c       |    1
       fs/xfs/xfs_attr.c              |  107 ---
       fs/xfs/xfs_attr.h              |   10
       fs/xfs/xfs_attr_leaf.c         |   14
       fs/xfs/xfs_attr_sf.h           |   40 -
       fs/xfs/xfs_bmap.c              |  507 +++------------
       fs/xfs/xfs_bmap.h              |   49 -
       fs/xfs/xfs_bmap_btree.c        |    6
       fs/xfs/xfs_btree.c             |    5
       fs/xfs/xfs_btree_trace.h       |   17
       fs/xfs/xfs_buf_item.c          |   87 --
       fs/xfs/xfs_buf_item.h          |   20
       fs/xfs/xfs_da_btree.c          |    3
       fs/xfs/xfs_da_btree.h          |    7
       fs/xfs/xfs_dfrag.c             |    2
       fs/xfs/xfs_dir2.c              |    8
       fs/xfs/xfs_dir2_block.c        |   20
       fs/xfs/xfs_dir2_leaf.c         |   21
       fs/xfs/xfs_dir2_node.c         |   27
       fs/xfs/xfs_dir2_sf.c           |   26
       fs/xfs/xfs_dir2_trace.c        |  216 ------
       fs/xfs/xfs_dir2_trace.h        |   72 --
       fs/xfs/xfs_filestream.c        |    8
       fs/xfs/xfs_fsops.c             |    2
       fs/xfs/xfs_iget.c              |  111 ---
       fs/xfs/xfs_inode.c             |   67 --
       fs/xfs/xfs_inode.h             |   76 --
       fs/xfs/xfs_inode_item.c        |    5
       fs/xfs/xfs_iomap.c             |   85 --
       fs/xfs/xfs_iomap.h             |    8
       fs/xfs/xfs_log.c               |  181 +----
       fs/xfs/xfs_log_priv.h          |   20
       fs/xfs/xfs_log_recover.c       |    1
       fs/xfs/xfs_mount.c             |    2
       fs/xfs/xfs_quota.h             |    8
       fs/xfs/xfs_rename.c            |    1
       fs/xfs/xfs_rtalloc.c           |    1
       fs/xfs/xfs_rw.c                |    3
       fs/xfs/xfs_trans.h             |   47 +
       fs/xfs/xfs_trans_buf.c         |   62 -
       fs/xfs/xfs_vnodeops.c          |    8
       70 files changed, 2151 insertions(+), 2592 deletions(-)
      
      Signed-off-by: default avatarChristoph Hellwig <hch@lst.de>
      Signed-off-by: default avatarAlex Elder <aelder@sgi.com>
      0b1b213f
  4. 11 Dec, 2009 2 commits
  5. 12 Aug, 2009 1 commit
    • Christoph Hellwig's avatar
      xfs: switch to NOFS allocation under i_lock in xfs_buf_associate_memory · 36fae17a
      Christoph Hellwig authored
      
      
      xfs_buf_associate_memory is used for setting up the spare buffer for the
      log wrap case in xlog_sync which can happen under i_lock when called from
      xfs_fsync. The i_lock mutex is taken in reclaim context so all allocations
      under it must avoid recursions into the filesystem.  There are a couple
      more uses of xfs_buf_associate_memory in the log recovery code that are
      also affected by this, but I'd rather keep the code simple than passing on
      a gfp_mask argument.  Longer term we should just stop requiring the memoery
      allocation in xlog_sync by some smaller rework of the buffer layer.
      
      Reported by the new reclaim context tracing in lockdep.
      
      Signed-off-by: default avatarChristoph Hellwig <hch@lst.de>
      Reviewed-by: default avatarFelix Blyakher <felixb@sgi.com>
      Signed-off-by: default avatarFelix Blyakher <felixb@sgi.com>
      36fae17a
  6. 11 Aug, 2009 1 commit
    • Christoph Hellwig's avatar
      xfs: switch to NOFS allocation under i_lock in xfs_buf_associate_memory · 837273b8
      Christoph Hellwig authored
      
      
      xfs_buf_associate_memory is used for setting up the spare buffer for the
      log wrap case in xlog_sync which can happen under i_lock when called from
      xfs_fsync. The i_lock mutex is taken in reclaim context so all allocations
      under it must avoid recursions into the filesystem.  There are a couple
      more uses of xfs_buf_associate_memory in the log recovery code that are
      also affected by this, but I'd rather keep the code simple than passing on
      a gfp_mask argument.  Longer term we should just stop requiring the memoery
      allocation in xlog_sync by some smaller rework of the buffer layer.
      
      Reported by the new reclaim context tracing in lockdep.
      
      Signed-off-by: default avatarChristoph Hellwig <hch@lst.de>
      Reviewed-by: default avatarFelix Blyakher <felixb@sgi.com>
      Signed-off-by: default avatarFelix Blyakher <felixb@sgi.com>
      837273b8
  7. 10 Jul, 2009 1 commit
  8. 22 May, 2009 1 commit
  9. 06 Apr, 2009 1 commit
  10. 06 Mar, 2009 1 commit
  11. 04 Mar, 2009 1 commit
  12. 19 Feb, 2009 2 commits
  13. 18 Feb, 2009 2 commits
  14. 08 Jan, 2009 2 commits
    • Nick Piggin's avatar
      [XFS] use scalable vmap API · 0087167c
      Nick Piggin authored
      Implement XFS's large buffer support with the new vmap APIs. See the vmap
      rewrite (db64fe02
      
      ) for some numbers. The biggest improvement that comes from
      using the new APIs is avoiding the global KVA allocation lock on every call.
      
      Signed-off-by: default avatarNick Piggin <npiggin@suse.de>
      Reviewed-by: default avatarChristoph Hellwig <hch@infradead.org>
      Signed-off-by: default avatarLachlan McIlroy <lachlan@sgi.com>
      0087167c
    • Nick Piggin's avatar
      [XFS] remove old vmap cache · 958f8c0e
      Nick Piggin authored
      
      
      XFS's vmap batching simply defers a number (up to 64) of vunmaps, and keeps
      track of them in a list. To purge the batch, it just goes through the list and
      calls vunamp on each one. This is pretty poor: a global TLB flush is generally
      still performed on each vunmap, with the most expensive parts of the operation
      being the broadcast IPIs and locking involved in the SMP callouts, and the
      locking involved in the vmap management -- none of these are avoided by just
      batching up the calls. I'm actually surprised it ever made much difference.
      (Now that the lazy vmap allocator is upstream, this description is not quite
      right, but the vunmap batching still doesn't seem to do much)
      
      Rip all this logic out of XFS completely. I will improve vmap performance
      and scalability directly in subsequent patch.
      
      Signed-off-by: default avatarNick Piggin <npiggin@suse.de>
      Reviewed-by: default avatarChristoph Hellwig <hch@infradead.org>
      Signed-off-by: default avatarLachlan McIlroy <lachlan@sgi.com>
      958f8c0e
  15. 05 Jan, 2009 2 commits
    • Nick Piggin's avatar
      [XFS] use scalable vmap API · 95f8e302
      Nick Piggin authored
      Implement XFS's large buffer support with the new vmap APIs. See the vmap
      rewrite (db64fe02
      
      ) for some numbers. The biggest improvement that comes from
      using the new APIs is avoiding the global KVA allocation lock on every call.
      
      Signed-off-by: default avatarNick Piggin <npiggin@suse.de>
      Reviewed-by: default avatarChristoph Hellwig <hch@infradead.org>
      Signed-off-by: default avatarLachlan McIlroy <lachlan@sgi.com>
      95f8e302
    • Nick Piggin's avatar
      [XFS] remove old vmap cache · d2859751
      Nick Piggin authored
      
      
      XFS's vmap batching simply defers a number (up to 64) of vunmaps, and keeps
      track of them in a list. To purge the batch, it just goes through the list and
      calls vunamp on each one. This is pretty poor: a global TLB flush is generally
      still performed on each vunmap, with the most expensive parts of the operation
      being the broadcast IPIs and locking involved in the SMP callouts, and the
      locking involved in the vmap management -- none of these are avoided by just
      batching up the calls. I'm actually surprised it ever made much difference.
      (Now that the lazy vmap allocator is upstream, this description is not quite
      right, but the vunmap batching still doesn't seem to do much)
      
      Rip all this logic out of XFS completely. I will improve vmap performance
      and scalability directly in subsequent patch.
      
      Signed-off-by: default avatarNick Piggin <npiggin@suse.de>
      Reviewed-by: default avatarChristoph Hellwig <hch@infradead.org>
      Signed-off-by: default avatarLachlan McIlroy <lachlan@sgi.com>
      d2859751
  16. 11 Dec, 2008 1 commit
  17. 10 Dec, 2008 1 commit
  18. 03 Dec, 2008 1 commit
    • Christoph Hellwig's avatar
      kill xfs_buf_iostart · 5d765b97
      Christoph Hellwig authored
      
      
      xfs_buf_iostart is a "shared" helper for xfs_buf_read_flags,
      xfs_bawrite, and xfs_bdwrite - except that there isn't much shared
      code but rather special cases for each caller.
      
      So remove this function and move the functionality to the caller.
      xfs_bawrite and xfs_bdwrite are now big enough to be moved out of
      line and the xfs_buf_read_flags is moved into a new helper called
      _xfs_buf_read.
      
      Signed-off-by: default avatarChristoph Hellwig <hch@lst.de>
      Reviewed-by: default avatarDave Chinner <david@fromorbit.com>
      Signed-off-by: default avatarNiv Sardi <xaiki@sgi.com>
      5d765b97
  19. 10 Oct, 2008 1 commit
  20. 13 Aug, 2008 3 commits
  21. 12 Aug, 2008 1 commit
  22. 28 Jul, 2008 2 commits
  23. 23 May, 2008 1 commit
  24. 29 Apr, 2008 1 commit
  25. 17 Apr, 2008 2 commits
  26. 07 Feb, 2008 3 commits
  27. 06 Feb, 2008 1 commit
  28. 05 Feb, 2008 1 commit