1. 20 Nov, 2007 2 commits
  2. 05 Nov, 2007 2 commits
    • Roel Kluin's avatar
      [S390] Fix priority mistakes in drivers/s390/cio/cmf.c · b2eaee6e
      Roel Kluin authored
      
      
      Fixes priority mistakes similar to '!x & y'
      Signed-off-by: default avatarRoel Kluin <12o3l@tiscali.nl>
      Signed-off-by: default avatarMartin Schwidefsky <schwidefsky@de.ibm.com>
      b2eaee6e
    • Heiko Carstens's avatar
      [S390] cio: use INIT_WORK to initialize struct work. · 33583c36
      Heiko Carstens authored
      
      
      Use INIT_WORK to initialize struct work and don't initialize a
      struct work partial by explicitly initializing its private structures.
      Fixes the following lockdep bug because no key was assigned:
      
      INFO: trying to register non-static key.
      the code is fine but needs lockdep annotation.
      turning off the locking correctness validator.
      0000000001f07bb8 0000000001f07bf8 0000000000000002 0000000000000000
             0000000001f07c98 0000000001f07c10 0000000001f07c10 0000000000015406
             0000000000000000 0000000000000002 0000000000000000 0000000000000000
             0000000001f07bf8 000000000000000c 0000000001f07bf8 0000000001f07c68
             000000000039ae60 0000000000015406 0000000001f07bf8 0000000001f07c48
      Call Trace:
      ([<0000000000015376>] show_trace+0xda/0x104)
       [<0000000000015460>] show_stack+0xc0/0xf8
       [<00000000000154c6>] dump_stack+0x2e/0x3c
       [<000000000006a71e>] __lock_acquire+0x47e/0x11a0
       [<000000000006b4f0>] lock_acquire+0xb0/0xd8
       [<00000000000555a6>] run_workqueue+0x1aa/0x24c
       [<00000000000556de>] worker_thread+0x96/0xf4
       [<000000000005c210>] kthread+0x90/0xb4
       [<000000000001947a>] kernel_thread_starter+0x6/0xc
       [<0000000000019474>] kernel_thread_starter+0x0/0xc
      Signed-off-by: default avatarHeiko Carstens <heiko.carstens@de.ibm.com>
      Signed-off-by: default avatarMartin Schwidefsky <schwidefsky@de.ibm.com>
      33583c36
  3. 22 Oct, 2007 2 commits
  4. 19 Oct, 2007 2 commits
  5. 12 Oct, 2007 15 commits
  6. 22 Aug, 2007 5 commits
  7. 10 Aug, 2007 2 commits
  8. 27 Jul, 2007 6 commits
  9. 17 Jul, 2007 3 commits
  10. 11 Jul, 2007 1 commit
    • Zhang Rui's avatar
      sysfs: add parameter "struct bin_attribute *" in .read/.write methods for sysfs binary attributes · 91a69029
      Zhang Rui authored
      
      
      Well, first of all, I don't want to change so many files either.
      
      What I do:
      Adding a new parameter "struct bin_attribute *" in the
      .read/.write methods for the sysfs binary attributes.
      
      In fact, only the four lines change in fs/sysfs/bin.c and
      include/linux/sysfs.h do the real work.
      But I have to update all the files that use binary attributes
      to make them compatible with the new .read and .write methods.
      I'm not sure if I missed any. :(
      
      Why I do this:
      For a sysfs attribute, we can get a pointer pointing to the
      struct attribute in the .show/.store method,
      while we can't do this for the binary attributes.
      I don't know why this is different, but this does make it not
      so handy to use the binary attributes as the regular ones.
      So I think this patch is reasonable. :)
      
      Who benefits from it:
      The patch that exposes ACPI tables in sysfs
      requires such an improvement.
      All the table binary attributes share the same .read method.
      Parameter "struct bin_attribute *" is used to get
      the table signature and instance number which are used to
      distinguish different ACPI table binary attributes.
      
      Without this parameter, we need to offer different .read methods
      for different ACPI table binary attributes.
      This is impossible as there are various ACPI tables on different
      platforms, and we don't know what they are until they are loaded.
      Signed-off-by: default avatarZhang Rui <rui.zhang@intel.com>
      Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@suse.de>
      91a69029