1. 12 May, 2008 12 commits
    • Sergei Shtylyov's avatar
      [MIPS] Alchemy common code style cleanup · c1dcb14e
      Sergei Shtylyov authored
      
      
      Fix many errors and warnings given by checkpatch.pl:
      
      - use of C99 // comments;
      
      - missing space between the type and asterisk in a variable declaration;
      
      - space between the asterisk and function/variable name;
      
      - leading spaces instead of tabs;
      
      - space after opening and before closing parentheses;
      
      - initialization of a 'static' variable to 0;
      
      - missing spaces around assignement/comparison operator;
      
      - brace not on the same line with condition (or 'else') in the 'if'/'switch'
        statement;
      
      - missing space between 'if'/'for'/'while' and opening parenthesis;
      
      - use of assignement in 'if' statement's condition;
      
      - printk() without KERN_* facility level;
      
      - EXPORT_SYMBOL() not following its function immediately;
      
      - unnecessary braces for single-statement block;
      
      - adding new 'typedef' (where including <linux/types.h> will do);
      
      - use of 'extern' in the .c file (where it can be avoided by including header);
      
      - line over 80 characters.
      
      In addition to these changes, also do the following:
      
      - insert missing space after opening brace and/or before closing brace in the
        structure initializers;
      
      - insert spaces between operator and its operands;
      
      - put the function's result type and name/parameters on the same line;
      
      - properly indent multi-line expressions;
      
      - remove commented out code;
      
      - remove useless initializers and code;
      
      - remove needless parentheses;
      
      - fix broken/excess indentation;
      
      - add missing spaces between operator and its operands;
      
      - insert missing and remove excess new lines;
      
      - group 'else' and 'if' together where possible;
      
      - make au1xxx_platform_init() 'static';
      
      - regroup variable declarations in pm_do_freq() for prettier look;
      
      - replace numeric literals with the matching macros;
      
      - fix printk() format specifiers mismatching the argument types;
      
      - make the multi-line comment style consistent with the kernel style elsewhere
        by adding empty first line and/or adding space on their left side;
      
      - make two-line comments that only have one line of text one-line;
      
      - fix typos/errors, capitalize acronyms, etc. in the comments;
      
      - fix/remove obsolete references in the comments;
      
      - reformat some comments;
      
      - add comment about the CPU:counter clock ratio to calc_clock();
      
      - update MontaVista copyright;
      
      - remove Pete Popov's and Steve Longerbeam's old email addresses...
      Signed-off-by: default avatarSergei Shtylyov <sshtylyov@ru.mvista.com>
      Signed-off-by: default avatarRalf Baechle <ralf@linux-mips.org>
      c1dcb14e
    • Sergei Shtylyov's avatar
      [MIPS] Alchemy common headers style cleanup · ff6814d5
      Sergei Shtylyov authored
      
      
      Fix several errors and warnings given by checkpatch.pl:
      
      - space after opening and before closing parentheses;
      
      - opening brace following 'struct' not on the same line;
      
      - leading spaces instead of tabs;
      
      - use of C99 // comments;
      
      - macros with complex values not enclosed in parentheses;
      
      - missing space between the type and asterisk in a variable declaration;
      
      - space between asterisk and function name;
      
      - including <asm/io.h> instead of <linux/io.h> and <asm/irq.h> instead of
        <linux/irq.h>;
      
      - use of '__inline__' instead of 'inline';
      
      - space between function name and opening parenthesis;
      
      - line over 80 characters.
      
      In addition to these changes, also do the following:
      
      - remove needless parentheses;
      
      - insert spaces between operator and its operands;
      
      - replace spaces after the macro name with tabs in the #define directives and
        after the type in the structure field declarations;
      
      - remove excess tabs after the macro name in the #define directives and in the
        'extern' variable declarations;
      
      - remove excess spaces between # and define for the SSI_*_MASK macros to align
        with other such macros;
      
      - put '||' operator on the same line with its first operand;
      
      - properly indent multi-line function prototypes;
      
      - make the multi-line comment style consistent with the kernel style elsewhere
        by adding empty first line and/or adding space/asterisk on their left side;
      
      - make two-line comments that only have one line of text one-line;
      
      - convert the large multi-line comment in au1xxx_ide.h into several one-liners,
        replace spaces with tabs there;
      
      - fix typos/errors, capitalize acronyms, etc. in the comments;
      
      - insert missing and remove excess new lines;
      
      - update MontaVista copyright;
      
      - remove Pete Popov's and Steve Longerbeam's old email addresses...
      Signed-off-by: default avatarSergei Shtylyov <sshtylyov@ru.mvista.com>
      Signed-off-by: default avatarRalf Baechle <ralf@linux-mips.org>
      ff6814d5
    • Ralf Baechle's avatar
      [MIPS] Add empty argument parenthesis to GCC_IMM_ASM · ad1d77a3
      Ralf Baechle authored
      
      
      This is to clarify that GCC_IMM_ASM does not take an argument as the
      context of the macro's invocation seems to imply.
      
      As suggested by Maciej W. Rozycki (macro@linux-mips.org).
      Signed-off-by: default avatarRalf Baechle <ralf@linux-mips.org>
      ad1d77a3
    • Jeff Garzik's avatar
      [MIPS] msp_hwbutton.c: minor irq handler cleanups · 1c9e919f
      Jeff Garzik authored
      
      
      - remove always-true test
      
      - neaten request_irq() indentation
      
      This change's main purpose is to prepare for the patchset in
      jgarzik/misc-2.6.git#irq-remove, that explores removal of the
      never-used 'irq' argument in each interrupt handler.
      Signed-off-by: default avatarJeff Garzik <jgarzik@redhat.com>
      Signed-off-by: default avatarRalf Baechle <ralf@linux-mips.org>
      1c9e919f
    • Adrian Bunk's avatar
      [MIPS] unexport __kmap_atomic_to_page · a6406304
      Adrian Bunk authored
      
      
      This patch removes the no longer used export of __kmap_atomic_to_page.
      Signed-off-by: default avatarAdrian Bunk <bunk@kernel.org>
      Signed-off-by: default avatarRalf Baechle <ralf@linux-mips.org>
      a6406304
    • Ralf Baechle's avatar
      [MIPS] Initialize max_pfn again. · dc3bf353
      Ralf Baechle authored
      This was dropped by
      
      commit a0d9e2d891e4cf54676c430da63bd4a17d1cdb80 (lmo)
      commit b6f1f0de
      
       (ko)
      Author: Franck Bui-Huu <vagabon.xyz@gmail.com>
      Date:   Fri Aug 11 17:51:48 2006 +0200
      Signed-off-by: default avatarRalf Baechle <ralf@linux-mips.org>
      dc3bf353
    • Ralf Baechle's avatar
      [MIPS] IRIX: Handle do_brk() error return correctly. · f4324f3e
      Ralf Baechle authored
      
      
      do_brk's return value was stored in an unsigned long variable before being
      tested for less than zero making the test always fail.  Also do_brk's
      called irix_map_prda_page wasn't forwarding do_brk() success.
      
      Bug checking the return value of do_brk() and initial fix for it found
      by Roel Kluin <12o3l@tiscali.nl>.
      Signed-off-by: default avatarRalf Baechle <ralf@linux-mips.org>
      f4324f3e
    • Kevin D. Kissell's avatar
    • Ralf Baechle's avatar
      [MIPS] Don't use max_pfn which is no longer initialized these days. · 9f2546ad
      Ralf Baechle authored
      
      
      Still won't play nicely with esotheric configurations such as discontig
      memory ...
      Signed-off-by: default avatarRalf Baechle <ralf@linux-mips.org>
      9f2546ad
    • Roel Kluin's avatar
    • Kevin D. Kissell's avatar
    • Sergei Shtylyov's avatar
      [MIPS] Alchemy: SMBus resource fix · 8e07c2c6
      Sergei Shtylyov authored
      
      
      The Alchemy platform code registers the SMBus device using the virtual
      address of its registers instead of the physical one -- fix this, taking
      into account that actually the whole megabyte is decoded by any of the
      programmable serial controllers (one of which is SMBus), and that all the
      Alchemy peripherals are directly mappable into KSEG1 kernel space and
      therefore ioremap() call would just boil down to CKSEG1ADDR() invocation.
      Signed-off-by: default avatarSergei Shtylyov <sshtylyov@ru.mvista.com>
      Signed-off-by: default avatarRalf Baechle <ralf@linux-mips.org>
      8e07c2c6
  2. 11 May, 2008 17 commits
  3. 10 May, 2008 11 commits
    • Linus Torvalds's avatar
      Merge master.kernel.org:/home/rmk/linux-2.6-arm · 5bb7ff79
      Linus Torvalds authored
      * master.kernel.org:/home/rmk/linux-2.6-arm:
        [ARM] 5033/1: Unbreak corgi_ssp by registering ssp drivers earlier.
        [ARM] Orion: clean up addr-map.c after window setting code purge
        [ARM] Orion: pass proper t_clk into mv643xx_eth
        [ARM] Orion: use mv643xx_eth driver mbus window handling
        [ARM] pxa: Fix RCSR handling
        [ARM] lubbock: fix compilation
        [ARM] 5032/1: Added cpufreq support for pxa27x CPU
        [ARM] 5031/1: Indentation correction in cpu-pxa.c.
        [ARM] 5028/1: pxafb: fix broken "backward compatibility way" in framebuffer
        [ARM] 4882/2: Correction for S3C2410 clkout generation
        [ARM] 5027/1: Fixed random memory corruption on pxa suspend cycle.
        [ARM] 5024/1: Fix some minor clk issues in the MMCI PL18x driver
        [ARM] 5023/1: Fix broken gpio interrupts on ep93xx
        ns9xxx: fix sparse warning
        ns9xxx: check for irq lockups
        ns9xxx: fix handle_prio_irq to unmask irqs with lower priority
      5bb7ff79
    • Linus Torvalds's avatar
      Merge branch 'for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/x86/linux-2.6-x86 · 3e1b83ab
      Linus Torvalds authored
      * 'for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/x86/linux-2.6-x86:
        x86: rdc: leds build/config fix
        x86: sysfs cpu?/topology is empty in 2.6.25 (32-bit Intel system)
        x86: revert commit 709f744f ("x86: bitops asm constraint fixes")
        x86: restrict keyboard io ports reservation to make ipmi driver work
        x86: fix fpu restore from sig return
        x86: remove spew print out about bus to node mapping
        x86: revert printk format warning change which is for linux-next
        x86: cleanup PAT cpu validation
        x86: geode: define geode_has_vsa2() even if CONFIG_MGEODE_LX is not set
        x86: GEODE: cache results from geode_has_vsa2() and uninline
        x86: revert geode config dependency
      3e1b83ab
    • Linus Torvalds's avatar
      BKL: revert back to the old spinlock implementation · 8e3e076c
      Linus Torvalds authored
      The generic semaphore rewrite had a huge performance regression on AIM7
      (and potentially other BKL-heavy benchmarks) because the generic
      semaphores had been rewritten to be simple to understand and fair.  The
      latter, in particular, turns a semaphore-based BKL implementation into a
      mess of scheduling.
      
      The attempt to fix the performance regression failed miserably (see the
      previous commit 00b41ec2
      
       'Revert
      "semaphore: fix"'), and so for now the simple and sane approach is to
      instead just go back to the old spinlock-based BKL implementation that
      never had any issues like this.
      
      This patch also has the advantage of being reported to fix the
      regression completely according to Yanmin Zhang, unlike the semaphore
      hack which still left a couple percentage point regression.
      
      As a spinlock, the BKL obviously has the potential to be a latency
      issue, but it's not really any different from any other spinlock in that
      respect.  We do want to get rid of the BKL asap, but that has been the
      plan for several years.
      
      These days, the biggest users are in the tty layer (open/release in
      particular) and Alan holds out some hope:
      
        "tty release is probably a few months away from getting cured - I'm
         afraid it will almost certainly be the very last user of the BKL in
         tty to get fixed as it depends on everything else being sanely locked."
      
      so while we're not there yet, we do have a plan of action.
      Tested-by: default avatarYanmin Zhang <yanmin_zhang@linux.intel.com>
      Cc: Ingo Molnar <mingo@elte.hu>
      Cc: Andi Kleen <andi@firstfloor.org>
      Cc: Matthew Wilcox <matthew@wil.cx>
      Cc: Alexander Viro <viro@ftp.linux.org.uk>
      Cc: Andrew Morton <akpm@linux-foundation.org>
      Signed-off-by: default avatarLinus Torvalds <torvalds@linux-foundation.org>
      8e3e076c
    • Linus Torvalds's avatar
      Revert "semaphore: fix" · 00b41ec2
      Linus Torvalds authored
      This reverts commit bf726eab, as it has
      been reported to cause a regression with processes stuck in __down(),
      apparently because some missing wakeup.
      
      Quoth Sven Wegener:
       "I'm currently investigating a regression that has showed up with my
        last git pull yesterday.  Bisecting the commits showed bf726e
        "semaphore: fix" to be the culprit, reverting it fixed the issue.
      
        Symptoms: During heavy filesystem usage (e.g.  a kernel compile) I get
        several compiler processes in uninterruptible sleep, blocking all i/o
        on the filesystem.  System is an Intel Core 2 Quad running a 64bit
        kernel and userspace.  Filesystem is xfs on top of lvm.  See below for
        the output of sysrq-w."
      
      See
      
      	http://lkml.org/lkml/2008/5/10/45
      
      
      
      for full report.
      
      In the meantime, we can just fix the BKL performance regression by
      reverting back to the good old BKL spinlock implementation instead,
      since any sleeping lock will generally perform badly, especially if it
      tries to be fair.
      Reported-by: default avatarSven Wegener <sven.wegener@stealer.net>
      Cc: Andrew Morton <akpm@linux-foundation.org>
      Cc: Ingo Molnar <mingo@elte.hu>
      Signed-off-by: default avatarLinus Torvalds <torvalds@linux-foundation.org>
      00b41ec2
    • Linus Torvalds's avatar
      Make <asm-x86/spinlock.h> use ACCESS_ONCE() · 39f004ba
      Linus Torvalds authored
      
      
      ..instead of cooking up its own uglier local version of it.
      Signed-off-by: default avatarLinus Torvalds <torvalds@linux-foundation.org>
      39f004ba
    • Linus Torvalds's avatar
      Move ACCESS_ONCE() to <linux/compiler.h> · 9c3cdc1f
      Linus Torvalds authored
      
      
      It actually makes much more sense there, and we do tend to need it for
      non-RCU usage too.  Moving it to <linux/compiler.h> will allow some
      other cases that have open-coded the same logic to use the same helper
      function that RCU has used.
      Signed-off-by: default avatarLinus Torvalds <torvalds@linux-foundation.org>
      9c3cdc1f
    • Ingo Molnar's avatar
      x86: rdc: leds build/config fix · 82fd8667
      Ingo Molnar authored
      
      
      select NEW_LEDS for now until the Kconfig dependencies have been
      fixed.
      Signed-off-by: default avatarIngo Molnar <mingo@elte.hu>
      Signed-off-by: default avatarThomas Gleixner <tglx@linutronix.de>
      82fd8667
    • Vaidyanathan Srinivasan's avatar
      x86: sysfs cpu?/topology is empty in 2.6.25 (32-bit Intel system) · 5c3a121d
      Vaidyanathan Srinivasan authored
      
      
      System topology on intel based system needs to be exported
      for non-numa case as well.
      
      All parts of asm-i386/topology.h has come under
      #ifdef CONFIG_NUMA after the merge to asm-x86/topology.h
      
      /sys/devices/system/cpu/cpu?/topology/* is populated based on
      ENABLE_TOPO_DEFINES
      
      The sysfs cpu topology is not being populated on my dual socket
      dual core xeon 5160 processor based (x86 32 bit) system.
      
      CONFIG_NUMA is not set in my case yet the topology is relevant
      and useful.
      
      irqbalance daemon application depends on topology to build the
      cpus and package list and it fails on Fedora9 beta since the
      sysfs topology was not being populated in the 2.6.25 kernel.
      
      I am not sure if it was intentional to not define ENABLE_TOPO_DEFINES
      for non-numa systems.
      
      This fix has been tested on the above mentioned dual core, dual socket
      system.
      Signed-off-by: default avatarVaidyanathan Srinivasan <svaidy@linux.vnet.ibm.com>
      Signed-off-by: default avatarIngo Molnar <mingo@elte.hu>
      Signed-off-by: default avatarThomas Gleixner <tglx@linutronix.de>
      Cc: stable@kernel.org
      5c3a121d
    • Simon Holm Thøgersen's avatar
      x86: revert commit 709f744f ("x86: bitops asm constraint fixes") · eb2b4e68
      Simon Holm Thøgersen authored
      709f744f causes my computer to freeze during the start up of X and my
      login manger (GDM). It gets to the point where it has shown the default
      X mouse cursor logo (a big X / cross) and does not respond to anything
      from that point on.
      
      This worked fine before 709f744f, and it works fine with 709f744f
      reverted on top of Linus' current tree (f74d505b
      
      ). The revert had
      conflicts, as far as I can tell due to white space changes. The diff I
      ended up with is below.
      
      It is 100% reproducible.
      Signed-off-by: default avatarIngo Molnar <mingo@elte.hu>
      Signed-off-by: default avatarThomas Gleixner <tglx@linutronix.de>
      eb2b4e68
    • Helge Wagner's avatar
      x86: restrict keyboard io ports reservation to make ipmi driver work · 9096bd7a
      Helge Wagner authored
      
      
      On some of our (single board computer) boards (x86) we are using an
      IPMI controller that uses I/O ports 0x62 and 0x66 for a KCS (keyboard
      controller style) IPMI system interface.
      
      Trying to load the openipmi driver fails, because the ports
      (0x62/0x66) are reserved for keyboard. keyboard reserves the full
      range 0x60-0x6F while it doesn't need to.
      
      Reserve only ports 0x60 and 0x64 for the legacy PS/2 i8042 keyboad
      controller instead of 0x60-0x6F to allow the openipmi driver to work.
      
      [ tglx: added 64bit fixup ]
      Signed-off-by: default avatarThomas Gleixner <tglx@linutronix.de>
      Acked-by: default avatarH. Peter Anvin <hpa@zytor.com>
      Signed-off-by: default avatarIngo Molnar <mingo@elte.hu>
      9096bd7a
    • Suresh Siddha's avatar
      x86: fix fpu restore from sig return · fd3c3ed5
      Suresh Siddha authored
      
      
      If the task never used fpu, initialize the fpu before restoring the FP
      state from the signal handler context. This will allocate the fpu
      state, if the task never needed it before.
      Reported-and-bisected-by: default avatarEric Sesterhenn <snakebyte@gmx.de>
      Signed-off-by: default avatarSuresh Siddha <suresh.b.siddha@intel.com>
      Tested-by: default avatarEric Sesterhenn <snakebyte@gmx.de>
      Cc: Frederik Deweerdt <deweerdt@free.fr>
      Signed-off-by: default avatarThomas Gleixner <tglx@linutronix.de>
      fd3c3ed5