1. 22 Aug, 2009 1 commit
  2. 21 Jun, 2009 1 commit
  3. 23 May, 2009 1 commit
  4. 27 Apr, 2009 1 commit
    • Abhijeet Joglekar's avatar
      [SCSI] libfc: Track rogue remote ports · b4c6f546
      Abhijeet Joglekar authored
      Rogue ports are currently not tracked on any list. The only reference
      to them is through any outstanding exchanges pending on the rogue ports.
      If the module is removed while a retry is set on a rogue port
      (say a Plogi retry for instance), this retry is not cancelled because there
      is no reference to the rogue port in the discovery rports list. Thus the
      local port can clean itself up, delete the exchange pool, and then the
      rogue port timeout can fire and try to start up another exchange.
      This patch tracks the rogue ports in a new list disc->rogue_rports. Creating
      a new list instead of using the disc->rports list keeps remote port code
      change to a minimum.
      1)  Whenever a rogue port is created, it is immediately added to the
      disc->rogue_rports list.
      2) When the rogues port goes to ready, it is removed from the rogue list
      and the real remote port is added to the disc->rports list
      3) The removal of the rogue from the disc->rogue_rports list is done in
      the context of the fc_rport_work() workQ thread in discovery callback.
      4) Real rports are removed from the disc->rports list like before. Lookup
      is done only in the real rports list. This avoids making large changes
      to the remote port code.
      5) In fc_disc_stop_rports, the rogues list is traversed in addition to the
      real list to stop the rogue ports and issue logoffs on them. This way, rogue
      ports get cleaned up when the local port goes away.
      6) rogue remote ports are not removed from the list right away, but
      removed late in fc_rport_work() context, multiple threads can find the same
      remote port in the list and call rport_logoff(). Rport_logoff() only
      continues with the logoff if port is not in NONE state, thus preventing
      multiple logoffs and multiple list deletions.
      7) Since the rport is removed from the disc list at a later stage
      (in the disc callback), incoming frames can find the rport even if
      rport_logoff() has been called on the rport. When rport_logoff() is called,
      the rport state is set to NONE, and we are trying to cancel all exchanges
      and retries on that port. While in this state, if an incoming
      Plogi/Prli/Logo or other frames match the rport, we should not reply
      because the rport is in the NONE state. Just drop the frame, since the
      rport will be deleted soon in the disc callback (fc_rport_work)
      8)  In fc_disc_single(), remove rport lookup and call to fc_disc_del_target.
      fc_disc_single() is called from recv_rscn_req() where rport lookup
      and rport_logoff is already done.
      Signed-off-by: default avatarAbhijeet Joglekar <abjoglek@cisco.com>
      Signed-off-by: default avatarRobert Love <robert.w.love@intel.com>
      Signed-off-by: default avatarJames Bottomley <James.Bottomley@HansenPartnership.com>
  5. 03 Apr, 2009 2 commits
  6. 13 Mar, 2009 2 commits
  7. 10 Mar, 2009 1 commit
    • Robert Love's avatar
      [SCSI] libfc, fcoe: Fix kerneldoc comments · 34f42a07
      Robert Love authored
      1) Added '()' for function names in kerneldoc comments
      2) Changed comment bookends from '**/' to '*/'. The comment on the the
         mailing list was that '**/' "is consistently unconventional.  Not
         wrong, just odd." The Documentation/kernel-doc-nano-HOWTO.txt
         states that kerneldoc comment blocks should end with '**/' but most
         (if not all) instance I found under drivers/scsi/ were only using
         the '*/' so I converted to that style.
      3) Removed incorrect linebreaks in kerneldoc comments where found
      4) Removed a few unnecessary blank comment lines in kerneldoc comment
      Signed-off-by: default avatarRobert Love <robert.w.love@intel.com>
      Signed-off-by: default avatarJames Bottomley <James.Bottomley@HansenPartnership.com>
  8. 06 Mar, 2009 4 commits
  9. 29 Dec, 2008 1 commit
    • Robert Love's avatar
      [SCSI] libfc: A modular Fibre Channel library · 42e9a92f
      Robert Love authored
      libFC is composed of 4 blocks supported by an exchange manager
      and a framing library. The upper 4 layers are fc_lport, fc_disc,
      fc_rport and fc_fcp. A LLD that uses libfc could choose to
      either use libfc's block, or using the transport template
      defined in libfc.h, override one or more blocks with its own
      The EM (Exchange Manager) manages exhcanges/sequences for all
      commands- ELS, CT and FCP.
      The framing library frames ELS and CT commands.
      The fc_lport block manages the library's representation of the
      host's FC enabled ports.
      The fc_disc block manages discovery of targets as well as
      handling changes that occur in the FC fabric (via. RSCN events).
      The fc_rport block manages the library's representation of other
      entities in the FC fabric. Currently the library uses this block
      for targets, its peer when in point-to-point mode and the
      directory server, but can be extended for other entities if
      The fc_fcp block interacts with the scsi-ml and handles all
      Signed-off-by: default avatarRobert Love <robert.w.love@intel.com>
      [jejb: added include of delay.h to fix ppc64 compile prob spotted by sfr]
      Signed-off-by: default avatarJames Bottomley <James.Bottomley@HansenPartnership.com>