1. 27 Nov, 2007 3 commits
  2. 13 Nov, 2007 3 commits
  3. 05 Nov, 2007 1 commit
  4. 26 Oct, 2007 4 commits
    • Jeff Garzik's avatar
      drivers/ide/pci/sc1200.c: fix suspend/resume buglets and warnings · 9d434813
      Jeff Garzik authored
      * We shouldn't bother with dev->current_state, the PCI API functions we
        call manage this for us (and do a far better job at it too).
      
      * Remove pci_set_power_state(dev, PCI_D0) call in resume, as
        pci_enable_device() does the same thing.
      
      * Check pci_enable_device() return value.  If it failed, fail
        the entire resume and avoid programming timings into the [potentially
        dead/asleep] chip.
      Signed-off-by: default avatarJeff Garzik <jgarzik@redhat.com>
      Cc: Andrew Morton <akpm@linux-foundation.org>
      Signed-off-by: default avatarBartlomiej Zolnierkiewicz <bzolnier@gmail.com>
      9d434813
    • Bartlomiej Zolnierkiewicz's avatar
      drivers/ide/pci/generic: fix build for CONFIG_HOTPLUG=n · d5271be6
      Bartlomiej Zolnierkiewicz authored
      It turns out that const and __{dev}initdata cannot be mixed currently
      and that generic IDE PCI host driver is also affected by the same issue:
      
      On Thursday 25 October 2007, Ralf Baechle wrote:
      >   CC      drivers/ide/pci/generic.o
      > drivers/ide/pci/generic.c:52: error: __setup_str_ide_generic_all_on causes a
      > +section type conflict
      
      [ Also reported by Martijn Uffing <mp3project@sarijopen.student.utwente.nl>. ]
      
      This patch workarounds the problem in a bit hackish way but without
      removing const from generic_chipsets[] (it adds const to __setup() so
      __setup_str_ide_generic_all becomes const).
      
      Now all __{dev}initdata data in generic IDE PCI host driver are read-only
      so it builds again (driver's .init.data section gets marked as READONLY).
      
      Cc: Martijn Uffing <mp3project@sarijopen.student.utwente.nl>
      Cc: Ralf Baechle <ralf@linux-mips.org>
      Cc: Andrew Morton <akpm@linux-foundation.org>
      Signed-off-by: default avatarBartlomiej Zolnierkiewicz <bzolnier@gmail.com>
      d5271be6
    • Bartlomiej Zolnierkiewicz's avatar
      hpt366: fix build for CONFIG_HOTPLUG=n · 282037f1
      Bartlomiej Zolnierkiewicz authored
      On Saturday 20 October 2007, Avuton Olrich wrote:
      
      > My randconfig script the attached config caught an error on:
      > drivers/ide/pci/cy82c693.c:439: error: primary causes a section type conflict
      >
      > My git tree: c00046c2
      >
      > Bisected to:
      > 85620436 is first bad commit
      > commit 85620436
      > Author: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
      > Date:   Sat Oct 20 00:32:34 2007 +0200
      >
      >     ide: constify struct ide_port_info
      >
      >     Signed-off-by: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
      
      It turns out that const and __{dev}initdata cannot be mixed currently
      and that hpt366 host driver is also affected by the same issue:
      
      > drivers/ide/pci/hpt366.c:1428: error: hpt366_chipsets causes a section type
      > conflict
      
      This patch workarounds the problem by making static struct hpt_info instances
      const.  Now all __devinitdata data in hpt366 host driver are read-only so it
      builds again (driver's .init.data section gets marked as READONLY).
      
      While at it:
      
      * Bump driver version.
      
      Cc: Sergei Shtylyov <sshtylyov@ru.mvista.com>
      Cc: "Avuton Olrich" <avuton@gmail.com>
      Cc: Randy Dunlap <randy.dunlap@oracle.com>
      Signed-off-by: default avatarBartlomiej Zolnierkiewicz <bzolnier@gmail.com>
      282037f1
    • Bartlomiej Zolnierkiewicz's avatar
      cy82c693: fix build for CONFIG_HOTPLUG=n · f32d26ae
      Bartlomiej Zolnierkiewicz authored
      On Saturday 20 October 2007, Avuton Olrich wrote:
      
      > My randconfig script the attached config caught an error on:
      > drivers/ide/pci/cy82c693.c:439: error: primary causes a section type conflict
      >
      > My git tree: c00046c2
      >
      > Bisected to:
      > 85620436 is first bad commit
      > commit 85620436
      > Author: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
      > Date:   Sat Oct 20 00:32:34 2007 +0200
      >
      >     ide: constify struct ide_port_info
      >
      >     Signed-off-by: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
      
      It turns out that const and __{dev}initdata cannot be mixed currently.
      
      This patch workarounds the problem by removing __devinitdata tag from 'primary'
      variable (which makes 'primary' to be moved from .init.data to .bss section).
      Now all __devinitdata data in cy82c693 host driver are read-only so it builds
      again (driver's .init.data section gets marked as READONLY).
      
      While at it:
      
      * Move 'primary' variable to its only user, init_iops_cy82c693().
      
      * Bump driver version.
      
      Cc: "Avuton Olrich" <avuton@gmail.com>
      Cc: Randy Dunlap <randy.dunlap@oracle.com>
      Signed-off-by: default avatarBartlomiej Zolnierkiewicz <bzolnier@gmail.com>
      f32d26ae
  5. 19 Oct, 2007 24 commits
  6. 18 Oct, 2007 5 commits