1. 01 Oct, 2010 1 commit
  2. 08 Aug, 2010 1 commit
  3. 07 Jul, 2010 2 commits
  4. 18 Apr, 2010 1 commit
  5. 26 Feb, 2010 1 commit
  6. 19 Nov, 2009 1 commit
    • Joe Perches's avatar
      drivers/isdn/gigaset: tasklet_init - Remove unnecessary leading & from second arg · 5452fee2
      Joe Perches authored
      Changed function pointer use from non-majority address-of style
      to majority short form without & via:
      
      grep -rPl "\btasklet_init\s*\([^,\)]+,\s*\&" drivers/isdn | while read file ; do \
              perl -i -e 'local $/; while (<>) { s@(\btasklet_init\s*\([^,\)]+,\s*)\&@\1@g ; print ; }' $file ;\
      done
      
      Compile tested allyesconfig x86
      Signed-off-by: default avatarJoe Perches <joe@perches.com>
      
       drivers/isdn/gigaset/bas-gigaset.c |    4 ++--
       drivers/isdn/gigaset/common.c      |    2 +-
       drivers/isdn/gigaset/interface.c   |    2 +-
       drivers/isdn/gigaset/ser-gigaset.c |    2 +-
       drivers/isdn/gigaset/usb-gigaset.c |    2 +-
       5 files changed, 6 insertions(+), 6 deletions(-)
      Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
      5452fee2
  7. 29 Oct, 2009 1 commit
  8. 06 Oct, 2009 3 commits
  9. 06 Apr, 2009 1 commit
  10. 19 Mar, 2009 1 commit
  11. 26 Dec, 2008 1 commit
  12. 29 Nov, 2008 1 commit
  13. 24 Jul, 2008 1 commit
  14. 06 Feb, 2008 5 commits
  15. 16 Oct, 2007 1 commit
  16. 29 Mar, 2007 1 commit
  17. 11 Feb, 2007 1 commit
  18. 13 Dec, 2006 1 commit
  19. 07 Dec, 2006 2 commits
  20. 05 Oct, 2006 1 commit
    • David Howells's avatar
      IRQ: Maintain regs pointer globally rather than passing to IRQ handlers · 7d12e780
      David Howells authored
      Maintain a per-CPU global "struct pt_regs *" variable which can be used instead
      of passing regs around manually through all ~1800 interrupt handlers in the
      Linux kernel.
      
      The regs pointer is used in few places, but it potentially costs both stack
      space and code to pass it around.  On the FRV arch, removing the regs parameter
      from all the genirq function results in a 20% speed up of the IRQ exit path
      (ie: from leaving timer_interrupt() to leaving do_IRQ()).
      
      Where appropriate, an arch may override the generic storage facility and do
      something different with the variable.  On FRV, for instance, the address is
      maintained in GR28 at all times inside the kernel as part of general exception
      handling.
      
      Having looked over the code, it appears that the parameter may be handed down
      through up to twenty or so layers of functions.  Consider a USB character
      device attached to a USB hub, attached to a USB controller that posts its
      interrupts through a cascaded auxiliary interrupt controller.  A character
      device driver may want to pass regs to the sysrq handler through the input
      layer which adds another few layers of parameter passing.
      
      I've build this code with allyesconfig for x86_64 and i386.  I've runtested the
      main part of the code on FRV and i386, though I can't test most of the drivers.
      I've also done partial conversion for powerpc and MIPS - these at least compile
      with minimal configurations.
      
      This will affect all archs.  Mostly the changes should be relatively easy.
      Take do_IRQ(), store the regs pointer at the beginning, saving the old one:
      
      	struct pt_regs *old_regs = set_irq_regs(regs);
      
      And put the old one back at the end:
      
      	set_irq_regs(old_regs);
      
      Don't pass regs through to generic_handle_irq() or __do_IRQ().
      
      In timer_interrupt(), this sort of change will be necessary:
      
      	-	update_process_times(user_mode(regs));
      	-	profile_tick(CPU_PROFILING, regs);
      	+	update_process_times(user_mode(get_irq_regs()));
      	+	profile_tick(CPU_PROFILING);
      
      I'd like to move update_process_times()'s use of get_irq_regs() into itself,
      except that i386, alone of the archs, uses something other than user_mode().
      
      Some notes on the interrupt handling in the drivers:
      
       (*) input_dev() is now gone entirely.  The regs pointer is no longer stored in
           the input_dev struct.
      
       (*) finish_unlinks() in drivers/usb/host/ohci-q.c needs checking.  It does
           something different depending on whether it's been supplied with a regs
           pointer or not.
      
       (*) Various IRQ handler function pointers have been moved to type
           irq_handler_t.
      Signed-Off-By: default avatarDavid Howells <dhowells@redhat.com>
      (cherry picked from 1b16e7ac850969f38b375e511e3fa2f474a33867 commit)
      7d12e780
  21. 27 Sep, 2006 1 commit
    • Pete Zaitcev's avatar
      USB: Dealias -110 code (more complete) · 38e2bfc9
      Pete Zaitcev authored
      The purpose of this patch is to split off the case when a device does
      not reply on the lower level (which is reported by HC hardware), and
      a case when the device accepted the request, but does not reply at
      upper level. This redefinition allows to diagnose issues easier,
      without asking the user if the -110 happened "immediately".
      
      The usbmon splits such cases already thanks to its timestamp, but
      it's not always available.
      
      I adjusted all drivers which I found affected (by searching for "urb").
      Out of tree drivers may suffer a little bit, but I do not expect much
      breakage. At worst they may print a few messages.
      Signed-off-by: default avatarPete Zaitcev <zaitcev@redhat.com>
      Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@suse.de>
      38e2bfc9
  22. 26 Jun, 2006 2 commits
  23. 22 Apr, 2006 1 commit
    • Tilman Schmidt's avatar
      [PATCH] isdn4linux: Siemens Gigaset base driver: fix disconnect handling · 73a88814
      Tilman Schmidt authored
      Fix a possible Oops in the Siemens Gigaset base driver when the device is
      unplugged while an ISDN connection is still active, and makes sure that the
      isdn4linux link level (LL) is properly informed if a connection is broken
      by the USB cable being unplugged.
      
      - Avoid unsafe checks of URB status fields outside the URB completion
        handlers, keep track of in-use URBs myself instead.
      
      - If an isochronous transfer URB completes with status==0, also check the
        status of the frame descriptors.
      
      - Verify length of interrupt messages received from the device.
      
      - Align the length limit on transmitted AT commands with the device
        documentation.
      
      - In case of AT response receive overrun, keep newly arrived instead of old
        unread data.
      
      - Remove redundant check of device ID in the USB probe function.
      
      - Correct and improve some comments and formatting.
      Signed-off-by: default avatarTilman Schmidt <tilman@imap.cc>
      Acked-by: default avatarHansjoerg Lipp <hjlipp@web.de>
      Cc: Karsten Keil <kkeil@suse.de>
      Signed-off-by: default avatarAndrew Morton <akpm@osdl.org>
      Signed-off-by: default avatarLinus Torvalds <torvalds@osdl.org>
      73a88814
  24. 11 Apr, 2006 7 commits
  25. 26 Mar, 2006 1 commit