1. 01 Oct, 2010 1 commit
  2. 15 Sep, 2010 2 commits
  3. 14 Sep, 2010 1 commit
  4. 08 Sep, 2010 1 commit
  5. 06 Sep, 2010 2 commits
  6. 22 Aug, 2010 1 commit
    • Randy Dunlap's avatar
      isdn/avm: fix build when PCMCIA is not enabled · 6a6d01d3
      Randy Dunlap authored
      
      
      Why wouldn't kconfig symbol ISDN_DRV_AVMB1_B1PCMCIA also depend on
      PCMCIA?
      
      Fix build for PCMCIA not enabled:
      
      ERROR: "b1_free_card" [drivers/isdn/hardware/avm/b1pcmcia.ko] undefined!
      ERROR: "b1ctl_proc_fops" [drivers/isdn/hardware/avm/b1pcmcia.ko] undefined!
      ERROR: "b1_reset_ctr" [drivers/isdn/hardware/avm/b1pcmcia.ko] undefined!
      ERROR: "b1_load_firmware" [drivers/isdn/hardware/avm/b1pcmcia.ko] undefined!
      ERROR: "b1_send_message" [drivers/isdn/hardware/avm/b1pcmcia.ko] undefined!
      ERROR: "b1_release_appl" [drivers/isdn/hardware/avm/b1pcmcia.ko] undefined!
      ERROR: "b1_register_appl" [drivers/isdn/hardware/avm/b1pcmcia.ko] undefined!
      ERROR: "b1_getrevision" [drivers/isdn/hardware/avm/b1pcmcia.ko] undefined!
      ERROR: "b1_detect" [drivers/isdn/hardware/avm/b1pcmcia.ko] undefined!
      ERROR: "b1_interrupt" [drivers/isdn/hardware/avm/b1pcmcia.ko] undefined!
      ERROR: "b1_alloc_card" [drivers/isdn/hardware/avm/b1pcmcia.ko] undefined!
      Signed-off-by: default avatarRandy Dunlap <randy.dunlap@oracle.com>
      Cc: Carsten Paeth <calle@calle.de>
      Cc: Karsten Keil <isdn@linux-pingi.de>
      Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
      6a6d01d3
  7. 16 Aug, 2010 1 commit
    • Julia Lawall's avatar
      drivers/isdn: Adjust confusing if indentation · f7df0b8d
      Julia Lawall authored
      In hisax/hfc_sx.c and mISDN/l1oip_core.c, the code after the if is
      outdented so that it is not aligned with the if branch.
      
      In mISDN/dsp_cmx.c, an else is added between the original if branch and the
      following statement, in line with the code following it.  Without this
      change, the first assignment to dsp->rx_W has no useful effect.
      
      The semantic match that finds this problem is as follows:
      (http://coccinelle.lip6.fr/
      
      )
      
      // <smpl>
      @r disable braces4@
      position p1,p2;
      statement S1,S2;
      @@
      
      (
      if (...) { ... }
      |
      if (...) S1@p1 S2@p2
      )
      
      @script:python@
      p1 << r.p1;
      p2 << r.p2;
      @@
      
      if (p1[0].column == p2[0].column):
        cocci.print_main("branch",p1)
        cocci.print_secs("after",p2)
      // </smpl>
      Signed-off-by: default avatarJulia Lawall <julia@diku.dk>
      Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
      f7df0b8d
  8. 10 Aug, 2010 3 commits
  9. 08 Aug, 2010 2 commits
  10. 05 Aug, 2010 1 commit
  11. 03 Aug, 2010 4 commits
    • Dominik Brodowski's avatar
      pcmcia: do not request windows if you don't need to · 0f52e86d
      Dominik Brodowski authored
      
      
      Several drivers contained dummy code to request for memory windows,
      even though they never made use of it. Remove all such code
      snippets.
      
      CC: netdev@vger.kernel.org
      CC: linux-wireless@vger.kernel.org
      Signed-off-by: default avatarDominik Brodowski <linux@dominikbrodowski.net>
      0f52e86d
    • Dominik Brodowski's avatar
      pcmcia: remove memreq_t · b5cb259e
      Dominik Brodowski authored
      
      
      Page already had to be set to 0; Offset can easily be passed as
      parameter to pcmcia_map_mem_page.
      
      CC: netdev@vger.kernel.org
      CC: linux-wireless@vger.kernel.org
      CC: linux-ide@vger.kernel.org
      CC: linux-usb@vger.kernel.org
      CC: laforge@gnumonks.org
      CC: linux-mtd@lists.infradead.org
      CC: linux-bluetooth@vger.kernel.org
      CC: alsa-devel@alsa-project.org
      CC: linux-serial@vger.kernel.org
      CC: Michael Buesch <mb@bu3sch.de>
      Signed-off-by: default avatarDominik Brodowski <linux@dominikbrodowski.net>
      b5cb259e
    • Dominik Brodowski's avatar
      pcmcia: do not use io_req_t when calling pcmcia_request_io() · 90abdc3b
      Dominik Brodowski authored
      
      
      Instead of io_req_t, drivers are now requested to fill out
      struct pcmcia_device *p_dev->resource[0,1] for up to two ioport
      ranges. After a call to pcmcia_request_io(), the ports found there
      are reserved, after calling pcmcia_request_configuration(), they may
      be used.
      
      CC: netdev@vger.kernel.org
      CC: linux-wireless@vger.kernel.org
      CC: linux-ide@vger.kernel.org
      CC: linux-usb@vger.kernel.org
      CC: laforge@gnumonks.org
      CC: linux-mtd@lists.infradead.org
      CC: alsa-devel@alsa-project.org
      CC: linux-serial@vger.kernel.org
      CC: Michael Buesch <mb@bu3sch.de>
      Acked-by: Marcel Holtmann <marcel@holtmann.org> (for drivers/bluetooth/)
      Signed-off-by: default avatarDominik Brodowski <linux@dominikbrodowski.net>
      90abdc3b
    • Dominik Brodowski's avatar
      pcmcia: do not use io_req_t after call to pcmcia_request_io() · 9a017a91
      Dominik Brodowski authored
      
      
      After pcmcia_request_io(), do not make use of the values stored in
      io_req_t, but instead use those found in struct pcmcia_device->resource[].
      
      CC: netdev@vger.kernel.org
      CC: linux-wireless@vger.kernel.org
      CC: linux-ide@vger.kernel.org
      CC: linux-usb@vger.kernel.org
      CC: laforge@gnumonks.org
      CC: linux-mtd@lists.infradead.org
      CC: alsa-devel@alsa-project.org
      CC: linux-serial@vger.kernel.org
      Acked-by: Marcel Holtmann <marcel@holtmann.org> (for drivers/bluetooth/)
      Signed-off-by: default avatarDominik Brodowski <linux@dominikbrodowski.net>
      9a017a91
  12. 30 Jul, 2010 1 commit
    • Dominik Brodowski's avatar
      pcmcia: remove cs_types.h · ac8b4228
      Dominik Brodowski authored
      
      
      Remove cs_types.h which is no longer needed: Most definitions aren't
      used at all, a few can be made away with, and two remaining definitions
      (typedefs, unfortunatley) may be moved to more specific places.
      
      CC: linux-ide@vger.kernel.org
      CC: linux-usb@vger.kernel.org
      CC: laforge@gnumonks.org
      CC: linux-mtd@lists.infradead.org
      CC: alsa-devel@alsa-project.org
      CC: linux-serial@vger.kernel.org
      Acked-by: Marcel Holtmann <marcel@holtmann.org> (for drivers/bluetooth/)
      Acked-by: default avatarDavid S. Miller <davem@davemloft.net>
      Signed-off-by: default avatarDominik Brodowski <linux@dominikbrodowski.net>
      ac8b4228
  13. 15 Jul, 2010 8 commits
  14. 12 Jul, 2010 3 commits
    • Joe Perches's avatar
      54cbb1ca
    • Arnd Bergmann's avatar
      isdn: autoconvert trivial BKL users to private mutex · 76a64921
      Arnd Bergmann authored
      
      
      All these files use the big kernel lock in a trivial
      way to serialize their private file operations,
      typically resulting from an earlier semi-automatic
      pushdown from VFS.
      
      None of these drivers appears to want to lock against
      other code, and they all use the BKL as the top-level
      lock in their file operations, meaning that there
      is no lock-order inversion problem.
      
      Consequently, we can remove the BKL completely,
      replacing it with a per-file mutex in every case.
      Using a scripted approach means we can avoid
      typos.
      
      file=$1
      name=$2
      if grep -q lock_kernel ${file} ; then
          if grep -q 'include.*linux.mutex.h' ${file} ; then
                  sed -i '/include.*<linux\/smp_lock.h>/d' ${file}
          else
                  sed -i 's/include.*<linux\/smp_lock.h>.*$/include <linux\/mutex.h>/g' ${file}
          fi
          sed -i ${file} \
              -e "/^#include.*linux.mutex.h/,$ {
                      1,/^\(static\|int\|long\)/ {
                           /^\(static\|int\|long\)/istatic DEFINE_MUTEX(${name}_mutex);
      
      } }"  \
          -e "s/\(un\)*lock_kernel\>[ ]*()/mutex_\1lock(\&${name}_mutex)/g" \
          -e '/[      ]*cycle_kernel_lock();/d'
      else
          sed -i -e '/include.*\<smp_lock.h\>/d' ${file}  \
                      -e '/cycle_kernel_lock()/d'
      fi
      Signed-off-by: default avatarArnd Bergmann <arnd@arndb.de>
      Cc: Karsten Keil <isdn@linux-pingi.de>
      Cc: netdev@vger.kernel.org
      Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
      76a64921
    • Dan Carpenter's avatar
      isdn: fix strlen() usage · 84ce981a
      Dan Carpenter authored
      
      
      There was a missing "else" statement so the original code overflowed if
      ->master->name was too long.  Also the ->slave and ->master buffers can
      hold names with 9 characters and a NULL so I cleaned it up to allow
      another character.
      Signed-off-by: default avatarDan Carpenter <error27@gmail.com>
      Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
      84ce981a
  15. 11 Jul, 2010 1 commit
  16. 07 Jul, 2010 8 commits