1. 06 Feb, 2008 1 commit
  2. 03 Feb, 2008 6 commits
  3. 28 Jan, 2008 1 commit
    • Al Viro's avatar
      forcedeth endianness bugs · 5bb7ea26
      Al Viro authored
      
      
      * misannotation: struct register_test members are actually host-endian
      * bug: cpu_to_le64(n) >> 32 instead of cpu_to_le32(n >> 32) in setting
      ->bufhigh and similar for ->buflow (take low bits, _then_ convert to
      little-endian, not the other way round).
      * bug: setup_hw_rings() should not convert to little-endian at all (we
      feed the result to writel(), not store in shared data structure), let
      alone try to play with shifting and masking little-endian values.  Introduced
      when setup_hw_rings() went in, screwed both 64bit case and the old code for
      32bit rings it had replaced.
      Signed-off-by: default avatarAl Viro <viro@zeniv.linux.org.uk>
      Signed-off-by: default avatarJeff Garzik <jeff@garzik.org>
      5bb7ea26
  4. 09 Jan, 2008 1 commit
    • Björn Steinbrink's avatar
      [FORCEDETH]: Fix reversing the MAC address on suspend. · 2e3884b5
      Björn Steinbrink authored
      
      
      For cards that initially have the MAC address stored in reverse order,
      the forcedeth driver uses a flag to signal whether the address was
      already corrected, so that it is not reversed again on a subsequent
      probe.
      
      Unfortunately this flag, which is stored in a register of the card,
      seems to get lost during suspend, resulting in the MAC address being
      reversed again. To fix that, the MAC address needs to be written back
      in reversed order before we suspend and the flag needs to be reset.
      
      The flag is still required because at least kexec will never write
      back the reversed address and thus needs to know what state the card
      is in.
      Signed-off-by: default avatarBjörn Steinbrink <B.Steinbrink@gmx.de>
      Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
      2e3884b5
  5. 23 Nov, 2007 2 commits
  6. 25 Oct, 2007 1 commit
  7. 17 Oct, 2007 2 commits
  8. 16 Oct, 2007 3 commits
    • Jeff Garzik's avatar
      [netdrvr] forcedeth: remove in-driver copy of net_device_stats · 8148ff45
      Jeff Garzik authored
      
      
      A copy of struct net_device_stats now lives in struct net_device,
      making in-driver copies a waste of memory.
      Signed-off-by: default avatarJeff Garzik <jgarzik@redhat.com>
      8148ff45
    • Jeff Garzik's avatar
      [netdrvr] forcedeth: improved probe info; dev_printk() cleanups · 3f88ce49
      Jeff Garzik authored
      
      
      main change:
      * greatly improve per-NIC probe diagnostic output.  Similar to other
        net drivers, print out MAC address, PHY info, and various hardware and
        software flags that may be relevant.
      
      other changes:
      * similar to other net drivers, only print the initial version message
        when we have found at least one board.
      
      * don't bother to print error message when pci_enable_device() fails,
        it will do so for us.
      
      * use dev_printk() rather than printk() in nv_probe().  This gives
        use a standardized output similar to the rest of the kernel, and
        eliminates the need to manually print out PCI bus id.
      
      * use DRV_NAME constant where appropriate
      
      * clean struct pci_driver indentation
      Signed-off-by: default avatarJeff Garzik <jgarzik@redhat.com>
      3f88ce49
    • Ingo Molnar's avatar
      forcedeth: fix NAPI rx poll function · bcb5febb
      Ingo Molnar authored
      
      
      fix the forcedeth NAPI poll function to not emit this warning:
      
      [  186.635916] WARNING: at net/core/dev.c:2166 net_rx_action()
      [  186.641351]  [<c060d9f5>] net_rx_action+0x145/0x1b0
      [  186.646191]  [<c011d752>] __do_softirq+0x42/0x90
      [  186.650784]  [<c011d7c6>] do_softirq+0x26/0x30
      [  186.655202]  [<c011db48>] local_bh_enable+0x48/0xa0
      [  186.660055]  [<c06023e0>] lock_sock_nested+0xa0/0xc0
      [  186.664995]  [<c065da16>] tcp_recvmsg+0x16/0xbc0
      [  186.669588]  [<c013e94b>] __generic_file_aio_write_nolock+0x27b/0x520
      [  186.676001]  [<c0601d75>] sock_common_recvmsg+0x45/0x70
      [  186.681202]  [<c05ff5df>] sock_aio_read+0x11f/0x140
      [  186.686054]  [<c015c086>] do_sync_read+0xc6/0x110
      [  186.690735]  [<c012b9b0>] autoremove_wake_function+0x0/0x40
      [  186.696280]  [<c060dcfc>] net_tx_action+0x3c/0xe0
      [  186.700961]  [<c015c9c2>] vfs_read+0x132/0x140
      [  186.705378]  [<c015cd41>] sys_read+0x41/0x70
      [  186.709625]  [<c0102b66>] sysenter_past_esp+0x5f/0x89
      [  186.714651]  =======================
      Signed-off-by: default avatarIngo Molnar <mingo@elte.hu>
      Signed-off-by: default avatarJeff Garzik <jgarzik@redhat.com>
      bcb5febb
  9. 10 Oct, 2007 6 commits
  10. 25 Aug, 2007 1 commit
  11. 18 Aug, 2007 1 commit
    • Timo Jantunen's avatar
      fix random hang in forcedeth driver when using netconsole · 1a2b7330
      Timo Jantunen authored
      
      
      If the forcedeth driver receives too much work in an interrupt, it
      assumes it has a broken hardware with stuck IRQ.  It works around the
      problem by disabling interrupts on the nic but makes a printk while
      holding device spinlog - which isn't smart thing to do if you have
      netconsole on the same nic.
      
      This patch moves the printk's out of the spinlock protected area.
      
      Without this patch the machine hangs hard.  With this patch everything
      still works even when there is significant increase on CPU usage while
      using the nic.
      Signed-off-by: default avatarTimo Jantunen <jeti@iki.fi>
      Signed-off-by: default avatarLinus Torvalds <torvalds@linux-foundation.org>
      1a2b7330
  12. 31 Jul, 2007 1 commit
  13. 30 Jul, 2007 1 commit
  14. 24 Jul, 2007 1 commit
  15. 19 Jul, 2007 1 commit
  16. 16 Jul, 2007 3 commits
  17. 11 Jul, 2007 1 commit
    • Auke Kok's avatar
      PCI: Change all drivers to use pci_device->revision · 44c10138
      Auke Kok authored
      
      
      Instead of all drivers reading pci config space to get the revision
      ID, they can now use the pci_device->revision member.
      
      This exposes some issues where drivers where reading a word or a dword
      for the revision number, and adding useless error-handling around the
      read. Some drivers even just read it for no purpose of all.
      
      In devices where the revision ID is being copied over and used in what
      appears to be the equivalent of hotpath, I have left the copy code
      and the cached copy as not to influence the driver's performance.
      
      Compile tested with make all{yes,mod}config on x86_64 and i386.
      Signed-off-by: default avatarAuke Kok <auke-jan.h.kok@intel.com>
      Acked-by: default avatarDave Jones <davej@redhat.com>
      Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@suse.de>
      44c10138
  18. 20 Jun, 2007 1 commit
    • Tim Mann's avatar
      forcedeth: use unicast receive mode for WoL · 2cc49a5c
      Tim Mann authored
      
      
      I happened to notice that a system with an NVidia NIC using the
      forcedeth driver won't wake-on-LAN if the interface was in promiscuous
      mode when you power off.  By experiment, it looks like
      the hardware needs to have NvRegPacketFilterFlags set to
      NVREG_PFF_ALWAYS|NVREG_PFF_MYADDR (i.e., receive unicast packets to my
      address) in order for WoL to work.
      
      Jeff Garzik writes: "NVIDIA says the patch looks OK."  I didn't venture
      to insert a signed-off-by line with his name on it, though.
      Signed-off-by: default avatarTim Mann <mann@vmware.com>
      Signed-off-by: default avatarJeff Garzik <jeff@garzik.org>
      2cc49a5c
  19. 03 Jun, 2007 1 commit
  20. 24 May, 2007 1 commit
  21. 25 Apr, 2007 3 commits
  22. 28 Mar, 2007 1 commit