- 29 Nov, 2009 2 commits
-
-
Steve Hodgson authored
We never use MDIO in atomic context, so we don't need to spin. Signed-off-by:
Ben Hutchings <bhutchings@solarflare.com> Signed-off-by:
David S. Miller <davem@davemloft.net>
-
Steve Hodgson authored
Falcon can generate events for LASI interrupts from the PHY, but in practice we have never implemented this in reference designs. Instead we have polled, inserted the appropriate events, and then handled the events later. This is a waste of time and code. Instead, make PHY poll functions update the link state synchronously and report whether it changed. We can still make use of the LASI registers as a shortcut on the SFT9001. Signed-off-by:
-
- 26 Nov, 2009 11 commits
-
-
Ben Hutchings authored
From: Steve Hodgson <shodgson@solarflare.com> Currently we can set multicast hash immediately (in atomic context) but must delay setting MAC promiscuity. There is not that much point in deferring one but not the other, and setting the multicast hash on Siena will involve a firmware request. So process them both in efx_mac_work(). Also, set the broadcast bit in the multicast hash in efx_set_multicast_list(), since this is required for both Falcon and Siena. Signed-off-by:
-
Ben Hutchings authored
From: Steve Hodgson <shodgson@solarflare.com> Only the XMAC on Falcon needs help from the driver to poll and reset the MAC-PHY link (XAUI); GMII is a simple parallel bus and on later NICs firmware takes care of the XAUI link. Also, an XMAC interrupt currently schedules a work item which simply clears a flag (efx_nic::mac_up) to be checked by the regular monitor (or the next link reconfiguration, if that is sooner). Rename the flag to xmac_poll_required, changing its sense. Remove the needless indirection and just set the flag immediately. Call falcon_xmac_poll() directly where required. Add a new generic operation mac_op::check_fault to check the link outside of regular monitoring, as required during self-tests. (Note that this leaves us with an unused work item, but we will immediately have another use for it.) Signed-off-by:
-
Ben Hutchings authored
Signed-off-by:
-
Ben Hutchings authored
From: Steve Hodgson <shodgson@solarflare.com> Currently we initiate MAC stats DMA and busy-wait for completion when stats are requested. We can improve on this with a periodic timer to initiate and poll for stats, and opportunistically poll when stats are requested. Since efx_nic::stats_disable_count and efx_stats_{disable,enable}() are Falcon-specific, rename them and move them accordingly. Signed-off-by: -
Steve Hodgson authored
Signed-off-by:
-
Ben Hutchings authored
Avoid overrunning the hardware limit of 4 concurrent RX queue flushes. Expand the queue flush state to support this. Make similar changes to TX flushing to keep the code symmetric. Signed-off-by:
-
Ben Hutchings authored
Put all static information in struct falcon_board_type and replace it with a pointer in struct falcon_board. Simplify probing aocordingly. Signed-off-by:
-
Ben Hutchings authored
Signed-off-by:
-
Ben Hutchings authored
Signed-off-by:
-
Ben Hutchings authored
Although all the defined fields in these registers are within 32 bits, they are architecturally defined as 128-bit like most other Falcon registers. In particular, we must use efx_reado() to ensure proper locking when reading MD_STAT_REG. Signed-off-by:
-
Ben Hutchings authored
These were accidentally undersized by a factor of 2, which limited performance. Signed-off-by:
-
- 24 Nov, 2009 5 commits
-
-
Ben Hutchings authored
Define name tables for these enumerations in a similar way as for loopback. Move the loopback name table together with them. Signed-off-by:
-
Ben Hutchings authored
Signed-off-by:
-
Ben Hutchings authored
Signed-off-by:
-
Ben Hutchings authored
This is preparation for moving Falcon-specific state required by other Falcon-specific code. Signed-off-by:
-
Ben Hutchings authored
Rename struct efx_board to struct falcon_board. Introduce and use inline function to look up board info from struct efx_nic, in preparation for moving it. Move board init and fini calls into NIC probe and remove functions. Signed-off-by:
-
- 28 Oct, 2009 1 commit
-
-
Ben Hutchings authored
We have never checked the efx_nic::rx_checksum_enabled flag everywhere we should, and since the switch to GRO we don't check it anywhere. It's simplest to check it in the one place where we initialise the per-packet checksummed flag. Signed-off-by:
-
- 24 Oct, 2009 15 commits
-
-
Ben Hutchings authored
The 'XFP' driver is really a driver for the QT2022C2 and QT2025C PHYs, covering both more and less than XFP. Rename its functions and constants to reflect reality and to reduce namespace pollution when sfc is a built-in driver. Signed-off-by:
-
Ben Hutchings authored
MAC and PHY probing are bound up together, as evidenced by the initialisation of efx_nic::loopback_modes. Remove the current arbitrary separation. Signed-off-by:
-
Ben Hutchings authored
Signed-off-by:
-
Ben Hutchings authored
This simplifies the implementation a lot. Signed-off-by:
-
Ben Hutchings authored
These will also be used with Siena NICs. Signed-off-by:
-
Ben Hutchings authored
Replace the duplicated logic in efx_enqueue_skb() and efx_tx_queue_insert() with an inline function, efx_max_tx_len(). Remove the failed attempt at abstracting hardware-specifics and put all the magic numbers in efx_max_tx_len(). Signed-off-by:
-
Ben Hutchings authored
Signed-off-by:
-
Ben Hutchings authored
Move size and mask definitions into efx.h; calculate page orders in falcon.c. Signed-off-by:
-
Ben Hutchings authored
While we're at it, use type suffixes of 'd', 'q' and 'o', consistent with register type names. Signed-off-by:
-
Ben Hutchings authored
Siena is still based on the Falcon hardware architecture and will share many of these definitions, so replace falcon_hwdefs.h with regs.h. The new definitions have been generated according to a naming convention which incorporates the type and revision information. Update the code accordingly. Signed-off-by:
-
Ben Hutchings authored
Since there are now separate blocks of code to set the thresholds for each NIC type, it is no longer useful to include them in the NIC type description. Signed-off-by:
-
Ben Hutchings authored
These macros are not extensible to more than two NIC types without repetition of register definitions, and they are only used to deal with a few fields in RX_CFG_REG and global events which moved between Falcon rev A1 and B0. Therefore: - Move RX_CFG_REG initialisation into its own function which tests the NIC revision just once - Explicitly test the NIC revision when checking the RX_RECOVERY flag in global events - Merge definitions of RX_XOFF_MAC_EN flag, which did not move - Remove the macro definitions Signed-off-by:
-
Ben Hutchings authored
Signed-off-by:
-
Ben Hutchings authored
Siena will require entirely different board code. Signed-off-by:
-
Ben Hutchings authored
Signed-off-by:
-
- 29 Apr, 2009 1 commit
-
-
Ben Hutchings authored
Make use of the newly-added generic MDIO clause 45 support and remove redundant definitions. Add an 'efx_' prefix to the remaining driver-specific MDIO functions and remove arguments which are redundant with efx->mdio.prtad. Signed-off-by:
-
- 14 Apr, 2009 1 commit
-
-
Ben Hutchings authored
falcon_sim_phy_event() used EFX_OWORD_FIELD, which operates on bitfields in 128-bit values, on an event, which is a 64-bit value. This should be harmless - these macros always use little-endian ordering, so it would read and write back the following 8 bytes unchanged - but it is obviously wrong. Signed-off-by:
-
- 21 Mar, 2009 3 commits
-
-
Ben Hutchings authored
Calculate a score for each 1000 IRQs: - TX completions are worth 1 point - RX completions are worth 4 if merged using LRO or 2 otherwise Reduce moderation if the score is less than 10000, down to a minimum of 5 us. Increase moderation if the score is more than 20000, up to the specified maximum. Signed-off-by:
-
Ben Hutchings authored
Signed-off-by:
-
Ben Hutchings authored
In rare cases, reading the legacy interrupt status register can acknowledge an event queue whose attention flag has not yet been set in the register. Until we service this event queue it will not generate any more interrupts. Therefore, as a secondary check, poll the next slot in each active event queue whose flag is not set. Signed-off-by:
-
- 04 Mar, 2009 1 commit
-
-
Ben Hutchings authored
Make the error count a per-NIC variable. Reset this the count after an hour if it has not reached the critical value. Set the critical value back to 5. Signed-off-by:
-
