1. 27 Sep, 2011 1 commit
  2. 13 Sep, 2011 1 commit
  3. 20 Jul, 2011 1 commit
  4. 19 Jul, 2011 1 commit
  5. 27 Jun, 2011 1 commit
  6. 07 May, 2011 1 commit
  7. 26 Apr, 2011 1 commit
    • Rajkumar Manoharan's avatar
      mac80211: Fix warnings due to -Wunused-but-set-variable · 0915cba3
      Rajkumar Manoharan authored
      These warnings are exposed by gcc 4.6.
      net/mac80211/sta_info.c: In function 'sta_info_cleanup_expire_buffered':
      net/mac80211/sta_info.c:590:32: warning: variable 'sdata' set but not used
      net/mac80211/ibss.c: In function 'ieee80211_rx_mgmt_auth_ibss':
      net/mac80211/ibss.c:43:34: warning: variable 'status_code' set but not used
      net/mac80211/work.c: In function 'ieee80211_send_assoc':
      net/mac80211/work.c:203:9: warning: variable 'len' set but not used
      net/mac80211/tx.c: In function '__ieee80211_parse_tx_radiotap':
      net/mac80211/tx.c:1039:35: warning: variable 'sband' set but not used
      net/mac80211/mesh.c: In function 'ieee80211_mesh_rx_queued_mgmt':
      net/mac80211/mesh.c:616:28: warning: variable 'ifmsh' set but not used
       ...
      Signed-off-by: default avatarRajkumar Manoharan <rmanoharan@atheros.com>
      Signed-off-by: default avatarJohn W. Linville <linville@tuxdriver.com>
      0915cba3
  8. 07 Mar, 2011 1 commit
  9. 18 Feb, 2011 1 commit
  10. 09 Feb, 2011 1 commit
  11. 04 Feb, 2011 1 commit
    • Ben Greear's avatar
      mac80211: Optimize scans on current operating channel. · b23b025f
      Ben Greear authored
      This should decrease un-necessary flushes, on/off channel work,
      and channel changes in cases where the only scanned channel is
      the current operating channel.
      
      * Removes SCAN_OFF_CHANNEL flag, uses SDATA_STATE_OFFCHANNEL
        and is-scanning flags instead.
      
      * Add helper method to determine if we are currently configured
        for the operating channel.
      
      * Do no blindly go off/on channel in work.c  Instead, only call
        appropriate on/off code when we really need to change channels.
        Always enable offchannel-ps mode when starting work,
        and disable it when we are done.
      
      * Consolidate ieee80211_offchannel_stop_station and
        ieee80211_offchannel_stop_beaconing, call it
        ieee80211_offchannel_stop_vifs instead.
      
      * Accept non-beacon frames when scanning on operating channel.
      
      * Scan state machine optimized to minimize on/off channel
        transitions.  Also, when going on-channel, go ahead and
        re-enable beaconing.  We're going to be there for 200ms,
        so seems like some useful beaconing could happen.
        Always enable offchannel-ps mode when starting software
        scan, and disable it when we are done.
      
      * Grab local->mtx earlier in __ieee80211_scan_completed_finish
        so that we are protected when calling hw_config(), etc.
      
      * Pass probe-responses up the stack if scanning on local
        channel, so that mlme can take a look.
      Signed-off-by: default avatarBen Greear <greearb@candelatech.com>
      Signed-off-by: default avatarJohn W. Linville <linville@tuxdriver.com>
      b23b025f
  12. 13 Dec, 2010 1 commit
  13. 08 Dec, 2010 1 commit
  14. 29 Nov, 2010 1 commit
  15. 16 Aug, 2010 2 commits
  16. 29 Jul, 2010 1 commit
  17. 16 Jun, 2010 1 commit
  18. 02 Jun, 2010 1 commit
  19. 12 May, 2010 1 commit
    • Johannes Berg's avatar
      mac80211: don't process work item with wrong frame · b8d92c9c
      Johannes Berg authored
      When we process a frame, we currently just match it
      to the work struct by the MAC addresses, and not by
      the work type. This means that we can end up doing
      the work for an association request item when (for
      whatever reason) we receive another frame type, for
      example a probe response. Processing the wrong type
      of frame will lead to completely invalid data being
      processed, and will lead to various problems like
      thinking the association was successful even if the
      AP never sent an assocation response.
      
      Fix this by making each processing function check
      that it is invoked for the right work struct type
      only and continue processing otherwise (and drop
      frames that we didn't expect).
      
      This bug was uncovered during the debugging for
      https://bugzilla.kernel.org/show_bug.cgi?id=15862
      but doesn't seem to be the cause for any of the
      various problems reported there.
      Signed-off-by: default avatarJohannes Berg <johannes@sipsolutions.net>
      Signed-off-by: default avatarJohn W. Linville <linville@tuxdriver.com>
      b8d92c9c
  20. 28 Apr, 2010 1 commit
  21. 09 Apr, 2010 1 commit
  22. 30 Mar, 2010 1 commit
    • Tejun Heo's avatar
      include cleanup: Update gfp.h and slab.h includes to prepare for breaking... · 5a0e3ad6
      Tejun Heo authored
      include cleanup: Update gfp.h and slab.h includes to prepare for breaking implicit slab.h inclusion from percpu.h
      
      percpu.h is included by sched.h and module.h and thus ends up being
      included when building most .c files.  percpu.h includes slab.h which
      in turn includes gfp.h making everything defined by the two files
      universally available and complicating inclusion dependencies.
      
      percpu.h -> slab.h dependency is about to be removed.  Prepare for
      this change by updating users of gfp and slab facilities include those
      headers directly instead of assuming availability.  As this conversion
      needs to touch large number of source files, the following script is
      used as the basis of conversion.
      
        http://userweb.kernel.org/~tj/misc/slabh-sweep.py
      
      The script does the followings.
      
      * Scan files for gfp and slab usages and update includes such that
        only the necessary includes are there.  ie. if only gfp is used,
        gfp.h, if slab is used, slab.h.
      
      * When the script inserts a new include, it looks at the include
        blocks and try to put the new include such that its order conforms
        to its surrounding.  It's put in the include block which contains
        core kernel includes, in the same order that the rest are ordered -
        alphabetical, Christmas tree, rev-Xmas-tree or at the end if there
        doesn't seem to be any matching order.
      
      * If the script can't find a place to put a new include (mostly
        because the file doesn't have fitting include block), it prints out
        an error message indicating which .h file needs to be added to the
        file.
      
      The conversion was done in the following steps.
      
      1. The initial automatic conversion of all .c files updated slightly
         over 4000 files, deleting around 700 includes and adding ~480 gfp.h
         and ~3000 slab.h inclusions.  The script emitted errors for ~400
         files.
      
      2. Each error was manually checked.  Some didn't need the inclusion,
         some needed manual addition while adding it to implementation .h or
         embedding .c file was more appropriate for others.  This step added
         inclusions to around 150 files.
      
      3. The script was run again and the output was compared to the edits
         from #2 to make sure no file was left behind.
      
      4. Several build tests were done and a couple of problems were fixed.
         e.g. lib/decompress_*.c used malloc/free() wrappers around slab
         APIs requiring slab.h to be added manually.
      
      5. The script was run on all .h files but without automatically
         editing them as sprinkling gfp.h and slab.h inclusions around .h
         files could easily lead to inclusion dependency hell.  Most gfp.h
         inclusion directives were ignored as stuff from gfp.h was usually
         wildly available and often used in preprocessor macros.  Each
         slab.h inclusion directive was examined and added manually as
         necessary.
      
      6. percpu.h was updated not to include slab.h.
      
      7. Build test were done on the following configurations and failures
         were fixed.  CONFIG_GCOV_KERNEL was turned off for all tests (as my
         distributed build env didn't work with gcov compiles) and a few
         more options had to be turned off depending on archs to make things
         build (like ipr on powerpc/64 which failed due to missing writeq).
      
         * x86 and x86_64 UP and SMP allmodconfig and a custom test config.
         * powerpc and powerpc64 SMP allmodconfig
         * sparc and sparc64 SMP allmodconfig
         * ia64 SMP allmodconfig
         * s390 SMP allmodconfig
         * alpha SMP allmodconfig
         * um on x86_64 SMP allmodconfig
      
      8. percpu.h modifications were reverted so that it could be applied as
         a separate patch and serve as bisection point.
      
      Given the fact that I had only a couple of failures from tests on step
      6, I'm fairly confident about the coverage of this conversion patch.
      If there is a breakage, it's likely to be something in one of the arch
      headers which should be easily discoverable easily on most builds of
      the specific arch.
      Signed-off-by: default avatarTejun Heo <tj@kernel.org>
      Guess-its-ok-by: default avatarChristoph Lameter <cl@linux-foundation.org>
      Cc: Ingo Molnar <mingo@redhat.com>
      Cc: Lee Schermerhorn <Lee.Schermerhorn@hp.com>
      5a0e3ad6
  23. 26 Feb, 2010 1 commit
    • Juuso Oikarinen's avatar
      mac80211: fix direct probe loop on ieee80211_work_purge · 0e0a2283
      Juuso Oikarinen authored
      If authentication has already been performed when the WLAN interface is
      stopped, (sometimes) the ieee80211_work_purge would corrupt some
      ieee80211_work-structures. The outcome is this (cleaned up):
      
      [ 2252.398681] WARNING: at net/mac80211/work.c:995 ieee80211_work_purge
      [ 2252.466430] Backtrace:
      [ 2252.529266] (ieee80211_work_purge+0x0/0xcc [mac80211])
      [ 2252.546875] (ieee80211_stop+0x0/0x4c0 [mac80211])
      
      Additionally, one would get this, going on regarless of the WLAN interface
      state, going on forever:
      
      [ 2252.859985] wlan0: direct probe to 00:90:4c:60:04:00 (try -996717525)
      [ 2253.055419] wlan0: direct probe to 00:90:4c:60:04:00 (try -996717524)
      [ 2253.250610] wlan0: direct probe to 00:90:4c:60:04:00 (try -996717523)
      [ 2253.446014] wlan0: direct probe to 00:90:4c:60:04:00 (try -996717522)
      [ 2253.641357] wlan0: direct probe to 00:90:4c:60:04:00 (try -996717521)
      Signed-off-by: default avatarJuuso Oikarinen <juuso.oikarinen@nokia.com>
      Reviewed-by: default avatarJohannes Berg <johannes@sipsolutions.net>
      Signed-off-by: default avatarJohn W. Linville <linville@tuxdriver.com>
      0e0a2283
  24. 25 Jan, 2010 2 commits
  25. 12 Jan, 2010 3 commits
  26. 05 Jan, 2010 1 commit
    • Kalle Valo's avatar
      mac80211: fix a warning related to pointer conversion to u64 cookie · 1990ca61
      Kalle Valo authored
      On a 32 bit system (in this case an omap 3430 system) gcc warned about
      pointer conversion:
      
      net/mac80211/work.c: In function 'ieee80211_remain_on_channel_timeout':
      net/mac80211/work.c:534: warning: cast from pointer to integer of different size
      net/mac80211/work.c: In function 'ieee80211_remain_done':
      net/mac80211/work.c:1030: warning: cast from pointer to integer of different size
      net/mac80211/work.c: In function 'ieee80211_wk_remain_on_channel':
      net/mac80211/work.c:1056: warning: cast from pointer to integer of different size
      net/mac80211/work.c: In function 'ieee80211_wk_cancel_remain_on_channel':
      net/mac80211/work.c:1072: warning: cast from pointer to integer of different size
      
      Fix it by casting the pointers to unsigned long instead. This makes the
      compiler happy again.
      
      Compile-tested only.
      
      Cc: Johannes Berg <johannes@sipsolutions.net>
      Signed-off-by: default avatarKalle Valo <kalle.valo@nokia.com>
      Signed-off-by: default avatarJohn W. Linville <linville@tuxdriver.com>
      1990ca61
  27. 28 Dec, 2009 8 commits