1. 15 Jan, 2011 1 commit
    • Sven Eckelmann's avatar
      batman-adv: Use "__attribute__" shortcut macros · aa0adb1a
      Sven Eckelmann authored
      
      
      Linux 2.6.21 defines different macros for __attribute__ which are also
      used inside batman-adv. The next version of checkpatch.pl warns about
      the usage of __attribute__((packed))).
      
      Linux 2.6.33 defines an extra macro __always_unused which is used to
      assist source code analyzers and can be used to removed the last
      existing __attribute__ inside the source code.
      Signed-off-by: default avatarSven Eckelmann <sven@narfation.org>
      aa0adb1a
  2. 13 Jan, 2011 1 commit
    • Jesper Juhl's avatar
      batman-adv: Even Batman should not dereference NULL pointers · ed7809d9
      Jesper Juhl authored
      
      
      There's a problem in net/batman-adv/unicast.c::frag_send_skb().
      dev_alloc_skb() allocates memory and may fail, thus returning NULL. If
      this happens we'll pass a NULL pointer on to skb_split() which in turn
      hands it to skb_split_inside_header() from where it gets passed to
      skb_put() that lets skb_tail_pointer() play with it and that function
      dereferences it. And thus the bat dies.
      
      While I was at it I also moved the call to dev_alloc_skb() above the
      assignment to 'unicast_packet' since there's no reason to do that
      assignment if the memory allocation fails.
      Signed-off-by: default avatarJesper Juhl <jj@chaosbits.net>
      Signed-off-by: default avatarSven Eckelmann <sven@narfation.org>
      ed7809d9
  3. 20 Dec, 2010 2 commits
  4. 19 Dec, 2010 4 commits
  5. 18 Dec, 2010 2 commits
  6. 17 Dec, 2010 7 commits
  7. 16 Dec, 2010 23 commits