1. 25 Jun, 2012 2 commits
  2. 21 Apr, 2012 1 commit
    • Arnd Bergmann's avatar
      caif: include linux/io.h · 6e4a7629
      Arnd Bergmann authored
      
      
      The caif_shmcore requires io.h in order to use ioremap, so include that
      explicitly to compile in all configurations.
      
      Also add a note about the use of ioremap(), which is not a proper way
      to map a DMA buffer into kernel space. It's not completely clear what
      the intention is for using ioremap, but it is clear that the result
      of ioremap must not simply be accessed using kernel pointers but
      should use readl/writel or memcopy_{to,from}io. Assigning the result
      of ioremap to a regular pointer that can also be set to something
      else is not ok.
      Signed-off-by: default avatarArnd Bergmann <arnd@arndb.de>
      Signed-off-by: default avatarMathieu Poirier <mathieu.poirier@linaro.org>
      Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
      6e4a7629
  3. 13 Apr, 2012 5 commits
  4. 05 Apr, 2012 1 commit
    • Stephen Boyd's avatar
      simple_open: automatically convert to simple_open() · 234e3405
      Stephen Boyd authored
      
      
      Many users of debugfs copy the implementation of default_open() when
      they want to support a custom read/write function op.  This leads to a
      proliferation of the default_open() implementation across the entire
      tree.
      
      Now that the common implementation has been consolidated into libfs we
      can replace all the users of this function with simple_open().
      
      This replacement was done with the following semantic patch:
      
      <smpl>
      @ open @
      identifier open_f != simple_open;
      identifier i, f;
      @@
      -int open_f(struct inode *i, struct file *f)
      -{
      (
      -if (i->i_private)
      -f->private_data = i->i_private;
      |
      -f->private_data = i->i_private;
      )
      -return 0;
      -}
      
      @ has_open depends on open @
      identifier fops;
      identifier open.open_f;
      @@
      struct file_operations fops = {
      ...
      -.open = open_f,
      +.open = simple_open,
      ...
      };
      </smpl>
      
      [akpm@linux-foundation.org: checkpatch fixes]
      Signed-off-by: default avatarStephen Boyd <sboyd@codeaurora.org>
      Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
      Cc: Al Viro <viro@zeniv.linux.org.uk>
      Cc: Julia Lawall <Julia.Lawall@lip6.fr>
      Acked-by: default avatarIngo Molnar <mingo@elte.hu>
      Signed-off-by: default avatarAndrew Morton <akpm@linux-foundation.org>
      Signed-off-by: default avatarLinus Torvalds <torvalds@linux-foundation.org>
      234e3405
  5. 06 Mar, 2012 1 commit
  6. 04 Feb, 2012 1 commit
  7. 19 Dec, 2011 1 commit
  8. 06 Dec, 2011 4 commits
  9. 19 Oct, 2011 8 commits
  10. 28 Aug, 2011 1 commit
    • Joe Perches's avatar
      caif: Remove OOM messages, use kzalloc · 7ac2ed0c
      Joe Perches authored
      
      
      Remove per site OOM messages because they duplicate
      the generic mm subsystem OOM message.
      
      Use kzalloc instead of kmalloc/memset
      when next to the OOM message removals.
      
      Reduces object size (allyesconfig ~2%)
      
      $ size -t drivers/net/caif/built-in.o.old net/caif/built-in.o.old
         text	   data	    bss	    dec	    hex	filename
        32297	    700	   8224	  41221	   a105	drivers/net/caif/built-in.o.old
        72159	   1317	  20552	  94028	  16f4c	net/caif/built-in.o.old
       104456	   2017	  28776	 135249	  21051	(TOTALS)
      $ size -t drivers/net/caif/built-in.o.new net/caif/built-in.o.new
         text	   data	    bss	    dec	    hex	filename
        31975	    700	   8184	  40859	   9f9b	drivers/net/caif/built-in.o.new
        70748	   1317	  20152	  92217	  16839	net/caif/built-in.o.new
       102723	   2017	  28336	 133076	  207d4	(TOTALS)
      Signed-off-by: default avatarJoe Perches <joe@perches.com>
      Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
      7ac2ed0c
  11. 07 Jul, 2011 1 commit
  12. 29 Jun, 2011 1 commit
  13. 24 Jun, 2011 1 commit
  14. 21 Jun, 2011 1 commit
  15. 06 Jun, 2011 1 commit
  16. 03 Jun, 2011 1 commit
    • Linus Torvalds's avatar
      Revert "tty: make receive_buf() return the amout of bytes received" · 55db4c64
      Linus Torvalds authored
      This reverts commit b1c43f82.
      
      It was broken in so many ways, and results in random odd pty issues.
      
      It re-introduced the buggy schedule_work() in flush_to_ldisc() that can
      cause endless work-loops (see commit a5660b41: "tty: fix endless
      work loop when the buffer fills up").
      
      It also used an "unsigned int" return value fo the ->receive_buf()
      function, but then made multiple functions return a negative error code,
      and didn't actually check for the error in the caller.
      
      And it didn't actually work at all.  BenH bisected down odd tty behavior
      to it:
        "It looks like the patch is causing some major malfunctions of the X
         server for me, possibly related to PTYs.  For example, cat'ing a
         large file in a gnome terminal hangs the kernel for -minutes- in a
         loop of what looks like flush_to_ldisc/workqueue code, (some ftrace
         data in the quoted bits further down).
      
         ...
      
         Some more data: It -looks- like what happens is that the
         flush_to_ldisc work queue entry constantly re-queues itself (because
         the PTY is full ?) and the workqueue thread will basically loop
         forver calling it without ever scheduling, thus starving the consumer
         process that could have emptied the PTY."
      
      which is pretty much exactly the problem we fixed in a5660b41
      
      .
      
      Milton Miller pointed out the 'unsigned int' issue.
      Reported-by: default avatarBenjamin Herrenschmidt <benh@kernel.crashing.org>
      Reported-by: default avatarMilton Miller <miltonm@bga.com>
      Cc: Stefan Bigler <stefan.bigler@keymile.com>
      Cc: Toby Gray <toby.gray@realvnc.com>
      Cc: Felipe Balbi <balbi@ti.com>
      Cc: Greg Kroah-Hartman <gregkh@suse.de>
      Cc: Alan Cox <alan@lxorguk.ukuu.org.uk>
      Signed-off-by: default avatarLinus Torvalds <torvalds@linux-foundation.org>
      55db4c64
  17. 01 Jun, 2011 1 commit
  18. 22 Apr, 2011 1 commit
  19. 31 Mar, 2011 1 commit
  20. 17 Mar, 2011 1 commit
  21. 22 Dec, 2010 1 commit
  22. 08 Dec, 2010 1 commit
  23. 18 Nov, 2010 1 commit
  24. 03 Nov, 2010 1 commit
  25. 27 Oct, 2010 1 commit