1. 04 Apr, 2011 3 commits
    • Linus Torvalds's avatar
      tty: fix endless work loop when the buffer fills up · a5660b41
      Linus Torvalds authored
      Commit f23eb2b2 ('tty: stop using "delayed_work" in the tty layer')
      ended up causing hung machines on UP with no preemption, because the
      work routine to flip the buffer data to the ldisc would endlessly re-arm
      itself if the destination buffer had filled up.
      
      With the delayed work, that only caused a timer-driving polling of the
      tty state every timer tick, but without the delay we just ended up with
      basically a busy loop instead.
      
      Stop the insane polling, and instead make the code that opens up the
      receive room re-schedule the buffer flip work.  That's what we should
      have been doing anyway.
      
      This same "poll for tty room" issue is almost certainly also the cause
      of excessive kworker activity when idle reported by Dave Jones, who also
      reported "flush_to_ldisc executing 2500 times a second" back in Nov 2010:
      
        http://lkml.org/lkml/2010/11/30/592
      
      which is that silly flushing done every timer tick.  Wasting both power
      and CPU for no good reason.
      Reported-and-tested-by: default avatarAlexander Beregalov <a.beregalov@gmail.com>
      Reported-and-tested-by: default avatarSitsofe Wheeler <sitsofe@yahoo.com>
      Cc: Greg KH <gregkh@suse.de>
      Cc: Alan Cox <alan@lxorguk.ukuu.org.uk>
      Cc: Dave Jones <davej@redhat.com>
      Signed-off-by: default avatarLinus Torvalds <torvalds@linux-foundation.org>
      a5660b41
    • Randy Dunlap's avatar
      usb/serial: fix function args warnings, dropping *filp · 4acfaf82
      Randy Dunlap authored
      Fix build warnings caused by removal of *filp arg in struct
      usb_serial_driver.
      
      These changes were missed somehow in commits 00a0d0d6 ("tty: remove
      filp from the USB tty ioctls") and 60b33c13 ("tiocmget: kill off
      the passing of the struct file")
      
        drivers/usb/serial/mct_u232.c:159: warning: initialization from incompatible pointer type
        drivers/usb/serial/opticon.c:627: warning: initialization from incompatible pointer type
      Signed-off-by: default avatarRandy Dunlap <randy.dunlap@oracle.com>
      Cc: Alan Cox <alan@linux.intel.com>
      Signed-off-by: default avatarLinus Torvalds <torvalds@linux-foundation.org>
      4acfaf82
    • Major Lee's avatar
      rtc-mrst: Fix section types · b3b896c7
      Major Lee authored
      Fix the following section mismatch warning.
      
        WARNING: drivers/rtc/built-in.o(.data+0xa0): Section mismatch in reference from the variable vrtc_mrst_platform_driver to the function .init.text:vrtc_mrst_platform_probe()
        The variable vrtc_mrst_platform_driver references the function __init vrtc_mrst_platform_probe()
        If the reference is valid then annotate the variable with __init* or __refdata (see linux/init.h) or name the variable:
          *_template, *_timer, *_sht, *_ops, *_probe, *_probe_one, *_console,
      Signed-off-by: default avatarMajor Lee <major_lee@wistron.com>
      Signed-off-by: default avatarAlan Cox <alan@linux.intel.com>
      Signed-off-by: default avatarLinus Torvalds <torvalds@linux-foundation.org>
      b3b896c7
  2. 02 Apr, 2011 1 commit
  3. 31 Mar, 2011 6 commits
  4. 30 Mar, 2011 12 commits
  5. 29 Mar, 2011 18 commits