1. 20 Apr, 2009 7 commits
  2. 19 Apr, 2009 1 commit
  3. 17 Apr, 2009 4 commits
    • Andrew Gallatin's avatar
      myri10ge: fix compile error · 7fe624f5
      Andrew Gallatin authored
      A compilation error snuck into
      2d90b0aa
      
      
      due to an over-zealous indent script removing spaces around array
      initialization ellipsis.  The attached patch fixes the myri10ge
      compilation in net-next.
      Signed-off-by: default avatarAndrew Gallatin <gallatin@myri.com>
      Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
      7fe624f5
    • Eric Dumazet's avatar
      [PATCH] net: remove superfluous call to synchronize_net() · 573636cb
      Eric Dumazet authored
      
      
      inet_register_protosw() function is responsible for adding a new
      inet protocol into a global table (inetsw[]) that is used with RCU rules.
      
      As soon as the store of the pointer is done, other cpus might see
      this new protocol in inetsw[], so we have to make sure new protocol
      is ready for use. All pending memory updates should thus be committed
      to memory before setting the pointer.
      This is correctly done using rcu_assign_pointer()
      
      synchronize_net() is typically used at unregister time, after
      unsetting the pointer, to make sure no other cpu is still using
      the object we want to dismantle. Using it at register time
      is only adding an artificial delay that could hide a real bug,
      and this bug could popup if/when synchronize_rcu() can proceed
      faster than now.
      
      This saves about 13 ms on boot time on a HZ=1000 8 cpus machine  ;) 
      (4 calls to inet_register_protosw(), and about 3200 us per call)
      Signed-off-by: default avatarEric Dumazet <dada1@cosmosbay.com>
      Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
      573636cb
    • Alexander Beregalov's avatar
      wan/pc300_drv: convert to net_device_ops · d32da050
      Alexander Beregalov authored
      
      
      On Fri, Apr 17, 2009 at 05:23:02AM +0400, Alexander Beregalov wrote:
      >
      > Signed-off-by: Alexander Beregalov <a.beregalov@gmail.com>
      > ---
      >  drivers/net/wan/pc300_drv.c |   22 ++++++++++++++--------
      >  1 files changed, 14 insertions(+), 8 deletions(-)
      >
      > diff --git a/drivers/net/wan/pc300_drv.c b/drivers/net/wan/pc300_drv.c
      > index c23fde0..df10a4c 100644
      > --- a/drivers/net/wan/pc300_drv.c
      > +++ b/drivers/net/wan/pc300_drv.c
      > @@ -225,6 +225,7 @@ static char rcsid[] =
      >  #include <linux/skbuff.h>
      >  #include <linux/if_arp.h>
      >  #include <linux/netdevice.h>
      > +#include <linux/etherdevice.h>
      >  #include <linux/spinlock.h>
      >  #include <linux/if.h>
      >  #include <net/arp.h>
      > @@ -3246,6 +3247,18 @@ static inline void show_version(void)
      >  		rcsvers, rcsdate, __DATE__, __TIME__);
      >  }				/* show_version */
      >
      > +static const struct net_device_ops cpc_netdev_ops = {
      > +	.ndo_init		= NULL,
      > +	.ndo_open		= cpc_open,
      > +	.ndo_stop		= cpc_close,
      > +	.ndo_tx_timeout		= cpc_tx_timeout,
      > +	.ndo_set_multicast_list	= NULL,
      
      In this case ndo_init and ndo_set_multicast_list
      are not needed.
      
      >From 1507a5a797a5f0005696a9bf10e390caca9c3800 Mon Sep 17 00:00:00 2001
      From: Alexander Beregalov <a.beregalov@gmail.com>
      Date: Fri, 17 Apr 2009 05:45:48 +0400
      Subject: [PATCH] wan/pc300_drv: convert to net_device_ops
      Signed-off-by: default avatarAlexander Beregalov <a.beregalov@gmail.com>
      Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
      d32da050
    • Alexander Beregalov's avatar
  4. 16 Apr, 2009 28 commits