1. 21 Sep, 2011 9 commits
    • Ohad Ben-Cohen's avatar
      hwspinlock/omap: omap_hwspinlock_remove should be __devexit · 9efb4a1b
      Ohad Ben-Cohen authored
      Mark omap_hwspinlock_remove with __devexit (and use __devexit_p
      appropriately) so the function can be discarded when the conditions are met.
      Signed-off-by: default avatarOhad Ben-Cohen <ohad@wizery.com>
    • Mathieu J. Poirier's avatar
      hwspinlock/u8500: add hwspinlock driver · f84a8ecf
      Mathieu J. Poirier authored
      Add hwspinlock driver for U8500's Hsem hardware.
      At this point only HSem's protocol 1 is used (i.e. no interrupts).
      Signed-off-by: default avatarMathieu Poirier <mathieu.poirier@linaro.org>
      Acked-by: default avatarLinus Walleij <linus.walleij@linaro.org>
      [ohad@wizery.com: adopt recent hwspin_lock_{un}register API changes]
      [ohad@wizery.com: set the owner member of the driver]
      [ohad@wizery.com: mark ->remove() function as __devexit]
      [ohad@wizery.com: write commit log]
      [ohad@wizery.com: small cleanups]
      Signed-off-by: default avatarOhad Ben-Cohen <ohad@wizery.com>
    • Ohad Ben-Cohen's avatar
      hwspinlock/core: register a bank of hwspinlocks in a single API call · 300bab97
      Ohad Ben-Cohen authored
      Hardware Spinlock devices usually contain numerous locks (known
      devices today support between 32 to 256 locks).
      Originally hwspinlock core required drivers to register (and later,
      when needed, unregister) each lock separately.
      That worked, but required hwspinlocks drivers to do a bit extra work
      when they were probed/removed.
      This patch changes hwspin_lock_{un}register() to allow a bank of
      hwspinlocks to be {un}registered in a single invocation.
      A new 'struct hwspinlock_device', which contains an array of 'struct
      hwspinlock's is now being passed to the core upon registration (so
      instead of wrapping each struct hwspinlock, a priv member has been added
      to allow drivers to piggyback their private data with each hwspinlock).
      While at it, several per-lock members were moved to be per-device:
      1. struct device *dev
      2. struct hwspinlock_ops *ops
      In addition, now that the array of locks is handled by the core,
      there's no reason to maintain a per-lock 'int id' member: the id of the
      lock anyway equals to its index in the bank's array plus the bank's
      Remove this per-lock id member too, and instead use a simple pointers
      arithmetic to derive it.
      As a result of this change, hwspinlocks drivers are now simpler and smaller
      (about %20 code reduction) and the memory footprint of the hwspinlock
      framework is reduced.
      Signed-off-by: default avatarOhad Ben-Cohen <ohad@wizery.com>
    • Ohad Ben-Cohen's avatar
      hwspinlock/core: remove stubs for register/unregister · c536abfd
      Ohad Ben-Cohen authored
      hwspinlock drivers must anyway select CONFIG_HWSPINLOCK,
      so there's no point in having register/unregister stubs.
      Removing those stubs will only make it easier for developers
      to catch CONFIG_HWSPINLOCK mis-.config-urations.
      Signed-off-by: default avatarOhad Ben-Cohen <ohad@wizery.com>
    • Juan Gutierrez's avatar
      hwspinlock/core: use a mutex to protect the radix tree · 93b465c2
      Juan Gutierrez authored
      Since we're using non-atomic radix tree allocations, we
      should be protecting the tree using a mutex and not a
      Non-atomic allocations and process context locking is good enough,
      as the tree is manipulated only when locks are registered/
      The locks themselves are still protected by spinlocks of course,
      and mutexes are not involved in the locking/unlocking paths.
      Cc: <stable@kernel.org>
      Signed-off-by: default avatarJuan Gutierrez <jgutierrez@ti.com>
      [ohad@wizery.com: rewrite the commit log, #include mutex.h, add minor
      [ohad@wizery.com: update register/unregister parts in hwspinlock.txt]
      Signed-off-by: default avatarOhad Ben-Cohen <ohad@wizery.com>
    • Ohad Ben-Cohen's avatar
      hwspinlock/core/omap: fix id issues on multiple hwspinlock devices · c3c1250e
      Ohad Ben-Cohen authored
      hwspinlock devices provide system-wide hardware locks that are used
      by remote processors that have no other way to achieve synchronization.
      To achieve that, each physical lock must have a system-wide id number
      that is agreed upon, otherwise remote processors can't possibly assume
      they're using the same hardware lock.
      Usually boards have a single hwspinlock device, which provides several
      hwspinlocks, and in this case, they can be trivially numbered 0 to
      (num-of-locks - 1).
      In case boards have several hwspinlocks devices, a different base id
      should be used for each hwspinlock device (they can't all use 0 as
      a starting id!).
      While this is certainly not common, it's just plain wrong to just
      silently use 0 as a base id whenever the hwspinlock driver is probed.
      This patch provides a hwspinlock_pdata structure, that boards can use
      to set a different base id for each of the hwspinlock devices they may
      have, and demonstrates how to use it with the omap hwspinlock driver.
      While we're at it, make sure the hwspinlock core prints an explicit
      error message in case an hwspinlock is registered with an id number
      that already exists; this will help users catch such base id issues.
      Reported-by: default avatarArnd Bergmann <arnd@arndb.de>
      Signed-off-by: default avatarOhad Ben-Cohen <ohad@wizery.com>
      Acked-by: default avatarTony Lindgren <tony@atomide.com>
    • Ohad Ben-Cohen's avatar
      hwspinlock/omap: simplify allocation scheme · c97f6dd0
      Ohad Ben-Cohen authored
      Instead of allocating every hwspinlock separately, allocate
      them all in one shot.
      This both simplifies the driver and helps achieving better
      slab utilization.
      Reported-by: default avatarArnd Bergmann <arnd@arndb.de>
      Signed-off-by: default avatarOhad Ben-Cohen <ohad@wizery.com>
    • Ohad Ben-Cohen's avatar
      hwspinlock/core: simplify 'owner' handling · e467b642
      Ohad Ben-Cohen authored
      Use struct device_driver's owner member instead of asking drivers to
      explicitly pass the owner again.
      This simplifies drivers and also save some memory, since there's no
      point now in maintaining a separate owner pointer per hwspinlock.
      Signed-off-by: default avatarOhad Ben-Cohen <ohad@wizery.com>
    • Ohad Ben-Cohen's avatar
      hwspinlock/core: simplify Kconfig · 315d8f5c
      Ohad Ben-Cohen authored
      Simplify hwspinlock's Kconfig by making the global CONFIG_HWSPINLOCK
      entry invisible; users will just select it when needed.
      This also prepares the ground for adding hwspinlock support for other
      platforms (the 'depends on ARCH_OMAP4' was rather hideous, and while
      we're at it, a dedicated menu is added).
      Signed-off-by: default avatarOhad Ben-Cohen <ohad@wizery.com>
  2. 12 Sep, 2011 9 commits
  3. 11 Sep, 2011 22 commits