1. 21 Sep, 2010 20 commits
  2. 17 Sep, 2010 10 commits
  3. 16 Sep, 2010 10 commits
    • Luis R. Rodriguez's avatar
      ath9k: fix regression which disabled ps on ath9k · 008443de
      Luis R. Rodriguez authored
      The patch titled "ath9k: Add new file init.c" shuffled some code
      around but in dong so for some reason also removed the revision
      check for disablign power save. Add this revision check again
      so we can get power save re-enabled again by default on cards
      newer than AR5416 and AR5418.
      
      $ git describe --contains 55624204
      
      
      v2.6.34-rc1~233^2~49^2~343
      
      This patch has fixes for stable kernels [2.6.34+].
      
      Cc: stable@kernel.org
      Cc: Paul Stewart <pstew@google.com>
      Cc: Amod Bodas <amod.bodas@atheros.com>
      Signed-off-by: default avatarLuis R. Rodriguez <lrodriguez@atheros.com>
      Signed-off-by: default avatarJohn W. Linville <linville@tuxdriver.com>
      008443de
    • Senthil Balasubramanian's avatar
      ath9k: fix regression which prevents chip sleep after CAB data · 3fac6dfd
      Senthil Balasubramanian authored
      The patch:
      
      commit 293dc5df
      
      
      Author: Gabor Juhos <juhosg@openwrt.org>
      Date:   Fri Jun 19 12:17:48 2009 +0200
      
          ath9k: remove ath_rx_ps_back_to_sleep helper
      
          This helper only clears the SC_OP_WAIT_FOR_{BEACON,CAB} flags.
          Remove it and clear these flags directly in the approptiate
          places instead.
      
          Changes-licensed-under: ISC
      Signed-off-by: default avatarGabor Juhos <juhosg@openwrt.org>
      Signed-off-by: default avatarJohn W. Linville <linville@tuxdriver.com>
      
      introduced a regression which forgot to lift the beacon flag
      after we received all broadcast and multicast data. This meant
      we never went to sleep consuming about ~650mW on idle. This pretty
      much broke power save completely.
      
      This patch has fixes for stable kernels [2.6.32+].
      
      Cc: stable@kernel.org
      Cc: Paul Stewart <pstew@google.com>
      Cc: Sameer Nanda <snanda@google.com>
      Cc: Gabor Juhos <juhosg@openwrt.org>
      Cc: Amod Bodas <amod.bodas@atheros.com>
      Signed-off-by: default avatarSenthil Balasubramanian <senthilkumar@atheros.com>
      Signed-off-by: default avatarLuis R. Rodriguez <lrodriguez@atheros.com>
      Signed-off-by: default avatarJohn W. Linville <linville@tuxdriver.com>
      3fac6dfd
    • Luis R. Rodriguez's avatar
      mac80211: send last 3/5 probe requests as unicast · f01a067d
      Luis R. Rodriguez authored
      Some buggy APs do not respond to unicast probe requests
      or send unicast probe requests very delayed so in the
      worst case we should try to send broadcast probe requests,
      otherwise we can get disconnected from these APs.
      
      Even if drivers do not have filters to disregard probe
      responses from foreign APs mac80211 will only process
      probe responses from our associated AP for re-arming
      connection monitoring.
      
      We need to do this since the beacon monitor does not
      push back the connection monitor by design so even if we
      are getting beacons from these type of APs our connection
      monitor currently relies heavily on the way the probe
      requests are received on the AP. An example of an AP
      affected by this is the Nexus One, but this has also been
      observed with random APs.
      
      We can probably optimize this later by using null funcs
      instead of probe requests.
      
      For more details refer to:
      
      http://code.google.com/p/chromium-os/issues/detail?id=5715
      
      
      
      This patch has fixes for stable kernels [2.6.35+].
      
      Cc: stable@kernel.org
      Cc: Paul Stewart <pstew@google.com>
      Cc: Amod Bodas <amod.bodas@atheros.com>
      Signed-off-by: default avatarLuis R. Rodriguez <lrodriguez@atheros.com>
      Signed-off-by: default avatarJohn W. Linville <linville@tuxdriver.com>
      f01a067d
    • Luis R. Rodriguez's avatar
      mac80211: disable beacon monitor while going offchannel · 3bc3c0d7
      Luis R. Rodriguez authored
      
      
      The beacon monitor should be disabled when going off channel
      to prevent spurious warnings and triggering connection
      deterioration work such as sending probe requests. Re-enable
      the beacon monitor once we come back to the home channel.
      
      This patch has fixes for stable kernels [2.6.34+].
      
      Cc: stable@kernel.org
      Cc: Paul Stewart <pstew@google.com>
      Cc: Amod Bodas <amod.bodas@atheros.com>
      Signed-off-by: default avatarLuis R. Rodriguez <lrodriguez@atheros.com>
      Signed-off-by: default avatarJohn W. Linville <linville@tuxdriver.com>
      3bc3c0d7
    • Luis R. Rodriguez's avatar
      mac80211: make the beacon monitor available externally · d3a910a8
      Luis R. Rodriguez authored
      
      
      This will be used by other components next. The beacon
      monitor was added as of 2.6.34 so these fixes are applicable
      only to kernels >= 2.6.34.
      
      Cc: stable@kernel.org
      Cc: Paul Stewart <pstew@google.com>
      Cc: Amod Bodas <amod.bodas@atheros.com>
      Signed-off-by: default avatarLuis R. Rodriguez <lrodriguez@atheros.com>
      Signed-off-by: default avatarJohn W. Linville <linville@tuxdriver.com>
      d3a910a8
    • Luis R. Rodriguez's avatar
      mac80211: reset connection idle when going offchannel · 4730d597
      Luis R. Rodriguez authored
      
      
      When we go offchannel mac80211 currently leaves alive the
      connection idle monitor. This should be instead postponed
      until we come back to our home channel, otherwise by the
      time we get back to the home channel we could be triggering
      unecesary probe requests. For APs that do not respond to
      unicast probe requests (Nexus One is a simple example) this
      means we essentially get disconnected after the probes
      fails.
      
      This patch has stable fixes for kernels [2.6.35+]
      
      Cc: stable@kernel.org
      Cc: Paul Stewart <pstew@google.com>
      Cc: Amod Bodas <amod.bodas@atheros.com>
      Signed-off-by: default avatarLuis R. Rodriguez <lrodriguez@atheros.com>
      Signed-off-by: default avatarJohn W. Linville <linville@tuxdriver.com>
      4730d597
    • Luis R. Rodriguez's avatar
      mac80211: reset probe send counter upon connection timer reset · 0c699c3a
      Luis R. Rodriguez authored
      
      
      Upon beacon loss we send probe requests after 30 seconds of idle
      time and we wait for each probe response 1/2 second. We send a
      total of 3 probe requests before giving up on the AP. In the case
      that we reset the connection idle monitor we should reset the probe
      requests count to 0. Right now this won't help in any way but
      the next patch will.
      
      This patch has fixes for stable kernel [2.6.35+].
      
      Cc: stable@kernel.org
      Cc: Paul Stewart <pstew@google.com>
      Cc: Amod Bodas <amod.bodas@atheros.com>
      Signed-off-by: default avatarLuis R. Rodriguez <lrodriguez@atheros.com>
      Signed-off-by: default avatarJohn W. Linville <linville@tuxdriver.com>
      0c699c3a
    • Luis R. Rodriguez's avatar
      mac80211: add helper for reseting the connection monitor · be099e82
      Luis R. Rodriguez authored
      
      
      This will be used in another place later. The connection
      monitor was added as of 2.6.35 so these fixes will be
      applicable to >= 2.6.35.
      
      Cc: stable@kernel.org
      Cc: Paul Stewart <pstew@google.com>
      Cc: Amod Bodas <amod.bodas@atheros.com>
      Signed-off-by: default avatarLuis R. Rodriguez <lrodriguez@atheros.com>
      Signed-off-by: default avatarJohn W. Linville <linville@tuxdriver.com>
      be099e82
    • Luis R. Rodriguez's avatar
      ath9k: fix enabling ANI / tx monitor after bg scan · 48a6a468
      Luis R. Rodriguez authored
      
      
      ath9k's entire logic with SC_OP_SCANNING is incorrect due to the
      way mac80211 currently implements the scan complete callback and
      we handle it in ath9k. This patch removes the flag completely in
      preference for the SC_OP_OFFCHANNEL which is really what we wanted.
      
      The scanning flag was used to ensure we reset ANI to the old values
      when we go back to the home channel, but if we are offchannel we
      use some defaults. The flag was also used to re-enable the TX monitor.
      
      Without this patch we simply never re-enabled ANI and the TX monitor
      after going offchannel. This means that after one background
      scan we are prone to noise issues and if we had a TX hang we would
      not recover. To get this to work properly we must enable ANI after
      we have configured the beacon timers, otherwise hardware acts really
      oddly.
      
      This patch has stable fixes which apply down to [2.6.36+], there
      *may* be a to fix this on older kernels but requires a bit of
      work since this patch relies on the new mac80211 flag
      IEEE80211_CONF_OFFCHANNEL which was introduced as of 2.6.36.
      
      Cc: stable@kernel.org
      Cc: Paul Stewart <pstew@google.com>
      Cc: Amod Bodas <amod.bodas@atheros.com>
      Signed-off-by: default avatarLuis R. Rodriguez <lrodriguez@atheros.com>
      Signed-off-by: default avatarJohn W. Linville <linville@tuxdriver.com>
      48a6a468
    • Luis R. Rodriguez's avatar
      ath9k: fix regression on beacon loss after bgscan · 52b8ac92
      Luis R. Rodriguez authored
      When we return to the home channel we were never reseting our beacon
      timers, this was casued by the fact that the scanning flag was still
      on even after we returned to our home channel. There are also other
      reasons why we would get a reset and if we are not off channel
      we always need to resynch our beacon timers, because a reset will
      clear them.
      
      This bug is a regression introduced on 2.6.36. The order of the
      changes are as follows:
      
      5ee08656 - Sat Jul 31 - ath9k: prevent calibration during off-channel activity
      a0daa0e7 - Tue Jul 27 - Revert "mac80211: fix sw scan bracketing"
      543708be - Fri Jun 18 - mac80211: fix sw scan bracketing
      
      mcgrof@tux ~/linux-2.6-allstable (git::master)$ git describe \
              --contains 5ee08656
      v2.6.36-rc1~43^2~34^2~22
      
      mcgrof@tux ~/linux-2.6-allstable (git::master)$ git describe \
              --contains a0daa0e7
      v2.6.36-rc1~571^2~64^2~13
      
      mcgrof@tux ~/linux-2.6-allstable (git::master)$ git describe \
              --contains 543708be
      v2.6.36-rc1~571^2~107^2~187
      
      So 5ee08656 would have worked if a0daa0e7 was not committed but
      it was so this means 5ee08656 was broken since it assumed that
      when we were in the channel change routine the scan flag would
      be lifted. As it turns out the scan flag will be set when we
      are already on the home channel.
      
      For more details refer to:
      
      http://code.google.com/p/chromium-os/issues/detail?id=5715
      
      
      
      These issues will need to be considered for our solution on
      reshifting the scan complete callback location on mac80211 on
      current development kernel work.
      
      This patch has stable fixes which apply down to [2.6.36+]
      
      Cc: stable@kernel.org
      Cc: Paul Stewart <pstew@google.com>
      Cc: Amod Bodas <amod.bodas@atheros.com>
      Signed-off-by: default avatarLuis R. Rodriguez <lrodriguez@atheros.com>
      Signed-off-by: default avatarJohn W. Linville <linville@tuxdriver.com>
      52b8ac92