1. 08 Feb, 2013 1 commit
  2. 14 Dec, 2012 1 commit
    • Tomi Valkeinen's avatar
      OMAP: board-files: fix i2c_bus for tfp410 · ca2e16fa
      Tomi Valkeinen authored
      The i2c handling in tfp410 driver, which handles converting parallel RGB
      to DVI, was changed in 958f2717
      (OMAPDSS: TFP410: pdata rewrite). The patch changed what value the
      driver considers as invalid/undefined.  Before the patch, 0 was the
      invalid value, but as 0 is a valid bus number, the patch changed this to
      -1.
      
      However, the fact was missed that many board files do not define the bus
      number at all, thus it's left to 0. This causes the driver to fail to
      get the i2c bus, exiting from the driver's probe with an error, meaning
      that the DVI output does not work for those boards.
      
      This patch fixes the issue by changing the i2c_bus number field in the
      driver's platform data from u16 to int, and setting the bus number to -1
      in the board files for the boards that did not define the bus. The
      exception is devkit8000, for which the bus is set to 1, which is the
      correct bus for that board.
      
      The bug exists in v3.5+ kernels.
      Signed-off-by: default avatarTomi Valkeinen <tomi.valkeinen@ti.com>
      Reported-by: default avatarThomas Weber <thomas@tomweber.eu>
      Cc: Thomas Weber <thomas@tomweber.eu>
      Cc: <stable@vger.kernel.org> # v3.5+
      Signed-off-by: default avatarTony Lindgren <tony@atomide.com>
      ca2e16fa
  3. 08 Nov, 2012 1 commit
  4. 24 Oct, 2012 2 commits
    • Felipe Balbi's avatar
      ARM: OMAP: move OMAP USB platform data to <linux/platform_data/omap-usb.h> · e8c4a7ac
      Felipe Balbi authored
      In order to make single zImage work for ARM architecture,
      we need to make sure we don't depend on private headers.
      
      Move USB platform_data to <linux/platform_data/omap-usb.h>
      and add a minimal drivers/mfd/usb-omap.h.
      
      Cc: Samuel Ortiz <sameo@linux.intel.com>
      Cc: Alan Stern <stern@rowland.harvard.edu>
      Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
      Cc: Partha Basak <parthab@india.ti.com>
      Cc: Keshava Munegowda <keshava_mgowda@ti.com>
      Cc: linux-usb@vger.kernel.org
      Signed-off-by: default avatarFelipe Balbi <balbi@ti.com>
      [tony@atomide.com: updated for local mfd/usb-omap.h]
      Signed-off-by: default avatarTony Lindgren <tony@atomide.com>
      e8c4a7ac
    • Tony Lindgren's avatar
      ARM: OMAP2+: Introduce local usb.h · 54db6eee
      Tony Lindgren authored
      Let's move what we can from plat/usb.h to the local usb.h
      for ARM common zImage support.
      
      This is needed so we can remove plat/usb.h for ARM common
      zImage support.
      
      Cc: Samuel Ortiz <sameo@linux.intel.com>
      Cc: Alan Stern <stern@rowland.harvard.edu>
      Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
      Cc: Partha Basak <parthab@india.ti.com>
      Cc: Keshava Munegowda <keshava_mgowda@ti.com>
      Cc: linux-usb@vger.kernel.org
      Acked-by: default avatarFelipe Balbi <balbi@ti.com>
      Signed-off-by: default avatarTony Lindgren <tony@atomide.com>
      54db6eee
  5. 18 Oct, 2012 1 commit
    • Tony Lindgren's avatar
      ARM: OMAP: Split plat/cpu.h into local soc.h for mach-omap1 and mach-omap2 · e4c060db
      Tony Lindgren authored
      We want to remove plat/cpu.h. To do this, let's first split
      it to private soc.h to mach-omap1 and mach-omap2. We have to
      keep plat/cpu.h around until the remaining drivers are fixed,
      so let's include the local soc.h in plat/cpu.h and for drivers
      still including plat/cpu.h.
      
      Once the drivers are fixed not to include plat/cpu.h, we
      can remove the file.
      
      This is needed for the ARM common zImage support.
      
      [tony@atomide.com: updated to not print a warning]
      Signed-off-by: default avatarTony Lindgren <tony@atomide.com>
      e4c060db
  6. 15 Oct, 2012 1 commit
    • Afzal Mohammed's avatar
      ARM: OMAP2+: nand: unify init functions · 2e618261
      Afzal Mohammed authored
      Helper function for updating nand platform data has been
      added the capability to take timing structure arguement.
      Usage of omap_nand_flash_init() has been replaced by modifed
      one, omap_nand_flash_init was doing things similar to
      board_nand_init except that NAND CS# were being acquired
      based on bootloader setting. As CS# is hardwired for a given
      board, acquiring gpmc CS# has been removed, and updated with
      the value on board.
      
      NAND CS# used in beagle board & omap3evm was found to be CS0.
      Thomas Weber <thomas.weber.linux@googlemail.com> reported
      that value of devkit8000 to be CS0. Overo board was found
      to be using CS0 based on u-boot, while google grep says
      omap3touchbook too has CS0.
      Signed-off-by: default avatarAfzal Mohammed <afzal@ti.com>
      Reviewed-by: default avatarJon Hunter <jon-hunter@ti.com>
      Acked-by: default avatarIgor Grinberg <grinberg@compulab.co.il>
      2e618261
  7. 07 Oct, 2012 1 commit
  8. 20 Sep, 2012 1 commit
  9. 19 Sep, 2012 1 commit
    • Arnd Bergmann's avatar
      ARM: omap: move platform_data definitions · 2203747c
      Arnd Bergmann authored
      Platform data for device drivers should be defined in
      include/linux/platform_data/*.h, not in the architecture
      and platform specific directories.
      
      This moves such data out of the omap include directories
      Signed-off-by: default avatarArnd Bergmann <arnd@arndb.de>
      Acked-by: default avatarMark Brown <broonie@opensource.wolfsonmicro.com>
      Acked-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
      Acked-by: default avatarNicolas Pitre <nico@linaro.org>
      Acked-by: default avatarTony Lindgren <tony@atomide.com>
      Cc: Kevin Hilman <khilman@ti.com>
      Cc: "Benoît Cousson" <b-cousson@ti.com>
      Cc: Dmitry Torokhov <dmitry.torokhov@gmail.com>
      Cc: David Woodhouse <dwmw2@infradead.org>
      Cc: Kyungmin Park <kyungmin.park@samsung.com>
      Cc: Ohad Ben-Cohen <ohad@wizery.com>
      Cc: Grant Likely <grant.likely@secretlab.ca>
      Cc: Omar Ramirez Luna <omar.ramirez@ti.com>
      Cc: Tomi Valkeinen <tomi.valkeinen@ti.com>
      Cc: Florian Tobias Schandinat <FlorianSchandinat@gmx.de>
      Cc: Peter Ujfalusi <peter.ujfalusi@ti.com>
      Cc: Jarkko Nikula <jarkko.nikula@bitmer.com>
      Cc: Liam Girdwood <lrg@ti.com>
      Cc: Artem Bityutskiy <artem.bityutskiy@linux.intel.com>
      Cc: Jean Pihet <j-pihet@ti.com>
      Cc: J Keerthy <j-keerthy@ti.com>
      Cc: linux-omap@vger.kernel.org
      2203747c
  10. 12 Sep, 2012 2 commits
    • Tony Lindgren's avatar
      ARM: OMAP: Split plat/hardware.h, use local soc.h for omap2+ · dbc04161
      Tony Lindgren authored
      As the plat and mach includes need to disappear for single zImage work,
      we need to remove plat/hardware.h.
      
      Do this by splitting plat/hardware.h into omap1 and omap2+ specific files.
      
      The old plat/hardware.h already has omap1 only defines, so it gets moved
      to mach/hardware.h for omap1. For omap2+, we use the local soc.h
      that for now just includes the related SoC headers to keep this patch more
      readable.
      
      Note that the local soc.h still includes plat/cpu.h that can be dealt
      with in later patches. Let's also include plat/serial.h from common.h for
      all the board-*.c files. This allows making the include files local later
      on without patching these files again.
      
      Note that only minimal changes are done in this patch for the
      drivers/watchdog/omap_wdt.c driver to keep things compiling. Further
      patches are needed to eventually remove cpu_is_omap usage in the drivers.
      
      Also only minimal changes are done to sound/soc/omap/* to remove the
      unneeded includes and to define OMAP44XX_MCPDM_L3_BASE locally so there's
      no need to include omap44xx.h.
      
      While at it, also sort some of the includes in the standard way.
      
      Cc: linux-watchdog@vger.kernel.org
      Cc: alsa-devel@alsa-project.org
      Cc: Peter Ujfalusi <peter.ujfalusi@ti.com>
      Cc: Jarkko Nikula <jarkko.nikula@bitmer.com>
      Cc: Liam Girdwood <lrg@ti.com>
      Acked-by: default avatarWim Van Sebroeck <wim@iguana.be>
      Acked-by: default avatarMark Brown <broonie@opensource.wolfsonmicro.com>
      Signed-off-by: default avatarTony Lindgren <tony@atomide.com>
      dbc04161
    • Tony Lindgren's avatar
      ARM: OMAP2+: Remove hardcoded twl4030 gpio_base, irq_base and irq_end · a940d9a1
      Tony Lindgren authored
      We can't use hardcoded interrupts for SPARSE_IRQ, and can replace
      the hardcoded gpio_base with twl_gpiochip.base after it's been
      allocated.
      
      Cc: Grant Likely <grant.likely@secretlab.ca>
      Cc: Samuel Ortiz <sameo@linux.intel.com>
      Cc: Peter Ujfalusi <peter.ujfalusi@ti.com>
      Acked-by: default avatarLinus Walleij <linus.walleij@linaro.org>
      Signed-off-by: default avatarTony Lindgren <tony@atomide.com>
      a940d9a1
  11. 10 Sep, 2012 2 commits
  12. 15 Aug, 2012 1 commit
  13. 06 Aug, 2012 1 commit
    • Igor Grinberg's avatar
      Revert "ARM: OMAP3530evm: set pendown_state and debounce time for ads7846" · c31cc1b7
      Igor Grinberg authored
      1) The above commit introduced a common ->get_pendown_state() function
      into the generic code, but that function was board-specific for the
      OMAP3EVM and thus broke most other boards using this code.
      
      2) The above commit was mis-merged introducing another bug which
      prevents the ads7846 driver probe function to succeed.
      The omap_ads7846_init() function frees the pendown GPIO in case there is
      no ->get_pendown_state() function set by the caller (board specific
      code), so it can be requested later by the ads7846 driver.
      The above commit add a common ->get_pendown_state() function without
      removing the gpio_free() call and thus once the ads7846 driver tries
      to use the pendown GPIO, it crashes as the pendown GPIO has not been
      requested.
      
      3) The above commit introduces NO new functionality as
      get_pendown_state() function is already implemented in a suitable way by
      the ads7846 driver and the debounce time handling has already been
      fixed by commit 97ee9f01 (ARM: OMAP: fix the ads7846 init code).
      
      This reverts commit 16aced80.
      
      Conflicts:
      	arch/arm/mach-omap2/common-board-devices.c
      
      Solved by taking the working version prior to the above commit.
      
      Cc: Zumeng Chen <zumeng.chen@windriver.com>
      Cc: Arnd Bergmann <arnd@arndb.de>
      Signed-off-by: default avatarIgor Grinberg <grinberg@compulab.co.il>
      Reviewed-by: default avatarKevin Hilman <khilman@ti.com>
      Tested-by: default avatarKevin Hilman <khilman@ti.com>
      Signed-off-by: default avatarKevin Hilman <khilman@ti.com>
      c31cc1b7
  14. 03 Aug, 2012 1 commit
  15. 10 Jul, 2012 1 commit
  16. 06 Jul, 2012 4 commits
  17. 09 May, 2012 3 commits
  18. 08 May, 2012 1 commit
  19. 17 Apr, 2012 1 commit
    • Paul Walmsley's avatar
      ARM: OMAP2+: clean up some cppcheck warnings · eeb3711b
      Paul Walmsley authored
      Resolve some warnings identified by cppcheck in arch/arm/mach-omap2:
      
          [arch/arm/mach-omap2/usb-tusb6010.c:129]: (style) Checking if unsigned variable 'tmp' is less than zero.
          [arch/arm/mach-omap2/prm_common.c:241]: (error) Possible null pointer dereference: irq_setup - otherwise it is redundant to check if irq_setup is null at line 247
          [arch/arm/mach-omap2/pm34xx.c:790]: (style) Variable 'per_clkdm' is assigned a value that is never used
          [arch/arm/mach-omap2/pm34xx.c:790]: (style) Variable 'core_clkdm' is assigned a value that is never used
          [arch/arm/mach-omap2/pm24xx.c:185]: (style) Variable 'only_idle' is assigned a value that is never used
          [arch/arm/mach-omap2/mux.c:254]: (error) Possible null pointer dereference: mux
          [arch/arm/mach-omap2/mux.c:258]: (error) Possible null pointer dereference: mux
          [arch/arm/mach-omap2/gpmc-onenand.c:178]: (style) Variable 'tick_ns' is assigned a value that is never used
          [arch/arm/mach-omap2/gpio.c:56]: (error) Possible null pointer dereference: pdata - otherwise it is redundant to check if pdata is null at line 57
          [arch/arm/mach-omap2/devices.c:45]: (style) Variable 'l' is assigned a value that is never used
          [arch/arm/mach-omap2/board-omap3evm.c:641] -> [arch/arm/mach-omap2/board-omap3evm.c:639]: (style) Found duplicate branches for if and else.
          [arch/arm/mach-omap2/am35xx-emac.c:95]: (style) Variable 'regval' is assigned a value that is never used
          [arch/arm/mach-omap2/devices.c:74]: (style) Variable 'l' is assigned a value that is never used
          [arch/arm/mach-omap2/pm34xx.c:277]: (style) Variable 'per_prev_state' is assigned a value that is never used
          [arch/arm/plat-omap/dmtimer.c:352]: (error) Possible null pointer dereference: timer - otherwise it is redundant to check if timer is null at line 354
          [arch/arm/plat-omap/omap_device.c:478]: (style) Variable 'c' is assigned a value that is never used
          [arch/arm/plat-omap/usb.c:42]: (style) Variable 'status' is assigned a value that is never used
          [arch/arm/mach-omap1/clock.c:197]: (style) Variable 'dpll1_rate' is assigned a value that is never used
          [arch/arm/mach-omap1/lcd_dma.c:60]: (style) struct or union member 'lcd_dma_info::size' is never used
          [arch/arm/mach-omap1/pm.c:572]: (style) Variable 'entry' is assigned a value that is never used
      
      Some of them are pretty good catches, such as gpio.c:56 and
      usb-tusb6010.c:129.
      
      Thanks to Jarkko Nikula for some comments on the sscanf() warnings.
      It seems that the kernel sscanf() ignores the field width anyway for the
      %d format, so those changes have been dropped from this second version.
      
      Thanks to Daniel Marjamäki <daniel.marjamaki@gmail.com> for pointing
      out that a variable was unnecessarily marked static in the
      board-omap3evm.c change.
      Signed-off-by: default avatarPaul Walmsley <paul@pwsan.com>
      Cc: Felipe Balbi <balbi@ti.com>
      Cc: Tony Lindgren <tony@atomide.com>
      Cc: Kevin Hilman <khilman@ti.com>
      Cc: Peter Ujfalusi <peter.ujfalusi@ti.com>
      Cc: Jarkko Nikula <jarkko.nikula@bitmer.com>
      Cc: Charulatha Varadarajan <charu@ti.com>
      Cc: Daniel Marjamäki <daniel.marjamaki@gmail.com>
      Cc: Tarun Kanti DebBarma <tarun.kanti@ti.com>
      Reviewed-by: Charulatha Varadarajan <charu@ti.com> # for gpio.c
      eeb3711b
  20. 03 Apr, 2012 2 commits
  21. 29 Mar, 2012 1 commit
  22. 24 Feb, 2012 1 commit
    • Tony Lindgren's avatar
      ARM: OMAP2+: Mark omap_hsmmc_init and omap_mux related functions as __init · d1589f09
      Tony Lindgren authored
      Now that omap hsmmc init is split into two functions, it's safe
      to mark omap_hsmmc_init and omap_mux related functions to __init.
      
      This basically reverts the following fixes for the case where
      TWL was compiled as a module:
      
      a98f77bb (ARM: omap: fix section mismatch warning for sdp3430_twl_gpio_setup())
      8930b4e3 (ARM: omap: fix section mismatch warnings in mux.c caused by hsmmc.c)
      
      Additionally it fixes up the remaining section warnings for
      all callers of omap_mux functions.
      
      Cc: Russell King <rmk+kernel@arm.linux.org.uk>
      Signed-off-by: default avatarTony Lindgren <tony@atomide.com>
      d1589f09
  23. 21 Feb, 2012 1 commit
  24. 20 Feb, 2012 1 commit
    • Tony Lindgren's avatar
      ARM: OMAP2+: Split omap2_hsmmc_init() to properly support I2C GPIO pins · 3b972bf0
      Tony Lindgren authored
      Otherwise omap_device_build() and omap_mux related functions
      can't be marked as __init when twl is build as a module.
      
      If a board is using GPIO pins or regulators configured by an
      external chip, such as TWL PMIC on I2C bus, the board must
      mark those MMC controllers as deferred. Additionally both
      omap_hsmmc_init() and omap_hsmmc_late_init() must be called
      by the board.
      
      For MMC controllers using internal GPIO pins for card
      detect and regulators the slots don't need to be marked
      deferred. In this case calling omap_hsmmc_init() is sufficient.
      
      Only mark the MMC slots using gpio_cd or gpio_wd as deferred
      as noted by Igor Grinberg <grinberg@compulab.co.il>.
      
      Note that this patch does not change the behaviour for
      board-4430sdp.c board-omap4panda.c. These boards wrongly
      rely on the omap_hsmmc.c init function callback to configure
      the PMIC GPIO interrupt lines on external chip. If the PMIC
      interrupt lines are not configured during init, they will
      fail.
      Reported-by: default avatarRussell King <rmk+kernel@arm.linux.org.uk>
      Signed-off-by: default avatarRajendra Nayak <rnayak@ti.com>
      Signed-off-by: default avatarTony Lindgren <tony@atomide.com>
      3b972bf0
  25. 13 Feb, 2012 1 commit
    • Russell King's avatar
      ARM: omap: resolve nebulous 'Error setting wl12xx data' · 70d669de
      Russell King authored
      It's useful to print the error code when a called function fails so a
      diagnosis of why it failed is possible.  In this case, it fails because
      we try to register some data for the wl12xx driver, but as the driver
      is not configured, a stub function is used which simply returns -ENOSYS.
      
      Let's do the simple thing for -rc and print the error code.
      
      Also, the return code from platform_register_device() at each of these
      sites was not being checked.  Add some checking, and again print the
      error code.
      
      This should be fixed properly for the next merge window so we don't
      issue error messages merely because a driver is not configured.
      Acked-by: default avatarTony Lindgren <tony@atomide.com>
      Signed-off-by: default avatarRussell King <rmk+kernel@arm.linux.org.uk>
      70d669de
  26. 05 Jan, 2012 1 commit
  27. 17 Nov, 2011 1 commit
  28. 15 Nov, 2011 1 commit
  29. 31 Oct, 2011 1 commit
  30. 30 Sep, 2011 1 commit
  31. 24 Aug, 2011 1 commit