1. 15 Jun, 2015 6 commits
  2. 08 Jun, 2015 32 commits
  3. 04 Jun, 2015 2 commits
    • Wei Liu's avatar
      tcp: double default TSQ output bytes limit · c39c4c6a
      Wei Liu authored
      
      
      Xen virtual network driver has higher latency than a physical NIC.
      Having only 128K as limit for TSQ introduced 30% regression in guest
      throughput.
      
      This patch raises the limit to 256K. This reduces the regression to 8%.
      This buys us more time to work out a proper solution in the long run.
      Signed-off-by: default avatarWei Liu <wei.liu2@citrix.com>
      Cc: David Miller <davem@davemloft.net>
      Cc: Eric Dumazet <eric.dumazet@gmail.com>
      Acked-by: default avatarEric Dumazet <edumazet@google.com>
      Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
      c39c4c6a
    • Eric Dumazet's avatar
      tcp: remove redundant checks · 12e25e10
      Eric Dumazet authored
      
      
      tcp_v4_rcv() checks the following before calling tcp_v4_do_rcv():
      
      if (th->doff < sizeof(struct tcphdr) / 4)
          goto bad_packet;
      if (!pskb_may_pull(skb, th->doff * 4))
          goto discard_it;
      
      So following check in tcp_v4_do_rcv() is redundant
      and "goto csum_err;" is wrong anyway.
      
      if (skb->len < tcp_hdrlen(skb) || ...)
      	goto csum_err;
      
      A second check can be removed after no_tcp_socket label for same reason.
      
      Same tests can be removed in tcp_v6_do_rcv()
      
      Note : short tcp frames are not properly accounted in tcpInErrs MIB,
      because pskb_may_pull() failure simply drops incoming skb, we might
      fix this in a separate patch.
      Signed-off-by: default avatarEric Dumazet  <edumazet@google.com>
      Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
      12e25e10