- 27 Jul, 2010 3 commits
-
-
Dan Carpenter authored
"phba" is always null here so we can't dereference it. Signed-off-by:
Dan Carpenter <error27@gmail.com> Reviewed-by:
Mike Christie <michaelc@cs.wisc.edu> Signed-off-by:
James Bottomley <James.Bottomley@suse.de>
-
Dan Carpenter authored
I added a kfree(pwrb_arr) in front of the return. Signed-off-by:
-
Mike Christie authored
This patch fixes 4 bugs in the connection connect/disconnect cleanup path. 1. If beiscsi_open_conn fails beiscsi_free_ep was always being called, and if beiscsi_open_conn failed because beiscsi_get_cid failed then we would free an unallocated cid. 2. If beiscsi_ep_connect failed due to a beiscsi_open_conn failure it was leaking iscsi_endpoints. 3. beiscsi_ep_disconnect was leaking iscsi_endpoints. beiscsi_ep_disconnect should free the iscsi_endpoint. We cannot do it in beiscsi_conn_stop because that is only called for iscsi connection cleanup. If beiscsi_ep_connect returns success, but then the poll function fails or the connect times out then beiscsi_ep_disconnect will be called to clean up the ep. The conn_stop callout will not be called in that path. 4. beiscsi_conn_stop was freeing the iscsi_endpoint then accessing it a couple lines later. Signed-off-by:
-
- 24 May, 2010 1 commit
-
-
Dan Carpenter authored
This function should return 0 on error. Returning -1 would cause a crash. Also there is an extra space before the newline character and a missing space between the "for" and the "mgmt_invalidate_icds". I put the string on one line. The current version of checkpatch.pl complains that the line is too long, but it makes grepping easier. Signed-off-by:
-
- 08 Apr, 2010 1 commit
-
-
Jiri Slaby authored
Stanse found that one error path in mgmt_invalidate_icds omits to unlock ctrl->mbox_lock. Fix that. Added in 756d29c8 (Enable async mode for mcc rings) where the spinlock was moved. Signed-off-by:
Jiri Slaby <jslaby@suse.cz> Acked-by:
Jayamohan Kallickal <jayamohank@serverengines.com> Reviewed-by:
-
- 30 Mar, 2010 1 commit
-
-
Tejun Heo authored
include cleanup: Update gfp.h and slab.h includes to prepare for breaking implicit slab.h inclusion from percpu.h percpu.h is included by sched.h and module.h and thus ends up being included when building most .c files. percpu.h includes slab.h which in turn includes gfp.h making everything defined by the two files universally available and complicating inclusion dependencies. percpu.h -> slab.h dependency is about to be removed. Prepare for this change by updating users of gfp and slab facilities include those headers directly instead of assuming availability. As this conversion needs to touch large number of source files, the following script is used as the basis of conversion. http://userweb.kernel.org/~tj/misc/slabh-sweep.py The script does the followings. * Scan files for gfp and slab usages and update includes such that only the necessary includes are there. ie. if only gfp is used, gfp.h, if slab is used, slab.h. * When the script inserts a new include, it looks at the include bloc...
-
- 03 Mar, 2010 7 commits
-
-
Jayamohan Kallickal authored
This patch ensures that we alloc only one EQ if we are if we are not in msix mode Signed-off-by:
-
Jayamohan Kallickal authored
This patch fixes some situations where enough resources were not avaialable when targets exceeded a certain limit Signed-off-by:
-
Jayamohan Kallickal authored
This patch removes some debug lines which are unnecessary and also aligns some lines in code Signed-off-by:
-
Jayamohan Kallickal authored
This patch cleans up abort handling when TMF is sent Signed-off-by:
-
Jayamohan Kallickal authored
This patch fixes a situation where we could call udelay while holding spin_lock Signed-off-by:
-
Jayamohan Kallickal authored
This patch cleans up device and target reset handling for the driver Signed-off-by:
-
Jayamohan Kallickal authored
The iscsi_eh_target_reset has been modified to attempt target reset only. If it fails, then iscsi_eh_session_reset will be called. Signed-off-by:
-
- 17 Feb, 2010 1 commit
-
-
Jayamohan Kallickal authored
This patch contains changes to support the BE3 chip Signed-off-by:
-
- 08 Feb, 2010 11 commits
-
-
Jayamohan Kallickal authored
This patch correct the math done for num_cxn_wrb Signed-off-by:
-
Jayamohan Kallickal authored
This patch corrects the chipopcode for text and chooses correct paramters for that command Signed-off-by:
-
Jayamohan Kallickal authored
This patch ensures that wrb is cleanly resued for io path and is memset to zero for non io path Signed-off-by:
-
Jayamohan Kallickal authored
This patch fixes an issue where return was not called properly. Thanks to Mike Christie for spotting this Signed-off-by:
-
Jayamohan Kallickal authored
This patch adds proper checking of value in for hba state. We would be adding more states later on Signed-off-by:
-
Jayamohan Kallickal authored
This patch fixes the first_burst being modified instead of max_burst Signed-off-by:
-
Jayamohan Kallickal authored
This patch replaces 2009 with 2010 in copyright statement Signed-off-by:
-
Jayamohan Kallickal authored
Ring mode is not used. This patch removes the code. Signed-off-by:
-
Jayamohan Kallickal authored
This fix allows the driver to load when the FW allows more cids than than the driver supports. The driver will limit the number of cid to what it can support. There was no reason to fail the driver load,so, correcting that Signed-off-by:
-
Jayamohan Kallickal authored
The number of SGE's supported is fixed to what the chip expects. Also, the max sectors set to tested values Signed-off-by:
-
Jayamohan Kallickal authored
The patch fixes a but where the sg_next is not assigned and hence the first sge was being resused wrongly Signed-off-by:
-
- 18 Jan, 2010 12 commits
-
-
Jayamohan Kallickal authored
This patch enables TEXT Request / Response for the driver Signed-off-by:
-
Jayamohan Kallickal authored
This patch fixes can_queue being uninitiallized since it was done before beiscsi_get_params was called. Thanks to Mike Christie for identifying this Signed-off-by:
-
Jayamohan Kallickal authored
This fixes a situation where the sessions were being killed whenever LinkUP is notified rather than LinkDown Signed-off-by:
-
Jayamohan Kallickal authored
This patches enables async mode for mcc rings so that multiple requests can be queued. Signed-off-by:
-
Jayamohan Kallickal authored
This patch removes the endianess change that was wrongly added for data_count Signed-off-by:
-
Jayamohan Kallickal authored
This patch decides whether ack based completion is required or not Signed-off-by:
-
Jayamohan Kallickal authored
This patch enables use of opcode that is passed in Signed-off-by:
-
Jayamohan Kallickal authored
This patch moves pci_set_drvdata to inside beiscsi_hba_alloc Signed-off-by:
-
Jayamohan Kallickal authored
This patch adds opcodes in thecompletion path that were missed out earlier Signed-off-by:
-
Jayamohan Kallickal authored
This patch will link the current allocated wrb with the next wrb that will be allocated. This is a requirement from the chip. Signed-off-by:
-
Jayamohan Kallickal authored
We need to hold on to ep resources untill invalidate and close connection are completed Signed-off-by:
-
Jayamohan Kallickal authored
This patch enablesi be2iscsi to use the start number and number of cids/icd provided by FW rather than hard coded values. Signed-off-by:
-
- 10 Dec, 2009 1 commit
-
-
Jayamohan Kallickal authored
This patch allows for future addition of various async messages from the chip. This ensures that the driver won't hit a BUG_ON if the Firmware used is newer than inbox driver and so is using latest async messages. Signed-off-by:
-
- 04 Dec, 2009 2 commits
-
-
Mike Christie authored
This implements warm target reset tmf support for the scsi-ml target reset callback. Previously we would just drop the session in that callback. This patch will now try a target reset and if that fails drop the session. Signed-off-by:
-
Jayamohan Kallickal authored
This patch adds support for ring based wrbs Signed-off-by:
-
