1. 28 Nov, 2011 1 commit
  2. 21 Nov, 2011 1 commit
    • Johannes Berg's avatar
      mac80211: fix RCU warnings in mesh · 30be52e4
      Johannes Berg authored
      
      
      Sparse RCU checking reports two warnings in the mesh
      path table code. These are due to questionable uses of
      rcu_dereference.
      
      To fix the first one, get rid of mesh_gate_add() and
      just make mesh_path_add_gate() do the correct deref.
      
      To fix the second one, simply remove rcu_dereference()
      in mesh_gate_del() -- it already gets a proper pointer
      as indicated by the prototype (no __rcu annotation)
      and confirmed by the code.
      
      Cc: Javier Cardona <javier@cozybit.com>
      Cc: Thomas Pedersen <thomas@cozybit.com>
      Signed-off-by: default avatarJohannes Berg <johannes.berg@intel.com>
      Signed-off-by: default avatarJohn W. Linville <linville@tuxdriver.com>
      30be52e4
  3. 09 Nov, 2011 1 commit
  4. 14 Sep, 2011 2 commits
  5. 13 Sep, 2011 8 commits
  6. 29 Aug, 2011 1 commit
  7. 26 Aug, 2011 1 commit
  8. 24 Aug, 2011 5 commits
  9. 22 Aug, 2011 1 commit
  10. 12 Aug, 2011 1 commit
  11. 05 Jul, 2011 1 commit
  12. 19 May, 2011 1 commit
  13. 16 May, 2011 3 commits
  14. 12 May, 2011 1 commit
  15. 11 May, 2011 2 commits
  16. 13 Apr, 2011 1 commit
    • cozybit Inc's avatar
      mac80211: Allocate new mesh path and portal tables before taking locks · a3e6b12c
      cozybit Inc authored
      
      
      It is unnecessary to hold the path table resize lock while allocating a
      new table.  Allocate first and take lock later.  This resolves a
      soft-lockup:
      
      [  293.385799] BUG: soft lockup - CPU#0 stuck for 61s! [kworker/u:3:744]
      (...)
      [  293.386049] Call Trace:
      [  293.386049]  [<c119fd04>] do_raw_read_lock+0x26/0x29
      [  293.386049]  [<c14b2982>] _raw_read_lock+0x8/0xa
      [  293.386049]  [<c148c178>] mesh_path_add+0xb7/0x24e
      [  293.386049]  [<c148b98d>] ? mesh_path_lookup+0x1b/0xa6
      [  293.386049]  [<c148ded5>] hwmp_route_info_get+0x276/0x2fd
      [  293.386049]  [<c148dfb6>] mesh_rx_path_sel_frame+0x5a/0x5d9
      [  293.386049]  [<c102667d>] ? update_curr+0x1cf/0x1d7
      [  293.386049]  [<c148b45a>] ieee80211_mesh_rx_queued_mgmt+0x60/0x67
      [  293.386049]  [<c147c374>] ieee80211_iface_work+0x1f0/0x258
      (...)
      Signed-off-by: default avatarJavier Cardona <javier@cozybit.com>
      Signed-off-by: default avatarJohn W. Linville <linville@tuxdriver.com>
      a3e6b12c
  17. 31 Mar, 2011 1 commit
  18. 06 Dec, 2010 1 commit
  19. 14 Jun, 2010 1 commit
  20. 30 Mar, 2010 1 commit
    • Tejun Heo's avatar
      include cleanup: Update gfp.h and slab.h includes to prepare for breaking... · 5a0e3ad6
      Tejun Heo authored
      include cleanup: Update gfp.h and slab.h includes to prepare for breaking implicit slab.h inclusion from percpu.h
      
      percpu.h is included by sched.h and module.h and thus ends up being
      included when building most .c files.  percpu.h includes slab.h which
      in turn includes gfp.h making everything defined by the two files
      universally available and complicating inclusion dependencies.
      
      percpu.h -> slab.h dependency is about to be removed.  Prepare for
      this change by updating users of gfp and slab facilities include those
      headers directly instead of assuming availability.  As this conversion
      needs to touch large number of source files, the following script is
      used as the basis of conversion.
      
        http://userweb.kernel.org/~tj/misc/slabh-sweep.py
      
      
      
      The script does the followings.
      
      * Scan files for gfp and slab usages and update includes such that
        only the necessary includes are there.  ie. if only gfp is used,
        gfp.h, if slab is used, slab.h.
      
      * When the script inserts a new include, it looks at the include
        blocks and try to put the new include such that its order conforms
        to its surrounding.  It's put in the include block which contains
        core kernel includes, in the same order that the rest are ordered -
        alphabetical, Christmas tree, rev-Xmas-tree or at the end if there
        doesn't seem to be any matching order.
      
      * If the script can't find a place to put a new include (mostly
        because the file doesn't have fitting include block), it prints out
        an error message indicating which .h file needs to be added to the
        file.
      
      The conversion was done in the following steps.
      
      1. The initial automatic conversion of all .c files updated slightly
         over 4000 files, deleting around 700 includes and adding ~480 gfp.h
         and ~3000 slab.h inclusions.  The script emitted errors for ~400
         files.
      
      2. Each error was manually checked.  Some didn't need the inclusion,
         some needed manual addition while adding it to implementation .h or
         embedding .c file was more appropriate for others.  This step added
         inclusions to around 150 files.
      
      3. The script was run again and the output was compared to the edits
         from #2 to make sure no file was left behind.
      
      4. Several build tests were done and a couple of problems were fixed.
         e.g. lib/decompress_*.c used malloc/free() wrappers around slab
         APIs requiring slab.h to be added manually.
      
      5. The script was run on all .h files but without automatically
         editing them as sprinkling gfp.h and slab.h inclusions around .h
         files could easily lead to inclusion dependency hell.  Most gfp.h
         inclusion directives were ignored as stuff from gfp.h was usually
         wildly available and often used in preprocessor macros.  Each
         slab.h inclusion directive was examined and added manually as
         necessary.
      
      6. percpu.h was updated not to include slab.h.
      
      7. Build test were done on the following configurations and failures
         were fixed.  CONFIG_GCOV_KERNEL was turned off for all tests (as my
         distributed build env didn't work with gcov compiles) and a few
         more options had to be turned off depending on archs to make things
         build (like ipr on powerpc/64 which failed due to missing writeq).
      
         * x86 and x86_64 UP and SMP allmodconfig and a custom test config.
         * powerpc and powerpc64 SMP allmodconfig
         * sparc and sparc64 SMP allmodconfig
         * ia64 SMP allmodconfig
         * s390 SMP allmodconfig
         * alpha SMP allmodconfig
         * um on x86_64 SMP allmodconfig
      
      8. percpu.h modifications were reverted so that it could be applied as
         a separate patch and serve as bisection point.
      
      Given the fact that I had only a couple of failures from tests on step
      6, I'm fairly confident about the coverage of this conversion patch.
      If there is a breakage, it's likely to be something in one of the arch
      headers which should be easily discoverable easily on most builds of
      the specific arch.
      Signed-off-by: default avatarTejun Heo <tj@kernel.org>
      Guess-its-ok-by: default avatarChristoph Lameter <cl@linux-foundation.org>
      Cc: Ingo Molnar <mingo@redhat.com>
      Cc: Lee Schermerhorn <Lee.Schermerhorn@hp.com>
      5a0e3ad6
  21. 21 Dec, 2009 1 commit
    • Johannes Berg's avatar
      mac80211: reduce reliance on netdev · 47846c9b
      Johannes Berg authored
      
      
      For bluetooth 3, we will most likely not have
      a netdev for a virtual interface (sdata), so
      prepare for that by reducing the reliance on
      having a netdev. This patch moves the name
      and address fields into the sdata struct and
      uses them from there all over. Some work is
      needed to keep them sync'ed, but that's not
      a lot of work and in slow paths anyway.
      
      In doing so, this also reduces the number of
      pointer dereferences in many places, because
      of things like sdata->dev->dev_addr becoming
      sdata->vif.addr.
      Signed-off-by: default avatarJohannes Berg <johannes@sipsolutions.net>
      Signed-off-by: default avatarJohn W. Linville <linville@tuxdriver.com>
      47846c9b
  22. 04 Dec, 2009 1 commit
  23. 19 Nov, 2009 1 commit
  24. 18 Nov, 2009 1 commit
  25. 13 Nov, 2009 1 commit