All new accounts created on Gitlab now require administrator approval. If you invite any collaborators, please let Flux staff know so they can approve the accounts.

  1. 02 Feb, 2008 2 commits
  2. 01 Feb, 2008 4 commits
    • Bartlomiej Zolnierkiewicz's avatar
      ide: delete filenames/versions from comments · 58f189fc
      Bartlomiej Zolnierkiewicz authored
      Delete filenames/versions from comments.
      
      I'm leaving decisions about adding DRV_VERSION defines and MODULE_VERSION()-s
      to maintainers of the respective drivers.
      
      While at it:
      
      * Remove unused VERSION define from ide.c.
      
      * Remove unused/stale DRV_VERSION define from au1xxx-ide.c.
      Signed-off-by: default avatarBartlomiej Zolnierkiewicz <bzolnier@gmail.com>
      58f189fc
    • Bartlomiej Zolnierkiewicz's avatar
      ide: keep pointer to struct device instead of struct pci_dev in ide_hwif_t · 36501650
      Bartlomiej Zolnierkiewicz authored
      Keep pointer to struct device instead of struct pci_dev in ide_hwif_t.
      
      While on it:
      * Use *dev->dma_mask instead of pci_dev->dma_mask in ide_toggle_bounce().
      
      There should be no functionality changes caused by this patch.
      Signed-off-by: default avatarBartlomiej Zolnierkiewicz <bzolnier@gmail.com>
      36501650
    • Bartlomiej Zolnierkiewicz's avatar
      ide: add IDE_HFLAG_CLEAR_SIMPLEX host flag · 8ac2b42a
      Bartlomiej Zolnierkiewicz authored
      * Rename 'simplex_stat' variable to 'dma_stat' in ide_get_or_set_dma_base().
      
      * Factor out code for forcing host out of "simplex" mode from
        ide_get_or_set_dma_base() to ide_pci_clear_simplex() helper.
      
      * Add IDE_HFLAG_CLEAR_SIMPLEX host flag and set it in alim15x3 (for M5229),
        amd74xx (for AMD 7409), cmd64x (for CMD643), generic (for Netcell) and
        serverworks (for CSB5) host drivers.
      
      * Make ide_get_or_set_dma_base() test for IDE_HFLAG_CLEAR_SIMPLEX host flag
        instead of checking dev->device (BTW the code was buggy because it didn't
        check for dev->vendor, luckily none of these PCI Device IDs was used by
        some other vendor for PCI IDE controller).
      Signed-off-by: default avatarBartlomiej Zolnierkiewicz <bzolnier@gmail.com>
      8ac2b42a
    • Bartlomiej Zolnierkiewicz's avatar
      amd74xx: remove amd_ide_chips table · 993da8f9
      Bartlomiej Zolnierkiewicz authored
      * Remove no longer needed assertion from amd74xx_probe().
      
      * Factor out cable detection for AMD7409 to amd7409_cable_detect() and for
        chipsets >= AMD7411 to amd7411_cable_detect().
      
      * Use dev->vendor and dev->device instead of amd_config->udma_mask when
        selecting cable detection method and checking for broken FIFO support in
        init_chipset_amd74xx().
      
      * Remove no longer needed AMD_BAD_FIFO define.
      
      * Add 'swdma' parameter for setting .swdma_mask to DECLARE_AMD_DEV() macro.
      
      * Add 'udma' parameter for setting .udma_mask to DECLARE_{AMD,NV}_DEV() macro.
      
      * Keep a copy of a current amd74xx_chipsets[] entry in amd74xx_probe()
        in order to fix ->swdma_mask on early AMD7409 revisions and ->udma_mask
        on Serenade mainboards.
      
      * Remove no longer needed fixups from init_chipset_amd74xx()
        and AMD_CHECK_{SWDMA,SERENADE} defines.
      
      * Move printing banner message from init_chipset_amd74xx() to amd74xx_probe(),
        also remove incorrect comment while at it.
      
      * Use hwif->ultra_mask instead of amd_config->udma_mask in amd_set_drive().
      
      * Add 'udma_mask' argument to amd_set_speed() and pass UDMA mask from
        amd_set_drive() instead of using amd_config->udma_mask.
      
      * Move amd_config->base from AMD_* defines to users of these defines and add
        0x40 the defined values.  Then add amd_offset() inline helper for selecting
        offset from 0x40 base (needed for nVidia controllers) and finally use it in
        amd_set_speed(), amd7411_cable_detect() and init_chipset_amd74xx() instead
        of amd_config->base.
      
      * Remove no longer needed AMD_BAD_SWDMA define, ->{swdma,ultra}_mask setup
        from init_hwif_amd74xx(), amd_{config,chipset} variables and amd_ide_chips
        table.
      
      * Fix init_chipset_amd74xx() comment.
      
      * Bump driver version.
      
      There should be no functionality changes caused by this patch.
      Signed-off-by: default avatarBartlomiej Zolnierkiewicz <bzolnier@gmail.com>
      993da8f9
  3. 25 Jan, 2008 1 commit
    • Bartlomiej Zolnierkiewicz's avatar
      ide: add IDE_HFLAG_ABUSE_SET_DMA_MODE host flag · 4db90a14
      Bartlomiej Zolnierkiewicz authored
      * Add IDE_HFLAG_ABUSE_SET_DMA_MODE host flag and use it to decide
        what to do with transfer modes < XFER_PIO_0 in ide_set_xfer_rate().
      
      * Set IDE_HFLAG_ABUSE_SET_DMA_MODE in host drivers that need it
        (aec62xx, amd74xx, cs5520, cs5535, hpt34x, hpt366, pdc202xx_old,
        serverworks, tc86c001 and via82cxxx) and cleanup ->set_dma_mode
        methods in host drivers that don't (IDE core code guarantees that
        ->set_dma_mode will be called only for modes which are present
        in SWDMA/MWDMA/UDMA masks).
      
      While at it:
      
      * Add IDE_HFLAGS_HPT34X/HPT3XX/PDC202XX/SVWKS define in
        hpt34x/hpt366/pdc202xx_old/serverworks host driver.
      
      There should be no functionality changes caused by this patch.
      Acked-by: default avatarSergei Shtylyov <sshtylyov@ru.mvista.com>
      Signed-off-by: default avatarBartlomiej Zolnierkiewicz <bzolnier@gmail.com>
      4db90a14
  4. 19 Oct, 2007 3 commits
  5. 18 Oct, 2007 6 commits
  6. 16 Oct, 2007 5 commits
    • Bartlomiej Zolnierkiewicz's avatar
      amd74xx: remove /proc/ide/amd74xx · b02fcae0
      Bartlomiej Zolnierkiewicz authored
      This belongs to user-space (and only if really needed).
      
         text    data     bss     dec     hex filename
         6723    2000      28    8751    222f drivers/ide/pci/amd74xx.o.before
         3833    2000      16    5849    16d9 drivers/ide/pci/amd74xx.o.after
      Signed-off-by: default avatarBartlomiej Zolnierkiewicz <bzolnier@gmail.com>
      b02fcae0
    • Bartlomiej Zolnierkiewicz's avatar
      amd74xx/via82cxxx: don't initialize drive->dn · 8fcb2ea8
      Bartlomiej Zolnierkiewicz authored
      drive->dn is initialized by ide-probe.c::probe_hwif() so no need to do it
      in ->init_hwif method.
      Acked-by: default avatarSergei Shtylyov <sshtylyov@ru.mvista.com>
      Signed-off-by: default avatarBartlomiej Zolnierkiewicz <bzolnier@gmail.com>
      8fcb2ea8
    • Bartlomiej Zolnierkiewicz's avatar
      ide: remove hwif->autodma and drive->autodma · 9ff6f72f
      Bartlomiej Zolnierkiewicz authored
      * hpt34x.c: disable DMA masks for HPT345
        (hwif->autodma is zero so DMA won't be enabled anyway).
      
      * trm290.c: disable IDE_HFLAG_TRUST_BIOS_FOR_DMA flag
        (hwif->autodma is zero so DMA won't be enabled anyway).
      
      * Check noautodma global variable instead of drive->autodma in ide_tune_dma().
      
        This fixes handling of "ide=nodma" kernel parameter for icside, ide-cris,
        au1xxx-ide, pmac, it821x, jmicron, sgiioc4 and siimage host drivers.
      
      * Remove hwif->autodma (it was not checked by IDE core code anyway) and
        drive->autodma (was set by all host drivers - except HPT345/TRM290 special
        cases - unless "ide=nodma" was used).
      
      While at it:
      - remove needless printk() from icside.c
      - remove stale FIXME/comment from ide-probe.c
      - don't force DMA off if PCI bus-mastering had to be enabled in setup-pci.c
        (this setting was always later over-ridden by host drivers anyway)
      Signed-off-by: default avatarBartlomiej Zolnierkiewicz <bzolnier@gmail.com>
      9ff6f72f
    • Bartlomiej Zolnierkiewicz's avatar
      ide: use PCI_VDEVICE() macro · 9cbcc5e3
      Bartlomiej Zolnierkiewicz authored
      While at it:
      - make struct pci_device_id tables const
      - use PCI_DEVICE_ID_ITE_8213 define in it8213.c
      - fix comment in generic.c
      Signed-off-by: default avatarBartlomiej Zolnierkiewicz <bzolnier@gmail.com>
      9cbcc5e3
    • Bartlomiej Zolnierkiewicz's avatar
      ide: remove ->ide_dma_check (take 2) · 0ae2e178
      Bartlomiej Zolnierkiewicz authored
      * Add IDE_HFLAG_TRUST_BIOS_FOR_DMA host flag for host drivers that depend
        on BIOS for programming device/controller for DMA.  Set it in cy82c693,
        generic, ns87415, opti621 and trm290 host drivers.
      
      * Add IDE_HFLAG_VDMA host flag for host drivers using VDMA.  Set it in cs5520
        host driver.
      
      * Teach ide_tune_dma() about IDE_HFLAG_TRUST_BIOS_FOR_DMA flag.
      
      * Add generic ide_dma_check() helper and remove all open coded ->ide_dma_check
        implementations.  Fix all places checking for presence of ->ide_dma_check
        hook to check for ->ide_dma_on instead.
      
      * Remove no longer needed code from config_drive_for_dma().
      
      * Make ide_tune_dma() static.
      
      v2:
      * Fix config_drive_for_dma() return values.
      
      * Fix ide-dma.c build for CONFIG_BLK_DEV_IDEDMA_PCI=n by adding
        dummy config_drive_for_dma() inline.
      
      * Fix IDE_HFLAG_TRUST_BIOS_FOR_DMA handling in ide_dma_check().
      
      * Fix init_hwif_it8213() comment.
      
      There should be no functionality changes caused by this patch.
      
      Cc: Sergei Shtylyov <sshtylyov@ru.mvista.com>
      Signed-off-by: default avatarBartlomiej Zolnierkiewicz <bzolnier@gmail.com>
      0ae2e178
  7. 13 Oct, 2007 2 commits
    • Bartlomiej Zolnierkiewicz's avatar
      ide: move ide_config_drive_speed() calls to upper layers (take 2) · 88b2b32b
      Bartlomiej Zolnierkiewicz authored
      * Convert {ide_hwif_t,ide_pci_device_t}->host_flag to be u16.
      
      * Add IDE_HFLAG_POST_SET_MODE host flag to indicate the need to program 
        the host for the transfer mode after programming the device.  Set it
        in au1xxx-ide, amd74xx, cs5530, cs5535, pdc202xx_new, sc1200, pmac
        and via82cxxx host drivers.
      
      * Add IDE_HFLAG_NO_SET_MODE host flag to indicate the need to completely
        skip programming of host/device for the transfer mode ("smart" hosts).
        Set it in it821x host driver and check it in ide_tune_dma().
      
      * Add ide_set_pio_mode()/ide_set_dma_mode() helpers and convert all
        direct ->set_pio_mode/->speedproc users to use these helpers.
      
      * Move ide_config_drive_speed() calls from ->set_pio_mode/->speedproc
        methods to callers.
      
      * Rename ->speedproc method to ->set_dma_mode, make it void and update
        all implementations accordingly.
      
      * Update ide_set_xfer_rate() comments.
      
      * Unexport ide_config_drive_speed().
      
      v2:
      * Fix issues noticed by Sergei:
        - export ide_set_dma_mode() instead of moving ->set_pio_mode abuse wrt
          to setting DMA modes from sc1200_set_pio_mode() to do_special()
        - check IDE_HFLAG_NO_SET_MODE in ide_tune_dma()
        - check for (hwif->set_pio_mode) == NULL in ide_set_pio_mode()
        - check for (hwif->set_dma_mode) == NULL in ide_set_dma_mode()
        - return -1 from ide_set_{pio,dma}_mode() if ->set_{pio,dma}_mode == NULL
        - don't set ->set_{pio,dma}_mode on it821x in "smart" mode
        - fix build problem in pmac.c
        - minor fixes in au1xxx-ide.c/cs5530.c/siimage.c
        - improve patch description
      
      Changes in behavior caused by this patch:
      - HDIO_SET_PIO_MODE ioctl would now return -ENOSYS for attempts to change
        PIO mode if it821x controller is in "smart" mode
      - removal of two debugging printk-s (from cs5530.c and sc1200.c)
      - transfer modes 0x00-0x07 passed from user space may be programmed twice on
        the device (not really an issue since 0x00 is not supported correctly by
        any host driver ATM, 0x01 is not supported at all and 0x02-0x07 are invalid)
      Acked-by: default avatarSergei Shtylyov <sshtylyov@ru.mvista.com>
      Signed-off-by: default avatarBartlomiej Zolnierkiewicz <bzolnier@gmail.com>
      88b2b32b
    • Bartlomiej Zolnierkiewicz's avatar
      amd74xx/via82cxxx: check ide_config_drive_speed() return value · 3b4024d4
      Bartlomiej Zolnierkiewicz authored
      * Check ide_config_drive_speed() return value.
      
      * While at also call ide_config_drive_speed() if the transfer mode is
        XFER_PIO_SLOW (this case happens iff the transfer mode has already been
        set on the device by ide-proc.c::set_xfer_rate()) and remove redundant
        setting of ->{init,current}_speed.
      
      * Bump driver version.
      Acked-by: default avatarSergei Shtylyov <sshtylyov@ru.mvista.com>
      Signed-off-by: default avatarBartlomiej Zolnierkiewicz <bzolnier@gmail.com>
      3b4024d4
  8. 11 Oct, 2007 4 commits
    • Bartlomiej Zolnierkiewicz's avatar
      amd74xx/via82cxxx: use ide_tune_dma() · 55f17e8d
      Bartlomiej Zolnierkiewicz authored
      * Use ide_tune_dma() in amd74xx/via82cxxx driver, this fixes following bugs:
        - DMA capability bit not being checked on the device
        - DMA blacklist not being checked
        - DMA mode being programmed even if drive->autodma == 0
          (thus possibly destroying PIO timings)
      
      * Bump driver version.
      Acked-by: default avatarSergei Shtylyov <sshtylyov@ru.mvista.com>
      Signed-off-by: default avatarBartlomiej Zolnierkiewicz <bzolnier@gmail.com>
      55f17e8d
    • Bartlomiej Zolnierkiewicz's avatar
      ide: add ide_set{_max}_pio() (take 4) · 26bcb879
      Bartlomiej Zolnierkiewicz authored
      * Add IDE_HFLAG_ABUSE_{PREFETCH,FAST_DEVSEL,DMA_MODES} flags
        and set them in ht6560, cmd640, cmd64x and sc1200 host drivers.
      
      * Add set_pio_mode_abuse() for checking if host driver has a non-standard
        ->tuneproc() implementation and use it in do_special().
      
      * Add ide_set_pio() for setting PIO mode (it uses hwif->pio_mask to find
        the maximum PIO mode supported by the host), also add ide_set_max_pio()
        wrapper for ide_set_pio() to use for auto-tuning.  Convert users of
        ->tuneproc to use ide_set{_max}_pio() where possible.  This leaves only
        do_special(), set_using_pio(), ide_hwif_restore() and ide_set_pio() as
        a direct users of ->tuneproc.
      
      * Remove no longer needed ide_get_best_pio_mode() calls and printk-s
        reporting PIO mode selected from ->tuneproc implementations.
      
      * Rename ->tuneproc hook to ->set_pio_mode and make 'pio' argument const.
      
      * Remove stale comment from ide_config_drive_speed().
      
      v2:
      * Fix "ata_" prefix (Noticed by Jeff).
      
      v3:
      * Minor cleanups/fixups per Sergei's suggestions.
      
      v4:
      * Fix compile problem in drivers/ide/pci/cmd640.c
        (Noticed by Andrew Morton).
      
      * Improve some ->set_pio_mode comments.
      Reviewed-by: default avatarSergei Shtylyov <sshtylyov@ru.mvista.com>
      Cc: Jeff Garzik <jeff@garzik.org>
      Signed-off-by: default avatarBartlomiej Zolnierkiewicz <bzolnier@gmail.com>
      26bcb879
    • Bartlomiej Zolnierkiewicz's avatar
      ide: move ide_rate_filter() calls to the upper layer (take 2) · f212ff28
      Bartlomiej Zolnierkiewicz authored
      * Move ide_rate_filter() calls from host drivers to IDE core.
      
      * Make ide_rate_filter() static.
      
      * Make 'speed' argument of ->speedproc const.
      
      v2:
      * Fix it8213_tune_chipset() comment.
      
      There should be no functionality changes caused by this patch.
      Acked-by: default avatarSergei Shtylyov <sshtylyov@ru.mvista.com>
      Signed-off-by: default avatarBartlomiej Zolnierkiewicz <bzolnier@gmail.com>
      f212ff28
    • Bartlomiej Zolnierkiewicz's avatar
      ide: add missing ide_rate_filter() calls to ->speedproc()-s · a8028fcb
      Bartlomiej Zolnierkiewicz authored
      * Fix icside, cris-ide, au1xxx-ide, amd74xx, via82cxxx and pmac host drivers
        to use ide_rate_filter().
      
        This results in the following modes (from user requests) being clipped down:
        - invalid modes (values 0x46-0xFF)  [ for all hosts ]
        - unsupported by a host UDMA modes  [ for hosts which support UDMA]
        - all UDMA modes and MWDMA3-4 modes [ for hosts which don't support UDMA ]
        - invalid modes (values 0x25-0x39)  [ for hosts which don't support UDMA ]
      
      * Host driver specific changes in behavior:
      
        icside:
          - no change
      
        cris-ide
          - clip unsupported UDMA3-6 modes down
          - fix BUG() on trying to set unsupported UDMA3-6 modes
      
        au1xxx-ide/pmac
          - clip unsupported UDMA modes down
      
        amd74xx/via82cxxx
          - clip unsupported UDMA modes down
          - fix random PIO timings being set for unsupported/invalid modes
          - fix unsupported/invalid modes being set on the device
      
      * While at it remove no longer needed checks from pmac.c driver.
      Acked-by: default avatarSergei Shtylyov <sshtylyov@ru.mvista.com>
      Signed-off-by: default avatarBartlomiej Zolnierkiewicz <bzolnier@gmail.com>
      a8028fcb
  9. 19 Jul, 2007 3 commits
  10. 11 Jul, 2007 1 commit
    • Auke Kok's avatar
      PCI: Change all drivers to use pci_device->revision · 44c10138
      Auke Kok authored
      Instead of all drivers reading pci config space to get the revision
      ID, they can now use the pci_device->revision member.
      
      This exposes some issues where drivers where reading a word or a dword
      for the revision number, and adding useless error-handling around the
      read. Some drivers even just read it for no purpose of all.
      
      In devices where the revision ID is being copied over and used in what
      appears to be the equivalent of hotpath, I have left the copy code
      and the cached copy as not to influence the driver's performance.
      
      Compile tested with make all{yes,mod}config on x86_64 and i386.
      Signed-off-by: default avatarAuke Kok <auke-jan.h.kok@intel.com>
      Acked-by: default avatarDave Jones <davej@redhat.com>
      Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@suse.de>
      44c10138
  11. 09 Jul, 2007 2 commits
    • Bartlomiej Zolnierkiewicz's avatar
      ide: add short cables support · 49521f97
      Bartlomiej Zolnierkiewicz authored
      This patch allows users to override both host and device side cable detection
      with "ideX=ata66" kernel parameter.  Thanks to this it should be now possible
      to use UDMA > 2 modes on systems (laptops mainly) which use short 40-pin cable
      instead of 80-pin one.
      
      Next patches add automatic detection of some systems using short cables.
      
      Changes:
      
      * Rename hwif->udma_four to hwif->cbl and make it u8.
      
      * Convert all existing users accordingly (use ATA_CBL_* defines while at it).  
      
      * Add ATA_CBL_PATA40_SHORT support to ide-iops.c:eighty_ninty_three().
      
      * Use ATA_CBL_PATA40_SHORT for "ideX=ata66" kernel parameter.
      Signed-off-by: default avatarBartlomiej Zolnierkiewicz <bzolnier@gmail.com>
      Reviewed-by: default avatarSergei Shtylyov <sshtylyov@ru.mvista.com>
      49521f97
    • Bartlomiej Zolnierkiewicz's avatar
      ide: convert ide_find_best_mode() users to use ide_max_dma_mode() · 75b1d975
      Bartlomiej Zolnierkiewicz authored
      ide-timing.h:
      
      * remove handling of DMA modes from ide_find_best_mode() and rename it to
        ide_find_best_pio_mode()
      
      * drop no longer needed "map" argument from ide_find_best_pio_mode()
        and delete needless ->id check
      
      * remove no longer needed XFER_SWDMA and XFER_UDMA* defines
      
      au1xxx-ide.c:
      
      * use ide_max_dma_mode() instead of ide_find_best_mode()
      
      * remove needless CONFIG_BLK_DEV_IDE_AU1XXX_MDMA2_DBDMA #ifdef
      
      amd74xx.c:
      
      * store UDMA masks in amd_ide_chip[] and while at it make "base" field
        to be u8 instead of unsigned long
      
      * convert the driver to use UDMA masks from amd_ide_chip[]
      
      * use ide_max_dma_mode() and ide_find_best_pio_mode() instead
        of ide_find_best_mode()
      
      * delete stale comment from amd74xx_ide_dma_check()
      
      * remove no longer needed AMD_UDMA* defines
      
      via82cxxx.c:
      
      * remove unused DISPLAY_VIA_TIMINGS define
      
      * store UDMA masks in via_isa_bridges[] and while at it make "flags" field
        to be u8 instead of u16
      
      * convert the driver to use UDMA masks from via_isa_bridges[]
      
      * use ide_max_dma_mode() and ide_find_best_pio_mode() instead
        of ide_find_best_mode()
      
      * remove no longer needed VIA_UDMA* defines
      
      pmac.c:
      
      * use ide_max_dma_mode() instead of ide_find_best_mode()
      
      There should be no functionality changes caused by this patch.
      Signed-off-by: default avatarBartlomiej Zolnierkiewicz <bzolnier@gmail.com>
      Reviewed-by: default avatarSergei Shtylyov <sshtylyov@ru.mvista.com>
      75b1d975
  12. 03 Jul, 2007 1 commit
  13. 08 Jun, 2007 1 commit
  14. 09 May, 2007 1 commit
    • Bartlomiej Zolnierkiewicz's avatar
      ide: make /proc/ide/ optional · ecfd80e4
      Bartlomiej Zolnierkiewicz authored
      All important information/features should be already available through
      sysfs and ioctl interfaces.
      
      Add CONFIG_IDE_PROC_FS (CONFIG_SCSI_PROC_FS rip-off) config option,
      disabling it makes IDE driver ~5 kB smaller (on x86-32).
      
      While at it add CONFIG_PROC_FS=n versions of proc_ide_{create,destroy}()
      and remove no longer needed #ifdefs.
      Signed-off-by: default avatarBartlomiej Zolnierkiewicz <bzolnier@gmail.com>
      ecfd80e4
  15. 16 Feb, 2007 1 commit
    • Bartlomiej Zolnierkiewicz's avatar
      ide: add ide_set_dma() helper (v2) · 3608b5d7
      Bartlomiej Zolnierkiewicz authored
      * add ide_set_dma() helper and make ide_hwif_t.ide_dma_check return
        -1 when DMA needs to be disabled (== need to call ->ide_dma_off_quietly)
         0 when DMA needs to be enabled  (== need to call ->ide_dma_on)
         1 when DMA setting shouldn't be changed
      * fix IDE code to use ide_set_dma() instead if using ->ide_dma_check directly
      
      v2:
      * updated for scc_pata
      Signed-off-by: default avatarBartlomiej Zolnierkiewicz <bzolnier@gmail.com>
      3608b5d7
  16. 27 Jan, 2007 1 commit
  17. 03 Nov, 2006 1 commit
  18. 30 Jun, 2006 1 commit