1. 22 Aug, 2008 2 commits
    • Henrique de Moraes Holschuh's avatar
      rfkill: add __must_check annotations · 77fba13c
      Henrique de Moraes Holschuh authored
      
      
      rfkill is not a small, mere detail in wireless support.  Once it starts
      supporting rfkill and users start counting on that support, a wireless
      device is at risk of operating in dangerous conditions should rfkill
      support fail to properly activate.
      
      Therefore, add the required __must_check annotations on some key functions
      of the rfkill API, for which the wireless drivers absolutely MUST handle
      the failure mode safely in order to avoid a potentially dangerous situation
      where the wireless transmitter is left enabled when the user don't want it
      to.
      
      Signed-off-by: default avatarHenrique de Moraes Holschuh <hmh@hmh.eng.br>
      Acked-by: default avatarIvo van Doorn <IvDoorn@gmail.com>
      Cc: Matthew Garrett <mjg@redhat.com>
      Signed-off-by: default avatarJohn W. Linville <linville@tuxdriver.com>
      77fba13c
    • Henrique de Moraes Holschuh's avatar
      rfkill: add default global states (v2) · 99619201
      Henrique de Moraes Holschuh authored
      
      
      Add a second set of global states, "rfkill_default_states", to track the
      state that will be used when the first rfkill class of a given type is
      registered, and also to save "undo" information when rfkill_epo is called.
      
      Add a new exported function, rfkill_set_default(), which can be used by
      platform drivers to restore radio state saved by the platform across
      reboots or shutdown.
      
      Also, fix rfkill_epo to properly update rfkill_states, but still preserve a
      copy of the state so that we can undo the effect of rfkill_epo later if we
      want to.  Add rfkill_restore_states() to restore rfkill_states from the
      copy.
      
      Signed-off-by: default avatarHenrique de Moraes Holschuh <hmh@hmh.eng.br>
      Acked-by: default avatarIvo van Doorn <IvDoorn@gmail.com>
      Signed-off-by: default avatarJohn W. Linville <linville@tuxdriver.com>
      99619201
  2. 29 Jul, 2008 1 commit
  3. 26 Jun, 2008 5 commits
    • Henrique de Moraes Holschuh's avatar
      rfkill: rename the rfkill_state states and add block-locked state · 5005657c
      Henrique de Moraes Holschuh authored
      
      
      The current naming of rfkill_state causes a lot of confusion: not only the
      "kill" in rfkill suggests negative logic, but also the fact that rfkill cannot
      turn anything on (it can just force something off or stop forcing something
      off) is often forgotten.
      
      Rename RFKILL_STATE_OFF to RFKILL_STATE_SOFT_BLOCKED (transmitter is blocked
      and will not operate; state can be changed by a toggle_radio request), and
      RFKILL_STATE_ON to RFKILL_STATE_UNBLOCKED (transmitter is not blocked, and may
      operate).
      
      Also, add a new third state, RFKILL_STATE_HARD_BLOCKED (transmitter is blocked
      and will not operate; state cannot be changed through a toggle_radio request),
      which is used by drivers to indicate a wireless transmiter was blocked by a
      hardware rfkill line that accepts no overrides.
      
      Keep the old names as #defines, but document them as deprecated.  This way,
      drivers can be converted to the new names *and* verified to actually use rfkill
      correctly one by one.
      
      Signed-off-by: default avatarHenrique de Moraes Holschuh <hmh@hmh.eng.br>
      Acked-by: default avatarIvo van Doorn <IvDoorn@gmail.com>
      Signed-off-by: default avatarJohn W. Linville <linville@tuxdriver.com>
      5005657c
    • Henrique de Moraes Holschuh's avatar
      rfkill: add notifier chains support · 79399a8d
      Henrique de Moraes Holschuh authored
      
      
      Add a notifier chain for use by the rfkill class.  This notifier chain
      signals the following events (more to be added when needed):
      
        1. rfkill: rfkill device state has changed
      
      A pointer to the rfkill struct will be passed as a parameter.
      
      The notifier message types have been added to include/linux/rfkill.h
      instead of to include/linux/notifier.h in order to avoid the madness of
      modifying a header used globally (and that triggers an almost full tree
      rebuild every time it is touched) with information that is of interest only
      to code that includes the rfkill.h header.
      
      Signed-off-by: default avatarHenrique de Moraes Holschuh <hmh@hmh.eng.br>
      Acked-by: default avatarIvo van Doorn <IvDoorn@gmail.com>
      Signed-off-by: default avatarJohn W. Linville <linville@tuxdriver.com>
      79399a8d
    • Henrique de Moraes Holschuh's avatar
      rfkill: add the WWAN radio type · 477576a0
      Henrique de Moraes Holschuh authored
      
      
      Unfortunately, instead of adding a generic Wireless WAN type, a technology-
      specific type (WiMAX) was added.  That's useless for other WWAN devices,
      such as EDGE, UMTS, X-RTT and other such radios.
      
      Add a WWAN rfkill type for generic wireless WAN devices.  No keys are added
      as most devices really want to use KEY_WLAN for WWAN control (in a cycle of
      none, WLAN, WWAN, WLAN+WWAN) and need no specific keycode added.
      
      Signed-off-by: default avatarHenrique de Moraes Holschuh <hmh@hmh.eng.br>
      Acked-by: default avatarIvo van Doorn <IvDoorn@gmail.com>
      Cc: Iñaky Pérez-González <inaky.perez-gonzalez@intel.com>
      Cc: David S. Miller <davem@davemloft.net>
      Signed-off-by: default avatarJohn W. Linville <linville@tuxdriver.com>
      477576a0
    • Henrique de Moraes Holschuh's avatar
      rfkill: add read-write rfkill switch support · 801e49af
      Henrique de Moraes Holschuh authored
      
      
      Currently, rfkill support for read/write rfkill switches is hacked through
      a round-trip over the input layer and rfkill-input to let a driver sync
      rfkill->state to hardware changes.
      
      This is buggy and sub-optimal.  It causes real problems.  It is best to
      think of the rfkill class as supporting only write-only switches at the
      moment.
      
      In order to implement the read/write functionality properly:
      
      Add a get_state() hook that is called by the class every time it needs to
      fetch the current state of the switch.  Add a call to this hook every time
      the *current* state of the radio plays a role in a decision.
      
      Also add a force_state() method that can be used to forcefully syncronize
      the class' idea of the current state of the switch.  This allows for a
      faster implementation of the read/write functionality, as a driver which
      get events on switch changes can avoid the need for a get_state() hook.
      
      If the get_state() hook is left as NULL, current behaviour is maintained,
      so this change is fully backwards compatible with the current rfkill
      drivers.
      
      For hardware that issues events when the rfkill state changes, leave
      get_state() NULL in the rfkill struct, set the initial state properly
      before registering with the rfkill class, and use the force_state() method
      in the driver to keep the rfkill interface up-to-date.
      
      get_state() can be called by the class from atomic context. It must not
      sleep.
      
      Signed-off-by: default avatarHenrique de Moraes Holschuh <hmh@hmh.eng.br>
      Acked-by: default avatarIvo van Doorn <IvDoorn@gmail.com>
      Cc: Dmitry Torokhov <dtor@mail.ru>
      Signed-off-by: default avatarJohn W. Linville <linville@tuxdriver.com>
      801e49af
    • Henrique de Moraes Holschuh's avatar
      rfkill: clarify meaning of rfkill states · f3146aff
      Henrique de Moraes Holschuh authored
      
      
      rfkill really should have been named rfswitch.  As it is, one can get
      confused whether RFKILL_STATE_ON means the KILL switch is on (and
      therefore, the radio is being *blocked* from operating), or whether it
      means the RADIO rf output is on.
      
      Clearly state that RFKILL_STATE_ON means the radio is *unblocked* from
      operating (i.e. there is no rf killing going on).
      
      Signed-off-by: default avatarHenrique de Moraes Holschuh <hmh@hmh.eng.br>
      Acked-by: default avatarIvo van Doorn <IvDoorn@gmail.com>
      Cc: Dmitry Torokhov <dtor@mail.ru>
      Signed-off-by: default avatarJohn W. Linville <linville@tuxdriver.com>
      f3146aff
  4. 31 Jan, 2008 1 commit
  5. 10 Oct, 2007 6 commits
  6. 07 Jun, 2007 1 commit
  7. 07 May, 2007 1 commit