1. 12 Apr, 2012 1 commit
    • Roland Dreier's avatar
      IB/srpt: Set srq_type to IB_SRQT_BASIC · 6f360336
      Roland Dreier authored
      Since commit 96104eda
       ("RDMA/core: Add SRQ type field"), kernel
      users of SRQs need to specify srq_type = IB_SRQT_BASIC in struct
      ib_srq_init_attr, or else most low-level drivers will fail in
      when srpt_add_one() calls ib_create_srq() and gets -ENOSYS.
      (mlx4_ib works OK nearly all of the time, because it just needs
      srq_type != IB_SRQT_XRC.  And apparently nearly everyone using
      ib_srpt is using mlx4 hardware)
      Reported-by: default avatarAlexey Shvetsov <alexxy@gentoo.org>
      Cc: <stable@vger.kernel.org>
      Signed-off-by: default avatarRoland Dreier <roland@purestorage.com>
  2. 17 Mar, 2012 1 commit
    • Nicholas Bellinger's avatar
      ib_srpt: Fix srpt_handle_cmd send_ioctx->ioctx_kref leak on exception · 187e70a5
      Nicholas Bellinger authored
      This patch addresses a bug in srpt_handle_cmd() failure handling where
      send_ioctx->kref is being leaked with the local extra reference after init,
      causing the expected kref_put() in srpt_handle_send_comp() to not be the final
      call to invoke srpt_put_send_ioctx_kref() -> transport_generic_free_cmd() and
      perform se_cmd descriptor memory release.
      It also fixes a SCF_SCSI_RESERVATION_CONFLICT handling bug where this code
      is incorrectly falling through to transport_handle_cdb_direct() after
      invoking srpt_queue_status() to send SAM_STAT_RESERVATION_CONFLICT status.
      Note this patch is for >= v3.3 mainline code, and current lio-core.git
      code has already been converted to target_submit_cmd() + se_cmd->cmd_kref usage,
      and internal ioctx->kref usage has been removed.  I'm including this patch
      now into target-pending/for-next with a CC' for v3.3 stable.
      Cc: Bart Van Assche <bvanassche@acm.org>
      Cc: Roland Dreier <roland@purestorage.com>
      Cc: stable@vger.kernel.org
      Signed-off-by: default avatarNicholas Bellinger <nab@linux-iscsi.org>
  3. 10 Mar, 2012 1 commit
  4. 25 Feb, 2012 3 commits
  5. 09 Feb, 2012 1 commit
  6. 06 Feb, 2012 1 commit
  7. 03 Feb, 2012 1 commit
  8. 02 Feb, 2012 2 commits
  9. 15 Dec, 2011 1 commit
    • Bart Van Assche's avatar
      ib_srpt: Initial SRP Target merge for v3.3-rc1 · a42d985b
      Bart Van Assche authored
      This patch adds the kernel module ib_srpt SCSI RDMA Protocol (SRP) target
      implementation conforming to the SRP r16a specification for the mainline
      drivers/target infrastructure.
      This driver was originally developed by Vu Pham and has been optimized by
      Bart Van Assche and merged into upstream LIO based on his srpt-lio-4.1
      branch here:
      This updated patch also contains the following two changes from
      lio-core-2.6.git/master.  One is to fix a bug with 1 >= task->task_sg[]
      chained mappings in ib_srpt, and the other to convert the configfs control
      plane to reference IB Port GUID and struct srpt_port directly following
      mainline v4.x target_core_fabric_configfs.c convertion for ib_srpt
      to work with rtslib/rtsadmin v2 code.
      These seperate patches can be found here:
      ib_srpt: Fix bug with chainged SGLs in srpt_map_sg_to_ib_sge
      ib_srpt: Convert se_wwn endpoint reference to struct srpt_port->port_wwn
      This also includes the following recent v1 -> v2 review changes:
      ib_srpt: Fix potential out-of-bounds array access
      ib_srpt: Avoid failed multipart RDMA transfers
      ib_srpt: Fix srpt_alloc_fabric_acl failure case return value
      ib_srpt: Update comments to reference $driver/$port layout
      ib_srpt: Fix sport->port_guid formatting code
      ib_srpt: Remove legacy use_port_guid_in_session_name module parameter
      ib_srpt: Convert srp_max_rdma_size into per port configfs attribute
      ib_srpt: Convert srp_max_rsp_size into per port configfs attribute
      ib_srpt: Convert srpt_sq_size into per port configfs attribute
      and v2 -> v3 review changes:
      ib_srpt: Fix possible race with srp_sq_size in srpt_create_ch_ib
      ib_srpt: Fix possible race with srp_max_rsp_size in srpt_release_channel_work
      ib_srpt: Fix up MAX_SRPT_RDMA_SIZE define
      ib_srpt: Make srpt_map_sg_to_ib_sge() failure case return -EAGAIN
      ib_srpt: Convert port_guid to use subnet_prefix + interface_id formatting
      ib_srpt: Make srpt_check_stop_free return kref_put status
      ib_srpt: Make compilation with BUG=n proceed`
      ib_srpt: Use new target_core_fabric.h include
      ib_srpt: Check hex2bin() return code to silence build warning
      Cc: Bart Van Assche <bvanassche@acm.org>
      Cc: Roland Dreier <roland@purestorage.com>
      Cc: Christoph Hellwig <hch@lst.de>
      Cc: Vu Pham <vu@mellanox.com>
      Cc: David Dillow <dillowda@ornl.gov>
      Signed-off-by: default avatarNicholas A. Bellinger <nab@risingtidesystems.com>