1. 06 Jul, 2012 9 commits
  2. 18 Jun, 2012 1 commit
    • Ian Abbott's avatar
      staging: comedi: change device used in dev_...() calls · f41ad667
      Ian Abbott authored
      
      
      A previous set of patches by Ravishankar Karkala Mallikarjunayya
      replaced a load of printk() calls with dev_info(), dev_err(), etc.
      Unfortunately, these used the 'struct device *hw_dev' member of 'struct
      comedi_device') as the first parameter of these dev_...() calls, but
      that pointer is usually NULL, so the kernel log messages come out a bit
      wrong (they contain the phrase "(NULL device *)").
      
      Use the 'struct device *class_dev' member of 'struct comedi_device'
      instead for these dev_...() calls.  It will be non-NULL and somewhat
      meaningful to users.  It's also consistent with those comedi drivers
      that already use the class_dev member in their dev_...() calls.
      
      Some of the messages included the format "comedi%d" with the minor
      device number used for the "%d".  This is now redundant as it will be
      the same as the dev_name() part of the kernel log message produced by
      the dev_...() calls.
      Signed-off-by: default avatarIan Abbott <abbotti@mev.co.uk>
      Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
      f41ad667
  3. 26 Nov, 2011 1 commit
  4. 05 May, 2011 1 commit
  5. 29 Sep, 2010 8 commits
    • Dominik Brodowski's avatar
      pcmcia: remove obsolete and wrong comments · 2262054e
      Dominik Brodowski authored
      
      
      What's worse than no comment? A wrong comment.
      
      Several PCMCIA device drivers contained the same comments, which
      were based on how the PCMCIA subsystem worked in the old days of 2.4.,
      and which were originally part of a "dummy_cs" driver. These comments
      no longer matched at all what is happening now, and therefore should
      be removed.
      Tested-by: default avatarWolfram Sang <w.sang@pengutronix.de>
      Signed-off-by: default avatarDominik Brodowski <linux@dominikbrodowski.net>
      2262054e
    • Dominik Brodowski's avatar
    • Dominik Brodowski's avatar
      pcmcia: remove the "Finally, report what we've done" message · 1cc745d1
      Dominik Brodowski authored
      
      
      Remove this unnecessary message -- this info is either available
      in sysfs or by enabling dynamic debug from the PCMCIA core.
      
      CC: netdev@vger.kernel.org
      CC: linux-wireless@vger.kernel.org
      CC: linux-scsi@vger.kernel.org
      CC: linux-usb@vger.kernel.org
      Tested-by: default avatarWolfram Sang <w.sang@pengutronix.de>
      Signed-off-by: default avatarDominik Brodowski <linux@dominikbrodowski.net>
      1cc745d1
    • Dominik Brodowski's avatar
      pcmcia: use autoconfiguration feature for ioports and iomem · 00990e7c
      Dominik Brodowski authored
      
      
      When CONF_AUTO_SET_IO or CONF_AUTO_SET_IOMEM are set, the corresponding
      fields in struct pcmcia_device *p_dev->resource[0,1,2] are set
      accordinly. Drivers wishing to override certain settings may do so in
      the callback function, but they no longer need to parse the CIS entries
      stored in cistpl_cftable_entry_t themselves.
      
      CC: netdev@vger.kernel.org
      CC: linux-wireless@vger.kernel.org
      CC: linux-ide@vger.kernel.org
      CC: linux-usb@vger.kernel.org
      CC: laforge@gnumonks.org
      CC: linux-mtd@lists.infradead.org
      CC: linux-bluetooth@vger.kernel.org
      CC: alsa-devel@alsa-project.org
      CC: linux-serial@vger.kernel.org
      CC: Jiri Kosina <jkosina@suse.cz>
      CC: linux-scsi@vger.kernel.org
      Tested-by: default avatarWolfram Sang <w.sang@pengutronix.de>
      Signed-off-by: default avatarDominik Brodowski <linux@dominikbrodowski.net>
      00990e7c
    • Dominik Brodowski's avatar
      pcmcia: introduce autoconfiguration feature · 440eed43
      Dominik Brodowski authored
      
      
      Introduce an autoconfiguration feature to set certain values in
      pcmcia_loop_config(), instead of copying the same code over and over
      in each PCMCIA driver. At first, introduce the following options:
      
      CONF_AUTO_CHECK_VCC	check or matching Vcc entry
      CONF_AUTO_SET_VPP	set Vpp
      CONF_AUTO_AUDIO		enable the speaker line
      
      CC: netdev@vger.kernel.org
      CC: linux-wireless@vger.kernel.org
      CC: linux-ide@vger.kernel.org
      CC: linux-usb@vger.kernel.org
      CC: laforge@gnumonks.org
      CC: linux-mtd@lists.infradead.org
      CC: alsa-devel@alsa-project.org
      CC: linux-serial@vger.kernel.org
      CC: Jiri Kosina <jkosina@suse.cz>
      CC: linux-scsi@vger.kernel.org
      Acked-by: Gustavo F. Padovan <padovan@profusion.mobi> (for drivers/bluetooth)
      Tested-by: default avatarWolfram Sang <w.sang@pengutronix.de>
      Signed-off-by: default avatarDominik Brodowski <linux@dominikbrodowski.net>
      440eed43
    • Dominik Brodowski's avatar
      pcmcia: convert pcmcia_request_configuration to pcmcia_enable_device · 1ac71e5a
      Dominik Brodowski authored
      
      
      pcmcia_enable_device() now replaces pcmcia_request_configuration().
      Instead of config_req_t, all necessary flags are either passed as
      a parameter to pcmcia_enable_device(), or (in rare circumstances)
      set in struct pcmcia_device -> flags.
      
      With the last remaining user of include/pcmcia/cs.h gone, remove
      all references.
      
      CC: netdev@vger.kernel.org
      CC: linux-wireless@vger.kernel.org
      CC: linux-ide@vger.kernel.org
      CC: linux-usb@vger.kernel.org
      CC: laforge@gnumonks.org
      CC: linux-mtd@lists.infradead.org
      CC: alsa-devel@alsa-project.org
      CC: linux-serial@vger.kernel.org
      CC: Jiri Kosina <jkosina@suse.cz>
      CC: linux-scsi@vger.kernel.org
      Acked-by: Gustavo F. Padovan <padovan@profusion.mobi> (for drivers/bluetooth)
      Tested-by: default avatarWolfram Sang <w.sang@pengutronix.de>
      Signed-off-by: default avatarDominik Brodowski <linux@dominikbrodowski.net>
      1ac71e5a
    • Dominik Brodowski's avatar
      pcmcia: move config_{base,index,regs} to struct pcmcia_device · 7feabb64
      Dominik Brodowski authored
      
      
      Several drivers prefer to explicitly set config_{base,index,regs},
      formerly known as ConfigBase, ConfigIndex and Present. Instead of
      passing these values inside config_req_t, store it in struct
      pcmcia_device.
      
      CC: netdev@vger.kernel.org
      CC: linux-wireless@vger.kernel.org
      CC: linux-ide@vger.kernel.org
      CC: linux-usb@vger.kernel.org
      CC: laforge@gnumonks.org
      CC: linux-mtd@lists.infradead.org
      CC: alsa-devel@alsa-project.org
      CC: linux-serial@vger.kernel.org
      CC: Jiri Kosina <jkosina@suse.cz>
      CC: linux-scsi@vger.kernel.org
      Acked-by: Gustavo F. Padovan <padovan@profusion.mobi> (for drivers/bluetooth)
      Tested-by: default avatarWolfram Sang <w.sang@pengutronix.de>
      Signed-off-by: default avatarDominik Brodowski <linux@dominikbrodowski.net>
      7feabb64
    • Dominik Brodowski's avatar
      pcmcia: simplify IntType · 37979e15
      Dominik Brodowski authored
      
      
      IntType was only set to INT_MEMORY (driver pcmciamtd) or INT_MEMORY_AND_IO
      (all other drivers). As this flags seems to relate to ioport access, make
      it conditional to the driver having requested IO port access. There are two
      drivers which do not request IO ports, but did set INT_MEMORY_AND_IO:
      ray_cs and b43. For those, we consistently only set INT_MEMORY in future.
      
      CC: netdev@vger.kernel.org
      CC: linux-wireless@vger.kernel.org
      CC: linux-ide@vger.kernel.org
      CC: linux-usb@vger.kernel.org
      CC: laforge@gnumonks.org
      CC: linux-mtd@lists.infradead.org
      CC: alsa-devel@alsa-project.org
      CC: linux-serial@vger.kernel.org
      CC: Jiri Kosina <jkosina@suse.cz>
      CC: linux-scsi@vger.kernel.org
      Acked-by: Gustavo F. Padovan <padovan@profusion.mobi> (for drivers/bluetooth)
      Tested-by: default avatarWolfram Sang <w.sang@pengutronix.de>
      Signed-off-by: default avatarDominik Brodowski <linux@dominikbrodowski.net>
      37979e15
  6. 03 Sep, 2010 1 commit
  7. 03 Aug, 2010 2 commits
    • Dominik Brodowski's avatar
      pcmcia: do not use io_req_t when calling pcmcia_request_io() · 90abdc3b
      Dominik Brodowski authored
      
      
      Instead of io_req_t, drivers are now requested to fill out
      struct pcmcia_device *p_dev->resource[0,1] for up to two ioport
      ranges. After a call to pcmcia_request_io(), the ports found there
      are reserved, after calling pcmcia_request_configuration(), they may
      be used.
      
      CC: netdev@vger.kernel.org
      CC: linux-wireless@vger.kernel.org
      CC: linux-ide@vger.kernel.org
      CC: linux-usb@vger.kernel.org
      CC: laforge@gnumonks.org
      CC: linux-mtd@lists.infradead.org
      CC: alsa-devel@alsa-project.org
      CC: linux-serial@vger.kernel.org
      CC: Michael Buesch <mb@bu3sch.de>
      Acked-by: Marcel Holtmann <marcel@holtmann.org> (for drivers/bluetooth/)
      Signed-off-by: default avatarDominik Brodowski <linux@dominikbrodowski.net>
      90abdc3b
    • Dominik Brodowski's avatar
      pcmcia: do not use io_req_t after call to pcmcia_request_io() · 9a017a91
      Dominik Brodowski authored
      
      
      After pcmcia_request_io(), do not make use of the values stored in
      io_req_t, but instead use those found in struct pcmcia_device->resource[].
      
      CC: netdev@vger.kernel.org
      CC: linux-wireless@vger.kernel.org
      CC: linux-ide@vger.kernel.org
      CC: linux-usb@vger.kernel.org
      CC: laforge@gnumonks.org
      CC: linux-mtd@lists.infradead.org
      CC: alsa-devel@alsa-project.org
      CC: linux-serial@vger.kernel.org
      Acked-by: Marcel Holtmann <marcel@holtmann.org> (for drivers/bluetooth/)
      Signed-off-by: default avatarDominik Brodowski <linux@dominikbrodowski.net>
      9a017a91
  8. 30 Jul, 2010 1 commit
    • Dominik Brodowski's avatar
      pcmcia: remove cs_types.h · ac8b4228
      Dominik Brodowski authored
      
      
      Remove cs_types.h which is no longer needed: Most definitions aren't
      used at all, a few can be made away with, and two remaining definitions
      (typedefs, unfortunatley) may be moved to more specific places.
      
      CC: linux-ide@vger.kernel.org
      CC: linux-usb@vger.kernel.org
      CC: laforge@gnumonks.org
      CC: linux-mtd@lists.infradead.org
      CC: alsa-devel@alsa-project.org
      CC: linux-serial@vger.kernel.org
      Acked-by: Marcel Holtmann <marcel@holtmann.org> (for drivers/bluetooth/)
      Acked-by: default avatarDavid S. Miller <davem@davemloft.net>
      Signed-off-by: default avatarDominik Brodowski <linux@dominikbrodowski.net>
      ac8b4228
  9. 17 Jun, 2010 1 commit
    • Dan Carpenter's avatar
      Staging: comedi: cleanup: remove unneeded null checks · f25bd6bf
      Dan Carpenter authored
      
      
      These checks are obviously pointless because kfree() can handle null
      dereferences.
      
      But really the main problem is that if the pointers were null that would
      cause problems on the ealier lines.  The dereferences would cause an
      oops and the _release() functions use ->priv to determine which IRQ to
      free.  I looked into it and quite a few of the detach functions assume
      link->priv is non-null.  It seems like we can remove these checks.
      Signed-off-by: default avatarDan Carpenter <error27@gmail.com>
      Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@suse.de>
      f25bd6bf
  10. 17 May, 2010 1 commit
  11. 14 May, 2010 1 commit
  12. 10 May, 2010 1 commit
    • Dominik Brodowski's avatar
      pcmcia: re-work pcmcia_request_irq() · eb14120f
      Dominik Brodowski authored
      
      
      Instead of the old pcmcia_request_irq() interface, drivers may now
      choose between:
      
      - calling request_irq/free_irq directly. Use the IRQ from *p_dev->irq.
      
      - use pcmcia_request_irq(p_dev, handler_t); the PCMCIA core will
        clean up automatically on calls to pcmcia_disable_device() or
        device ejection.
      
      - drivers still not capable of IRQF_SHARED (or not telling us so) may
        use the deprecated pcmcia_request_exclusive_irq() for the time
        being; they might receive a shared IRQ nonetheless.
      
      CC: linux-bluetooth@vger.kernel.org
      CC: netdev@vger.kernel.org
      CC: linux-wireless@vger.kernel.org
      CC: linux-serial@vger.kernel.org
      CC: alsa-devel@alsa-project.org
      CC: linux-usb@vger.kernel.org
      CC: linux-ide@vger.kernel.org
      Signed-off-by: default avatarDominik Brodowski <linux@dominikbrodowski.net>
      eb14120f
  13. 30 Mar, 2010 1 commit
    • Tejun Heo's avatar
      include cleanup: Update gfp.h and slab.h includes to prepare for breaking... · 5a0e3ad6
      Tejun Heo authored
      include cleanup: Update gfp.h and slab.h includes to prepare for breaking implicit slab.h inclusion from percpu.h
      
      percpu.h is included by sched.h and module.h and thus ends up being
      included when building most .c files.  percpu.h includes slab.h which
      in turn includes gfp.h making everything defined by the two files
      universally available and complicating inclusion dependencies.
      
      percpu.h -> slab.h dependency is about to be removed.  Prepare for
      this change by updating users of gfp and slab facilities include those
      headers directly instead of assuming availability.  As this conversion
      needs to touch large number of source files, the following script is
      used as the basis of conversion.
      
        http://userweb.kernel.org/~tj/misc/slabh-sweep.py
      
      
      
      The script does the followings.
      
      * Scan files for gfp and slab usages and update includes such that
        only the necessary includes are there.  ie. if only gfp is used,
        gfp.h, if slab is used, slab.h.
      
      * When the script inserts a new include, it looks at the include
        blocks and try to put the new include such that its order conforms
        to its surrounding.  It's put in the include block which contains
        core kernel includes, in the same order that the rest are ordered -
        alphabetical, Christmas tree, rev-Xmas-tree or at the end if there
        doesn't seem to be any matching order.
      
      * If the script can't find a place to put a new include (mostly
        because the file doesn't have fitting include block), it prints out
        an error message indicating which .h file needs to be added to the
        file.
      
      The conversion was done in the following steps.
      
      1. The initial automatic conversion of all .c files updated slightly
         over 4000 files, deleting around 700 includes and adding ~480 gfp.h
         and ~3000 slab.h inclusions.  The script emitted errors for ~400
         files.
      
      2. Each error was manually checked.  Some didn't need the inclusion,
         some needed manual addition while adding it to implementation .h or
         embedding .c file was more appropriate for others.  This step added
         inclusions to around 150 files.
      
      3. The script was run again and the output was compared to the edits
         from #2 to make sure no file was left behind.
      
      4. Several build tests were done and a couple of problems were fixed.
         e.g. lib/decompress_*.c used malloc/free() wrappers around slab
         APIs requiring slab.h to be added manually.
      
      5. The script was run on all .h files but without automatically
         editing them as sprinkling gfp.h and slab.h inclusions around .h
         files could easily lead to inclusion dependency hell.  Most gfp.h
         inclusion directives were ignored as stuff from gfp.h was usually
         wildly available and often used in preprocessor macros.  Each
         slab.h inclusion directive was examined and added manually as
         necessary.
      
      6. percpu.h was updated not to include slab.h.
      
      7. Build test were done on the following configurations and failures
         were fixed.  CONFIG_GCOV_KERNEL was turned off for all tests (as my
         distributed build env didn't work with gcov compiles) and a few
         more options had to be turned off depending on archs to make things
         build (like ipr on powerpc/64 which failed due to missing writeq).
      
         * x86 and x86_64 UP and SMP allmodconfig and a custom test config.
         * powerpc and powerpc64 SMP allmodconfig
         * sparc and sparc64 SMP allmodconfig
         * ia64 SMP allmodconfig
         * s390 SMP allmodconfig
         * alpha SMP allmodconfig
         * um on x86_64 SMP allmodconfig
      
      8. percpu.h modifications were reverted so that it could be applied as
         a separate patch and serve as bisection point.
      
      Given the fact that I had only a couple of failures from tests on step
      6, I'm fairly confident about the coverage of this conversion patch.
      If there is a breakage, it's likely to be something in one of the arch
      headers which should be easily discoverable easily on most builds of
      the specific arch.
      Signed-off-by: default avatarTejun Heo <tj@kernel.org>
      Guess-its-ok-by: default avatarChristoph Lameter <cl@linux-foundation.org>
      Cc: Ingo Molnar <mingo@redhat.com>
      Cc: Lee Schermerhorn <Lee.Schermerhorn@hp.com>
      5a0e3ad6
  14. 03 Mar, 2010 1 commit
  15. 28 Nov, 2009 1 commit
    • Dominik Brodowski's avatar
      pcmcia: rework the irq_req_t typedef · 5fa9167a
      Dominik Brodowski authored
      
      
      Most of the irq_req_t typedef'd struct can be re-worked quite
      easily:
      
      (1) IRQInfo2 was unused in any case, so drop it.
      
      (2) IRQInfo1 was used write-only, so drop it.
      
      (3) Instance (private data to be passed to the IRQ handler):
      	Most PCMCIA drivers using pcmcia_request_irq() to actually
      	register an IRQ handler set the "dev_id" to the same pointer
      	as the "priv" pointer in struct pcmcia_device. Modify the two
      	exceptions (ipwireless, ibmtr_cs) to also work this waym and
      	set the IRQ handler's "dev_id" to p_dev->priv unconditionally.
      
      (4) Handler is to be of type irq_handler_t.
      
      (5) Handler != NULL already tells whether an IRQ handler is present.
      	Therefore, we do not need the IRQ_HANDLER_PRESENT flag in
      	irq_req_t.Attributes.
      
      CC: netdev@vger.kernel.org
      CC: linux-bluetooth@vger.kernel.org
      CC: linux-ide@vger.kernel.org
      CC: linux-wireless@vger.kernel.org
      CC: linux-scsi@vger.kernel.org
      CC: alsa-devel@alsa-project.org
      CC: Jaroslav Kysela <perex@perex.cz>
      CC: Jiri Kosina <jkosina@suse.cz>
      CC: Karsten Keil <isdn@linux-pingi.de>
      for the Bluetooth parts: Acked-by: Marcel Holtmann <marcel@holtmann.org>
      Signed-off-by: default avatarDominik Brodowski <linux@dominikbrodowski.net>
      5fa9167a
  16. 09 Nov, 2009 1 commit
  17. 15 Sep, 2009 2 commits
  18. 19 Jun, 2009 4 commits
  19. 03 Apr, 2009 2 commits