1. 26 Aug, 2007 1 commit
  2. 24 Jul, 2007 1 commit
    • Alexander Shmelev's avatar
      [SPARC32]: Fix bug in sparc optimized memset. · f61698e6
      Alexander Shmelev authored
      
      
      Sparc optimized memset (arch/sparc/lib/memset.S) does not fill last
      byte of the memory area, if area size is less than 8 bytes and start
      address is not word (4-bytes) aligned.
      
      Here is code chunk where bug located:
      /* %o0 - memory address, %o1 - size, %g3 - value */
      8:
           add    %o0, 1, %o0
          subcc    %o1, 1, %o1
          bne,a    8b
           stb %g3, [%o0 - 1]
      
      This code should write byte every loop iteration, but last time delay
      instruction stb is not executed because branch instruction sets
      "annul" bit.
      
      Patch replaces bne,a by bne instruction.
      
      Error can be reproduced by simple kernel module:
      
      --------------------
      #include <linux/module.h>
      #include <linux/config.h>
      #include <linux/kernel.h>
      #include <linux/errno.h>
      #include <string.h>
      
      static void do_memset(void **p, int size)
      {
              memset(p, 0x00, size);
      }
      
      static int __init memset_test_init(void)
      {
          char fooc[8];
          int *fooi;
          memset(fooc, 0xba, sizeof(fooc));
      
          do_memset((void**)(fooc + 3), 1);
      
          fooi = (int*) fooc;
          printk("%08X %08X\n", fooi[0], fooi[1]);
      
          return -1;
      }
      
      static void __exit memset_test_cleanup(void)
      {
          return;
      }
      
      module_init(memset_test_init);
      module_exit(memset_test_cleanup);
      
      MODULE_LICENSE("GPL");
      EXPORT_NO_SYMBOLS;
      --------------------
      Signed-off-by: default avatarAlexander Shmelev <ashmelev@task.sun.mcst.ru>
      Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
      f61698e6
  3. 31 May, 2007 1 commit
  4. 29 May, 2007 1 commit
  5. 08 May, 2007 1 commit
  6. 26 Mar, 2007 1 commit
  7. 17 Dec, 2006 1 commit
  8. 08 Oct, 2006 1 commit
    • Al Viro's avatar
      [PATCH] sparc32 rwlock fix · 7a39f522
      Al Viro authored
      
      
      read_trylock() is broken on sparc32 (doesn't build and didn't work
      right, actually).  Proposed fix:
      
       - make "writer holds lock" distinguishable from "reader tries to grab
         lock"
      
       - have __raw_read_trylock() try to acquire the mutex (in LSB of lock),
         terminating spin if we see that there's writer holding it.  Then do
         the rest as we do in read_lock().
      
      Thanks to Ingo for discussion...
      Signed-off-by: default avatarAl Viro <viro@zeniv.linux.org.uk>
      Signed-off-by: default avatarLinus Torvalds <torvalds@osdl.org>
      7a39f522
  9. 29 Sep, 2006 1 commit
  10. 30 Jun, 2006 1 commit
  11. 26 Jun, 2006 1 commit
  12. 12 Dec, 2005 1 commit
  13. 13 Nov, 2005 3 commits
  14. 11 Sep, 2005 1 commit
  15. 10 Sep, 2005 1 commit
    • Ingo Molnar's avatar
      [PATCH] spinlock consolidation · fb1c8f93
      Ingo Molnar authored
      
      
      This patch (written by me and also containing many suggestions of Arjan van
      de Ven) does a major cleanup of the spinlock code.  It does the following
      things:
      
       - consolidates and enhances the spinlock/rwlock debugging code
      
       - simplifies the asm/spinlock.h files
      
       - encapsulates the raw spinlock type and moves generic spinlock
         features (such as ->break_lock) into the generic code.
      
       - cleans up the spinlock code hierarchy to get rid of the spaghetti.
      
      Most notably there's now only a single variant of the debugging code,
      located in lib/spinlock_debug.c.  (previously we had one SMP debugging
      variant per architecture, plus a separate generic one for UP builds)
      
      Also, i've enhanced the rwlock debugging facility, it will now track
      write-owners.  There is new spinlock-owner/CPU-tracking on SMP builds too.
      All locks have lockup detection now, which will work for both soft and hard
      spin/rwlock lockups.
      
      The arch-level include files now only contain the minimally necessary
      subset of the spinlock code - all the rest that can be generalized now
      lives in the generic headers:
      
       include/asm-i386/spinlock_types.h       |   16
       include/asm-x86_64/spinlock_types.h     |   16
      
      I have also split up the various spinlock variants into separate files,
      making it easier to see which does what. The new layout is:
      
         SMP                         |  UP
         ----------------------------|-----------------------------------
         asm/spinlock_types_smp.h    |  linux/spinlock_types_up.h
         linux/spinlock_types.h      |  linux/spinlock_types.h
         asm/spinlock_smp.h          |  linux/spinlock_up.h
         linux/spinlock_api_smp.h    |  linux/spinlock_api_up.h
         linux/spinlock.h            |  linux/spinlock.h
      
      /*
       * here's the role of the various spinlock/rwlock related include files:
       *
       * on SMP builds:
       *
       *  asm/spinlock_types.h: contains the raw_spinlock_t/raw_rwlock_t and the
       *                        initializers
       *
       *  linux/spinlock_types.h:
       *                        defines the generic type and initializers
       *
       *  asm/spinlock.h:       contains the __raw_spin_*()/etc. lowlevel
       *                        implementations, mostly inline assembly code
       *
       *   (also included on UP-debug builds:)
       *
       *  linux/spinlock_api_smp.h:
       *                        contains the prototypes for the _spin_*() APIs.
       *
       *  linux/spinlock.h:     builds the final spin_*() APIs.
       *
       * on UP builds:
       *
       *  linux/spinlock_type_up.h:
       *                        contains the generic, simplified UP spinlock type.
       *                        (which is an empty structure on non-debug builds)
       *
       *  linux/spinlock_types.h:
       *                        defines the generic type and initializers
       *
       *  linux/spinlock_up.h:
       *                        contains the __raw_spin_*()/etc. version of UP
       *                        builds. (which are NOPs on non-debug, non-preempt
       *                        builds)
       *
       *   (included on UP-non-debug builds:)
       *
       *  linux/spinlock_api_up.h:
       *                        builds the _spin_*() APIs.
       *
       *  linux/spinlock.h:     builds the final spin_*() APIs.
       */
      
      All SMP and UP architectures are converted by this patch.
      
      arm, i386, ia64, ppc, ppc64, s390/s390x, x64 was build-tested via
      crosscompilers.  m32r, mips, sh, sparc, have not been tested yet, but should
      be mostly fine.
      
      From: Grant Grundler <grundler@parisc-linux.org>
      
        Booted and lightly tested on a500-44 (64-bit, SMP kernel, dual CPU).
        Builds 32-bit SMP kernel (not booted or tested).  I did not try to build
        non-SMP kernels.  That should be trivial to fix up later if necessary.
      
        I converted bit ops atomic_hash lock to raw_spinlock_t.  Doing so avoids
        some ugly nesting of linux/*.h and asm/*.h files.  Those particular locks
        are well tested and contained entirely inside arch specific code.  I do NOT
        expect any new issues to arise with them.
      
       If someone does ever need to use debug/metrics with them, then they will
        need to unravel this hairball between spinlocks, atomic ops, and bit ops
        that exist only because parisc has exactly one atomic instruction: LDCW
        (load and clear word).
      
      From: "Luck, Tony" <tony.luck@intel.com>
      
         ia64 fix
      Signed-off-by: default avatarIngo Molnar <mingo@elte.hu>
      Signed-off-by: default avatarArjan van de Ven <arjanv@infradead.org>
      Signed-off-by: default avatarGrant Grundler <grundler@parisc-linux.org>
      Cc: Matthew Wilcox <willy@debian.org>
      Signed-off-by: default avatarHirokazu Takata <takata@linux-m32r.org>
      Signed-off-by: default avatarMikael Pettersson <mikpe@csd.uu.se>
      Signed-off-by: default avatarBenoit Boissinot <benoit.boissinot@ens-lyon.org>
      Signed-off-by: default avatarAndrew Morton <akpm@osdl.org>
      Signed-off-by: default avatarLinus Torvalds <torvalds@osdl.org>
      fb1c8f93
  16. 09 Sep, 2005 1 commit
  17. 16 Apr, 2005 1 commit
    • Linus Torvalds's avatar
      Linux-2.6.12-rc2 · 1da177e4
      Linus Torvalds authored
      Initial git repository build. I'm not bothering with the full history,
      even though we have it. We can create a separate "historical" git
      archive of that later if we want to, and in the meantime it's about
      3.2GB when imported into git - space that would just make the early
      git days unnecessarily complicated, when we don't have a lot of good
      infrastructure for it.
      
      Let it rip!
      1da177e4