1. 02 May, 2012 3 commits
  2. 27 Apr, 2012 1 commit
  3. 14 Apr, 2012 2 commits
    • Bruce Allan's avatar
      e1000e: cleanup boolean logic · 04499ec4
      Bruce Allan authored
      Replace occurrences of 'if (<bool expr> == <1|0>)' with
      'if ([!]<bool expr>)'
      Replace occurrences of '<bool var> = (<non-bool expr>) ? true : false'
      with '<bool var> = <non-bool expr>'.
      Replace occurrence of '<bool var> = <non-bool expr>' with
      '<bool var> = !!<non-bool expr>'
      While the latter replacement is not really necessary, it is done here for
      consistency and clarity.  No functional changes.
      Signed-off-by: default avatarBruce Allan <bruce.w.allan@intel.com>
      Tested-by: default avatarAaron Brown <aaron.f.brown@intel.com>
      Signed-off-by: default avatarJeff Kirsher <jeffrey.t.kirsher@intel.com>
    • Bruce Allan's avatar
      e1000e: issues in Sx on 82577/8/9 · 92fe1733
      Bruce Allan authored
      A workaround was previously put in the driver to reset the device when
      transitioning to Sx in order to activate the changed settings of the PHY
      OEM bits (Low Power Link Up, or LPLU, and GbE disable configuration) for
      82577/8/9 devices.  After further review, it was found such a reset can
      cause the 82579 to confuse which version of 82579 it actually is and broke
      LPLU on all 82577/8/9 devices.  The workaround during an S0->Sx transition
      on 82579 (instead of resetting the PHY) is to restart auto-negotiation
      after the OEM bits are configured; the restart of auto-negotiation
      activates the new OEM bits as does the reset.  With 82577/8, the reset is
      changed to a generic reset which fixes the LPLU bits getting set wrong.
      Signed-off-by: default avatarBruce Allan <bruce.w.allan@intel.com>
      Tested-by: default avatarAaron Brown <aaron.f.brown@intel.com>
      Signed-off-by: default avatarJeff Kirsher <jeffrey.t.kirsher@intel.com>
  4. 01 Mar, 2012 1 commit
  5. 24 Feb, 2012 7 commits
  6. 13 Feb, 2012 9 commits
  7. 10 Feb, 2012 2 commits
  8. 07 Feb, 2012 2 commits
  9. 26 Jan, 2012 9 commits
  10. 02 Nov, 2011 1 commit
  11. 16 Oct, 2011 1 commit
    • Bruce Allan's avatar
      e1000e: locking bug introduced by commit 67fd4fcb · a90b412c
      Bruce Allan authored
      Commit 67fd4fcb
       (e1000e: convert to stats64) added the ability to update
      statistics more accurately and on-demand through the net_device_ops
      .ndo_get_stats64 hook, but introduced a locking bug on 82577/8/9 when
      linked at half-duplex (seen on kernels with CONFIG_DEBUG_ATOMIC_SLEEP=y and
      CONFIG_PROVE_LOCKING=y).  The commit introduced code paths that caused a
      mutex to be locked in atomic contexts, e.g. an rcu_read_lock is held when
      irqbalance reads the stats from /sys/class/net/ethX/statistics causing the
      mutex to be locked to read the Phy half-duplex statistics registers.
      The mutex was originally introduced to prevent concurrent accesses of
      resources (the NVM and Phy) shared by the driver, firmware and hardware
      a few years back when there was an issue with the NVM getting corrupted.
      It was later split into two mutexes - one for the NVM and one for the Phy
      when it was determined the NVM, unlike the Phy, should not be protected by
      the software/firmware/hardware semaphore (arbitration of which is done in
      part with the SWFLAG bit in the EXTCNF_CTRL register).  This latter
      semaphore should be sufficient to prevent resource contention of the Phy in
      the driver (i.e. the mutex for Phy accesses is not needed), but to be sure
      the mutex is replaced with an atomic bit flag which will warn if any
      contention is possible.
      Also add additional debug output to help determine when the sw/fw/hw
      semaphore is owned by the firmware or hardware.
      Signed-off-by: default avatarBruce Allan <bruce.w.allan@intel.com>
      Reported-by: default avatarFrancois Romieu <romieu@fr.zoreil.com>
      Tested-by: default avatarJeff Pieper <jeffrey.e.pieper@intel.com>
  12. 06 Oct, 2011 2 commits