1. 10 Jun, 2009 4 commits
  2. 09 Jun, 2009 1 commit
  3. 08 Jun, 2009 1 commit
  4. 23 May, 2009 5 commits
  5. 15 May, 2009 1 commit
    • Andrew Vasquez's avatar
      [SCSI] fc-transport: Close state transition-window during rport deletion. · 9a1a69a1
      Andrew Vasquez authored
      
      
      Andrew Vasquez wrote:
      > fc-transport: Close state transition-window during rport deletion.
      >
      > After an rport's state has transitioned to FC_PORTSTATE_BLOCKED,
      > but, prior to making the upcall to 'block' the scsi-target
      > associated with an rport, queued commands can recycle and
      > ultimately run out of retries causing failures to propagate to
      > upper-level drivers.  Close this transition-window by returning
      > the non-'retries' modifying DID_IMM_RETRY status for submitted
      > I/Os.
      
      The same can happen for iscsi when transitioning from logged in
      to failed and blocking the sdevs.
      
      This patch converts iscsi and fc's transitions back to use DID_IMM_RETRY
      instead of DID_TRANSPORT_DISRUPTED which has a limited number of retries
      that we do not want to use for handling this race.
      Signed-off-by: default avatarAndrew Vasquez <andrew.vasquez@qlogic.com>
      [Addition of iscsi and fc port online devloss case conversion by Mike Christie]
      Signed-off-by: default avatarMike Christie <michaelc@cs.wisc.edu>
      Signed-off-by: default avatarJames Bottomley <James.Bottomley@HansenPartnership.com>
      9a1a69a1
  6. 27 Apr, 2009 6 commits
    • Boaz Harrosh's avatar
      [SCSI] libosd: OSD2r05: on-the-wire changes for latest OSD2 revision 5. · e9da4d7f
      Boaz Harrosh authored
      OSC's OSD2 target: [git clone git://git.open-osd.org/osc-osd/
      
       master]
      (Initiator code prior to this patch must use: "git checkout CDB_VER_OSD2r01"
       in the target tree above)
      
      This is a summery of the wire changes:
      
       * OSDv2_ADDITIONAL_CDB_LENGTH == 192 => 228 (Total CDB is now 236 bytes)
       * Attributes List Element Header grew, so attribute values are 8 bytes
         aligned.
       * Cryptographic keys and signatures are 20 => 32
       * Few new definitions.
      
      (Still missing new standard definitions attribute values, these do not change
       wire format and will be added later when needed)
      Signed-off-by: default avatarBoaz Harrosh <bharrosh@panasas.com>
      Signed-off-by: default avatarJames Bottomley <James.Bottomley@HansenPartnership.com>
      e9da4d7f
    • Boaz Harrosh's avatar
      [SCSI] libosd: OSD2r05: OSD_CRYPTO_KEYID_SIZE will grow 20 => 32 bytes · f8d3a644
      Boaz Harrosh authored
      
      
      In OSD2r04 draft, cryptographic key size changed to 32 bytes from
      OSD1's 20 bytes. This causes a couple of on-the-wire structures
      to change, including the CDB.
      
      In this patch the OSD1/OSD2 handling is separated out in regard
      to affected structures, but on-the-wire is still the same. All
      on the wire changes will be submitted in one patch for bisect-ability.
      Signed-off-by: default avatarBoaz Harrosh <bharrosh@panasas.com>
      Signed-off-by: default avatarJames Bottomley <James.Bottomley@HansenPartnership.com>
      f8d3a644
    • Boaz Harrosh's avatar
      [SCSI] libosd: OSD2r05: Prepare for rev5 attribute list changes · 71f32e31
      Boaz Harrosh authored
      
      
      In OSD2r05 draft each attribute list element header was changed
      so attribute-value would be 8 bytes aligned. In OSD2r01-r04
      it was aligned on 2 bytes. (This is because in OSD2r01 the complete
      element was 8 bytes padded at end but the header was not adjusted
      and caused permanent miss-alignment.)
      
      OSD1 elements are not padded and might be or might not be aligned.
      OSD1 is still supported.
      
      In this code we do all the code re-factoring to separate OSD1/OSD2
      differences but do not change actual wire format. All wire format
      changes will happen in one patch later, for bisect-ability.
      Signed-off-by: default avatarBoaz Harrosh <bharrosh@panasas.com>
      Signed-off-by: default avatarJames Bottomley <James.Bottomley@HansenPartnership.com>
      71f32e31
    • Robert Love's avatar
      [SCSI] libfc: Fix compilation warnings with allmodconfig · a29e7646
      Robert Love authored
      
      
      When building with a .config generated from 'make allmodconfig'
      some build warnings are generated. This patch corrects the warnings,
      adds a FC_FID_NONE (= 0) enumeration for FC-IDs and cleans up one
      variable naming to meet our variable naming conventions. For example,
      fc_lport's should be named "lport," not "lp."
      Signed-off-by: default avatarRobert Love <robert.w.love@intel.com>
      Signed-off-by: default avatarJames Bottomley <James.Bottomley@HansenPartnership.com>
      a29e7646
    • Abhijeet Joglekar's avatar
      [SCSI] libfc: Track rogue remote ports · b4c6f546
      Abhijeet Joglekar authored
      
      
      Rogue ports are currently not tracked on any list. The only reference
      to them is through any outstanding exchanges pending on the rogue ports.
      If the module is removed while a retry is set on a rogue port
      (say a Plogi retry for instance), this retry is not cancelled because there
      is no reference to the rogue port in the discovery rports list. Thus the
      local port can clean itself up, delete the exchange pool, and then the
      rogue port timeout can fire and try to start up another exchange.
      
      This patch tracks the rogue ports in a new list disc->rogue_rports. Creating
      a new list instead of using the disc->rports list keeps remote port code
      change to a minimum.
      
      1)  Whenever a rogue port is created, it is immediately added to the
      disc->rogue_rports list.
      
      2) When the rogues port goes to ready, it is removed from the rogue list
      and the real remote port is added to the disc->rports list
      
      3) The removal of the rogue from the disc->rogue_rports list is done in
      the context of the fc_rport_work() workQ thread in discovery callback.
      
      4) Real rports are removed from the disc->rports list like before. Lookup
      is done only in the real rports list. This avoids making large changes
      to the remote port code.
      
      5) In fc_disc_stop_rports, the rogues list is traversed in addition to the
      real list to stop the rogue ports and issue logoffs on them. This way, rogue
      ports get cleaned up when the local port goes away.
      
      6) rogue remote ports are not removed from the list right away, but
      removed late in fc_rport_work() context, multiple threads can find the same
      remote port in the list and call rport_logoff(). Rport_logoff() only
      continues with the logoff if port is not in NONE state, thus preventing
      multiple logoffs and multiple list deletions.
      
      7) Since the rport is removed from the disc list at a later stage
      (in the disc callback), incoming frames can find the rport even if
      rport_logoff() has been called on the rport. When rport_logoff() is called,
      the rport state is set to NONE, and we are trying to cancel all exchanges
      and retries on that port. While in this state, if an incoming
      Plogi/Prli/Logo or other frames match the rport, we should not reply
      because the rport is in the NONE state. Just drop the frame, since the
      rport will be deleted soon in the disc callback (fc_rport_work)
      
      8)  In fc_disc_single(), remove rport lookup and call to fc_disc_del_target.
      fc_disc_single() is called from recv_rscn_req() where rport lookup
      and rport_logoff is already done.
      Signed-off-by: default avatarAbhijeet Joglekar <abjoglek@cisco.com>
      Signed-off-by: default avatarRobert Love <robert.w.love@intel.com>
      Signed-off-by: default avatarJames Bottomley <James.Bottomley@HansenPartnership.com>
      b4c6f546
    • Mike Christie's avatar
      [SCSI] cxgb3i, iser, iscsi_tcp: set target can queue · 6b5d6c44
      Mike Christie authored
      
      
      Set target can queue limit to the number of preallocated
      session tasks we have.
      
      This along with the cxgb3i can_queue patch will fix a throughput
      problem where it could only queue one LU worth of data at a time.
      Signed-off-by: default avatarMike Christie <michaelc@cs.wisc.edu>
      Signed-off-by: default avatarJames Bottomley <James.Bottomley@HansenPartnership.com>
      6b5d6c44
  7. 13 Apr, 2009 1 commit
  8. 03 Apr, 2009 10 commits
  9. 13 Mar, 2009 10 commits
  10. 12 Mar, 2009 1 commit