1. 18 Dec, 2008 3 commits
    • Baruch Siach's avatar
      enc28j60: reduce the number of spi transfers in enc28j60_set_bank() · 5664dd55
      Baruch Siach authored
      A major source of overhead in the enc28j60 driver is the SPI transfers. Each
      SPI transfer entails two kernel thread context switches. One major source of
      SPI transfers is the enc28j60_set_bank() functions which runs before every
      register access. This patch reduces the number of SPI transfers that
      enc28j60_set_bank() performs in two ways:
        1. removes unnecessary bank switch for the registers that are present in all
        2. when switching from banks 0 or 3 to banks 1 or 2 (i.e. only one bit
      	 changes) enc28j60_set_bank() does only one SPI transfer instead of two
      According to my tests these changes reduce the number of SPI transfers in
      about 25%.
      Signed-off-by: default avatarBaruch Siach <baruch@tkos.co.il>
      Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
    • Wang Chen's avatar
      netdevice zd1201: Use after free · b88a2a22
      Wang Chen authored
      | commit 3d29b0c3
      | Author: John W. Linville <linville@tuxdriver.com>
      | Date:   Fri Oct 31 14:13:12 2008 -0400
      |     netdevice zd1201: Convert directly reference of netdev->priv to netdev_priv()
      |     We have some reasons to kill netdev->priv:
      |     1. netdev->priv is equal to netdev_priv().
      |     2. netdev_priv() wraps the calculation of netdev->priv's offset, obviously
      |        netdev_priv() is more flexible than netdev->priv.
      |     But we cann't kill netdev->priv, because so many drivers reference to it
      |     directly.
      |     OK, becasue Dave S. Miller said, "every direct netdev->priv usage is a bug",
      |     and I want to kill netdev->priv later, I decided to convert all the direct
      |     reference of netdev->priv first.
      |     (Original patch posted by Wang Chen <wangchen@cn.fujitsu.com> w/ above
      |     changelog but using dev->ml_priv.  That doesn't seem appropriate
      |     to me for this driver, so I've revamped it to use netdev_priv()
      |     instead. -- JWL)
      This commit changed the allocation of netdev, but didn't change
      the free method of it.
      This causes "zd" be used after the memory, which is pointed by "zd", being
      freed by free_netdev().
      Signed-off-by: default avatarWang Chen <wangchen@cn.fujitsu.com>
      Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
    • David S. Miller's avatar
  2. 17 Dec, 2008 25 commits
  3. 16 Dec, 2008 12 commits