1. 10 Feb, 2008 17 commits
    • Andrew Morton's avatar
      via-velocity: section fix · 4f14b92f
      Andrew Morton authored
      
      
      From: Andrew Morton <akpm@linux-foundation.org>
      
      gcc-3.4.4 on powerpc:
      
      drivers/net/via-velocity.c:443: error: chip_info_table causes a section type conflict
      
      on this one I had to remove the __devinitdata too.  Don't know why.
      
      Cc: Jeff Garzik <jeff@garzik.org>
      Cc: Sam Ravnborg <sam@ravnborg.org>
      Signed-off-by: default avatarAndrew Morton <akpm@linux-foundation.org>
      Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
      4f14b92f
    • Andrew Morton's avatar
      natsemi: section fix · aa738adf
      Andrew Morton authored
      
      
      gcc-3.4.4 on powerpc:
      
      drivers/net/natsemi.c:245: error: natsemi_pci_info causes a section type conflict
      
      Cc: Jeff Garzik <jeff@garzik.org>
      Cc: Sam Ravnborg <sam@ravnborg.org>
      Signed-off-by: default avatarAndrew Morton <akpm@linux-foundation.org>
      Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
      aa738adf
    • Andrew Morton's avatar
      typhoon: section fix · 952b3494
      Andrew Morton authored
      
      
      gcc-3.4.4 on powerpc:
      
      drivers/net/typhoon.c:137: error: version causes a section type conflict
      
      Cc: Jeff Garzik <jeff@garzik.org>
      Cc: Sam Ravnborg <sam@ravnborg.org>
      Signed-off-by: default avatarAndrew Morton <akpm@linux-foundation.org>
      Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
      952b3494
    • Sam Ravnborg's avatar
      isdn: fix section mismatch warning for ISACVer · f4e64333
      Sam Ravnborg authored
      
      
      Fix following warnings:
      WARNING: drivers/isdn/hisax/built-in.o(.text+0x19723): Section mismatch in reference from the function ISACVersion() to the variable .devinit.data:ISACVer
      WARNING: drivers/isdn/hisax/built-in.o(.text+0x2005b): Section mismatch in reference from the function setup_avm_a1_pcmcia() to the function .devinit.text:setup_isac()
      
      ISACVer were only used from function annotated __devinit
      so add same annotation to ISACVer.
      One af the fererencing functions missed __devinit so add it
      and kill an additional warning.
      Signed-off-by: default avatarSam Ravnborg <sam@ravnborg.org>
      Acked-by: default avatarKarsten Keil <kkeil@suse.de>
      Cc: Jeff Garzik <jgarzik@pobox.com>
      Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
      f4e64333
    • Sam Ravnborg's avatar
      isdn: fix section mismatch warnings from hisax_cs_setup_card · 2fddb6e2
      Sam Ravnborg authored
      
      
      Fix the following warnings:
      WARNING: drivers/isdn/hisax/built-in.o(.text+0x722): Section mismatch in reference from the function hisax_cs_setup_card() to the function .devinit.text:setup_teles3()
      WARNING: drivers/isdn/hisax/built-in.o(.text+0x72c): Section mismatch in reference from the function hisax_cs_setup_card() to the function .devinit.text:setup_s0box()
      WARNING: drivers/isdn/hisax/built-in.o(.text+0x736): Section mismatch in reference from the function hisax_cs_setup_card() to the function .devinit.text:setup_telespci()
      WARNING: drivers/isdn/hisax/built-in.o(.text+0x747): Section mismatch in reference from the function hisax_cs_setup_card() to the function .devinit.text:setup_avm_pcipnp()
      WARNING: drivers/isdn/hisax/built-in.o(.text+0x74e): Section mismatch in reference from the function hisax_cs_setup_card() to the function .devinit.text:setup_elsa()
      WARNING: drivers/isdn/hisax/built-in.o(.text+0x755): Section mismatch in reference from the function hisax_cs_setup_card() to the function .devinit.text:setup_diva()
      WARNING: drivers/isdn/hisax/built-in.o(.text+0x75c): Section mismatch in reference from the function hisax_cs_setup_card() to the function .devinit.text:setup_sedlbauer()
      WARNING: drivers/isdn/hisax/built-in.o(.text+0x763): Section mismatch in reference from the function hisax_cs_setup_card() to the function .devinit.text:setup_netjet_s()
      WARNING: drivers/isdn/hisax/built-in.o(.text+0x76a): Section mismatch in reference from the function hisax_cs_setup_card() to the function .devinit.text:setup_hfcpci()
      WARNING: drivers/isdn/hisax/built-in.o(.text+0x771): Section mismatch in reference from the function hisax_cs_setup_card() to the function .devinit.text:setup_hfcsx()
      WARNING: drivers/isdn/hisax/built-in.o(.text+0x778): Section mismatch in reference from the function hisax_cs_setup_card() to the function .devinit.text:setup_niccy()
      WARNING: drivers/isdn/hisax/built-in.o(.text+0x77f): Section mismatch in reference from the function hisax_cs_setup_card() to the function .devinit.text:setup_bkm_a4t()
      WARNING: drivers/isdn/hisax/built-in.o(.text+0x786): Section mismatch in reference from the function hisax_cs_setup_card() to the function .devinit.text:setup_sct_quadro()
      WARNING: drivers/isdn/hisax/built-in.o(.text+0x78d): Section mismatch in reference from the function hisax_cs_setup_card() to the function .devinit.text:setup_gazel()
      WARNING: drivers/isdn/hisax/built-in.o(.text+0x794): Section mismatch in reference from the function hisax_cs_setup_card() to the function .devinit.text:setup_w6692()
      WARNING: drivers/isdn/hisax/built-in.o(.text+0x79b): Section mismatch in reference from the function hisax_cs_setup_card() to the function .devinit.text:setup_netjet_u()
      WARNING: drivers/isdn/hisax/built-in.o(.text+0x7a2): Section mismatch in reference from the function hisax_cs_setup_card() to the function .devinit.text:setup_enternow_pci()
      
      checkcard() are the only user of hisax_cs_setup_card().
      And checkcard is only used during init or when hot plugging
      ISDN devices. So annotate hisax_cs_setup_card() with __devinit.
      checkcard() is used by exported functions so it cannot be
      annotated __devinit. Annotate it with __ref so modpost
      ignore references to _devinit section.
      Signed-off-by: default avatarSam Ravnborg <sam@ravnborg.org>
      Acked-by: default avatarKarsten Keil <kkeil@suse.de>
      Cc: Jeff Garzik <jgarzik@pobox.com>
      Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
      2fddb6e2
    • Sam Ravnborg's avatar
      isdn: fix section mismatch warnings in isac.c and isar.c · d348c2a3
      Sam Ravnborg authored
      
      
      Fix the following warnings:
      WARNING: drivers/isdn/hisax/built-in.o(.text+0x1b276): Section mismatch in reference from the function inithscxisac() to the function .devinit.text:clear_pending_isac_ints()
      WARNING: drivers/isdn/hisax/built-in.o(.text+0x1b286): Section mismatch in reference from the function inithscxisac() to the function .devinit.text:initisac()
      WARNING: drivers/isdn/hisax/built-in.o(.text+0x1fec7): Section mismatch in reference from the function AVM_card_msg() to the function .devinit.text:clear_pending_isac_ints()
      WARNING: drivers/isdn/hisax/built-in.o(.text+0x21669): Section mismatch in reference from the function AVM_card_msg() to the function .devinit.text:clear_pending_isac_ints()
      WARNING: drivers/isdn/hisax/built-in.o(.text+0x21671): Section mismatch in reference from the function AVM_card_msg() to the function .devinit.text:initisac()
      WARNING: drivers/isdn/hisax/built-in.o(.text+0x2991e): Section mismatch in reference from the function Sedl_card_msg() to the function .devinit.text:clear_pending_isac_ints()
      WARNING: drivers/isdn/hisax/built-in.o(.text+0x29936): Section mismatch in reference from the function Sedl_card_msg() to the function .devinit.text:initisac()
      WARNING: drivers/isdn/hisax/built-in.o(.text+0x2993e): Section mismatch in reference from the function Sedl_card_msg() to the function .devinit.text:initisar()
      WARNING: drivers/isdn/hisax/built-in.o(.text+0x2e026): Section mismatch in reference from the function NETjet_S_card_msg() to the function .devinit.text:clear_pending_isac_ints()
      WARNING: drivers/isdn/hisax/built-in.o(.text+0x2e02e): Section mismatch in reference from the function NETjet_S_card_msg() to the function .devinit.text:initisac()
      WARNING: drivers/isdn/hisax/built-in.o(.text+0x37813): Section mismatch in reference from the function BKM_card_msg() to the function .devinit.text:clear_pending_isac_ints()
      WARNING: drivers/isdn/hisax/built-in.o(.text+0x37823): Section mismatch in reference from the function BKM_card_msg() to the function .devinit.text:initisac()
      
      initisar(), initisac() and clear_pending_isac_ints()
      were all used via a cardmsg fnction - which may be called
      ouside __devinit context.
      So remove the bogus __devinit annotation of the
      above three functions to fix the warnings.
      Signed-off-by: default avatarSam Ravnborg <sam@ravnborg.org>
      Acked-by: default avatarKarsten Keil <kkeil@suse.de>
      Cc: Jeff Garzik <jgarzik@pobox.com>
      Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
      d348c2a3
    • Sam Ravnborg's avatar
      isdn: fix section mismatch warning in hfc_sx.c · 7740ac6a
      Sam Ravnborg authored
      
      
      Fix the following warning:
      WARNING: drivers/isdn/hisax/built-in.o(.text+0x35818): Section mismatch in reference from the function hfcsx_card_msg() to the function .devinit.text:inithfcsx()
      
      hfcsx_card_msg() may be called outside __devinit context.
      Following the program logic is looks like the CARD_INIT branch
      will only be taken under __devinit context but to be consistent
      remove the __devinit annotation of inithfcsx() so we
      do not mix non-__devinit and __devinit code.
      Signed-off-by: default avatarSam Ravnborg <sam@ravnborg.org>
      Acked-by: default avatarKarsten Keil <kkeil@suse.de>
      Cc: Jeff Garzik <jgarzik@pobox.com>
      Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
      7740ac6a
    • Stephen Hemminger's avatar
      [PKT_SCHED] ematch: tcf_em_destroy robustness · 954415e3
      Stephen Hemminger authored
      
      
      Make the code in tcf_em_tree_destroy more robust and cleaner:
       * Don't need to cast pointer to kfree() or avoid passing NULL.
       * After freeing the tree, clear the pointer to avoid possible problems
      from repeated free.
      Signed-off-by: default avatarStephen Hemminger <shemminger@vyatta.com>
      Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
      954415e3
    • Stephen Hemminger's avatar
      [PKT_SCHED]: deinline functions in meta match · ed7af3b3
      Stephen Hemminger authored
      
      
      A couple of functions in meta match don't need to be inline.
      Signed-off-by: default avatarStephen Hemminger <shemminger@vyatta.com>
      Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
      ed7af3b3
    • Pavel Emelyanov's avatar
      [SCTP]: Convert sctp_dbg_objcnt to seq files. · 8ff65b46
      Pavel Emelyanov authored
      
      
      This makes the code use a good proc API and the text ~50 bytes shorter.
      Signed-off-by: default avatarPavel Emelyanov <xemul@openvz.org>
      Acked-by: default avatarVlad Yasevich <vladislav.yasevich@hp.com>
      Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
      8ff65b46
    • Pavel Emelyanov's avatar
      [SCTP]: Use snmp_fold_field instead of a homebrew analogue. · 3f5340a6
      Pavel Emelyanov authored
      
      
      SCPT already depends in INET, so this doesn't create additional
      dependencies.
      Signed-off-by: default avatarPavel Emelyanov <xemul@openvz.org>
      Acked-by: default avatarVlad Yasevich <vladislav.yasevich@hp.com>
      Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
      3f5340a6
    • Denis V. Lunev's avatar
      [IGMP]: Optimize kfree_skb in igmp_rcv. · cd557bc1
      Denis V. Lunev authored
      
      
      Merge error paths inside igmp_rcv.
      Signed-off-by: default avatarDenis V. Lunev <den@openvz.org>
      Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
      cd557bc1
    • Pavel Emelyanov's avatar
      [KEY]: Convert net/pfkey to use seq files. · bd2f7476
      Pavel Emelyanov authored
      
      
      The seq files API disposes the caller of the difficulty of
      checking file position, the length of data to produce and
      the size of provided buffer.
      Signed-off-by: default avatarPavel Emelyanov <xemul@openvz.org>
      Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
      bd2f7476
    • Pavel Emelyanov's avatar
      [KEY]: Clean up proc files creation a bit. · 61145aa1
      Pavel Emelyanov authored
      
      
      Mainly this removes ifdef-s from inside the ipsec_pfkey_init.
      Signed-off-by: default avatarPavel Emelyanov <xemul@openvz.org>
      Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
      61145aa1
    • Andrew Morton's avatar
      pppol2tp: fix printk warnings · 0efeaa33
      Andrew Morton authored
      
      
      drivers/net/pppol2tp.c: In function `pppol2tp_seq_tunnel_show':
      drivers/net/pppol2tp.c:2295: warning: long long unsigned int format, __u64 arg (arg 4)
      drivers/net/pppol2tp.c:2295: warning: long long unsigned int format, __u64 arg (arg 5)
      drivers/net/pppol2tp.c:2295: warning: long long unsigned int format, __u64 arg (arg 6)
      drivers/net/pppol2tp.c:2295: warning: long long unsigned int format, __u64 arg (arg 7)
      drivers/net/pppol2tp.c:2295: warning: long long unsigned int format, __u64 arg (arg 8)
      drivers/net/pppol2tp.c:2295: warning: long long unsigned int format, __u64 arg (arg 9)
      drivers/net/pppol2tp.c: In function `pppol2tp_seq_session_show':
      drivers/net/pppol2tp.c:2328: warning: long long unsigned int format, __u64 arg (arg 5)
      drivers/net/pppol2tp.c:2328: warning: long long unsigned int format, __u64 arg (arg 6)
      drivers/net/pppol2tp.c:2328: warning: long long unsigned int format, __u64 arg (arg 7)
      drivers/net/pppol2tp.c:2328: warning: long long unsigned int format, __u64 arg (arg 8)
      drivers/net/pppol2tp.c:2328: warning: long long unsigned int format, __u64 arg (arg 9)
      drivers/net/pppol2tp.c:2328: warning: long long unsigned int format, __u64 arg (arg 10)
      
      Not all platforms implement u64 with unsigned long long.  eg: powerpc.
      
      Cc: Jeff Garzik <jeff@garzik.org>
      Signed-off-by: default avatarAndrew Morton <akpm@linux-foundation.org>
      Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
      0efeaa33
    • Andrew Morton's avatar
      bnx2: section fix · fefa8645
      Andrew Morton authored
      
      
      gcc-3.4.4 on powerpc:
      
      drivers/net/bnx2.c:67: error: version causes a section type conflict
      
      Cc: Jeff Garzik <jeff@garzik.org>
      Cc: Sam Ravnborg <sam@ravnborg.org>
      Signed-off-by: default avatarAndrew Morton <akpm@linux-foundation.org>
      Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
      fefa8645
    • Andrew Morton's avatar
      bnx2x: section fix · 53a10565
      Andrew Morton authored
      
      
      From: Andrew Morton <akpm@linux-foundation.org>
      
      gcc-3.4.4 on powerpc:
      
      drivers/net/bnx2x.c:73: error: version causes a section type conflict
      
      Cc: Jeff Garzik <jeff@garzik.org>
      Cc: Sam Ravnborg <sam@ravnborg.org>
      Signed-off-by: default avatarAndrew Morton <akpm@linux-foundation.org>
      Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
      53a10565
  2. 09 Feb, 2008 2 commits
    • Stephen Hemminger's avatar
      [PKT_SCHED] ematch: oops from uninitialized variable (resend) · 268bcca1
      Stephen Hemminger authored
      
      
      Setting up a meta match causes a kernel OOPS because of uninitialized
      elements in tree.
      
      [   37.322381] BUG: unable to handle kernel NULL pointer dereference at 0000000000000000
      [   37.322381] IP: [<ffffffff883fc717>] :em_meta:em_meta_destroy+0x17/0x80
      
      [   37.322381] Call Trace:
      [   37.322381]  [<ffffffff803ec83d>] tcf_em_tree_destroy+0x2d/0xa0
      [   37.322381]  [<ffffffff803ecc8c>] tcf_em_tree_validate+0x2dc/0x4a0
      [   37.322381]  [<ffffffff803f06d2>] nla_parse+0x92/0xe0
      [   37.322381]  [<ffffffff883f9672>] :cls_basic:basic_change+0x202/0x3c0
      [   37.322381]  [<ffffffff802a3917>] kmem_cache_alloc+0x67/0xa0
      [   37.322381]  [<ffffffff803ea221>] tc_ctl_tfilter+0x3b1/0x580
      [   37.322381]  [<ffffffff803dffd0>] rtnetlink_rcv_msg+0x0/0x260
      [   37.322381]  [<ffffffff803ee944>] netlink_rcv_skb+0x74/0xa0
      [   37.322381]  [<ffffffff803dffc8>] rtnetlink_rcv+0x18/0x20
      [   37.322381]  [<ffffffff803ee6c3>] netlink_unicast+0x263/0x290
      [   37.322381]  [<ffffffff803cf276>] __alloc_skb+0x96/0x160
      [   37.322381]  [<ffffffff803ef014>] netlink_sendmsg+0x274/0x340
      [   37.322381]  [<ffffffff803c7c3b>] sock_sendmsg+0x12b/0x140
      [   37.322381]  [<ffffffff8024de90>] autoremove_wake_function+0x0/0x30
      [   37.322381]  [<ffffffff8024de90>] autoremove_wake_function+0x0/0x30
      [   37.322381]  [<ffffffff803c7c3b>] sock_sendmsg+0x12b/0x140
      [   37.322381]  [<ffffffff80288611>] zone_statistics+0xb1/0xc0
      [   37.322381]  [<ffffffff803c7e5e>] sys_sendmsg+0x20e/0x360
      [   37.322381]  [<ffffffff803c7411>] sockfd_lookup_light+0x41/0x80
      [   37.322381]  [<ffffffff8028d04b>] handle_mm_fault+0x3eb/0x7f0
      [   37.322381]  [<ffffffff8020c2fb>] system_call_after_swapgs+0x7b/0x80
      Signed-off-by: default avatarStephen Hemminger <shemminger@vyatta.com>
      Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
      268bcca1
    • David S. Miller's avatar
  3. 08 Feb, 2008 21 commits