1. 23 Feb, 2011 1 commit
  2. 17 Feb, 2011 7 commits
  3. 24 Jan, 2011 2 commits
  4. 10 Dec, 2010 1 commit
  5. 06 Dec, 2010 1 commit
  6. 21 Oct, 2010 1 commit
  7. 11 Oct, 2010 1 commit
  8. 08 Oct, 2010 1 commit
  9. 21 Sep, 2010 2 commits
  10. 17 Sep, 2010 2 commits
  11. 15 Sep, 2010 1 commit
    • Ben Hutchings's avatar
      ethtool: Remove unimplemented flow specification types · e0de7c93
      Ben Hutchings authored
      
      
      struct ethtool_rawip4_spec and struct ethtool_ether_spec are neither
      commented nor used by any driver, so remove them.  Adjust padding in
      the user-visible unions that included these structures.
      
      Fix references to struct ethtool_rawip4_spec in
      ethtool_get_rx_ntuple(), which should use struct ethtool_usrip4_spec.
      
      struct ethtool_usrip4_spec cannot hold IPv6 host addresses and there
      is no separate structure that can, so remove ETH_RX_NFC_IP6 and the
      reference to it in niu.
      Signed-off-by: default avatarBen Hutchings <bhutchings@solarflare.com>
      Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
      e0de7c93
  12. 23 Aug, 2010 1 commit
    • stephen hemminger's avatar
      ethtool: allow non-netadmin to query settings · 0fdc100b
      stephen hemminger authored
      
      
      The SNMP daemon uses ethtool to determine the speed of
      network interfaces. This fails on Debian (and probably elsewhere)
      because for security SNMP daemon runs as non-root user (snmp).
      
      Note: A similar patch was rejected previously because of a concern about
      the possibility that on some hardware querying the ethtool settings
      requires access to the PHY and could slow the machine down.  But the
      security risk of requiring SNMP daemon (and related services)
      to run as root far out weighs the risk of denial-of-service.
      Signed-off-by: default avatarStephen Hemminger <shemminger@vyatta.com>
      Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
      0fdc100b
  13. 17 Aug, 2010 1 commit
  14. 30 Jun, 2010 2 commits
  15. 29 Jun, 2010 2 commits
  16. 17 May, 2010 1 commit
  17. 07 Apr, 2010 1 commit
  18. 31 Mar, 2010 1 commit
  19. 30 Mar, 2010 1 commit
    • Tejun Heo's avatar
      include cleanup: Update gfp.h and slab.h includes to prepare for breaking... · 5a0e3ad6
      Tejun Heo authored
      include cleanup: Update gfp.h and slab.h includes to prepare for breaking implicit slab.h inclusion from percpu.h
      
      percpu.h is included by sched.h and module.h and thus ends up being
      included when building most .c files.  percpu.h includes slab.h which
      in turn includes gfp.h making everything defined by the two files
      universally available and complicating inclusion dependencies.
      
      percpu.h -> slab.h dependency is about to be removed.  Prepare for
      this change by updating users of gfp and slab facilities include those
      headers directly instead of assuming availability.  As this conversion
      needs to touch large number of source files, the following script is
      used as the basis of conversion.
      
        http://userweb.kernel.org/~tj/misc/slabh-sweep.py
      
      The script does the followings.
      
      * Scan files for gfp and slab usages and update includes such that
        only the necessary includes are there.  ie. if only gfp is used,
        gfp.h, if slab is used, slab.h.
      
      * When the script inserts a new include, it looks at the include
        bloc...
      5a0e3ad6
  20. 08 Mar, 2010 1 commit
  21. 05 Mar, 2010 2 commits
    • Jeff Garzik's avatar
      ethtool: Add direct access to ops->get_sset_count · d17792eb
      Jeff Garzik authored
      
      
      On 03/04/2010 09:26 AM, Ben Hutchings wrote:
      > On Thu, 2010-03-04 at 00:51 -0800, Jeff Kirsher wrote:
      >> From: Jeff Garzik<jgarzik@redhat.com>
      >>
      >> This patch is an alternative approach for accessing string
      >> counts, vs. the drvinfo indirect approach.  This way the drvinfo
      >> space doesn't run out, and we don't break ABI later.
      > [...]
      >> --- a/net/core/ethtool.c
      >> +++ b/net/core/ethtool.c
      >> @@ -214,6 +214,10 @@ static noinline int ethtool_get_drvinfo(struct net_device *dev, void __user *use
      >>   	info.cmd = ETHTOOL_GDRVINFO;
      >>   	ops->get_drvinfo(dev,&info);
      >>
      >> +	/*
      >> +	 * this method of obtaining string set info is deprecated;
      >> +	 * consider using ETHTOOL_GSSET_INFO instead
      >> +	 */
      >
      > This comment belongs on the interface (ethtool.h) not the
      > implementation.
      
      Debatable -- the current comment is located at the callsite of
      ops->get_sset_count(), which is where an implementor might think to add
      a new call.  Not all the numeric fields in ethtool_drvinfo are obtained
      from ->get_sset_count().
      
      Hence the "some" in the attached patch to include/linux/ethtool.h,
      addressing your comment.
      
      > [...]
      >> +static noinline int ethtool_get_sset_info(struct net_device *dev,
      >> +                                          void __user *useraddr)
      >> +{
      > [...]
      >> +	/* calculate size of return buffer */
      >> +	for (i = 0; i<  64; i++)
      >> +		if (sset_mask&  (1ULL<<  i))
      >> +			n_bits++;
      > [...]
      >
      > We have a function for this:
      >
      > 	n_bits = hweight64(sset_mask);
      
      Agreed.
      
      I've attached a follow-up patch, which should enable my/Jeff's kernel
      patch to be applied, followed by this one.
      Signed-off-by: default avatarJeff Garzik <jgarzik@redhat.com>
      Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
      d17792eb
    • Jeff Garzik's avatar
      ethtool: Add direct access to ops->get_sset_count · 723b2f57
      Jeff Garzik authored
      
      
      This patch is an alternative approach for accessing string
      counts, vs. the drvinfo indirect approach.  This way the drvinfo
      space doesn't run out, and we don't break ABI later.
      Signed-off-by: default avatarJeff Garzik <jgarzik@redhat.com>
      Signed-off-by: default avatarPeter P Waskiewicz Jr <peter.p.waskiewicz.jr@intel.com>
      Signed-off-by: default avatarJeff Kirsher <jeffrey.t.kirsher@intel.com>
      Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
      723b2f57
  22. 28 Feb, 2010 1 commit
  23. 26 Feb, 2010 2 commits
  24. 17 Feb, 2010 1 commit
  25. 16 Feb, 2010 1 commit
  26. 15 Feb, 2010 2 commits