1. 09 Jun, 2009 2 commits
  2. 08 Jun, 2009 16 commits
  3. 07 Jun, 2009 3 commits
  4. 06 Jun, 2009 6 commits
  5. 05 Jun, 2009 12 commits
  6. 04 Jun, 2009 1 commit
    • Oleg Nesterov's avatar
      ptrace: revert "ptrace_detach: the wrong wakeup breaks the ERESTARTxxx logic" · edaba2c5
      Oleg Nesterov authored
      Commit 95a3540d
      
       ("ptrace_detach: the wrong
      wakeup breaks the ERESTARTxxx logic") removed the "extra"
      wake_up_process() from ptrace_detach(), but as Jan pointed out this breaks
      the compatibility.
      
      I believe the changelog is right and this wake_up() is wrong in many
      ways, but GDB assumes that ptrace(PTRACE_DETACH, child, 0, 0) always
      wakes up the tracee.
      
      Despite the fact this breaks SIGNAL_STOP_STOPPED/group_stop_count logic,
      and despite the fact this wake_up_process() can break another
      assumption: PTRACE_DETACH with SIGSTOP should leave the tracee in
      TASK_STOPPED case.  Because the untraced child can dequeue SIGSTOP and
      call do_signal_stop() before ptrace_detach() calls wake_up_process().
      
      Revert this change for now.  We need some fixes even if we we want to keep
      the current behaviour, but these fixes are not for 2.6.30.
      
      Signed-off-by: default avatarOleg Nesterov <oleg@redhat.com>
      Acked-by: default avatarRoland McGrath <roland@redhat.com>
      Cc: Jan Kratochvil <jan.kratochvil@redhat.com>
      Cc: Denys Vlasenko <dvlasenk@redhat.com>
      Signed-off-by: default avatarAndrew Morton <akpm@linux-foundation.org>
      Signed-off-by: default avatarLinus Torvalds <torvalds@linux-foundation.org>
      edaba2c5