1. 12 Jun, 2008 1 commit
    • David S. Miller's avatar
      net: Eliminate flush_scheduled_work() calls while RTNL is held. · 4bb073c0
      David S. Miller authored
      If the RTNL is held when we invoke flush_scheduled_work() we could
      deadlock.  One such case is linkwatch, it is a work struct which tries
      to grab the RTNL semaphore.
      
      The most common case are net driver ->stop() methods.  The
      simplest conversion is to instead use cancel_{delayed_}work_sync()
      explicitly on the various work struct the driver uses.
      
      This is an OK transformation because these work structs are doing
      things like resetting the chip, restarting link negotiation, and so
      forth.  And if we're bringing down the device, we're about to turn the
      chip off and reset it anways.  So if we cancel a pending work event,
      that's fine here.
      
      Some drivers were working around this deadlock by using a msleep()
      polling loop of some sort, and those cases are converted to instead
      use cancel_{delayed_}work_sync() as well.
      Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
      4bb073c0
  2. 25 Apr, 2008 1 commit
    • Kay Sievers's avatar
      net drivers: fix platform driver hotplug/coldplug · 72abb461
      Kay Sievers authored
      Since 43cc71ee, the platform modalias is
      prefixed with "platform:".  Add MODULE_ALIAS() to the hotpluggable network
      platform drivers, to re-enable auto loading.
      
      NOTE: didn't change drivers/net/fs_enet/fs_enet-main.c "old binding" support.
      That looks problematic in the first place (it even uses the ancient "struct
      device_driver" binding scheme for platform_bus!) and I suspect it will vanish
      soonish when arch/powerpc rules the world.  Also, drivers/net/ne.c would have
      needed more thought to sort out.
      
      [akpm@linux-foundation.org: fix sgiseeq.c]
      [dbrownell@users.sourceforge.net: more drivers, registration fixes]
      Signed-off-by: default avatarKay Sievers <kay.sievers@vrfy.org>
      Signed-off-by: default avatarDavid Brownell <dbrownell@users.sourceforge.net>
      Cc: Scott Wood <scottwood@freescale.com>
      Cc: Vitaly Bordug <vitb@kernel.crashing.org>
      Cc: Dale Farnsworth <dale@farnsworth.org>
      Cc: Ben Dooks <ben-linux@fluff.org>
      Cc: Ralf Baechle <ralf@linux-mips.org>
      Cc: Andrew Victor <andrew@sanpeople.com>
      Cc: Bryan Wu <bryan.wu@analog.com>
      Signed-off-by: default avatarAndrew Morton <akpm@linux-foundation.org>
      Signed-off-by: default avatarJeff Garzik <jgarzik@redhat.com>
      72abb461
  3. 12 Apr, 2008 1 commit
  4. 17 Mar, 2008 2 commits
  5. 28 Jan, 2008 1 commit
    • Russell King's avatar
      [NET] smc91x: Make smc91x use IRQ resource trigger flags · e7b3dc7e
      Russell King authored
      smc91x is shared between many different platforms.  Each platform needs
      to specify the interrupt type, and in some cases the irq type depends
      on more than just the build configuration - it depends on runtime
      checks.
      
      Rather than throwing this code into the SMC_IRQ_FLAGS definition, provide
      a way for these flags to be passed via the IRQ resource itself.
      
      Note that IRQF_TRIGGER_* constants are intentionally defined to correspond
      with the IORESOURCE_IRQ_* interrupt type flags, in much the same way that
      the low bits of PCI iomem resources correspond with the BAR flag bits.
      
      Also provide a way to configure smc91x to read the IRQ flags from the
      resource.  Once all platforms have been converted over (signified
      by all definitions of SMC_IRQ_FLAGS being -1) SMC_IRQ_FLAGS should
      be removed.
      Signed-off-by: default avatarRussell King <rmk+kernel@arm.linux.org.uk>
      Acked-by: default avatarNicolas Pitre <nico@cam.org>
      Acked-by: default avatarJeff Garzik <jgarzik@redhat.com>
      e7b3dc7e
  6. 15 Oct, 2007 1 commit
    • Russell King's avatar
      [NET] smc91x: fix PXA DMA support code · 073ac8fd
      Russell King authored
      The PXA DMA support code for smc91x doesn't pass a struct device to
      the dma_*map_single() functions, which leads to an oops in the dma
      bounce code.  We have a struct device which was used to probe the
      SMC chip.  Use it.
      
      (This patch is slightly larger because it requires struct smc_local
      to move into the header file.)
      Signed-off-by: default avatarRussell King <rmk+kernel@arm.linux.org.uk>
      073ac8fd
  7. 10 Oct, 2007 3 commits
  8. 25 Apr, 2007 1 commit
  9. 07 Feb, 2007 1 commit
  10. 05 Dec, 2006 1 commit
  11. 07 Oct, 2006 1 commit
  12. 05 Oct, 2006 1 commit
    • David Howells's avatar
      IRQ: Maintain regs pointer globally rather than passing to IRQ handlers · 7d12e780
      David Howells authored
      Maintain a per-CPU global "struct pt_regs *" variable which can be used instead
      of passing regs around manually through all ~1800 interrupt handlers in the
      Linux kernel.
      
      The regs pointer is used in few places, but it potentially costs both stack
      space and code to pass it around.  On the FRV arch, removing the regs parameter
      from all the genirq function results in a 20% speed up of the IRQ exit path
      (ie: from leaving timer_interrupt() to leaving do_IRQ()).
      
      Where appropriate, an arch may override the generic storage facility and do
      something different with the variable.  On FRV, for instance, the address is
      maintained in GR28 at all times inside the kernel as part of general exception
      handling.
      
      Having looked over the code, it appears that the parameter may be handed down
      through up to twenty or so layers of functions.  Consider a USB character
      device attached to a USB hub, attached to a USB controller that posts its
      interrupts through a cascaded auxiliary interrupt controller.  A character
      device driver may want to pass regs to the sysrq handler through the input
      layer which adds another few layers of parameter passing.
      
      I've build this code with allyesconfig for x86_64 and i386.  I've runtested the
      main part of the code on FRV and i386, though I can't test most of the drivers.
      I've also done partial conversion for powerpc and MIPS - these at least compile
      with minimal configurations.
      
      This will affect all archs.  Mostly the changes should be relatively easy.
      Take do_IRQ(), store the regs pointer at the beginning, saving the old one:
      
      	struct pt_regs *old_regs = set_irq_regs(regs);
      
      And put the old one back at the end:
      
      	set_irq_regs(old_regs);
      
      Don't pass regs through to generic_handle_irq() or __do_IRQ().
      
      In timer_interrupt(), this sort of change will be necessary:
      
      	-	update_process_times(user_mode(regs));
      	-	profile_tick(CPU_PROFILING, regs);
      	+	update_process_times(user_mode(get_irq_regs()));
      	+	profile_tick(CPU_PROFILING);
      
      I'd like to move update_process_times()'s use of get_irq_regs() into itself,
      except that i386, alone of the archs, uses something other than user_mode().
      
      Some notes on the interrupt handling in the drivers:
      
       (*) input_dev() is now gone entirely.  The regs pointer is no longer stored in
           the input_dev struct.
      
       (*) finish_unlinks() in drivers/usb/host/ohci-q.c needs checking.  It does
           something different depending on whether it's been supplied with a regs
           pointer or not.
      
       (*) Various IRQ handler function pointers have been moved to type
           irq_handler_t.
      Signed-Off-By: default avatarDavid Howells <dhowells@redhat.com>
      (cherry picked from 1b16e7ac850969f38b375e511e3fa2f474a33867 commit)
      7d12e780
  13. 13 Sep, 2006 2 commits
  14. 19 Aug, 2006 1 commit
    • Russell King's avatar
      [PATCH] lockdep: fix smc91x · 76cb4fe7
      Russell King authored
      When booting using root-nfs, I'm seeing (independently) two lockdep dumps
      in the smc91x driver.  The patch below fixes both.  Both dumps look like
      real locking issues.
      
      Nico - please review and ack if you think the patch is correct.
      
      Dump 1:
      
      Sending DHCP requests .
      =================================
      [ INFO: inconsistent lock state ]
      Signed-off-by: default avatarJeff Garzik <jeff@garzik.org>
      76cb4fe7
  15. 30 Jun, 2006 1 commit
  16. 21 Mar, 2006 1 commit
    • Nicolas Pitre's avatar
      [PATCH] smc91x: allow for dynamic bus access configs · 09779c6d
      Nicolas Pitre authored
      All accessor's different methods are now selected with C code and unused
      ones statically optimized away at compile time instead of being selected
      with #if's and #ifdef's.  This has many advantages such as allowing the
      compiler to validate the syntax of the whole code, making it cleaner and
      easier to understand, and ultimately allowing people to define
      configuration symbols in terms of variables if they really want to
      dynamically support multiple bus configurations at the same time (with
      the unavoidable performance cost).
      Signed-off-by: default avatarNicolas Pitre <nico@cam.org>
      Signed-off-by: default avatarJeff Garzik <jeff@garzik.org>
      09779c6d
  17. 20 Mar, 2006 1 commit
  18. 08 Jan, 2006 1 commit
    • Russell King's avatar
      [PATCH] IRQ type flags · 9ded96f2
      Russell King authored
      Some ARM platforms have the ability to program the interrupt controller to
      detect various interrupt edges and/or levels.  For some platforms, this is
      critical to setup correctly, particularly those which the setting is dependent
      on the device.
      
      Currently, ARM drivers do (eg) the following:
      
      	err = request_irq(irq, ...);
      
      	set_irq_type(irq, IRQT_RISING);
      
      However, if the interrupt has previously been programmed to be level sensitive
      (for whatever reason) then this will cause an interrupt storm.
      
      Hence, if we combine set_irq_type() with request_irq(), we can then safely set
      the type prior to unmasking the interrupt.  The unfortunate problem is that in
      order to support this, these flags need to be visible outside of the ARM
      architecture - drivers such as smc91x need these flags and they're
      cross-architecture.
      
      Finally, the SA_TRIGGER_* flag passed to request_irq() should reflect the
      property that the device would like.  The IRQ controller code should do its
      best to select the most appropriate supported mode.
      Signed-off-by: default avatarRussell King <rmk+kernel@arm.linux.org.uk>
      Signed-off-by: default avatarAndrew Morton <akpm@osdl.org>
      Signed-off-by: default avatarLinus Torvalds <torvalds@osdl.org>
      9ded96f2
  19. 18 Nov, 2005 2 commits
  20. 09 Nov, 2005 1 commit
  21. 29 Oct, 2005 1 commit
  22. 28 Oct, 2005 2 commits
  23. 27 Jun, 2005 1 commit
  24. 26 Jun, 2005 1 commit
  25. 27 May, 2005 2 commits
  26. 12 May, 2005 1 commit
  27. 16 Apr, 2005 2 commits