1. 16 Oct, 2008 1 commit
  2. 20 Aug, 2008 1 commit
  3. 07 Aug, 2008 1 commit
  4. 16 Jul, 2008 1 commit
    • Isaku Yamahata's avatar
      xen-netfront: fix xennet_release_tx_bufs() · 1ffb40b8
      Isaku Yamahata authored
      After restore on ia64 xen domain, kernel panics as follows.
      This patch fixes it.
      union skb_entry assumes sizeof(link->skb, pointer) ==
      sizeof(list->link, unsigned).
      However this isn't true on ia64. So  make link type unsigned long.
      And introduced two accesor.
      kernel unaligned access to 0xe0000000000000bd, ip=0xa0000001004c2ca0
      xenwatch[14]: error during unaligned kernel access
       -1 [1]
      Modules linked in:
      Pid: 14, CPU 0, comm:             xenwatch
      psr : 0000101008422010 ifs : 8000000000000307 ip  : [<a0000001004c2ca0>]    Not tainted (2.6.26-rc4xen-ia64-dirty)
      ip is at dev_kfree_skb_irq+0x20/0x1a0
      unat: 0000000000000000 pfs : 400000000000040b rsc : 0000000000000007
      rnat: 0000000000000000 bsps: 0000000000000000 pr  : 000000000000a941
      ldrs: 0000000000000000 ccv : 0000000000000000 fpsr: 0009804c8a70433f
      csd : 0000000000000000 ssd : 0000000000000000
      b0  : a0000001003efb70 b6  : a000000100070e40 b7  : a000000100070e40
      f6  : 1003e000000fcb75352b1 f7  : 1003e000000000014ff97
      f8  : 1003e00fcb74fc3454d80 f9  : 1003e0000000080000000
      f10 : 1003e0000000000001431 f11 : 1003e0000000000989680
      r1  : a000000100bfcf80 r2  : e0000000000000bd r3  : 000000000000308c
      r8  : 0000000000000000 r9  : e00000000fc31310 r10 : a000000100a13b28
      r11 : 0000000000000000 r12 : e00000000fd0fdf0 r13 : e00000000fd08000
      r14 : 0000000000000000 r15 : e00000000fcc8000 r16 : 0000000000000009
      r17 : e000010000104000 r18 : e000010000104000 r19 : a000000100a13b40
      r20 : a0000001009c23f0 r21 : a0000001009fd4d0 r22 : 0000000000004000
      r23 : 0000000000000000 r24 : fffffffffff04c10 r25 : 0000000000000002
      r26 : 0000000000000000 r27 : 0000000000000000 r28 : e00000000fd08bd4
      r29 : a0000001007570b8 r30 : a0000001009e5500 r31 : a0000001009e54a0
      Call Trace:
       [<a000000100026000>] show_stack+0x40/0xa0
                                      sp=e00000000fd0f670 bsp=e00000000fd08f68
       [<a000000100026a60>] show_regs+0x9a0/0x9e0
                                      sp=e00000000fd0f840 bsp=e00000000fd08f10
       [<a000000100037680>] die+0x260/0x3a0
                                      sp=e00000000fd0f840 bsp=e00000000fd08ec8
       [<a000000100037810>] die_if_kernel+0x50/0x80
                                      sp=e00000000fd0f840 bsp=e00000000fd08e98
       [<a00000010003eb40>] ia64_handle_unaligned+0x2ea0/0x2fc0
                                      sp=e00000000fd0f840 bsp=e00000000fd08df0
       [<a00000010001ca30>] ia64_prepare_handle_unaligned+0x30/0x60
                                      sp=e00000000fd0fa10 bsp=e00000000fd08df0
       [<a00000010005d100>] paravirt_leave_kernel+0x0/0x40
                                      sp=e00000000fd0fc20 bsp=e00000000fd08df0
       [<a0000001004c2ca0>] dev_kfree_skb_irq+0x20/0x1a0
                                      sp=e00000000fd0fdf0 bsp=e00000000fd08db8
       [<a0000001003efb70>] xennet_release_tx_bufs+0xd0/0x120
                                      sp=e00000000fd0fdf0 bsp=e00000000fd08d78
       [<a0000001003f14c0>] backend_changed+0xc40/0xf80
                                      sp=e00000000fd0fdf0 bsp=e00000000fd08d08
       [<a00000010034bd50>] otherend_changed+0x190/0x1c0
                                      sp=e00000000fd0fe00 bsp=e00000000fd08cc8
       [<a000000100349530>] xenwatch_thread+0x310/0x3c0
                                      sp=e00000000fd0fe00 bsp=e00000000fd08ca0
       [<a0000001000cb040>] kthread+0xe0/0x160
                                      sp=e00000000fd0fe30 bsp=e00000000fd08c68
       [<a000000100024450>] kernel_thread_helper+0x30/0x60
                                      sp=e00000000fd0fe30 bsp=e00000000fd08c40
       [<a00000010001a8a0>] start_kernel_thread+0x20/0x40
                                      sp=e00000000fd0fe30 bsp=e00000000fd08c40
      Kernel panic - not syncing: Aiee, killing interrupt handler!
      Signed-off-by: default avatarIsaku Yamahata <yamahata@valinux.co.jp>
      Cc: Stephen Tweedie <sct@redhat.com>
      Cc: Eduardo Habkost <ehabkost@redhat.com>
      Cc: Mark McLoughlin <markmc@redhat.com>
      Signed-off-by: default avatarIngo Molnar <mingo@elte.hu>
  5. 03 Jul, 2008 1 commit
  6. 22 May, 2008 1 commit
  7. 01 May, 2008 1 commit
  8. 24 Apr, 2008 2 commits
  9. 28 Jan, 2008 1 commit
  10. 09 Jan, 2008 1 commit
  11. 18 Oct, 2007 1 commit
    • Joe Perches's avatar
      Add missing newlines to some uses of dev_<level> messages · 898eb71c
      Joe Perches authored
      Found these while looking at printk uses.
      Add missing newlines to dev_<level> uses
      Add missing KERN_<level> prefixes to multiline dev_<level>s
      Fixed a wierd->weird spelling typo
      Added a newline to a printk
      Signed-off-by: default avatarJoe Perches <joe@perches.com>
      Cc: "Luck, Tony" <tony.luck@intel.com>
      Cc: Jens Axboe <jens.axboe@oracle.com>
      Cc: Mark M. Hoffman <mhoffman@lightlink.com>
      Cc: Roland Dreier <rolandd@cisco.com>
      Cc: Tilman Schmidt <tilman@imap.cc>
      Cc: David Woodhouse <dwmw2@infradead.org>
      Cc: Jeff Garzik <jeff@garzik.org>
      Cc: Stephen Hemminger <shemminger@linux-foundation.org>
      Cc: Greg KH <greg@kroah.com>
      Cc: Jeremy Fitzhardinge <jeremy@goop.org>
      Cc: Geert Uytterhoeven <geert@linux-m68k.org>
      Cc: Alessandro Zummo <a.zummo@towertech.it>
      Cc: David Brownell <david-b@pacbell.net>
      Cc: James Smart <James.Smart@Emulex.Com>
      Cc: Andrew Vasquez <andrew.vasquez@qlogic.com>
      Cc: "Antonino A. Daplas" <adaplas@pol.net>
      Cc: Evgeniy Polyakov <johnpol@2ka.mipt.ru>
      Cc: Russell King <rmk@arm.linux.org.uk>
      Cc: Jaroslav Kysela <perex@suse.cz>
      Cc: Takashi Iwai <tiwai@suse.de>
      Signed-off-by: default avatarAndrew Morton <akpm@linux-foundation.org>
      Signed-off-by: default avatarLinus Torvalds <torvalds@linux-foundation.org>
  12. 15 Oct, 2007 1 commit
  13. 10 Oct, 2007 5 commits
    • Jeff Garzik's avatar
      [ETHTOOL] Provide default behaviors for a few ethtool sub-ioctls · 88d3aafd
      Jeff Garzik authored
      For the operations
      the default ethtool_op_xxx behavior is fine for all drivers, so we
      permit op==NULL to imply the default behavior.
      This provides a more uniform behavior across all drivers, eliminating
      ethtool(8) "ioctl not supported" errors on older drivers that had
      not been updated for the latest sub-ioctls.
      The ethtool_op_xxx() functions are left exported, in case anyone
      wishes to call them directly from a driver-private implementation --
      a not-uncommon case.  Should an ethtool_op_xxx() helper remain unused
      for a while, except by net/core/ethtool.c, we can un-export it at a
      later date.
      [ Resolved conflicts with set/get value ethtool patch... -DaveM ]
      Signed-off-by: default avatarJeff Garzik <jeff@garzik.org>
      Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
    • Jeff Garzik's avatar
      [NET] drivers/net: statistics cleanup #1 -- save memory and shrink code · 09f75cd7
      Jeff Garzik authored
      We now have struct net_device_stats embedded in struct net_device,
      and the default ->get_stats() hook does the obvious thing for us.
      Run through drivers/net/* and remove the driver-local storage of
      statistics, and driver-local ->get_stats() hook where applicable.
      This was just the low-hanging fruit in drivers/net; plenty more drivers
      remain to be updated.
      [ Resolved conflicts with napi_struct changes and fix sunqe build
        regression... -DaveM ]
      Signed-off-by: default avatarJeff Garzik <jeff@garzik.org>
      Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
    • Ralf Baechle's avatar
      [NET]: Nuke SET_MODULE_OWNER macro. · 10d024c1
      Ralf Baechle authored
      It's been a useless no-op for long enough in 2.6 so I figured it's time to
      remove it.  The number of people that could object because they're
      maintaining unified 2.4 and 2.6 drivers is probably rather small.
      [ Handled drivers added by netdev tree and some missed IRDA cases... -DaveM ]
      Signed-off-by: default avatarRalf Baechle <ralf@linux-mips.org>
      Signed-off-by: default avatarJeff Garzik <jeff@garzik.org>
      Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
    • Jeremy Fitzhardinge's avatar
      xen-netfront: remove dead code · 5dcddfae
      Jeremy Fitzhardinge authored
      This patch removes some residual dead code left over from removing the
      "flip" receive mode.  This patch doesn't change the generated output
      at all, since gcc already realized it was dead.
      This resolves the "regression" reported by Adrian.
      Signed-off-by: default avatarJeremy Fitzhardinge <jeremy@xensource.com>
      Cc: Adrian Bunk <bunk@stusta.de>
      Cc: Michal Piotrowski <michal.k.k.piotrowski@gmail.com>
      Signed-off-by: default avatarJeff Garzik <jeff@garzik.org>
    • Stephen Hemminger's avatar
      [NET]: Make NAPI polling independent of struct net_device objects. · bea3348e
      Stephen Hemminger authored
      Several devices have multiple independant RX queues per net
      device, and some have a single interrupt doorbell for several
      In either case, it's easier to support layouts like that if the
      structure representing the poll is independant from the net
      device itself.
      The signature of the ->poll() call back goes from:
      	int foo_poll(struct net_device *dev, int *budget)
      	int foo_poll(struct napi_struct *napi, int budget)
      The caller is returned the number of RX packets processed (or
      the number of "NAPI credits" consumed if you want to get
      abstract).  The callee no longer messes around bumping
      dev->quota, *budget, etc. because that is all handled in the
      caller upon return.
      The napi_struct is to be embedded in the device driver private data
      Furthermore, it is the driver's responsibility to disable all NAPI
      instances in it's ->stop() device close handler.  Since the
      napi_struct is privatized into the driver's private data structures,
      only the driver knows how to get at all of the napi_struct instances
      it may have per-device.
      With lots of help and suggestions from Rusty Russell, Roland Dreier,
      Michael Chan, Jeff Garzik, and Jamal Hadi Salim.
      Bug fixes from Thomas Graf, Roland Dreier, Peter Zijlstra,
      Joseph Fannin, Scott Wood, Hans J. Koch, and Michael Chan.
      [ Ported to current tree and all drivers converted.  Integrated
        Stephen's follow-on kerneldoc additions, and restored poll_list
        handling to the old style to fix mutual exclusion issues.  -DaveM ]
      Signed-off-by: default avatarStephen Hemminger <shemminger@linux-foundation.org>
      Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
  14. 13 Aug, 2007 1 commit
  15. 18 Jul, 2007 1 commit