1. 20 Jun, 2005 1 commit
  2. 19 Jun, 2005 4 commits
    • David S. Miller's avatar
      [TCP]: Fix sysctl_tcp_low_latency · 7df55125
      David S. Miller authored
      
      
      When enabled, this should disable UCOPY prequeue'ing altogether,
      but it does not due to a missing test.
      Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
      7df55125
    • Jesper Juhl's avatar
      [IPV4]: [4/4] signed vs unsigned cleanup in net/ipv4/raw.c · f7d7fc03
      Jesper Juhl authored
      
      
      This patch changes the type of the third parameter 'length' of the 
      raw_send_hdrinc() function from 'int' to 'size_t'.
      This makes sense since this function is only ever called from one 
      location, and the value passed as the third parameter in that location is 
      itself of type size_t, so this makes the recieving functions parameter 
      type match. Also, inside raw_send_hdrinc() the 'length' variable is 
      used in comparisons with unsigned values and passed as parameter to 
      functions expecting unsigned values (it's used in a single comparison with 
      a signed value, but that one can never actually be negative so the patch 
      also casts that one to size_t to stop gcc worrying, and it is passed in a 
      single instance to memcpy_fromiovecend() which expects a signed int, but 
      as far as I can see that's not a problem since the value of 'length' 
      shouldn't ever exceed the value of a signed int).
      Signed-off-by: default avatarJesper Juhl <juhl-lkml@dif.dk>
      Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
      f7d7fc03
    • Jesper Juhl's avatar
      [IPV4]: [3/4] signed vs unsigned cleanup in net/ipv4/raw.c · 93765d8a
      Jesper Juhl authored
      
      
      This patch changes the type of the local variable 'i' in 
      raw_probe_proto_opt() from 'int' to 'unsigned int'. The only use of 'i' in 
      this function is as a counter in a for() loop and subsequent index into 
      the msg->msg_iov[] array.
      Since 'i' is compared in a loop to the unsigned variable msg->msg_iovlen 
      gcc -W generates this warning : 
      
      net/ipv4/raw.c:340: warning: comparison between signed and unsigned
      
      Changing 'i' to unsigned silences this warning and is safe since the array 
      index can never be negative anyway, so unsigned int is the logical type to 
      use for 'i' and also enables a larger msg_iov[] array (but I don't know if 
      that will ever matter).
      Signed-off-by: default avatarJesper Juhl <juhl-lkml@dif.dk>
      Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
      93765d8a
    • Jesper Juhl's avatar
      [IPV4]: [2/4] signed vs unsigned cleanup in net/ipv4/raw.c · 926d4b81
      Jesper Juhl authored
      
      
      This patch gets rid of the following gcc -W warning in net/ipv4/raw.c :
      
      net/ipv4/raw.c:387: warning: comparison of unsigned expression < 0 is always false
      
      Since 'len' is of type size_t it is unsigned and can thus never be <0, and 
      since this is obvious from the function declaration just a few lines above 
      I think it's ok to remove the pointless check for len<0.
      Signed-off-by: default avatarJesper Juhl <juhl-lkml@dif.dk>
      Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
      926d4b81
  3. 18 Jun, 2005 34 commits
  4. 15 Jun, 2005 1 commit