1. 30 Aug, 2012 1 commit
    • Pablo Neira Ayuso's avatar
      netfilter: nf_nat_sip: fix incorrect handling of EBUSY for RTCP expectation · 3f509c68
      Pablo Neira Ayuso authored
      
      
      We're hitting bug while trying to reinsert an already existing
      expectation:
      
      kernel BUG at kernel/timer.c:895!
      invalid opcode: 0000 [#1] SMP
      [...]
      Call Trace:
       <IRQ>
       [<ffffffffa0069563>] nf_ct_expect_related_report+0x4a0/0x57a [nf_conntrack]
       [<ffffffff812d423a>] ? in4_pton+0x72/0x131
       [<ffffffffa00ca69e>] ip_nat_sdp_media+0xeb/0x185 [nf_nat_sip]
       [<ffffffffa00b5b9b>] set_expected_rtp_rtcp+0x32d/0x39b [nf_conntrack_sip]
       [<ffffffffa00b5f15>] process_sdp+0x30c/0x3ec [nf_conntrack_sip]
       [<ffffffff8103f1eb>] ? irq_exit+0x9a/0x9c
       [<ffffffffa00ca738>] ? ip_nat_sdp_media+0x185/0x185 [nf_nat_sip]
      
      We have to remove the RTP expectation if the RTCP expectation hits EBUSY
      since we keep trying with other ports until we succeed.
      Reported-by: default avatarRafal Fitt <rafalf@aplusc.com.pl>
      Signed-off-by: default avatarPablo Neira Ayuso <pablo@netfilter.org>
      3f509c68
  2. 10 Aug, 2012 2 commits
  3. 15 Apr, 2012 1 commit
  4. 07 Mar, 2012 1 commit
  5. 23 Dec, 2011 1 commit
  6. 02 Aug, 2011 1 commit
  7. 22 Sep, 2010 1 commit
  8. 11 Feb, 2010 3 commits
  9. 31 Oct, 2008 1 commit
  10. 21 Jul, 2008 1 commit
  11. 25 Mar, 2008 16 commits
  12. 31 Jan, 2008 1 commit
  13. 28 Jan, 2008 2 commits
  14. 20 Dec, 2007 1 commit
  15. 07 Nov, 2007 1 commit
  16. 15 Oct, 2007 1 commit
  17. 14 Aug, 2007 1 commit
  18. 10 Jul, 2007 3 commits
  19. 03 May, 2007 1 commit
    • Herbert Xu's avatar
      [NETFILTER]: sip: Fix RTP address NAT · cfd6c380
      Herbert Xu authored
      
      
      I needed to use this recently to talk to a Cisco server.  In my case
      I only did SNAT while the Cisco server used a different address for
      RTP traffic than the one for SIP.  I discovered that nf_nat_sip NATed
      the RTP address to the SIP one which was unnecessary but OK.  However,
      in doing so it did not DNAT the destination address on the RTP traffic
      to the Cisco back to the original RTP address.
      
      This patch corrects this by noting down the RTP address and using it
      when the expectation fires.
      Signed-off-by: default avatarHerbert Xu <herbert@gondor.apana.org.au>
      Signed-off-by: default avatarPatrick McHardy <kaber@trash.net>
      Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
      cfd6c380