1. 26 Sep, 2015 1 commit
  2. 23 Sep, 2015 2 commits
  3. 20 Aug, 2015 1 commit
    • Christopher Oo's avatar
      cifs: Fix use-after-free on mid_q_entry · 5fb4e288
      Christopher Oo authored
      With CIFS_DEBUG_2 enabled, additional debug information is tracked inside each
      mid_q_entry struct, however cifs_save_when_sent may use the mid_q_entry after it
      has been freed from the appropriate callback if the transport layer has very low
      latency. Holding the srv_mutex fixes this use-after-free, as cifs_save_when_sent
      is called while the srv_mutex is held while the request is sent.
      Signed-off-by: default avatarChristopher Oo <t-chriso@microsoft.com>
  4. 28 Jun, 2015 1 commit
  5. 27 Jun, 2015 3 commits
  6. 20 May, 2015 1 commit
  7. 31 Mar, 2015 3 commits
  8. 10 Dec, 2014 1 commit
  9. 07 Dec, 2014 1 commit
  10. 16 Oct, 2014 1 commit
    • Steve French's avatar
      Allow mknod and mkfifo on SMB2/SMB3 mounts · db8b631d
      Steve French authored
      The "sfu" mount option did not work on SMB2/SMB3 mounts.
      With these changes when the "sfu" mount option is passed in
      on an smb2/smb2.1/smb3 mount the client can emulate (and
      recognize) fifo and device (character and device files).
      In addition the "sfu" mount option should not conflict
      with "mfsymlinks" (symlink emulation) as we will never
      create "sfu" style symlinks, but using "sfu" mount option
      will allow us to recognize existing symlinks, created with
      Microsoft "Services for Unix" (SFU and SUA).
      To enable the "sfu" mount option for SMB2/SMB3 the calling
      syntax of the generic cifs/smb2/smb3 sync_read and sync_write
      protocol dependent function needed to be changed (we
      don't have a file struct in all cases), but this actually
      ended up simplifying the code a little.
      Signed-off-by: default avatarSteve French <smfrench@gmail.com>
  11. 25 Aug, 2014 1 commit
  12. 21 Aug, 2014 2 commits
  13. 17 Aug, 2014 1 commit
    • Pavel Shilovsky's avatar
      CIFS: Fix SMB2 readdir error handling · 52755808
      Pavel Shilovsky authored
      SMB2 servers indicates the end of a directory search with
      STATUS_NO_MORE_FILE error code that is not processed now.
      This causes generic/257 xfstest to fail. Fix this by triggering
      the end of search by this error code in SMB2_query_directory.
      Also when negotiating CIFS protocol we tell the server to close
      the search automatically at the end and there is no need to do
      it itself. In the case of SMB2 protocol, we need to close it
      explicitly - separate close directory checks for different
      Cc: <stable@vger.kernel.org>
      Signed-off-by: default avatarPavel Shilovsky <pshilovsky@samba.org>
      Signed-off-by: default avatarSteve French <smfrench@gmail.com>
  14. 16 Aug, 2014 1 commit
  15. 13 Aug, 2014 1 commit
    • Steve French's avatar
      Add sparse file support to SMB2/SMB3 mounts · 3d1a3745
      Steve French authored
      Many Linux filesystes make a file "sparse" when extending
      a file with ftruncate. This does work for CIFS to Samba
      (only) but not for SMB2/SMB3 (to Samba or Windows) since
      there is a "set sparse" fsctl which is supposed to be
      sent to mark a file as sparse.
      This patch marks a file as sparse by sending this simple
      set sparse fsctl if it is extended more than 2 pages.
      It has been tested to Windows 8.1, Samba and various
      SMB2/SMB3 servers which do support setting sparse (and
      MacOS which does not appear to support the fsctl yet).
      If a server share does not support setting a file
      as sparse, then we do not retry setting sparse on that
      The disk space savings for sparse files can be quite
      large (even more significant on Windows servers than Samba).
      Signed-off-by: default avatarSteve French <smfrench@gmail.com>
      Reviewed-by: default avatarShirish Pargaonkar <spargaonkar@suse.com>
  16. 05 Aug, 2014 1 commit
  17. 02 Aug, 2014 5 commits
  18. 31 Jul, 2014 1 commit
  19. 24 May, 2014 1 commit
  20. 21 May, 2014 3 commits
    • Steve French's avatar
      Clarify SMB2/SMB3 create context and add missing ones · 12197a7f
      Steve French authored
      Clarify comments for create contexts which we do send,
      and fix typo in one create context definition and add
      newer SMB3 create contexts to the list.
      Signed-off-by: default avatarSteve French <smfrench@gmail.com>
    • Steve French's avatar
      Do not send ClientGUID on SMB2.02 dialect · 3c5f9be1
      Steve French authored
      ClientGUID must be zero for SMB2.02 dialect.  See section 2.2.3
      of MS-SMB2. For SMB2.1 and later it must be non-zero.
      Signed-off-by: default avatarSteve French <smfrench@gmail.com>
      CC: Sachin Prabhu <sprabhu@redhat.com>
    • Sachin Prabhu's avatar
      cifs: Set client guid on per connection basis · 39552ea8
      Sachin Prabhu authored
      When mounting from a Windows 2012R2 server, we hit the following
      1) Mount with any of the following versions - 2.0, 2.1 or 3.0
      2) unmount
      3) Attempt a mount again using a different SMB version >= 2.0.
      You end up with the following failure:
      Status code returned 0xc0000203 STATUS_USER_SESSION_DELETED
      CIFS VFS: Send error in SessSetup = -5
      CIFS VFS: cifs_mount failed w/return code = -5
      I cannot reproduce this issue using a Windows 2008 R2 server.
      This appears to be caused because we use the same client guid for the
      connection on first mount which we then disconnect and attempt to mount
      again using a different protocol version. By generating a new guid each
      time a new connection is Negotiated, we avoid hitting this problem.
      Signed-off-by: default avatarSachin Prabhu <sprabhu@redhat.com>
      Signed-off-by: default avatarSteve French <smfrench@gmail.com>
  21. 16 Apr, 2014 1 commit
  22. 14 Feb, 2014 1 commit
  23. 07 Feb, 2014 1 commit
  24. 19 Nov, 2013 1 commit
  25. 18 Nov, 2013 2 commits
  26. 15 Nov, 2013 2 commits