1. 29 Feb, 2008 6 commits
  2. 20 Feb, 2008 3 commits
  3. 15 Feb, 2008 1 commit
    • Bruno Randolf's avatar
      ath5k: correct padding in tx descriptors · 281c56dd
      Bruno Randolf authored
      
      
      when setting up the tx descriptors for the hardware we must account for any
      padding between the header and the data we might have added previously. frame
      len is the length of the frame in the air (including FCS but no padding) and
      buffer len is the length of the buffer (including padding, but without FCS).
      
      changing the way ah_setup_tx_desc is called: now excluding the FCS, since it's
      easier to add that in the function where we need it.
      
      before this fix we sent trailing zero bytes after the packet (because frame len
      included the padding) which was not a big problem without WEP, but with WEP
      this resultes in a wrong WEP checksum and the packet is discarded - which is
      how i noticed at all ;)
      
      an easy way to run into header padding problems, btw, is to connect to a QoS
      (WME) enabled access point (eg. madwifi) - QoS data frames are 2 byte longer
      and will require padding.
      
      this patch applies on top of luis latest patch series from 04.02.2008.
      
      drivers/net/wireless/ath5k/base.c:      Changes-licensed-under: 3-Clause-BSD
      drivers/net/wireless/ath5k/hw.c:        Changes-licensed-under: ISC
      
      Signed-off-by: default avatarBruno Randolf <bruno@thinktube.com>
      Signed-off-by: default avatarJohn W. Linville <linville@tuxdriver.com>
      281c56dd
  4. 01 Feb, 2008 1 commit
  5. 31 Jan, 2008 1 commit
    • Bruno Randolf's avatar
      ath5k: debug level improvements · be9b7259
      Bruno Randolf authored
      
      
      * use only one debug level for beacon debugging: unify ATH5K_DEBUG_BEACON and
      ATH5K_DEBUG_BEACON_PROC.
      
      * remove debug level ATH5K_DEBUG_FATAL. doesn't make sense as a debug level -
      if it's fatal it should be logged as an error.
      
      * fancier printing of debug levels. cat /debugfs/ath5k/phy0/debug.
      
      * allow debug levels to be changed by echoing their name into
      /debugfs/ath5k/phy0/debug. this will toggle the state, when it was off it will
      be turned on and vice versa.
      
      * use copy_from_user() when reading from the debug files. use unsigned int for
      better optimization. reduce buffer sizes on stack.
      
      drivers/net/wireless/ath5k/base.c:      Changes-licensed-under: 3-Clause-BSD
      drivers/net/wireless/ath5k/debug.c:     Changes-licensed-under: GPL
      drivers/net/wireless/ath5k/debug.h:     Changes-licensed-under: GPL
      
      Signed-off-by: default avatarBruno Randolf <bruno@thinktube.com>
      Acked-by: default avatarLuis R. Rodriguez <mcgrof@winlab.rutgers.edu>
      Acked-by: default avatarJiri Slaby <jirislaby@gmail.com>
      Signed-off-by: default avatarJohn W. Linville <linville@tuxdriver.com>
      Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
      be9b7259
  6. 28 Jan, 2008 9 commits