1. 30 Mar, 2010 1 commit
  2. 16 Mar, 2010 3 commits
    • Adel Gadllah's avatar
      iwlwifi: Silence tfds_in_queue message · c8406ea8
      Adel Gadllah authored
      Commit a239a8b4 introduced a
      noisy message, that fills up the log very fast.
      
      The error seems not to be fatal (the connection is stable and
      performance is ok), so make it IWL_DEBUG_TX rather than IWL_ERR.
      Signed-off-by: default avatarAdel Gadllah <adel.gadllah@gmail.com>
      Cc: stable@kernel.org
      Acked-by: default avatarReinette Chatre <reinette.chatre@intel.com>
      Signed-off-by: default avatarJohn W. Linville <linville@tuxdriver.com>
      c8406ea8
    • Felix Fietkau's avatar
      ath9k: fix BUG_ON triggered by PAE frames · 4fdec031
      Felix Fietkau authored
      When I initially stumbled upon sequence number problems with PAE frames
      in ath9k, I submitted a patch to remove all special cases for PAE
      frames and let them go through the normal transmit path.
      Out of concern about crypto incompatibility issues, this change was
      merged instead:
      
      commit 6c8afef5
      Author: Sujith <Sujith.Manoharan@atheros.com>
      Date:   Tue Feb 9 10:07:00 2010 +0530
      
          ath9k: Fix sequence numbers for PAE frames
      
      After a lot of testing, I'm able to reliably trigger a driver crash on
      rekeying with current versions with this change in place.
      It seems that the driver does not support sending out regular MPDUs with
      the same TID while an A-MPDU session is active.
      This leads to duplicate entries in the TID Tx buffer, which hits the
      following BUG_ON in ath_tx_addto_baw():
      
          index  = ATH_BA_INDEX(tid->seq_start, bf->bf_seqno);
          cindex = (tid->baw_head + index) & (ATH_TID_MAX_BUFS - 1);
      
          BUG_ON(tid->tx_buf[cindex] != NULL);
      
      I believe until we actually have a reproducible case of an
      incompatibility with another AP using no PAE special cases, we should
      simply get rid of this mess.
      
      This patch completely fixes my crash issues in STA mode and makes it
      stay connected without throughput drops or connectivity issues even
      when the AP is configured to a very short group rekey interval.
      Signed-off-by: default avatarFelix Fietkau <nbd@openwrt.org>
      Cc: stable@kernel.org
      Signed-off-by: default avatarJohn W. Linville <linville@tuxdriver.com>
      4fdec031
    • Grazvydas Ignotas's avatar
      wl1251: fix potential crash · 3f60ebc9
      Grazvydas Ignotas authored
      In case debugfs does not init for some reason (or is disabled
      on older kernels) driver does not allocate stats.fw_stats
      structure, but tries to clear it later and trips on a NULL
      pointer:
      
      Unable to handle kernel NULL pointer dereference at virtual address
      00000000
      PC is at __memzero+0x24/0x80
      Backtrace:
      [<bf0ddb88>] (wl1251_debugfs_reset+0x0/0x30 [wl1251])
      [<bf0d6a2c>] (wl1251_op_stop+0x0/0x12c [wl1251])
      [<bf0bc228>] (ieee80211_stop_device+0x0/0x74 [mac80211])
      [<bf0b0d10>] (ieee80211_stop+0x0/0x4ac [mac80211])
      [<c02deeac>] (dev_close+0x0/0xb4)
      [<c02deac0>] (dev_change_flags+0x0/0x184)
      [<c031f478>] (devinet_ioctl+0x0/0x704)
      [<c0320720>] (inet_ioctl+0x0/0x100)
      
      Add a NULL pointer check to fix this.
      Signed-off-by: default avatarGrazvydas Ignotas <notasas@gmail.com>
      Acked-by: default avatarKalle Valo <kalle.valo@iki.fi>
      Cc: stable@kernel.org
      Signed-off-by: default avatarJohn W. Linville <linville@tuxdriver.com>
      3f60ebc9
  3. 10 Mar, 2010 11 commits
  4. 09 Mar, 2010 2 commits
    • Reinette Chatre's avatar
      Revert "iwlwifi: Send broadcast probe request only when asked to" · 1382c71c
      Reinette Chatre authored
      This reverts commit 21b2d8bd.
      
      As explained by Johannes:
      When we
      build a probe request frame in the buffer with the SSID, we could
      arrive over the limit of 200 bytes. When we build it in the buffer
      without the SSID (wildcard) we don't arrive over 200 bytes, but the
      ucode still allows direct probe in addition because it has an internal
      buffer that is larger when it inserts the SSID...
      Signed-off-by: default avatarReinette Chatre <reinette.chatre@intel.com>
      1382c71c
    • Reinette Chatre's avatar
      iwl3945: fix memory corruption · 1d79e53c
      Reinette Chatre authored
      Recent patch "iwlwifi: move 3945 clip groups to 3945 data" exposed a memory
      corruption problem. When initializing the clip groups the code was
      mistakenly using the iwlagn rate count, not the 3945 rate count. This
      resulted in more memory being written than was allocated.
      
      "iwlwifi: move 3945 clip groups to 3945 data" moved the location where the
      clip groups are stored and the impact is now severe in that the number of
      configured TX queues is modified. Previously the
      "temperature" field was overwritten, which did not seem to affect the
      operation.
      
      Fix this one instance where wrong rate count was used. I also noticed one
      more location where the iwlagn rate count was used to index an iwl3945
      array, fix this. I also modified one location that modified the iwlagn rate
      count to obtain the iwl3945 rate count ... just use the iwl3945 rate count
      directly.
      
      This fixes http://bugzilla.intellinuxwireless.org/show_bug.cgi?id=2165 and
      http://bugzilla.intellinuxwireless.org/show_bug.cgi?id=2168Signed-off-by: default avatarReinette Chatre <reinette.chatre@intel.com>
      1d79e53c
  5. 08 Mar, 2010 19 commits
  6. 07 Mar, 2010 4 commits